瀏覽代碼

add discardable results to operations that do not require result

Pierre-Marc Airoldi 2 年之前
父節點
當前提交
9f9aac4777

+ 2 - 2
Source/Charts/Data/Implementations/ChartBaseDataSet.swift

@@ -116,12 +116,12 @@ open class ChartBaseDataSet: NSObject, ChartDataSetProtocol, NSCopying
         fatalError("entryIndex(entry) is not implemented in ChartBaseDataSet")
     }
     
-    open func addEntry(_ e: ChartDataEntry) -> Bool
+    @discardableResult open func addEntry(_ e: ChartDataEntry) -> Bool
     {
         fatalError("addEntry is not implemented in ChartBaseDataSet")
     }
     
-    open func addEntryOrdered(_ e: ChartDataEntry) -> Bool
+    @discardableResult open func addEntryOrdered(_ e: ChartDataEntry) -> Bool
     {
         fatalError("addEntryOrdered is not implemented in ChartBaseDataSet")
     }

+ 3 - 3
Source/Charts/Data/Implementations/Standard/ChartDataSet.swift

@@ -300,7 +300,7 @@ open class ChartDataSet: ChartBaseDataSet
     /// - Returns: True
     // TODO: This should return `Void` to follow Swift convention
     @available(*, deprecated, message: "Use `append(_:)` instead", renamed: "append(_:)")
-    open override func addEntry(_ e: ChartDataEntry) -> Bool
+    @discardableResult open override func addEntry(_ e: ChartDataEntry) -> Bool
     {
         append(e)
         return true
@@ -313,8 +313,8 @@ open class ChartDataSet: ChartBaseDataSet
     /// - Parameters:
     ///   - e: the entry to add
     /// - Returns: True
-    @discardableResult
-    open override func addEntryOrdered(_ e: ChartDataEntry) -> Bool
+    // TODO: This should return `Void` to follow Swift convention
+    @discardableResult open override func addEntryOrdered(_ e: ChartDataEntry) -> Bool
     {
         if let last = last, last.x > e.x
         {