Explorar o código

For #3917. make init(label: String?) convenient initializer (#3973)

* fix #3917. make `init(label: String?)` to be a convenient init to enable auto inheritance.

* add UT for default dataSet label
Xuan %!s(int64=6) %!d(string=hai) anos
pai
achega
899fe1d132

+ 2 - 4
Source/Charts/Data/Implementations/Standard/ChartDataSet.swift

@@ -31,11 +31,9 @@ open class ChartDataSet: ChartBaseDataSet
         super.init()
     }
     
-    public override init(label: String?)
+    public override convenience init(label: String?)
     {
-        entries = []
-
-        super.init(label: label)
+        self.init(entries: nil, label: label)
     }
     
     @objc public init(entries: [ChartDataEntry]?, label: String?)

+ 10 - 0
Tests/Charts/BarChartTests.swift

@@ -109,6 +109,16 @@ class BarChartTests: FBSnapshotTestCase
         let dataSet = setupDefaultDataSet(chartDataEntries: dataEntries)
         let chart = setupDefaultChart(dataSets: [dataSet])
         ChartsSnapshotVerifyView(chart, identifier: Snapshot.identifier(UIScreen.main.bounds.size), overallTolerance: Snapshot.tolerance)
+
+    }
+
+    func testDefaultBarDataSetLabels()
+    {
+        let dataEntries = setupDefaultValuesDataEntries()
+        let dataSet = BarChartDataSet(entries: dataEntries)
+        dataSet.drawIconsEnabled = false
+        let chart = setupDefaultChart(dataSets: [dataSet])
+        ChartsSnapshotVerifyView(chart, identifier: Snapshot.identifier(UIScreen.main.bounds.size), overallTolerance: Snapshot.tolerance)
     }
 
     func testZeroValues()

BIN=BIN
Tests/ReferenceImages_64/ChartsTests.BarChartTests/testDefaultBarDataSetLabels_iOS_375_0_667_0@2x.png


BIN=BIN
Tests/ReferenceImages_64/ChartsTests.BarChartTests/testDefaultBarDataSetLabels_tvOS_1920_0_1080_0@1x.png