0001-configure.ac-fix-readline-static-build.patch 2.3 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849
  1. From 9836e2211ba8b3035a1d390bbf6a0eebe4c2439d Mon Sep 17 00:00:00 2001
  2. From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
  3. Date: Thu, 3 Nov 2022 17:19:09 +0100
  4. Subject: [PATCH] configure.ac: fix readline static build
  5. Use pkg-config to retrieve readline dependencies such as ncurses to
  6. avoid the following static build when readline is built with ncurses
  7. support (which is raised since version 1.8.19 and
  8. https://github.com/ipmitool/ipmitool/commit/63dd71c39c9bf522ad3a785dd001737a285458eb):
  9. ** Unable to build Solaris 9 x86 IPMI interface support!
  10. checking for library containing readline... no
  11. configure: error: ** Unable to find readline required by ipmishell.
  12. [...]
  13. configure:15125: /tmp/instance-0/output-1/host/bin/armeb-buildroot-linux-musleabi-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -O0 -g0 -static -Wall -Wextra -std=gnu11 -pedantic -Wformat -Wformat-nonliteral -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -static conftest.c -lreadline -lcrypto >&5
  14. /tmp/instance-0/output-1/host/lib/gcc/armeb-buildroot-linux-musleabi/11.3.0/../../../../armeb-buildroot-linux-musleabi/bin/ld: /tmp/instance-0/output-1/host/armeb-buildroot-linux-musleabi/sysroot/usr/lib/libreadline.a(display.o): in function `_rl_move_cursor_relative':
  15. display.c:(.text+0x80fc): undefined reference to `tputs'
  16. Fixes:
  17. - http://autobuild.buildroot.org/results/dabc6a4f49d464c129ac6bc3710011678142fcbe
  18. Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
  19. [Upstream status: https://github.com/ipmitool/ipmitool/pull/374]
  20. ---
  21. configure.ac | 6 +++++-
  22. 1 file changed, 5 insertions(+), 1 deletion(-)
  23. diff --git a/configure.ac b/configure.ac
  24. index d6ba62b..4ee1be8 100644
  25. --- a/configure.ac
  26. +++ b/configure.ac
  27. @@ -624,7 +624,11 @@ AC_ARG_ENABLE([ipmishell],
  28. dnl check for readline library to enable ipmi shell
  29. if test "x$xenable_ipmishell" = "xyes"; then
  30. - AC_SEARCH_LIBS([readline], [readline edit], [have_readline=yes])
  31. + PKG_PROG_PKG_CONFIG
  32. + PKG_CHECK_MODULES([READLINE], [readline],
  33. + [LIBS="$LIBS $READLINE_LIBS" have_readline=yes],
  34. + [AC_SEARCH_LIBS([readline], [readline edit], [have_readline=yes])]
  35. + )
  36. if test "x$have_readline" != "xyes"; then
  37. AC_MSG_ERROR([** Unable to find readline required by ipmishell.])
  38. xenable_ipmishell=no
  39. --
  40. 2.35.1