Prechádzať zdrojové kódy

Merge develop into feature/add-xcpretty

Andrea Bizzotto 8 rokov pred
rodič
commit
df14458894
3 zmenil súbory, kde vykonal 35 pridanie a 0 odobranie
  1. 2 0
      .travis.yml
  2. 30 0
      Dangerfile
  3. 3 0
      Gemfile

+ 2 - 0
.travis.yml

@@ -7,7 +7,9 @@ before_install:
 
 install:
   - ./scripts/install_swiftlint.sh
+  - bundle install --path vendor/bundle
 
 script:
   - swiftlint
   - ./scripts/build.sh
+  - bundle exec danger --verbose

+ 30 - 0
Dangerfile

@@ -0,0 +1,30 @@
+# Ensure there is a summary for a pull request
+fail 'Please provide a summary in the Pull Request description' if github.pr_body.length < 5
+
+# Warn about develop branch
+warn("Please target PRs to `develop` branch") if github.branch_for_base != "develop"
+
+# Sometimes it's a README fix, or something like that - which isn't relevant for
+# including in a project's CHANGELOG for example
+declared_trivial = github.pr_title.include? "#trivial"
+
+# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
+warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"
+
+# Warn no CHANGELOG
+warn("No CHANGELOG changes made") if git.lines_of_code > 50 && !git.modified_files.include?("CHANGELOG.md") && !declared_trivial
+
+# Warn when there is a big PR
+warn("Big PR") if git.lines_of_code > 500
+
+## Let's check if there are any changes in the project folder
+has_app_changes = !git.modified_files.grep(/SwiftyStoreKit/).empty?
+
+## Then, we should check if tests are updated
+has_test_changes = !git.modified_files.grep(/SwiftyStoreKitTests/).empty?
+
+## Finally, let's combine them and put extra condition
+## for changed number of lines of code
+if has_app_changes && !has_test_changes && git.lines_of_code > 20
+  fail("Tests were not updated", sticky: false)
+end

+ 3 - 0
Gemfile

@@ -0,0 +1,3 @@
+source 'https://rubygems.org'
+
+gem 'danger'