Ver código fonte

Merge pull request #270 from tbaranes/master

Fixes for Swiftlint 0.22.0
Andrea Bizzotto 8 anos atrás
pai
commit
53c0a8d8f8

+ 0 - 1
SwiftyStoreKit-iOS-Demo/AppDelegate.swift

@@ -42,7 +42,6 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
         SwiftyStoreKit.completeTransactions(atomically: true) { purchases in
         SwiftyStoreKit.completeTransactions(atomically: true) { purchases in
 
 
             for purchase in purchases {
             for purchase in purchases {
-                // swiftlint:disable:next for_where
                 if purchase.transaction.transactionState == .purchased || purchase.transaction.transactionState == .restored {
                 if purchase.transaction.transactionState == .purchased || purchase.transaction.transactionState == .restored {
 
 
                     if purchase.needsFinishTransaction {
                     if purchase.needsFinishTransaction {

+ 0 - 1
SwiftyStoreKit-macOS-Demo/AppDelegate.swift

@@ -38,7 +38,6 @@ class AppDelegate: NSObject, NSApplicationDelegate {
         SwiftyStoreKit.completeTransactions(atomically: true) { purchases in
         SwiftyStoreKit.completeTransactions(atomically: true) { purchases in
 
 
             for purchase in purchases {
             for purchase in purchases {
-                // swiftlint:disable:next for_where
                 if purchase.transaction.transactionState == .purchased || purchase.transaction.transactionState == .restored {
                 if purchase.transaction.transactionState == .purchased || purchase.transaction.transactionState == .restored {
 
 
                     if purchase.needsFinishTransaction {
                     if purchase.needsFinishTransaction {

+ 17 - 17
SwiftyStoreKitTests/InAppReceiptVerificatorTests.swift

@@ -81,9 +81,9 @@ class InAppReceiptVerificatorTests: XCTestCase {
             refreshCalled = true
             refreshCalled = true
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             
             
-        }) { _ in
+        }, completion: { _ in
             
             
-        }
+        })
         XCTAssertTrue(refreshCalled)
         XCTAssertTrue(refreshCalled)
     }
     }
 
 
@@ -100,9 +100,9 @@ class InAppReceiptVerificatorTests: XCTestCase {
             refreshCalled = true
             refreshCalled = true
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             
             
-        }) { _ in
+        }, completion: { _ in
             
             
-        }
+        })
         XCTAssertTrue(refreshCalled)
         XCTAssertTrue(refreshCalled)
     }
     }
     
     
@@ -120,9 +120,9 @@ class InAppReceiptVerificatorTests: XCTestCase {
             refreshCalled = true
             refreshCalled = true
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             
             
-        }) { _ in
+        }, completion: { _ in
             
             
-        }
+        })
         XCTAssertTrue(refreshCalled)
         XCTAssertTrue(refreshCalled)
     }
     }
 
 
@@ -137,10 +137,10 @@ class InAppReceiptVerificatorTests: XCTestCase {
             callback(.error(e: refreshError))
             callback(.error(e: refreshError))
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             
             
-        }) { result in
+        }, completion: { result in
             
             
             XCTAssertEqual(result, VerifyReceiptResult.error(error: ReceiptError.networkError(error: refreshError)))
             XCTAssertEqual(result, VerifyReceiptResult.error(error: ReceiptError.networkError(error: refreshError)))
-        }
+        })
     }
     }
 
 
     func testVerifyReceipt_when_appStoreReceiptURLIsNil_refreshCallbackSuccess_receiptDataNotWritten_then_errorNoReceiptData_validateNotCalled() {
     func testVerifyReceipt_when_appStoreReceiptURLIsNil_refreshCallbackSuccess_receiptDataNotWritten_then_errorNoReceiptData_validateNotCalled() {
@@ -152,11 +152,11 @@ class InAppReceiptVerificatorTests: XCTestCase {
             
             
             callback(.success)
             callback(.success)
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
-            
-        }) { result in
+
+        }, completion: { result in
 
 
             XCTAssertEqual(result, VerifyReceiptResult.error(error: ReceiptError.noReceiptData))
             XCTAssertEqual(result, VerifyReceiptResult.error(error: ReceiptError.noReceiptData))
-        }
+        })
         XCTAssertFalse(validator.validateCalled)
         XCTAssertFalse(validator.validateCalled)
     }
     }
 
 
@@ -173,10 +173,10 @@ class InAppReceiptVerificatorTests: XCTestCase {
             callback(.success)
             callback(.success)
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             
             
-        }) { result in
+        }, completion: { result in
             
             
             XCTAssertEqual(result, VerifyReceiptResult.error(error: ReceiptError.noReceiptData))
             XCTAssertEqual(result, VerifyReceiptResult.error(error: ReceiptError.noReceiptData))
-        }
+        })
         XCTAssertFalse(validator.validateCalled)
         XCTAssertFalse(validator.validateCalled)
         removeReceiptData(at: testReceiptURL)
         removeReceiptData(at: testReceiptURL)
     }
     }
@@ -194,9 +194,9 @@ class InAppReceiptVerificatorTests: XCTestCase {
             callback(.success)
             callback(.success)
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             
             
-        }) { _ in
+        }, completion: { _ in
             
             
-        }
+        })
         XCTAssertTrue(validator.validateCalled)
         XCTAssertTrue(validator.validateCalled)
         removeReceiptData(at: testReceiptURL)
         removeReceiptData(at: testReceiptURL)
     }
     }
@@ -215,9 +215,9 @@ class InAppReceiptVerificatorTests: XCTestCase {
             XCTFail("refresh should not be called if we already have a receipt")
             XCTFail("refresh should not be called if we already have a receipt")
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             return TestInAppReceiptRefreshRequest(receiptProperties: properties, callback: callback)
             
             
-        }) { _ in
+        }, completion: { _ in
             
             
-        }
+        })
         XCTAssertTrue(validator.validateCalled)
         XCTAssertTrue(validator.validateCalled)
         removeReceiptData(at: testReceiptURL)
         removeReceiptData(at: testReceiptURL)
     }
     }

+ 1 - 1
scripts/install_swiftlint.sh

@@ -7,7 +7,7 @@
 set -e
 set -e
 
 
 SWIFTLINT_PKG_PATH="/tmp/SwiftLint.pkg"
 SWIFTLINT_PKG_PATH="/tmp/SwiftLint.pkg"
-SWIFTLINT_PKG_URL="https://github.com/realm/SwiftLint/releases/download/0.21.0/SwiftLint.pkg"
+SWIFTLINT_PKG_URL="https://github.com/realm/SwiftLint/releases/download/0.22.0/SwiftLint.pkg"
 
 
 wget --output-document=$SWIFTLINT_PKG_PATH $SWIFTLINT_PKG_URL
 wget --output-document=$SWIFTLINT_PKG_PATH $SWIFTLINT_PKG_URL