Prechádzať zdrojové kódy

No need to call -stop from -dealloc

Pierre-Olivier Latour 11 rokov pred
rodič
commit
94ad8c745e
1 zmenil súbory, kde vykonal 1 pridanie a 5 odobranie
  1. 1 5
      GCDWebServer/Core/GCDWebServer.m

+ 1 - 5
GCDWebServer/Core/GCDWebServer.m

@@ -199,11 +199,7 @@ static void _ConnectedTimerCallBack(CFRunLoopTimerRef timer, void* info) {
 - (void)dealloc {
   DCHECK(_connected == NO);
   DCHECK(_activeConnections == 0);
-  
-  _delegate = nil;
-  if (_options) {
-    [self stop];
-  }
+  DCHECK(_options == nil);  // The server can never be dealloc'ed while running because of the retain-cycle with the dispatch source
   
   CFRunLoopTimerInvalidate(_connectedTimer);
   CFRelease(_connectedTimer);