Merge pull request #763 from valeriyvan/toHexString

To hex string

Sources/CryptoSwift/Array+Extension.swift

@@ -64,12 +64,12 @@ extension Array where Element == UInt8 {
   }
 
   public func toHexString() -> String {
-    `lazy`.reduce("") {
+    `lazy`.reduce(into: "") {
       var s = String($1, radix: 16)
       if s.count == 1 {
         s = "0" + s
       }
-      return $0 + s
+      $0 += s
     }
   }
 }

Tests/CryptoSwiftTests/ExtensionsTest.swift

@@ -82,6 +82,19 @@ final class ExtensionsTest: XCTestCase {
     let hex = array.toHexString()
     XCTAssertEqual(str, hex)
   }
+
+  func testToHexStringPerformance() {
+    let len = 100000
+    let a = [UInt8](unsafeUninitializedCapacity: len) { buf, count in
+        for i in 0..<len {
+            buf[i] = UInt8.random(in: 0...UInt8.max)
+        }
+        count = len
+    }
+    self.measure {
+        _ = a.toHexString()
+    }
+  }
 }
 
 extension ExtensionsTest {