瀏覽代碼

hw/display/sm501: Simplify sm501_i2c_write() logic

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Corey Minyard <cminyard@mvista.com>
Reviewed-by: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Philippe Mathieu-Daudé 4 年之前
父節點
當前提交
e91113d0f9
共有 1 個文件被更改,包括 3 次插入2 次删除
  1. 3 2
      hw/display/sm501.c

+ 3 - 2
hw/display/sm501.c

@@ -1036,8 +1036,9 @@ static void sm501_i2c_write(void *opaque, hwaddr addr, uint64_t value,
                 int res = i2c_start_transfer(s->i2c_bus,
                 int res = i2c_start_transfer(s->i2c_bus,
                                              s->i2c_addr >> 1,
                                              s->i2c_addr >> 1,
                                              s->i2c_addr & 1);
                                              s->i2c_addr & 1);
-                s->i2c_status |= (res ? SM501_I2C_STATUS_ERROR : 0);
-                if (!res) {
+                if (res) {
+                    s->i2c_status |= SM501_I2C_STATUS_ERROR;
+                } else {
                     int i;
                     int i;
                     for (i = 0; i <= s->i2c_byte_count; i++) {
                     for (i = 0; i <= s->i2c_byte_count; i++) {
                         res = i2c_send_recv(s->i2c_bus, &s->i2c_data[i],
                         res = i2c_send_recv(s->i2c_bus, &s->i2c_data[i],