Bläddra i källkod

Fix calculation of minimum in colo_compare_tcp

GitHub's CodeQL reports a critical error which is fixed by using the MIN macro:

    Unsigned difference expression compared to zero

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Cc: qemu-stable@nongnu.org
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Stefan Weil 11 månader sedan
förälder
incheckning
e29bc931e1
1 ändrade filer med 1 tillägg och 2 borttagningar
  1. 1 2
      net/colo-compare.c

+ 1 - 2
net/colo-compare.c

@@ -412,8 +412,7 @@ static void colo_compare_tcp(CompareState *s, Connection *conn)
      * can ensure that the packet's payload is acknowledged by
      * can ensure that the packet's payload is acknowledged by
      * primary and secondary.
      * primary and secondary.
     */
     */
-    uint32_t min_ack = conn->pack - conn->sack > 0 ?
-                       conn->sack : conn->pack;
+    uint32_t min_ack = MIN(conn->pack, conn->sack);
 
 
 pri:
 pri:
     if (g_queue_is_empty(&conn->primary_list)) {
     if (g_queue_is_empty(&conn->primary_list)) {