Browse Source

tests/functional: Fix hash validation

The _check() function is supposed to check whether the hash of the
downloaded file matches the expected one. Unfortunately, during the
last rework of this function, the check was accidentally turned into
returning the hash value itself instead of a True/False value,
effectively accepting each hash as valid. Let's do a proper check
again now.

Fixes:05e303210d ("tests/functional/qemu_test: Use Python hashlib ...")
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Thomas Huth 10 tháng trước cách đây
mục cha
commit
db17daf8c4

+ 1 - 1
tests/functional/qemu_test/asset.py

@@ -57,7 +57,7 @@ def _check(self, cache_file):
                     break
                     break
                 hl.update(chunk)
                 hl.update(chunk)
 
 
-        return  hl.hexdigest()
+        return self.hash == hl.hexdigest()
 
 
     def valid(self):
     def valid(self):
         return self.cache_file.exists() and self._check(self.cache_file)
         return self.cache_file.exists() and self._check(self.cache_file)