Bladeren bron

net: socket: Don't ignore EINVAL on netdev socket connection

Other errors are treated as failure by net_socket_connect_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Stefano Brivio 2 jaren geleden
bovenliggende
commit
daf188ff04
1 gewijzigde bestanden met toevoegingen van 1 en 2 verwijderingen
  1. 1 2
      net/socket.c

+ 1 - 2
net/socket.c

@@ -577,8 +577,7 @@ static int net_socket_connect_init(NetClientState *peer,
             if (errno == EINTR || errno == EWOULDBLOCK) {
             if (errno == EINTR || errno == EWOULDBLOCK) {
                 /* continue */
                 /* continue */
             } else if (errno == EINPROGRESS ||
             } else if (errno == EINPROGRESS ||
-                       errno == EALREADY ||
-                       errno == EINVAL) {
+                       errno == EALREADY) {
                 break;
                 break;
             } else {
             } else {
                 error_setg_errno(errp, errno, "can't connect socket");
                 error_setg_errno(errp, errno, "can't connect socket");