Browse Source

io: avoid double-free when closing QIOChannelBuffer

The QIOChannelBuffer's close implementation will free
the internal data buffer. It failed to reset the pointer
to NULL though, so when the object is later finalized
it will free it a second time with predictable crash.

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <1461751518-12128-3-git-send-email-berrange@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Daniel P. Berrange 9 years ago
parent
commit
d656ec5ea8
1 changed files with 1 additions and 0 deletions
  1. 1 0
      io/channel-buffer.c

+ 1 - 0
io/channel-buffer.c

@@ -140,6 +140,7 @@ static int qio_channel_buffer_close(QIOChannel *ioc,
     QIOChannelBuffer *bioc = QIO_CHANNEL_BUFFER(ioc);
     QIOChannelBuffer *bioc = QIO_CHANNEL_BUFFER(ioc);
 
 
     g_free(bioc->data);
     g_free(bioc->data);
+    bioc->data = NULL;
     bioc->capacity = bioc->usage = bioc->offset = 0;
     bioc->capacity = bioc->usage = bioc->offset = 0;
 
 
     return 0;
     return 0;