Browse Source

Merge tag 'tracing-pull-request' of https://gitlab.com/stefanha/qemu into staging

Pull request

# -----BEGIN PGP SIGNATURE-----
#
# iQEzBAABCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmesuKsACgkQnKSrs4Gr
# c8hK6Qf/bsHjBdZ38SFdusrTsAILBMI+A6KWtofbXk5qAo+A5dFLqMoVc+c1x/Cc
# GNccrlUXkqbNSVn2WsrARddTvy1s1o2B4zMjdBI/J6cUeeFGRU+YoMA2uBO7XRke
# qwma5j9Rrx5TX/dZG4PSlhJl4WM4sbbknjjX3G8ySiKTGBuK5rLeeexYSjk/TOYQ
# +LD8CnurrZ7ZbyLt4zzJu02s18/T3Rg50tmM81HVz8DpUZRE3Waz82tSqNZsHWva
# oh3cwKDimuxYcQYp9ePZxIwSkWjkUlHVJPj+zvHna8kkR76Ww+5Nvo2XvwSh4SCs
# SuJtB9HPo2FmdqmUp0lPDbknhc3CzA==
# =opYd
# -----END PGP SIGNATURE-----
# gpg: Signature made Wed 12 Feb 2025 10:05:15 EST
# gpg:                using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
# gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>" [ultimate]
# gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>" [ultimate]
# Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8

* tag 'tracing-pull-request' of https://gitlab.com/stefanha/qemu:
  scripts: improve error from qemu-trace-stap on missing 'stap'

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Stefan Hajnoczi 6 months ago
parent
commit
ce315328f8
1 changed files with 4 additions and 2 deletions
  1. 4 2
      scripts/qemu-trace-stap

+ 4 - 2
scripts/qemu-trace-stap

@@ -56,6 +56,7 @@ def tapset_dir(binary):
 
 
 
 
 def cmd_run(args):
 def cmd_run(args):
+    stap = which("stap")
     prefix = probe_prefix(args.binary)
     prefix = probe_prefix(args.binary)
     tapsets = tapset_dir(args.binary)
     tapsets = tapset_dir(args.binary)
 
 
@@ -76,7 +77,7 @@ def cmd_run(args):
 
 
     # We request an 8MB buffer, since the stap default 1MB buffer
     # We request an 8MB buffer, since the stap default 1MB buffer
     # can be easily overflowed by frequently firing QEMU traces
     # can be easily overflowed by frequently firing QEMU traces
-    stapargs = ["stap", "-s", "8", "-I", tapsets ]
+    stapargs = [stap, "-s", "8", "-I", tapsets ]
     if args.pid is not None:
     if args.pid is not None:
         stapargs.extend(["-x", args.pid])
         stapargs.extend(["-x", args.pid])
     stapargs.extend(["-e", script])
     stapargs.extend(["-e", script])
@@ -84,6 +85,7 @@ def cmd_run(args):
 
 
 
 
 def cmd_list(args):
 def cmd_list(args):
+    stap = which("stap")
     tapsets = tapset_dir(args.binary)
     tapsets = tapset_dir(args.binary)
 
 
     if args.verbose:
     if args.verbose:
@@ -96,7 +98,7 @@ def cmd_list(args):
 
 
         if verbose:
         if verbose:
             print("Listing probes with name '%s'" % script)
             print("Listing probes with name '%s'" % script)
-        proc = subprocess.Popen(["stap", "-I", tapsets, "-l", script],
+        proc = subprocess.Popen([stap, "-I", tapsets, "-l", script],
                                 stdout=subprocess.PIPE,
                                 stdout=subprocess.PIPE,
                                 universal_newlines=True)
                                 universal_newlines=True)
         out, err = proc.communicate()
         out, err = proc.communicate()