Browse Source

hw/ide/atapi: Restrict 'scsi/constants.h' inclusion

Only atapi.c requires the SCSI constants. No need to include
it in all files including "hw/ide/internal.h".

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230215112712.23110-7-philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Philippe Mathieu-Daudé 2 years ago
parent
commit
cc135b10f4
2 changed files with 1 additions and 1 deletions
  1. 1 0
      hw/ide/atapi.c
  2. 0 1
      include/hw/ide/internal.h

+ 1 - 0
hw/ide/atapi.c

@@ -27,6 +27,7 @@
 #include "hw/ide/internal.h"
 #include "hw/ide/internal.h"
 #include "hw/scsi/scsi.h"
 #include "hw/scsi/scsi.h"
 #include "sysemu/block-backend.h"
 #include "sysemu/block-backend.h"
+#include "scsi/constants.h"
 #include "trace.h"
 #include "trace.h"
 
 
 #define ATAPI_SECTOR_BITS (2 + BDRV_SECTOR_BITS)
 #define ATAPI_SECTOR_BITS (2 + BDRV_SECTOR_BITS)

+ 0 - 1
include/hw/ide/internal.h

@@ -13,7 +13,6 @@
 #include "hw/isa/isa.h"
 #include "hw/isa/isa.h"
 #include "sysemu/dma.h"
 #include "sysemu/dma.h"
 #include "hw/block/block.h"
 #include "hw/block/block.h"
-#include "scsi/constants.h"
 
 
 /* debug IDE devices */
 /* debug IDE devices */
 #define USE_DMA_CDROM
 #define USE_DMA_CDROM