Browse Source

hw/intc/grlib_irqmp: abort realize when ncpus value is out of range

Even if the error is set, the build is not aborted when the ncpus value
is wrong, the return is missing.

Signed-off-by: Clément Chigot <chigot@adacore.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Fixes: 6bf1478543 ("hw/intc/grlib_irqmp: add ncpus property")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20240308152719.591232-1-chigot@adacore.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Clément Chigot 1 year ago
parent
commit
c9ee67c3c6
1 changed files with 1 additions and 0 deletions
  1. 1 0
      hw/intc/grlib_irqmp.c

+ 1 - 0
hw/intc/grlib_irqmp.c

@@ -356,6 +356,7 @@ static void grlib_irqmp_realize(DeviceState *dev, Error **errp)
         error_setg(errp, "Invalid ncpus properties: "
         error_setg(errp, "Invalid ncpus properties: "
                    "%u, must be 0 < ncpus =< %u.", irqmp->ncpus,
                    "%u, must be 0 < ncpus =< %u.", irqmp->ncpus,
                    IRQMP_MAX_CPU);
                    IRQMP_MAX_CPU);
+        return;
     }
     }
 
 
     qdev_init_gpio_in(dev, grlib_irqmp_set_irq, MAX_PILS);
     qdev_init_gpio_in(dev, grlib_irqmp_set_irq, MAX_PILS);