Przeglądaj źródła

hw/i8254: fix vmstate load

QEMU timer of channel 0 in i8254 is used to raise irq
at the specified moment of time. This irq can be disabled
with irq_disabled flag. But when vmstate of the pit is
loaded, timer may be rearmed despite the disabled interrupts.
This patch adds irq_disabled flag check to fix that.

Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
Message-Id: <161537170060.6654.9430112746749476215.stgit@pasha-ThinkPad-X280>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Pavel Dovgalyuk 4 lat temu
rodzic
commit
c963fee4b0
1 zmienionych plików z 1 dodań i 1 usunięć
  1. 1 1
      hw/timer/i8254.c

+ 1 - 1
hw/timer/i8254.c

@@ -324,7 +324,7 @@ static void pit_post_load(PITCommonState *s)
 {
 {
     PITChannelState *sc = &s->channels[0];
     PITChannelState *sc = &s->channels[0];
 
 
-    if (sc->next_transition_time != -1) {
+    if (sc->next_transition_time != -1 && !sc->irq_disabled) {
         timer_mod(sc->irq_timer, sc->next_transition_time);
         timer_mod(sc->irq_timer, sc->next_transition_time);
     } else {
     } else {
         timer_del(sc->irq_timer);
         timer_del(sc->irq_timer);