浏览代码

monitor: Fix memory leak with readline completion

Each string which is shown during readline completion in the QEMU monitor
is allocated dynamically but currently never deallocated.

Add the missing loop which calls g_free for the allocated strings.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
(cherry picked from commit fc9fa4bd0a295ac18808c4cd2cfac484bc4649d3)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Stefan Weil 13 年之前
父节点
当前提交
c49dd1bf64
共有 1 个文件被更改,包括 3 次插入0 次删除
  1. 3 0
      readline.c

+ 3 - 0
readline.c

@@ -337,6 +337,9 @@ static void readline_completion(ReadLineState *rs)
         }
         }
         readline_show_prompt(rs);
         readline_show_prompt(rs);
     }
     }
+    for (i = 0; i < rs->nb_completions; i++) {
+        g_free(rs->completions[i]);
+    }
 }
 }
 
 
 /* return true if command handled */
 /* return true if command handled */