Jelajahi Sumber

qapi/expr.py: Remove 'info' argument from nested check_if_str

The function can just use the argument from the scope above. Otherwise,
we get shadowed argument errors because the parameter name clashes with
the name of a variable already in-scope.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Message-Id: <20210421182032.3521476-3-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
John Snow 4 tahun lalu
induk
melakukan
b7341b89c9
1 mengubah file dengan 3 tambahan dan 3 penghapusan
  1. 3 3
      scripts/qapi/expr.py

+ 3 - 3
scripts/qapi/expr.py

@@ -122,7 +122,7 @@ def check_flags(expr, info):
 
 
 def check_if(expr, info, source):
 def check_if(expr, info, source):
 
 
-    def check_if_str(ifcond, info):
+    def check_if_str(ifcond):
         if not isinstance(ifcond, str):
         if not isinstance(ifcond, str):
             raise QAPISemError(
             raise QAPISemError(
                 info,
                 info,
@@ -142,9 +142,9 @@ def check_if_str(ifcond, info):
             raise QAPISemError(
             raise QAPISemError(
                 info, "'if' condition [] of %s is useless" % source)
                 info, "'if' condition [] of %s is useless" % source)
         for elt in ifcond:
         for elt in ifcond:
-            check_if_str(elt, info)
+            check_if_str(elt)
     else:
     else:
-        check_if_str(ifcond, info)
+        check_if_str(ifcond)
         expr['if'] = [ifcond]
         expr['if'] = [ifcond]