瀏覽代碼

qemu-nbd: improve error message for dup2 error

This error happens if we are not able to close the pipe to the
parent (to trace errors in the child process) and assign stderr to
/dev/null as required by the daemonizing convention.

Signed-off-by: Denis V. Lunev <den@openvz.org>
Suggested-by: Eric Blake <eblake@redhat.com>
CC: Eric Blake <eblake@redhat.com>
CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-ID: <20230906093210.339585-2-den@openvz.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
[eblake: commit message grammar]
Signed-off-by: Eric Blake <eblake@redhat.com>
Denis V. Lunev 1 年之前
父節點
當前提交
b4bbdf51e3
共有 1 個文件被更改,包括 2 次插入2 次删除
  1. 2 2
      qemu-nbd.c

+ 2 - 2
qemu-nbd.c

@@ -324,7 +324,7 @@ static void *nbd_client_thread(void *arg)
     } else {
     } else {
         /* Close stderr so that the qemu-nbd process exits.  */
         /* Close stderr so that the qemu-nbd process exits.  */
         if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
         if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
-            error_report("Could not set stderr to /dev/null: %s",
+            error_report("Could not release pipe to parent: %s",
                          strerror(errno));
                          strerror(errno));
             exit(EXIT_FAILURE);
             exit(EXIT_FAILURE);
         }
         }
@@ -1181,7 +1181,7 @@ int main(int argc, char **argv)
 
 
     if (fork_process) {
     if (fork_process) {
         if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
         if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
-            error_report("Could not set stderr to /dev/null: %s",
+            error_report("Could not release pipe to parent: %s",
                          strerror(errno));
                          strerror(errno));
             exit(EXIT_FAILURE);
             exit(EXIT_FAILURE);
         }
         }