2
0
Эх сурвалжийг харах

kvm: Fix warning from static code analysis

Report from smatch:

kvm-all.c:1373 kvm_init(135) warn:
 variable dereferenced before check 's' (see line 1360)

's' cannot by NULL (it was alloced using g_malloc0), so there is no need
to check it here.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
(cherry picked from commit 6d1cc3210ccc4372ffa337c187da9db68314c0c4)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Stefan Weil 13 жил өмнө
parent
commit
a78cedc09e
1 өөрчлөгдсөн 5 нэмэгдсэн , 7 устгасан
  1. 5 7
      kvm-all.c

+ 5 - 7
kvm-all.c

@@ -1374,13 +1374,11 @@ int kvm_init(void)
     return 0;
     return 0;
 
 
 err:
 err:
-    if (s) {
-        if (s->vmfd >= 0) {
-            close(s->vmfd);
-        }
-        if (s->fd != -1) {
-            close(s->fd);
-        }
+    if (s->vmfd >= 0) {
+        close(s->vmfd);
+    }
+    if (s->fd != -1) {
+        close(s->fd);
     }
     }
     g_free(s);
     g_free(s);