Home Explore Help
Register Sign In
FangSoftSoft
/
qemu
mirror of https://github.com/utmapp/qemu.git
2
0
Fork 0
Files Issues 0 Wiki
Browse Source

hbitmap: fix hbitmap_status() return value for first dirty bit case

The last return statement should return true, as we already evaluated that
start == next_dirty

Also, fix hbitmap_status() description in header

Cc: qemu-stable@nongnu.org
Fixes: a6426475a75 ("block/dirty-bitmap: introduce bdrv_dirty_bitmap_status()")
Signed-off-by: Andrey Zhadchenko <andrey.zhadchenko@virtuozzo.com>
Message-Id: <20230202181523.423131-1-andrey.zhadchenko@virtuozzo.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Andrey Zhadchenko 2 years ago
parent
005ee3cdc7
commit
a4d5224c2c
2 changed files with 2 additions and 2 deletions
Unified View Show Diff Stats
  1. 1 1
      include/qemu/hbitmap.h
  2. 1 1
      util/hbitmap.c

+ 1 - 1
include/qemu/hbitmap.h
View File 

@@ -330,7 +330,7 @@ bool hbitmap_next_dirty_area(const HBitmap *hb, int64_t start, int64_t end,
 
                              int64_t *dirty_start, int64_t *dirty_count);
 
                              int64_t *dirty_start, int64_t *dirty_count);
 
 
 
 /*
 
 /*
 
- * bdrv_dirty_bitmap_status:
 
+ * hbitmap_status:
 
  * @hb: The HBitmap to operate on
 
  * @hb: The HBitmap to operate on
 
  * @start: The bit to start from
 
  * @start: The bit to start from
 
  * @count: Number of bits to proceed
 
  * @count: Number of bits to proceed

+ 1 - 1
util/hbitmap.c
View File 

@@ -331,7 +331,7 @@ bool hbitmap_status(const HBitmap *hb, int64_t start, int64_t count,
 
 
 
     assert(next_zero > start);
 
     assert(next_zero > start);
 
     *pnum = next_zero - start;
 
     *pnum = next_zero - start;
 
-    return false;
 
+    return true;
 
 }
 
 }
 
 
 
 bool hbitmap_empty(const HBitmap *hb)
 
 bool hbitmap_empty(const HBitmap *hb)