2
0
Эх сурвалжийг харах

qapi/gen: inline _wrap_ifcond into end_if()

We assert _start_if is not None in end_if, but that's opaque to mypy.
By inlining _wrap_ifcond, that constraint becomes provable to mypy.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20210201193747.2169670-5-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
John Snow 4 жил өмнө
parent
commit
a253b3eb9a

+ 2 - 5
scripts/qapi/gen.py

@@ -130,15 +130,12 @@ def start_if(self, ifcond: List[str]) -> None:
         self._start_if = (ifcond, self._body, self._preamble)
         self._start_if = (ifcond, self._body, self._preamble)
 
 
     def end_if(self) -> None:
     def end_if(self) -> None:
-        assert self._start_if
-        self._wrap_ifcond()
-        self._start_if = None
-
-    def _wrap_ifcond(self) -> None:
+        assert self._start_if is not None
         self._body = _wrap_ifcond(self._start_if[0],
         self._body = _wrap_ifcond(self._start_if[0],
                                   self._start_if[1], self._body)
                                   self._start_if[1], self._body)
         self._preamble = _wrap_ifcond(self._start_if[0],
         self._preamble = _wrap_ifcond(self._start_if[0],
                                       self._start_if[2], self._preamble)
                                       self._start_if[2], self._preamble)
+        self._start_if = None
 
 
     def get_content(self) -> str:
     def get_content(self) -> str:
         assert self._start_if is None
         assert self._start_if is None