Browse Source

mptsas: fix wrong formula

MPI_DOORBELL_WHO_INIT_SHIFT is being repeated twice.  Reported
by Coverity.

Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo Bonzini 9 years ago
parent
commit
9155b7606a
1 changed files with 1 additions and 1 deletions
  1. 1 1
      hw/scsi/mptsas.c

+ 1 - 1
hw/scsi/mptsas.c

@@ -824,7 +824,7 @@ static uint32_t mptsas_doorbell_read(MPTSASState *s)
 {
 {
     uint32_t ret;
     uint32_t ret;
 
 
-    ret = (s->who_init << MPI_DOORBELL_WHO_INIT_SHIFT) & MPI_DOORBELL_WHO_INIT_SHIFT;
+    ret = (s->who_init << MPI_DOORBELL_WHO_INIT_SHIFT) & MPI_DOORBELL_WHO_INIT_MASK;
     ret |= s->state;
     ret |= s->state;
     switch (s->doorbell_state) {
     switch (s->doorbell_state) {
     case DOORBELL_NONE:
     case DOORBELL_NONE: