瀏覽代碼

linux-user: target_argv is placed on ts->bprm->argv and can't be freed()

TaskState contains linux_bprm struct which encapsulates argv among
other things.
argv might be used around the code and is expected to contain valid
data. Before this patch, ts->bprm->argv was NULL due to it being
freed right after loader_exec().

Signed-off-by: Fabio Erculiani <lxnay@sabayon.org>
Acked-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
Fabio Erculiani 13 年之前
父節點
當前提交
84803b87a1
共有 1 個文件被更改,包括 0 次插入5 次删除
  1. 0 5
      linux-user/main.c

+ 0 - 5
linux-user/main.c

@@ -3486,11 +3486,6 @@ int main(int argc, char **argv, char **envp)
         _exit(1);
         _exit(1);
     }
     }
 
 
-    for (i = 0; i < target_argc; i++) {
-        free(target_argv[i]);
-    }
-    free(target_argv);
-
     for (wrk = target_environ; *wrk; wrk++) {
     for (wrk = target_environ; *wrk; wrk++) {
         free(*wrk);
         free(*wrk);
     }
     }