Переглянути джерело

qemu.py: Use iteritems rather than keys()

Let's avoid creating an in-memory list of keys and query for each value
and use `iteritems` which is an iterator of key-value pairs.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20170818142613.32394-4-ldoktor@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Lukáš Doktor 8 роки тому
батько
коміт
7f33ca7878
1 змінених файлів з 3 додано та 3 видалено
  1. 3 3
      scripts/qemu.py

+ 3 - 3
scripts/qemu.py

@@ -200,11 +200,11 @@ def shutdown(self):
     def qmp(self, cmd, conv_keys=True, **args):
     def qmp(self, cmd, conv_keys=True, **args):
         '''Invoke a QMP command and return the response dict'''
         '''Invoke a QMP command and return the response dict'''
         qmp_args = dict()
         qmp_args = dict()
-        for key in args.keys():
+        for key, value in args.iteritems():
             if conv_keys:
             if conv_keys:
-                qmp_args[key.translate(self.underscore_to_dash)] = args[key]
+                qmp_args[key.translate(self.underscore_to_dash)] = value
             else:
             else:
-                qmp_args[key] = args[key]
+                qmp_args[key] = value
 
 
         return self._qmp.cmd(cmd, args=qmp_args)
         return self._qmp.cmd(cmd, args=qmp_args)