Sfoglia il codice sorgente

hw/mips: Use QEMU_IOTHREAD_LOCK_GUARD in cpu_mips_irq_request

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Richard Henderson 2 anni fa
parent
commit
6fa8c46e55
1 ha cambiato i file con 1 aggiunte e 10 eliminazioni
  1. 1 10
      hw/mips/mips_int.c

+ 1 - 10
hw/mips/mips_int.c

@@ -32,17 +32,12 @@ static void cpu_mips_irq_request(void *opaque, int irq, int level)
     MIPSCPU *cpu = opaque;
     MIPSCPU *cpu = opaque;
     CPUMIPSState *env = &cpu->env;
     CPUMIPSState *env = &cpu->env;
     CPUState *cs = CPU(cpu);
     CPUState *cs = CPU(cpu);
-    bool locked = false;
 
 
     if (irq < 0 || irq > 7) {
     if (irq < 0 || irq > 7) {
         return;
         return;
     }
     }
 
 
-    /* Make sure locking works even if BQL is already held by the caller */
-    if (!qemu_mutex_iothread_locked()) {
-        locked = true;
-        qemu_mutex_lock_iothread();
-    }
+    QEMU_IOTHREAD_LOCK_GUARD();
 
 
     if (level) {
     if (level) {
         env->CP0_Cause |= 1 << (irq + CP0Ca_IP);
         env->CP0_Cause |= 1 << (irq + CP0Ca_IP);
@@ -59,10 +54,6 @@ static void cpu_mips_irq_request(void *opaque, int irq, int level)
     } else {
     } else {
         cpu_reset_interrupt(cs, CPU_INTERRUPT_HARD);
         cpu_reset_interrupt(cs, CPU_INTERRUPT_HARD);
     }
     }
-
-    if (locked) {
-        qemu_mutex_unlock_iothread();
-    }
 }
 }
 
 
 void cpu_mips_irq_init_cpu(MIPSCPU *cpu)
 void cpu_mips_irq_init_cpu(MIPSCPU *cpu)