Răsfoiți Sursa

qmp: Add some comments around null responses

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-Id: <20180703085358.13941-28-armbru@redhat.com>
Markus Armbruster 7 ani în urmă
părinte
comite
62e93be286
1 a modificat fișierele cu 2 adăugiri și 0 ștergeri
  1. 2 0
      qapi/qmp-dispatch.c

+ 2 - 0
qapi/qmp-dispatch.c

@@ -133,6 +133,7 @@ static QObject *do_qmp_dispatch(QmpCommandList *cmds, QObject *request,
     } else if (cmd->options & QCO_NO_SUCCESS_RESP) {
     } else if (cmd->options & QCO_NO_SUCCESS_RESP) {
         g_assert(!ret);
         g_assert(!ret);
     } else if (!ret) {
     } else if (!ret) {
+        /* TODO turn into assertion */
         ret = QOBJECT(qdict_new());
         ret = QOBJECT(qdict_new());
     }
     }
 
 
@@ -176,6 +177,7 @@ QDict *qmp_dispatch(QmpCommandList *cmds, QObject *request,
         rsp = qdict_new();
         rsp = qdict_new();
         qdict_put_obj(rsp, "return", ret);
         qdict_put_obj(rsp, "return", ret);
     } else {
     } else {
+        /* Can only happen for commands with QCO_NO_SUCCESS_RESP */
         rsp = NULL;
         rsp = NULL;
     }
     }