浏览代码

vga-pci: Register "big-endian-framebuffer" as class property

Class properties make QOM introspection simpler and easier, as
they don't require an object to be instantiated.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20200921221045.699690-22-ehabkost@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Eduardo Habkost 4 年之前
父节点
当前提交
5949703709
共有 1 个文件被更改,包括 4 次插入8 次删除
  1. 4 8
      hw/display/vga-pci.c

+ 4 - 8
hw/display/vga-pci.c

@@ -267,13 +267,6 @@ static void pci_std_vga_realize(PCIDevice *dev, Error **errp)
     }
     }
 }
 }
 
 
-static void pci_std_vga_init(Object *obj)
-{
-    /* Expose framebuffer byteorder via QOM */
-    object_property_add_bool(obj, "big-endian-framebuffer",
-                             vga_get_big_endian_fb, vga_set_big_endian_fb);
-}
-
 static void pci_secondary_vga_realize(PCIDevice *dev, Error **errp)
 static void pci_secondary_vga_realize(PCIDevice *dev, Error **errp)
 {
 {
     PCIVGAState *d = PCI_VGA(dev);
     PCIVGAState *d = PCI_VGA(dev);
@@ -386,6 +379,10 @@ static void vga_class_init(ObjectClass *klass, void *data)
     k->class_id = PCI_CLASS_DISPLAY_VGA;
     k->class_id = PCI_CLASS_DISPLAY_VGA;
     device_class_set_props(dc, vga_pci_properties);
     device_class_set_props(dc, vga_pci_properties);
     dc->hotpluggable = false;
     dc->hotpluggable = false;
+
+    /* Expose framebuffer byteorder via QOM */
+    object_class_property_add_bool(klass, "big-endian-framebuffer",
+                                   vga_get_big_endian_fb, vga_set_big_endian_fb);
 }
 }
 
 
 static void secondary_class_init(ObjectClass *klass, void *data)
 static void secondary_class_init(ObjectClass *klass, void *data)
@@ -403,7 +400,6 @@ static void secondary_class_init(ObjectClass *klass, void *data)
 static const TypeInfo vga_info = {
 static const TypeInfo vga_info = {
     .name          = "VGA",
     .name          = "VGA",
     .parent        = TYPE_PCI_VGA,
     .parent        = TYPE_PCI_VGA,
-    .instance_init = pci_std_vga_init,
     .class_init    = vga_class_init,
     .class_init    = vga_class_init,
 };
 };