2
0
Эх сурвалжийг харах

qapi: Replace qmp_dispatch()'s TODO comment by an explanation

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200317115459.31821-25-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Markus Armbruster 5 жил өмнө
parent
commit
4a8837389e

+ 5 - 1
qapi/qmp-dispatch.c

@@ -162,7 +162,11 @@ QDict *qmp_dispatch(QmpCommandList *cmds, QObject *request,
         g_assert(!ret);
         g_assert(!ret);
         return NULL;
         return NULL;
     } else if (!ret) {
     } else if (!ret) {
-        /* TODO turn into assertion */
+        /*
+         * When the command's schema has no 'returns', cmd->fn()
+         * leaves @ret null.  The QMP spec calls for an empty object
+         * then; supply it.
+         */
         ret = QOBJECT(qdict_new());
         ret = QOBJECT(qdict_new());
     }
     }