Selaa lähdekoodia

gitlab: disable accelerated zlib for s390x

There appears to be a bug in the s390 hardware-accelerated version of
zlib distributed with Ubuntu 20.04, which makes our test
/i386/migration/multifd/tcp/zlib hit an assertion perhaps one time in
10. Fortunately zlib provides an escape hatch where we can disable the
hardware-acceleration entirely by setting the environment variable
DFLTCC to 0. Do this on all our CI which runs on s390 hosts, both our
custom gitlab runner and also the Travis hosts.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Acked-by: Cornelia Huck <cohuck@redhat.com>
Message-id: 20220321161151.3654386-1-alex.bennee@linaro.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Alex Bennée 3 vuotta sitten
vanhempi
commit
309df6acb2
2 muutettua tiedostoa jossa 16 lisäystä ja 2 poistoa
  1. 12 0
      .gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml
  2. 4 2
      .travis.yml

+ 12 - 0
.gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml

@@ -8,6 +8,8 @@ ubuntu-20.04-s390x-all-linux-static:
  tags:
  tags:
  - ubuntu_20.04
  - ubuntu_20.04
  - s390x
  - s390x
+ variables:
+    DFLTCC: 0
  rules:
  rules:
  - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
  - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
  - if: "$S390X_RUNNER_AVAILABLE"
  - if: "$S390X_RUNNER_AVAILABLE"
@@ -27,6 +29,8 @@ ubuntu-20.04-s390x-all:
  tags:
  tags:
  - ubuntu_20.04
  - ubuntu_20.04
  - s390x
  - s390x
+ variables:
+    DFLTCC: 0
  rules:
  rules:
  - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
  - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
  - if: "$S390X_RUNNER_AVAILABLE"
  - if: "$S390X_RUNNER_AVAILABLE"
@@ -43,6 +47,8 @@ ubuntu-20.04-s390x-alldbg:
  tags:
  tags:
  - ubuntu_20.04
  - ubuntu_20.04
  - s390x
  - s390x
+ variables:
+    DFLTCC: 0
  rules:
  rules:
  - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
  - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
    when: manual
    when: manual
@@ -64,6 +70,8 @@ ubuntu-20.04-s390x-clang:
  tags:
  tags:
  - ubuntu_20.04
  - ubuntu_20.04
  - s390x
  - s390x
+ variables:
+    DFLTCC: 0
  rules:
  rules:
  - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
  - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
    when: manual
    when: manual
@@ -84,6 +92,8 @@ ubuntu-20.04-s390x-tci:
  tags:
  tags:
  - ubuntu_20.04
  - ubuntu_20.04
  - s390x
  - s390x
+ variables:
+    DFLTCC: 0
  rules:
  rules:
  - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
  - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
    when: manual
    when: manual
@@ -103,6 +113,8 @@ ubuntu-20.04-s390x-notcg:
  tags:
  tags:
  - ubuntu_20.04
  - ubuntu_20.04
  - s390x
  - s390x
+ variables:
+    DFLTCC: 0
  rules:
  rules:
  - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
  - if: '$CI_PROJECT_NAMESPACE == "qemu-project" && $CI_COMMIT_BRANCH =~ /^staging/'
    when: manual
    when: manual

+ 4 - 2
.travis.yml

@@ -218,6 +218,7 @@ jobs:
         - TEST_CMD="make check check-tcg V=1"
         - TEST_CMD="make check check-tcg V=1"
         - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},s390x-linux-user"
         - CONFIG="--disable-containers --target-list=${MAIN_SOFTMMU_TARGETS},s390x-linux-user"
         - UNRELIABLE=true
         - UNRELIABLE=true
+        - DFLTCC=0
       script:
       script:
         - BUILD_RC=0 && make -j${JOBS} || BUILD_RC=$?
         - BUILD_RC=0 && make -j${JOBS} || BUILD_RC=$?
         - |
         - |
@@ -257,7 +258,7 @@ jobs:
       env:
       env:
         - CONFIG="--disable-containers --audio-drv-list=sdl --disable-user
         - CONFIG="--disable-containers --audio-drv-list=sdl --disable-user
                   --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
                   --target-list-exclude=${MAIN_SOFTMMU_TARGETS}"
-
+        - DFLTCC=0
     - name: "[s390x] GCC (user)"
     - name: "[s390x] GCC (user)"
       arch: s390x
       arch: s390x
       dist: focal
       dist: focal
@@ -269,7 +270,7 @@ jobs:
           - ninja-build
           - ninja-build
       env:
       env:
         - CONFIG="--disable-containers --disable-system"
         - CONFIG="--disable-containers --disable-system"
-
+        - DFLTCC=0
     - name: "[s390x] Clang (disable-tcg)"
     - name: "[s390x] Clang (disable-tcg)"
       arch: s390x
       arch: s390x
       dist: focal
       dist: focal
@@ -303,3 +304,4 @@ jobs:
         - CONFIG="--disable-containers --disable-tcg --enable-kvm
         - CONFIG="--disable-containers --disable-tcg --enable-kvm
                   --disable-tools --host-cc=clang --cxx=clang++"
                   --disable-tools --host-cc=clang --cxx=clang++"
         - UNRELIABLE=true
         - UNRELIABLE=true
+        - DFLTCC=0