Pārlūkot izejas kodu

gdbstub: Fix handling of '!' packet with new infra

Since the '!' packet is not handled by the new infrastructure,
gdb_handle_packet() would call run_cmd_parser() with a NULL cmd_parser
value, which would lead to an unsupported packet ("$#00") being sent,
which could confuse the gdb client.

This also has a side-effect of speeding up the initial connection with
gdb.

Fixes: 3e2c12615b52 ("gdbstub: Implement deatch (D pkt) with new infra")
Signed-off-by: Ramiro Polla <ramiro.polla@gmail.com>
Message-Id: <20190805190901.14072-1-ramiro.polla@gmail.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Ramiro Polla 6 gadi atpakaļ
vecāks
revīzija
2bdec39848
1 mainītis faili ar 3 papildinājumiem un 1 dzēšanām
  1. 3 1
      gdbstub.c

+ 3 - 1
gdbstub.c

@@ -2588,7 +2588,9 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf)
         break;
         break;
     }
     }
 
 
-    run_cmd_parser(s, line_buf, cmd_parser);
+    if (cmd_parser) {
+        run_cmd_parser(s, line_buf, cmd_parser);
+    }
 
 
     return RS_IDLE;
     return RS_IDLE;
 }
 }