浏览代码

qapi: Fix some QMP documentation regressions

In the process of getting rid of docs/qmp-commands.txt, we managed
to regress on some of the text that changed after the point where
the move was first branched and when the move actually occurred.
For example, commit 3282eca for blockdev-snapshot re-added the
extra "options" layer which had been cleaned up in commit 0153d2f.

This clears up all regressions identified over the range
02b351d..bd6092e:
https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg05127.html
as well as a cleanup to x-blockdev-remove-medium to prefer
'id' over 'device' (matching the cleanup for 'eject').

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Eric Blake 8 年之前
父节点
当前提交
244d04db58
共有 2 个文件被更改,包括 15 次插入15 次删除
  1. 14 14
      qapi/block-core.json
  2. 1 1
      qapi/block.json

+ 14 - 14
qapi/block-core.json

@@ -1206,11 +1206,11 @@
 # Example:
 # Example:
 #
 #
 # -> { "execute": "blockdev-add",
 # -> { "execute": "blockdev-add",
-#      "arguments": { "options": { "driver": "qcow2",
-#                                  "node-name": "node1534",
-#                                  "file": { "driver": "file",
-#                                            "filename": "hd1.qcow2" },
-#                                  "backing": "" } } }
+#      "arguments": { "driver": "qcow2",
+#                     "node-name": "node1534",
+#                     "file": { "driver": "file",
+#                               "filename": "hd1.qcow2" },
+#                     "backing": "" } }
 #
 #
 # <- { "return": {} }
 # <- { "return": {} }
 #
 #
@@ -3214,7 +3214,7 @@
 # <- { "return": {} }
 # <- { "return": {} }
 #
 #
 # -> { "execute": "x-blockdev-remove-medium",
 # -> { "execute": "x-blockdev-remove-medium",
-#      "arguments": { "device": "ide0-1-0" } }
+#      "arguments": { "id": "ide0-1-0" } }
 #
 #
 # <- { "return": {} }
 # <- { "return": {} }
 #
 #
@@ -3245,10 +3245,10 @@
 #
 #
 # -> { "execute": "blockdev-add",
 # -> { "execute": "blockdev-add",
 #      "arguments": {
 #      "arguments": {
-#          "options": { "node-name": "node0",
-#                       "driver": "raw",
-#                       "file": { "driver": "file",
-#                                 "filename": "fedora.iso" } } } }
+#          "node-name": "node0",
+#          "driver": "raw",
+#          "file": { "driver": "file",
+#                    "filename": "fedora.iso" } } }
 # <- { "return": {} }
 # <- { "return": {} }
 #
 #
 # -> { "execute": "x-blockdev-insert-medium",
 # -> { "execute": "x-blockdev-insert-medium",
@@ -3701,10 +3701,10 @@
 # 1. Add a new node to a quorum
 # 1. Add a new node to a quorum
 # -> { "execute": "blockdev-add",
 # -> { "execute": "blockdev-add",
 #      "arguments": {
 #      "arguments": {
-#          "options": { "driver": "raw",
-#                       "node-name": "new_node",
-#                        "file": { "driver": "file",
-#                                  "filename": "test.raw" } } } }
+#          "driver": "raw",
+#          "node-name": "new_node",
+#          "file": { "driver": "file",
+#                    "filename": "test.raw" } } }
 # <- { "return": {} }
 # <- { "return": {} }
 # -> { "execute": "x-blockdev-change",
 # -> { "execute": "x-blockdev-change",
 #      "arguments": { "parent": "disk1",
 #      "arguments": { "parent": "disk1",

+ 1 - 1
qapi/block.json

@@ -180,7 +180,7 @@
 #
 #
 # Example:
 # Example:
 #
 #
-# -> { "execute": "eject", "arguments": { "device": "ide1-0-1" } }
+# -> { "execute": "eject", "arguments": { "id": "ide1-0-1" } }
 # <- { "return": {} }
 # <- { "return": {} }
 ##
 ##
 { 'command': 'eject',
 { 'command': 'eject',