Переглянути джерело

libdecnumber: Fix decNumberSetBCD

Fix a simple bug in the decNumberSetBCD() function.  This function
encodes a decNumber with "n" BCD digits.  The original code erroneously
computed the number of declets from the dn argument, which is the output
decNumber value, and hence may contain garbage.  Instead, the input "n"
value is used.

Signed-off-by: Tom Musta <tommusta@gmail.com>
Signed-off-by: Alexander Graf <agraf@suse.de>
Tom Musta 11 роки тому
батько
коміт
0a322e7e7c
1 змінених файлів з 1 додано та 1 видалено
  1. 1 1
      libdecnumber/decNumber.c

+ 1 - 1
libdecnumber/decNumber.c

@@ -3541,7 +3541,7 @@ uByte * decNumberGetBCD(const decNumber *dn, uint8_t *bcd) {
 /* and bcd[0] zero.						      */
 /* and bcd[0] zero.						      */
 /* ------------------------------------------------------------------ */
 /* ------------------------------------------------------------------ */
 decNumber * decNumberSetBCD(decNumber *dn, const uByte *bcd, uInt n) {
 decNumber * decNumberSetBCD(decNumber *dn, const uByte *bcd, uInt n) {
-  Unit *up=dn->lsu+D2U(dn->digits)-1;	/* -> msu [target pointer] */
+  Unit *up = dn->lsu + D2U(n) - 1;      /* -> msu [target pointer] */
   const uByte *ub=bcd;			/* -> source msd */
   const uByte *ub=bcd;			/* -> source msd */
 
 
   #if DECDPUN==1			/* trivial simple copy */
   #if DECDPUN==1			/* trivial simple copy */