|
@@ -11,7 +11,7 @@
|
|
*/
|
|
*/
|
|
|
|
|
|
/*
|
|
/*
|
|
- * How to add or update the tests:
|
|
|
|
|
|
+ * How to add or update the tests or commit changes that affect ACPI tables:
|
|
* Contributor:
|
|
* Contributor:
|
|
* 1. add empty files for new tables, if any, under tests/data/acpi
|
|
* 1. add empty files for new tables, if any, under tests/data/acpi
|
|
* 2. list any changed files in tests/qtest/bios-tables-test-allowed-diff.h
|
|
* 2. list any changed files in tests/qtest/bios-tables-test-allowed-diff.h
|
|
@@ -38,6 +38,11 @@
|
|
* $(SRC_PATH)/tests/data/acpi/rebuild-expected-aml.sh
|
|
* $(SRC_PATH)/tests/data/acpi/rebuild-expected-aml.sh
|
|
* 6. Now commit any changes to the expected binary, include diff from step 4
|
|
* 6. Now commit any changes to the expected binary, include diff from step 4
|
|
* in commit log.
|
|
* in commit log.
|
|
|
|
+ * Expected binary updates needs to be a separate patch from the code that
|
|
|
|
+ * introduces changes to ACPI tables. It lets the maintainer drop
|
|
|
|
+ * and regenerate binary updates in case of merge conflicts. Further, a code
|
|
|
|
+ * change is easily reviewable but a binary blob is not (without doing a
|
|
|
|
+ * disassembly).
|
|
* 7. Before sending patches to the list (Contributor)
|
|
* 7. Before sending patches to the list (Contributor)
|
|
* or before doing a pull request (Maintainer), make sure
|
|
* or before doing a pull request (Maintainer), make sure
|
|
* tests/qtest/bios-tables-test-allowed-diff.h is empty - this will ensure
|
|
* tests/qtest/bios-tables-test-allowed-diff.h is empty - this will ensure
|