Преглед на файлове

[llvm-objdump] errorToErrorCode+message -> toString

For test/Object/elf-invalid-phdr.test, the intended error message got lost due to errorToErrorCode().

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@359166 91177308-0d34-0410-b5e6-96231b3b80d8
Fangrui Song преди 6 години
родител
ревизия
f73a9f2ea6
променени са 2 файла, в които са добавени 4 реда и са изтрити 5 реда
  1. 1 1
      test/Object/elf-invalid-phdr.test
  2. 3 4
      tools/llvm-objdump/ELFDump.cpp

+ 1 - 1
test/Object/elf-invalid-phdr.test

@@ -23,4 +23,4 @@
 RUN: not llvm-objdump -private-headers %p/Inputs/invalid-phdr.elf 2>&1 \
 RUN:         | FileCheck %s
 
-CHECK: LLVM ERROR: Invalid data was encountered while parsing the file
+CHECK: LLVM ERROR: program headers longer than binary

+ 3 - 4
tools/llvm-objdump/ELFDump.cpp

@@ -131,7 +131,7 @@ static uint64_t getSectionLMA(const ELFFile<ELFT> *Obj,
                               const object::ELFSectionRef &Sec) {
   auto PhdrRangeOrErr = Obj->program_headers();
   if (!PhdrRangeOrErr)
-    report_fatal_error(errorToErrorCode(PhdrRangeOrErr.takeError()).message());
+    report_fatal_error(toString(PhdrRangeOrErr.takeError()));
 
   // Search for a PT_LOAD segment containing the requested section. Use this
   // segment's p_addr to calculate the section's LMA.
@@ -178,7 +178,7 @@ void printDynamicSection(const ELFFile<ELFT> *Elf, StringRef Filename) {
         outs() << (Data + Dyn.d_un.d_val) << "\n";
         continue;
       }
-      warn(errorToErrorCode(StrTabOrErr.takeError()).message());
+      warn(toString(StrTabOrErr.takeError()));
       consumeError(StrTabOrErr.takeError());
     }
     outs() << format(Fmt, (uint64_t)Dyn.d_un.d_val);
@@ -189,8 +189,7 @@ template <class ELFT> void printProgramHeaders(const ELFFile<ELFT> *o) {
   outs() << "Program Header:\n";
   auto ProgramHeaderOrError = o->program_headers();
   if (!ProgramHeaderOrError)
-    report_fatal_error(
-        errorToErrorCode(ProgramHeaderOrError.takeError()).message());
+    report_fatal_error(toString(ProgramHeaderOrError.takeError()));
   for (const typename ELFT::Phdr &Phdr : *ProgramHeaderOrError) {
     switch (Phdr.p_type) {
     case ELF::PT_DYNAMIC: