12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265426642674268426942704271427242734274427542764277427842794280428142824283428442854286428742884289429042914292429342944295429642974298429943004301430243034304430543064307430843094310431143124313431443154316431743184319432043214322432343244325432643274328432943304331433243334334433543364337433843394340434143424343434443454346434743484349435043514352435343544355435643574358435943604361436243634364436543664367436843694370437143724373437443754376437743784379438043814382438343844385438643874388438943904391439243934394439543964397439843994400440144024403440444054406440744084409441044114412441344144415441644174418441944204421442244234424442544264427442844294430443144324433443444354436443744384439444044414442444344444445444644474448444944504451445244534454445544564457445844594460446144624463446444654466446744684469447044714472447344744475447644774478447944804481448244834484448544864487448844894490449144924493449444954496449744984499450045014502450345044505450645074508450945104511451245134514451545164517451845194520452145224523452445254526452745284529453045314532453345344535453645374538453945404541454245434544454545464547454845494550455145524553455445554556455745584559456045614562456345644565456645674568456945704571457245734574457545764577457845794580458145824583458445854586458745884589459045914592459345944595459645974598459946004601460246034604460546064607460846094610461146124613461446154616461746184619462046214622462346244625462646274628462946304631463246334634463546364637463846394640464146424643464446454646464746484649465046514652465346544655465646574658465946604661466246634664466546664667466846694670467146724673467446754676467746784679468046814682468346844685468646874688468946904691469246934694469546964697469846994700470147024703470447054706470747084709471047114712471347144715471647174718471947204721472247234724472547264727472847294730473147324733473447354736473747384739474047414742474347444745474647474748474947504751475247534754475547564757475847594760476147624763476447654766476747684769477047714772477347744775477647774778477947804781478247834784478547864787478847894790479147924793479447954796479747984799480048014802480348044805480648074808480948104811481248134814481548164817481848194820482148224823482448254826482748284829483048314832483348344835 |
- #!/usr/bin/env vpython3
- # coding=utf-8
- # Copyright (c) 2012 The Chromium Authors. All rights reserved.
- # Use of this source code is governed by a BSD-style license that can be
- # found in the LICENSE file.
- """Unit tests for git_cl.py."""
- from __future__ import print_function
- from __future__ import unicode_literals
- import datetime
- import json
- import logging
- import multiprocessing
- import optparse
- import os
- import pprint
- import shutil
- import sys
- import tempfile
- import unittest
- if sys.version_info.major == 2:
- from StringIO import StringIO
- import mock
- else:
- from io import StringIO
- from unittest import mock
- sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
- import metrics
- import metrics_utils
- # We have to disable monitoring before importing git_cl.
- metrics_utils.COLLECT_METRICS = False
- import clang_format
- import contextlib
- import gclient_utils
- import gerrit_util
- import git_cl
- import git_common
- import git_footers
- import git_new_branch
- import owners_client
- import scm
- import subprocess2
- NETRC_FILENAME = '_netrc' if sys.platform == 'win32' else '.netrc'
- def callError(code=1, cmd='', cwd='', stdout=b'', stderr=b''):
- return subprocess2.CalledProcessError(code, cmd, cwd, stdout, stderr)
- CERR1 = callError(1)
- class TemporaryFileMock(object):
- def __init__(self):
- self.suffix = 0
- @contextlib.contextmanager
- def __call__(self):
- self.suffix += 1
- yield '/tmp/fake-temp' + str(self.suffix)
- class ChangelistMock(object):
- # A class variable so we can access it when we don't have access to the
- # instance that's being set.
- desc = ''
- def __init__(self, gerrit_change=None, use_python3=False, **kwargs):
- self._gerrit_change = gerrit_change
- self._use_python3 = use_python3
- def GetIssue(self):
- return 1
- def FetchDescription(self):
- return ChangelistMock.desc
- def UpdateDescription(self, desc, force=False):
- ChangelistMock.desc = desc
- def GetGerritChange(self, patchset=None, **kwargs):
- del patchset
- return self._gerrit_change
- def GetRemoteBranch(self):
- return ('origin', 'refs/remotes/origin/main')
- def GetUsePython3(self):
- return self._use_python3
- class GitMocks(object):
- def __init__(self, config=None, branchref=None):
- self.branchref = branchref or 'refs/heads/main'
- self.config = config or {}
- def GetBranchRef(self, _root):
- return self.branchref
- def NewBranch(self, branchref):
- self.branchref = branchref
- def GetConfig(self, root, key, default=None):
- if root != '':
- key = '%s:%s' % (root, key)
- return self.config.get(key, default)
- def SetConfig(self, root, key, value=None):
- if root != '':
- key = '%s:%s' % (root, key)
- if value:
- self.config[key] = value
- return
- if key not in self.config:
- raise CERR1
- del self.config[key]
- class WatchlistsMock(object):
- def __init__(self, _):
- pass
- @staticmethod
- def GetWatchersForPaths(_):
- return ['joe@example.com']
- class CodereviewSettingsFileMock(object):
- def __init__(self):
- pass
- # pylint: disable=no-self-use
- def read(self):
- return ('CODE_REVIEW_SERVER: gerrit.chromium.org\n' +
- 'GERRIT_HOST: True\n')
- class AuthenticatorMock(object):
- def __init__(self, *_args):
- pass
- def has_cached_credentials(self):
- return True
- def authorize(self, http):
- return http
- def CookiesAuthenticatorMockFactory(hosts_with_creds=None, same_auth=False):
- """Use to mock Gerrit/Git credentials from ~/.netrc or ~/.gitcookies.
- Usage:
- >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
- CookiesAuthenticatorMockFactory({'host': ('user', _, 'pass')})
- OR
- >>> self.mock(git_cl.gerrit_util, "CookiesAuthenticator",
- CookiesAuthenticatorMockFactory(
- same_auth=('user', '', 'pass'))
- """
- class CookiesAuthenticatorMock(git_cl.gerrit_util.CookiesAuthenticator):
- def __init__(self): # pylint: disable=super-init-not-called
- # Intentionally not calling super() because it reads actual cookie files.
- pass
- @classmethod
- def get_gitcookies_path(cls):
- return os.path.join('~', '.gitcookies')
- @classmethod
- def get_netrc_path(cls):
- return os.path.join('~', NETRC_FILENAME)
- def _get_auth_for_host(self, host):
- if same_auth:
- return same_auth
- return (hosts_with_creds or {}).get(host)
- return CookiesAuthenticatorMock
- class MockChangelistWithBranchAndIssue():
- def __init__(self, branch, issue):
- self.branch = branch
- self.issue = issue
- def GetBranch(self):
- return self.branch
- def GetIssue(self):
- return self.issue
- class SystemExitMock(Exception):
- pass
- class TestGitClBasic(unittest.TestCase):
- def setUp(self):
- mock.patch('sys.exit', side_effect=SystemExitMock).start()
- mock.patch('sys.stdout', StringIO()).start()
- mock.patch('sys.stderr', StringIO()).start()
- self.addCleanup(mock.patch.stopall)
- def test_die_with_error(self):
- with self.assertRaises(SystemExitMock):
- git_cl.DieWithError('foo', git_cl.ChangeDescription('lorem ipsum'))
- self.assertEqual(sys.stderr.getvalue(), 'foo\n')
- self.assertTrue('saving CL description' in sys.stdout.getvalue())
- self.assertTrue('Content of CL description' in sys.stdout.getvalue())
- self.assertTrue('lorem ipsum' in sys.stdout.getvalue())
- sys.exit.assert_called_once_with(1)
- def test_die_with_error_no_desc(self):
- with self.assertRaises(SystemExitMock):
- git_cl.DieWithError('foo')
- self.assertEqual(sys.stderr.getvalue(), 'foo\n')
- self.assertEqual(sys.stdout.getvalue(), '')
- sys.exit.assert_called_once_with(1)
- def test_fetch_description(self):
- cl = git_cl.Changelist(issue=1, codereview_host='host')
- cl.description = 'x'
- self.assertEqual(cl.FetchDescription(), 'x')
- @mock.patch('git_cl.Changelist.EnsureAuthenticated')
- @mock.patch('git_cl.Changelist.GetStatus', lambda cl: cl.status)
- def test_get_cl_statuses(self, *_mocks):
- statuses = [
- 'closed', 'commit', 'dry-run', 'lgtm', 'reply', 'unsent', 'waiting']
- changes = []
- for status in statuses:
- cl = git_cl.Changelist()
- cl.status = status
- changes.append(cl)
- actual = set(git_cl.get_cl_statuses(changes, True))
- self.assertEqual(set(zip(changes, statuses)), actual)
- def test_upload_to_non_default_branch_no_retry(self):
- m = mock.patch('git_cl.Changelist._CMDUploadChange',
- side_effect=[git_cl.GitPushError(), None]).start()
- mock.patch('git_cl.Changelist.GetRemoteBranch',
- return_value=('foo', 'bar')).start()
- mock.patch('git_cl.Changelist.GetGerritProject',
- return_value='foo').start()
- mock.patch('git_cl.gerrit_util.GetProjectHead',
- return_value='refs/heads/main').start()
- cl = git_cl.Changelist()
- options = optparse.Values()
- options.target_branch = 'refs/heads/bar'
- with self.assertRaises(SystemExitMock):
- cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
- # ensure upload is called once
- self.assertEqual(len(m.mock_calls), 1)
- sys.exit.assert_called_once_with(1)
- # option not set as retry didn't happen
- self.assertFalse(hasattr(options, 'force'))
- self.assertFalse(hasattr(options, 'edit_description'))
- def test_upload_to_old_default_still_active(self):
- m = mock.patch('git_cl.Changelist._CMDUploadChange',
- side_effect=[git_cl.GitPushError(), None]).start()
- mock.patch('git_cl.Changelist.GetRemoteBranch',
- return_value=('foo', git_cl.DEFAULT_OLD_BRANCH)).start()
- mock.patch('git_cl.Changelist.GetGerritProject',
- return_value='foo').start()
- mock.patch('git_cl.gerrit_util.GetProjectHead',
- return_value='refs/heads/main').start()
- cl = git_cl.Changelist()
- options = optparse.Values()
- options.target_branch = 'refs/heads/main'
- with self.assertRaises(SystemExitMock):
- cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
- # ensure upload is called once
- self.assertEqual(len(m.mock_calls), 1)
- sys.exit.assert_called_once_with(1)
- # option not set as retry didn't happen
- self.assertFalse(hasattr(options, 'force'))
- self.assertFalse(hasattr(options, 'edit_description'))
- def test_upload_with_message_file_no_editor(self):
- m = mock.patch('git_cl.ChangeDescription.prompt',
- return_value=None).start()
- mock.patch('git_cl.Changelist.GetRemoteBranch',
- return_value=('foo', git_cl.DEFAULT_NEW_BRANCH)).start()
- mock.patch('git_cl.GetTargetRef',
- return_value='refs/heads/main').start()
- mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
- lambda _, offer_removal: None).start()
- mock.patch('git_cl.Changelist.GetIssue', return_value=None).start()
- mock.patch('git_cl.Changelist.GetBranch',
- side_effect=SystemExitMock).start()
- mock.patch('git_cl.GenerateGerritChangeId', return_value=None).start()
- mock.patch('git_cl.RunGit').start()
- cl = git_cl.Changelist()
- options = optparse.Values()
- options.target_branch = 'refs/heads/main'
- options.squash = True
- options.edit_description = False
- options.force = False
- options.preserve_tryjobs = False
- options.message_file = "message.txt"
- with self.assertRaises(SystemExitMock):
- cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
- self.assertEqual(len(m.mock_calls), 0)
- options.message_file = None
- with self.assertRaises(SystemExitMock):
- cl.CMDUploadChange(options, [], 'foo', git_cl.ChangeDescription('bar'))
- self.assertEqual(len(m.mock_calls), 1)
- def test_get_cl_statuses_no_changes(self):
- self.assertEqual([], list(git_cl.get_cl_statuses([], True)))
- @mock.patch('git_cl.Changelist.EnsureAuthenticated')
- @mock.patch('multiprocessing.pool.ThreadPool')
- def test_get_cl_statuses_timeout(self, *_mocks):
- changes = [git_cl.Changelist() for _ in range(2)]
- pool = multiprocessing.pool.ThreadPool()
- it = pool.imap_unordered.return_value.__iter__ = mock.Mock()
- it.return_value.next.side_effect = [
- (changes[0], 'lgtm'),
- multiprocessing.TimeoutError,
- ]
- actual = list(git_cl.get_cl_statuses(changes, True))
- self.assertEqual([(changes[0], 'lgtm'), (changes[1], 'error')], actual)
- @mock.patch('git_cl.Changelist.GetIssueURL')
- def test_get_cl_statuses_not_finegrained(self, _mock):
- changes = [git_cl.Changelist() for _ in range(2)]
- urls = ['some-url', None]
- git_cl.Changelist.GetIssueURL.side_effect = urls
- actual = set(git_cl.get_cl_statuses(changes, False))
- self.assertEqual(
- set([(changes[0], 'waiting'), (changes[1], 'error')]), actual)
- def test_get_issue_url(self):
- cl = git_cl.Changelist(issue=123)
- cl._gerrit_server = 'https://example.com'
- self.assertEqual(cl.GetIssueURL(), 'https://example.com/123')
- self.assertEqual(cl.GetIssueURL(short=True), 'https://example.com/123')
- cl = git_cl.Changelist(issue=123)
- cl._gerrit_server = 'https://chromium-review.googlesource.com'
- self.assertEqual(cl.GetIssueURL(),
- 'https://chromium-review.googlesource.com/123')
- self.assertEqual(cl.GetIssueURL(short=True), 'https://crrev.com/c/123')
- def test_set_preserve_tryjobs(self):
- d = git_cl.ChangeDescription('Simple.')
- d.set_preserve_tryjobs()
- self.assertEqual(d.description.splitlines(), [
- 'Simple.',
- '',
- 'Cq-Do-Not-Cancel-Tryjobs: true',
- ])
- before = d.description
- d.set_preserve_tryjobs()
- self.assertEqual(before, d.description)
- d = git_cl.ChangeDescription('\n'.join([
- 'One is enough',
- '',
- 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
- 'Change-Id: Ideadbeef',
- ]))
- d.set_preserve_tryjobs()
- self.assertEqual(d.description.splitlines(), [
- 'One is enough',
- '',
- 'Cq-Do-Not-Cancel-Tryjobs: dups not encouraged, but don\'t hurt',
- 'Change-Id: Ideadbeef',
- 'Cq-Do-Not-Cancel-Tryjobs: true',
- ])
- def test_get_bug_line_values(self):
- f = lambda p, bugs: list(git_cl._get_bug_line_values(p, bugs))
- self.assertEqual(f('', ''), [])
- self.assertEqual(f('', '123,v8:456'), ['123', 'v8:456'])
- # Prefix that ends with colon.
- self.assertEqual(f('v8:', '456'), ['v8:456'])
- self.assertEqual(f('v8:', 'chromium:123,456'), ['v8:456', 'chromium:123'])
- # Prefix that ends without colon.
- self.assertEqual(f('v8', '456'), ['v8:456'])
- self.assertEqual(f('v8', 'chromium:123,456'), ['v8:456', 'chromium:123'])
- # Not nice, but not worth carying.
- self.assertEqual(f('v8:', 'chromium:123,456,v8:123'),
- ['v8:456', 'chromium:123', 'v8:123'])
- self.assertEqual(f('v8', 'chromium:123,456,v8:123'),
- ['v8:456', 'chromium:123', 'v8:123'])
- @mock.patch('gerrit_util.GetAccountDetails')
- def test_valid_accounts(self, mockGetAccountDetails):
- mock_per_account = {
- 'u1': None, # 404, doesn't exist.
- 'u2': {
- '_account_id': 123124,
- 'avatars': [],
- 'email': 'u2@example.com',
- 'name': 'User Number 2',
- 'status': 'OOO',
- },
- 'u3': git_cl.gerrit_util.GerritError(500, 'retries didn\'t help :('),
- }
- def GetAccountDetailsMock(_, account):
- # Poor-man's mock library's side_effect.
- v = mock_per_account.pop(account)
- if isinstance(v, Exception):
- raise v
- return v
- mockGetAccountDetails.side_effect = GetAccountDetailsMock
- actual = git_cl.gerrit_util.ValidAccounts(
- 'host', ['u1', 'u2', 'u3'], max_threads=1)
- self.assertEqual(actual, {
- 'u2': {
- '_account_id': 123124,
- 'avatars': [],
- 'email': 'u2@example.com',
- 'name': 'User Number 2',
- 'status': 'OOO',
- },
- })
- class TestParseIssueURL(unittest.TestCase):
- def _test(self, arg, issue=None, patchset=None, hostname=None, fail=False):
- parsed = git_cl.ParseIssueNumberArgument(arg)
- self.assertIsNotNone(parsed)
- if fail:
- self.assertFalse(parsed.valid)
- return
- self.assertTrue(parsed.valid)
- self.assertEqual(parsed.issue, issue)
- self.assertEqual(parsed.patchset, patchset)
- self.assertEqual(parsed.hostname, hostname)
- def test_basic(self):
- self._test('123', 123)
- self._test('', fail=True)
- self._test('abc', fail=True)
- self._test('123/1', fail=True)
- self._test('123a', fail=True)
- self._test('ssh://chrome-review.source.com/#/c/123/4/', fail=True)
- self._test('ssh://chrome-review.source.com/c/123/1/', fail=True)
- def test_gerrit_url(self):
- self._test('https://codereview.source.com/123', 123, None,
- 'codereview.source.com')
- self._test('http://chrome-review.source.com/c/123', 123, None,
- 'chrome-review.source.com')
- self._test('https://chrome-review.source.com/c/123/', 123, None,
- 'chrome-review.source.com')
- self._test('https://chrome-review.source.com/c/123/4', 123, 4,
- 'chrome-review.source.com')
- self._test('https://chrome-review.source.com/#/c/123/4', 123, 4,
- 'chrome-review.source.com')
- self._test('https://chrome-review.source.com/c/123/4', 123, 4,
- 'chrome-review.source.com')
- self._test('https://chrome-review.source.com/123', 123, None,
- 'chrome-review.source.com')
- self._test('https://chrome-review.source.com/123/4', 123, 4,
- 'chrome-review.source.com')
- self._test('https://chrome-review.source.com/bad/123/4', fail=True)
- self._test('https://chrome-review.source.com/c/123/1/whatisthis', fail=True)
- self._test('https://chrome-review.source.com/c/abc/', fail=True)
- def test_short_urls(self):
- self._test('https://crrev.com/c/2151934', 2151934, None,
- 'chromium-review.googlesource.com')
- def test_missing_scheme(self):
- self._test('codereview.source.com/123', 123, None, 'codereview.source.com')
- self._test('crrev.com/c/2151934', 2151934, None,
- 'chromium-review.googlesource.com')
- class GitCookiesCheckerTest(unittest.TestCase):
- def setUp(self):
- super(GitCookiesCheckerTest, self).setUp()
- self.c = git_cl._GitCookiesChecker()
- self.c._all_hosts = []
- mock.patch('sys.stdout', StringIO()).start()
- self.addCleanup(mock.patch.stopall)
- def mock_hosts_creds(self, subhost_identity_pairs):
- def ensure_googlesource(h):
- if not h.endswith(git_cl._GOOGLESOURCE):
- assert not h.endswith('.')
- return h + '.' + git_cl._GOOGLESOURCE
- return h
- self.c._all_hosts = [(ensure_googlesource(h), i, '.gitcookies')
- for h, i in subhost_identity_pairs]
- def test_identity_parsing(self):
- self.assertEqual(self.c._parse_identity('ldap.google.com'),
- ('ldap', 'google.com'))
- self.assertEqual(self.c._parse_identity('git-ldap.example.com'),
- ('ldap', 'example.com'))
- # Specical case because we know there are no subdomains in chromium.org.
- self.assertEqual(self.c._parse_identity('git-note.period.chromium.org'),
- ('note.period', 'chromium.org'))
- # Pathological: ".period." can be either username OR domain, more likely
- # domain.
- self.assertEqual(self.c._parse_identity('git-note.period.example.com'),
- ('note', 'period.example.com'))
- def test_analysis_nothing(self):
- self.c._all_hosts = []
- self.assertFalse(self.c.has_generic_host())
- self.assertEqual(set(), self.c.get_conflicting_hosts())
- self.assertEqual(set(), self.c.get_duplicated_hosts())
- self.assertEqual(set(), self.c.get_partially_configured_hosts())
- def test_analysis(self):
- self.mock_hosts_creds([
- ('.googlesource.com', 'git-example.chromium.org'),
- ('chromium', 'git-example.google.com'),
- ('chromium-review', 'git-example.google.com'),
- ('chrome-internal', 'git-example.chromium.org'),
- ('chrome-internal-review', 'git-example.chromium.org'),
- ('conflict', 'git-example.google.com'),
- ('conflict-review', 'git-example.chromium.org'),
- ('dup', 'git-example.google.com'),
- ('dup', 'git-example.google.com'),
- ('dup-review', 'git-example.google.com'),
- ('partial', 'git-example.google.com'),
- ('gpartial-review', 'git-example.google.com'),
- ])
- self.assertTrue(self.c.has_generic_host())
- self.assertEqual(set(['conflict.googlesource.com']),
- self.c.get_conflicting_hosts())
- self.assertEqual(set(['dup.googlesource.com']),
- self.c.get_duplicated_hosts())
- self.assertEqual(set(['partial.googlesource.com',
- 'gpartial-review.googlesource.com']),
- self.c.get_partially_configured_hosts())
- def test_report_no_problems(self):
- self.test_analysis_nothing()
- self.assertFalse(self.c.find_and_report_problems())
- self.assertEqual(sys.stdout.getvalue(), '')
- @mock.patch(
- 'git_cl.gerrit_util.CookiesAuthenticator.get_gitcookies_path',
- return_value=os.path.join('~', '.gitcookies'))
- def test_report(self, *_mocks):
- self.test_analysis()
- self.assertTrue(self.c.find_and_report_problems())
- with open(os.path.join(os.path.dirname(__file__),
- 'git_cl_creds_check_report.txt')) as f:
- expected = f.read() % {
- 'sep': os.sep,
- }
- def by_line(text):
- return [l.rstrip() for l in text.rstrip().splitlines()]
- self.maxDiff = 10000 # pylint: disable=attribute-defined-outside-init
- self.assertEqual(by_line(sys.stdout.getvalue().strip()), by_line(expected))
- class TestGitCl(unittest.TestCase):
- def setUp(self):
- super(TestGitCl, self).setUp()
- self.calls = []
- self._calls_done = []
- self.failed = False
- mock.patch('sys.stdout', StringIO()).start()
- mock.patch(
- 'git_cl.time_time',
- lambda: self._mocked_call('time.time')).start()
- mock.patch(
- 'git_cl.metrics.collector.add_repeated',
- lambda *a: self._mocked_call('add_repeated', *a)).start()
- mock.patch('subprocess2.call', self._mocked_call).start()
- mock.patch('subprocess2.check_call', self._mocked_call).start()
- mock.patch('subprocess2.check_output', self._mocked_call).start()
- mock.patch(
- 'subprocess2.communicate',
- lambda *a, **_k: ([self._mocked_call(*a), ''], 0)).start()
- mock.patch(
- 'git_cl.gclient_utils.CheckCallAndFilter',
- self._mocked_call).start()
- mock.patch('git_common.is_dirty_git_tree', lambda x: False).start()
- mock.patch('git_cl.FindCodereviewSettingsFile', return_value='').start()
- mock.patch(
- 'git_cl.SaveDescriptionBackup',
- lambda _: self._mocked_call('SaveDescriptionBackup')).start()
- mock.patch(
- 'git_cl.write_json',
- lambda *a: self._mocked_call('write_json', *a)).start()
- mock.patch(
- 'git_cl.Changelist.RunHook',
- return_value={'more_cc': ['test-more-cc@chromium.org']}).start()
- mock.patch('git_cl.watchlists.Watchlists', WatchlistsMock).start()
- mock.patch('git_cl.auth.Authenticator', AuthenticatorMock).start()
- mock.patch('gerrit_util.GetChangeDetail').start()
- mock.patch(
- 'git_cl.gerrit_util.GetChangeComments',
- lambda *a: self._mocked_call('GetChangeComments', *a)).start()
- mock.patch(
- 'git_cl.gerrit_util.GetChangeRobotComments',
- lambda *a: self._mocked_call('GetChangeRobotComments', *a)).start()
- mock.patch(
- 'git_cl.gerrit_util.AddReviewers',
- lambda *a: self._mocked_call('AddReviewers', *a)).start()
- mock.patch(
- 'git_cl.gerrit_util.SetReview',
- lambda h, i, msg=None, labels=None, notify=None, ready=None: (
- self._mocked_call(
- 'SetReview', h, i, msg, labels, notify, ready))).start()
- mock.patch(
- 'git_cl.gerrit_util.LuciContextAuthenticator.is_luci',
- return_value=False).start()
- mock.patch(
- 'git_cl.gerrit_util.GceAuthenticator.is_gce',
- return_value=False).start()
- mock.patch(
- 'git_cl.gerrit_util.ValidAccounts',
- lambda *a: self._mocked_call('ValidAccounts', *a)).start()
- mock.patch('sys.exit', side_effect=SystemExitMock).start()
- mock.patch('git_cl.Settings.GetRoot', return_value='').start()
- self.mockGit = GitMocks()
- mock.patch('scm.GIT.GetBranchRef', self.mockGit.GetBranchRef).start()
- mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
- mock.patch('scm.GIT.ResolveCommit', return_value='hash').start()
- mock.patch('scm.GIT.IsValidRevision', return_value=True).start()
- mock.patch('scm.GIT.SetConfig', self.mockGit.SetConfig).start()
- mock.patch(
- 'git_new_branch.create_new_branch', self.mockGit.NewBranch).start()
- mock.patch(
- 'scm.GIT.FetchUpstreamTuple',
- return_value=('origin', 'refs/heads/main')).start()
- mock.patch(
- 'scm.GIT.CaptureStatus', return_value=[('M', 'foo.txt')]).start()
- # It's important to reset settings to not have inter-tests interference.
- git_cl.settings = None
- self.addCleanup(mock.patch.stopall)
- def tearDown(self):
- try:
- if not self.failed:
- self.assertEqual([], self.calls)
- except AssertionError:
- calls = ''.join(' %s\n' % str(call) for call in self.calls[:5])
- if len(self.calls) > 5:
- calls += ' ...\n'
- self.fail(
- '\n'
- 'There are un-consumed calls after this test has finished:\n' +
- calls)
- finally:
- super(TestGitCl, self).tearDown()
- def _mocked_call(self, *args, **_kwargs):
- self.assertTrue(
- self.calls,
- '@%d Expected: <Missing> Actual: %r' % (len(self._calls_done), args))
- top = self.calls.pop(0)
- expected_args, result = top
- # Also logs otherwise it could get caught in a try/finally and be hard to
- # diagnose.
- if expected_args != args:
- N = 5
- prior_calls = '\n '.join(
- '@%d: %r' % (len(self._calls_done) - N + i, c[0])
- for i, c in enumerate(self._calls_done[-N:]))
- following_calls = '\n '.join(
- '@%d: %r' % (len(self._calls_done) + i + 1, c[0])
- for i, c in enumerate(self.calls[:N]))
- extended_msg = (
- 'A few prior calls:\n %s\n\n'
- 'This (expected):\n @%d: %r\n'
- 'This (actual):\n @%d: %r\n\n'
- 'A few following expected calls:\n %s' %
- (prior_calls, len(self._calls_done), expected_args,
- len(self._calls_done), args, following_calls))
- self.failed = True
- self.fail('@%d\n'
- ' Expected: %r\n'
- ' Actual: %r\n'
- '\n'
- '%s' % (
- len(self._calls_done), expected_args, args, extended_msg))
- self._calls_done.append(top)
- if isinstance(result, Exception):
- raise result
- # stdout from git commands is supposed to be a bytestream. Convert it here
- # instead of converting all test output in this file to bytes.
- if args[0][0] == 'git' and not isinstance(result, bytes):
- result = result.encode('utf-8')
- return result
- @mock.patch('sys.stdin', StringIO('blah\nye\n'))
- @mock.patch('sys.stdout', StringIO())
- def test_ask_for_explicit_yes_true(self):
- self.assertTrue(git_cl.ask_for_explicit_yes('prompt'))
- self.assertEqual(
- 'prompt [Yes/No]: Please, type yes or no: ',
- sys.stdout.getvalue())
- def test_LoadCodereviewSettingsFromFile_gerrit(self):
- codereview_file = StringIO('GERRIT_HOST: true')
- self.calls = [
- ((['git', 'config', '--unset-all', 'rietveld.cc'],), CERR1),
- ((['git', 'config', '--unset-all', 'rietveld.tree-status-url'],), CERR1),
- ((['git', 'config', '--unset-all', 'rietveld.viewvc-url'],), CERR1),
- ((['git', 'config', '--unset-all', 'rietveld.bug-prefix'],), CERR1),
- ((['git', 'config', '--unset-all', 'rietveld.cpplint-regex'],), CERR1),
- ((['git', 'config', '--unset-all', 'rietveld.cpplint-ignore-regex'],),
- CERR1),
- ((['git', 'config', '--unset-all', 'rietveld.run-post-upload-hook'],),
- CERR1),
- ((['git', 'config', '--unset-all', 'rietveld.format-full-by-default'],),
- CERR1),
- ((['git', 'config', '--unset-all', 'rietveld.use-python3'],),
- CERR1),
- ((['git', 'config', 'gerrit.host', 'true'],), ''),
- ]
- self.assertIsNone(git_cl.LoadCodereviewSettingsFromFile(codereview_file))
- @classmethod
- def _gerrit_base_calls(cls, issue=None, fetched_description=None,
- fetched_status=None, other_cl_owner=None,
- custom_cl_base=None, short_hostname='chromium',
- change_id=None, default_branch='main',
- reset_issue=False):
- calls = []
- if custom_cl_base:
- ancestor_revision = custom_cl_base
- else:
- # Determine ancestor_revision to be merge base.
- ancestor_revision = 'origin/' + default_branch
- if issue:
- # TODO: if tests don't provide a `change_id` the default used here
- # will cause the TRACES_README_FORMAT mock (which uses the test provided
- # `change_id` to fail.
- gerrit_util.GetChangeDetail.return_value = {
- 'owner': {'email': (other_cl_owner or 'owner@example.com')},
- 'change_id': (change_id or '123456789'),
- 'current_revision': 'sha1_of_current_revision',
- 'revisions': {'sha1_of_current_revision': {
- 'commit': {'message': fetched_description},
- }},
- 'status': fetched_status or 'NEW',
- }
- if fetched_status == 'ABANDONED':
- return calls
- if fetched_status == 'MERGED':
- calls.append(
- (('ask_for_data',
- 'Change https://chromium-review.googlesource.com/%s has been '
- 'submitted, new uploads are not allowed. Would you like to start '
- 'a new change (Y/n)?' % issue), 'y' if reset_issue else 'n')
- )
- if not reset_issue:
- return calls
- # Part of SetIssue call.
- calls.append(
- ((['git', 'log', '-1', '--format=%B'],), ''))
- if other_cl_owner:
- calls += [
- (('ask_for_data', 'Press Enter to upload, or Ctrl+C to abort'), ''),
- ]
- calls += [
- ((['git', 'diff', '--no-ext-diff', '--stat', '-l100000', '-C50'] +
- ([custom_cl_base] if custom_cl_base else
- [ancestor_revision, 'HEAD']),),
- '+dat'),
- ]
- return calls
- def _gerrit_upload_calls(self,
- description,
- reviewers,
- squash,
- squash_mode='default',
- title=None,
- notify=False,
- post_amend_description=None,
- issue=None,
- cc=None,
- custom_cl_base=None,
- short_hostname='chromium',
- labels=None,
- change_id=None,
- final_description=None,
- gitcookies_exists=True,
- force=False,
- edit_description=None,
- default_branch='main',
- ref_to_push='abcdef0123456789',
- external_parent=None,
- push_opts=None):
- if post_amend_description is None:
- post_amend_description = description
- cc = cc or []
- calls = []
- if squash_mode in ('override_squash', 'override_nosquash'):
- self.mockGit.config['gerrit.override-squash-uploads'] = (
- 'true' if squash_mode == 'override_squash' else 'false')
- if not git_footers.get_footer_change_id(description) and not squash:
- calls += [
- (('DownloadGerritHook', False), ''),
- ]
- if squash:
- if not issue and not force:
- calls += [
- ((['RunEditor'],), description),
- ]
- # user wants to edit description
- if edit_description:
- calls += [
- ((['RunEditor'],), edit_description),
- ]
- if external_parent:
- parent = external_parent
- else:
- if custom_cl_base is None:
- parent = 'origin/' + default_branch
- git_common.get_or_create_merge_base.return_value = parent
- else:
- calls += [
- (([
- 'git', 'merge-base', '--is-ancestor', custom_cl_base,
- 'refs/remotes/origin/' + default_branch
- ], ), callError(1)), # Means not ancenstor.
- (('ask_for_data',
- 'Do you take responsibility for cleaning up potential mess '
- 'resulting from proceeding with upload? Press Enter to upload, '
- 'or Ctrl+C to abort'), ''),
- ]
- parent = custom_cl_base
- calls += [
- ((['git', 'rev-parse', 'HEAD:'],), # `HEAD:` means HEAD's tree hash.
- '0123456789abcdef'),
- ((['FileWrite', '/tmp/fake-temp1', description],), None),
- ((['git', 'commit-tree', '0123456789abcdef', '-p', parent,
- '-F', '/tmp/fake-temp1'],),
- ref_to_push),
- ]
- else:
- ref_to_push = 'HEAD'
- parent = 'origin/refs/heads/' + default_branch
- calls += [
- (('SaveDescriptionBackup',), None),
- ((['git', 'rev-list', parent + '..' + ref_to_push],),'1hashPerLine\n'),
- ]
- metrics_arguments = []
- if notify:
- ref_suffix = '%ready,notify=ALL'
- metrics_arguments += ['ready', 'notify=ALL']
- else:
- if not issue and squash:
- ref_suffix = '%wip'
- metrics_arguments.append('wip')
- else:
- ref_suffix = '%notify=NONE'
- metrics_arguments.append('notify=NONE')
- # If issue is given, then description is fetched from Gerrit instead.
- if not title:
- if issue is None:
- if squash:
- title = 'Initial upload'
- else:
- calls += [
- ((['git', 'show', '-s', '--format=%s', 'HEAD'],), ''),
- (('ask_for_data', 'Title for patchset []: '), 'User input'),
- ]
- title = 'User input'
- if title:
- ref_suffix += ',m=' + gerrit_util.PercentEncodeForGitRef(title)
- metrics_arguments.append('m')
- if short_hostname == 'chromium':
- # All reviewers and ccs get into ref_suffix.
- for r in sorted(reviewers):
- ref_suffix += ',r=%s' % r
- metrics_arguments.append('r')
- if issue is None:
- cc += ['test-more-cc@chromium.org', 'joe@example.com']
- for c in sorted(cc):
- ref_suffix += ',cc=%s' % c
- metrics_arguments.append('cc')
- reviewers, cc = [], []
- else:
- # TODO(crbug/877717): remove this case.
- calls += [
- (('ValidAccounts', '%s-review.googlesource.com' % short_hostname,
- sorted(reviewers) + ['joe@example.com',
- 'test-more-cc@chromium.org'] + cc),
- {
- e: {'email': e}
- for e in (reviewers + ['joe@example.com'] + cc)
- })
- ]
- for r in sorted(reviewers):
- if r != 'bad-account-or-email':
- ref_suffix += ',r=%s' % r
- metrics_arguments.append('r')
- reviewers.remove(r)
- if issue is None:
- cc += ['joe@example.com']
- for c in sorted(cc):
- ref_suffix += ',cc=%s' % c
- metrics_arguments.append('cc')
- if c in cc:
- cc.remove(c)
- for k, v in sorted((labels or {}).items()):
- ref_suffix += ',l=%s+%d' % (k, v)
- metrics_arguments.append('l=%s+%d' % (k, v))
- calls += [
- (
- ('time.time', ),
- 1000,
- ),
- (
- ([
- 'git', 'push',
- 'https://%s.googlesource.com/my/repo' % short_hostname,
- ref_to_push + ':refs/for/refs/heads/' + default_branch +
- ref_suffix
- ] + (push_opts if push_opts else []), ),
- (('remote:\n'
- 'remote: Processing changes: (\)\n'
- 'remote: Processing changes: (|)\n'
- 'remote: Processing changes: (/)\n'
- 'remote: Processing changes: (-)\n'
- 'remote: Processing changes: new: 1 (/)\n'
- 'remote: Processing changes: new: 1, done\n'
- 'remote:\n'
- 'remote: New Changes:\n'
- 'remote: '
- 'https://%s-review.googlesource.com/#/c/my/repo/+/123456'
- ' XXX\n'
- 'remote:\n'
- 'To https://%s.googlesource.com/my/repo\n'
- ' * [new branch] hhhh -> refs/for/refs/heads/%s\n') %
- (short_hostname, short_hostname, default_branch)),
- ),
- (
- ('time.time', ),
- 2000,
- ),
- (
- ('add_repeated', 'sub_commands', {
- 'execution_time': 1000,
- 'command': 'git push',
- 'exit_code': 0,
- 'arguments': sorted(metrics_arguments),
- }),
- None,
- ),
- ]
- final_description = final_description or post_amend_description.strip()
- trace_name = os.path.join('TRACES_DIR', '20170316T200041.000000')
- # Trace-related calls
- calls += [
- # Write a description with context for the current trace.
- (
- ([
- 'FileWrite', trace_name + '-README',
- '%(date)s\n'
- '%(short_hostname)s-review.googlesource.com\n'
- '%(change_id)s\n'
- '%(title)s\n'
- '%(description)s\n'
- '1000\n'
- '0\n'
- '%(trace_name)s' % {
- 'date': '2017-03-16T20:00:41.000000',
- 'short_hostname': short_hostname,
- 'change_id': change_id,
- 'description': final_description,
- 'title': title or '<untitled>',
- 'trace_name': trace_name,
- }
- ], ),
- None,
- ),
- # Read traces and shorten git hashes.
- (
- (['os.path.isfile',
- os.path.join('TEMP_DIR', 'trace-packet')], ),
- True,
- ),
- (
- (['FileRead', os.path.join('TEMP_DIR', 'trace-packet')], ),
- ('git-hash: 0123456789012345678901234567890123456789\n'
- 'git-hash: abcdeabcdeabcdeabcdeabcdeabcdeabcdeabcde\n'),
- ),
- (
- ([
- 'FileWrite',
- os.path.join('TEMP_DIR', 'trace-packet'), 'git-hash: 012345\n'
- 'git-hash: abcdea\n'
- ], ),
- None,
- ),
- # Make zip file for the git traces.
- (
- (['make_archive', trace_name + '-traces', 'zip', 'TEMP_DIR'], ),
- None,
- ),
- # Collect git config and gitcookies.
- (
- (['git', 'config', '-l'], ),
- 'git-config-output',
- ),
- (
- ([
- 'FileWrite',
- os.path.join('TEMP_DIR', 'git-config'), 'git-config-output'
- ], ),
- None,
- ),
- (
- (['os.path.isfile',
- os.path.join('~', '.gitcookies')], ),
- gitcookies_exists,
- ),
- ]
- if gitcookies_exists:
- calls += [
- (
- (['FileRead', os.path.join('~', '.gitcookies')], ),
- 'gitcookies 1/SECRET',
- ),
- (
- ([
- 'FileWrite',
- os.path.join('TEMP_DIR', 'gitcookies'), 'gitcookies REDACTED'
- ], ),
- None,
- ),
- ]
- calls += [
- # Make zip file for the git config and gitcookies.
- (
- (['make_archive', trace_name + '-git-info', 'zip', 'TEMP_DIR'], ),
- None,
- ),
- ]
- # TODO(crbug/877717): this should never be used.
- if squash and short_hostname != 'chromium':
- calls += [
- (('AddReviewers',
- 'chromium-review.googlesource.com', 'my%2Frepo~123456',
- sorted(reviewers),
- cc + ['test-more-cc@chromium.org'],
- notify),
- ''),
- ]
- return calls
- def _run_gerrit_upload_test(self,
- upload_args,
- description,
- reviewers=None,
- squash=True,
- squash_mode=None,
- title=None,
- notify=False,
- post_amend_description=None,
- issue=None,
- patchset=None,
- cc=None,
- fetched_status=None,
- other_cl_owner=None,
- custom_cl_base=None,
- short_hostname='chromium',
- labels=None,
- change_id=None,
- final_description=None,
- gitcookies_exists=True,
- force=False,
- log_description=None,
- edit_description=None,
- fetched_description=None,
- default_branch='main',
- ref_to_push='abcdef0123456789',
- external_parent=None,
- push_opts=None,
- reset_issue=False):
- """Generic gerrit upload test framework."""
- if squash_mode is None:
- if '--no-squash' in upload_args:
- squash_mode = 'nosquash'
- elif '--squash' in upload_args:
- squash_mode = 'squash'
- else:
- squash_mode = 'default'
- reviewers = reviewers or []
- cc = cc or []
- mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
- CookiesAuthenticatorMockFactory(
- same_auth=('git-owner.example.com', '', 'pass'))).start()
- mock.patch('git_cl.Changelist._GerritCommitMsgHookCheck',
- lambda _, offer_removal: None).start()
- mock.patch('git_cl.Changelist.GetMostRecentPatchset', lambda _, update:
- patchset).start()
- mock.patch('git_cl.gclient_utils.RunEditor',
- lambda *_, **__: self._mocked_call(['RunEditor'])).start()
- mock.patch('git_cl.DownloadGerritHook', lambda force: self._mocked_call(
- 'DownloadGerritHook', force)).start()
- mock.patch('git_cl.gclient_utils.FileRead',
- lambda path: self._mocked_call(['FileRead', path])).start()
- mock.patch('git_cl.gclient_utils.FileWrite',
- lambda path, contents: self._mocked_call(
- ['FileWrite', path, contents])).start()
- mock.patch('git_cl.datetime_now',
- lambda: datetime.datetime(2017, 3, 16, 20, 0, 41, 0)).start()
- mock.patch('git_cl.tempfile.mkdtemp', lambda: 'TEMP_DIR').start()
- mock.patch('git_cl.TRACES_DIR', 'TRACES_DIR').start()
- mock.patch('git_cl.TRACES_README_FORMAT',
- '%(now)s\n'
- '%(gerrit_host)s\n'
- '%(change_id)s\n'
- '%(title)s\n'
- '%(description)s\n'
- '%(execution_time)s\n'
- '%(exit_code)s\n'
- '%(trace_name)s').start()
- mock.patch('git_cl.shutil.make_archive',
- lambda *args: self._mocked_call(['make_archive'] +
- list(args))).start()
- mock.patch('os.path.isfile',
- lambda path: self._mocked_call(['os.path.isfile', path])).start()
- mock.patch(
- 'git_cl._create_description_from_log',
- return_value=log_description or description).start()
- mock.patch(
- 'git_cl.Changelist._AddChangeIdToCommitMessage',
- return_value=post_amend_description or description).start()
- mock.patch(
- 'git_cl.GenerateGerritChangeId', return_value=change_id).start()
- mock.patch(
- 'git_common.get_or_create_merge_base',
- return_value='origin/' + default_branch).start()
- mock.patch(
- 'gclient_utils.AskForData',
- lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
- self.mockGit.config['gerrit.host'] = 'true'
- self.mockGit.config['branch.main.gerritissue'] = (
- str(issue) if issue else None)
- self.mockGit.config['remote.origin.url'] = (
- 'https://%s.googlesource.com/my/repo' % short_hostname)
- self.mockGit.config['user.email'] = 'me@example.com'
- self.calls = self._gerrit_base_calls(
- issue=issue,
- fetched_description=fetched_description or description,
- fetched_status=fetched_status,
- other_cl_owner=other_cl_owner,
- custom_cl_base=custom_cl_base,
- short_hostname=short_hostname,
- change_id=change_id,
- default_branch=default_branch,
- reset_issue=reset_issue)
- if fetched_status == 'ABANDONED' or (
- fetched_status == 'MERGED' and not reset_issue):
- pass # readability
- else:
- if fetched_status == 'MERGED' and reset_issue:
- fetched_status = 'NEW'
- issue = None
- mock.patch(
- 'gclient_utils.temporary_file', TemporaryFileMock()).start()
- mock.patch('os.remove', return_value=True).start()
- self.calls += self._gerrit_upload_calls(
- description,
- reviewers,
- squash,
- squash_mode=squash_mode,
- title=title,
- notify=notify,
- post_amend_description=post_amend_description,
- issue=issue,
- cc=cc,
- custom_cl_base=custom_cl_base,
- short_hostname=short_hostname,
- labels=labels,
- change_id=change_id,
- final_description=final_description,
- gitcookies_exists=gitcookies_exists,
- force=force,
- edit_description=edit_description,
- default_branch=default_branch,
- ref_to_push=ref_to_push,
- external_parent=external_parent,
- push_opts=push_opts)
- # Uncomment when debugging.
- # print('\n'.join(map(lambda x: '%2i: %s' % x, enumerate(self.calls))))
- git_cl.main(['upload'] + upload_args)
- if squash:
- self.assertIssueAndPatchset(patchset=str((patchset or 0) + 1))
- self.assertEqual(
- ref_to_push,
- scm.GIT.GetBranchConfig('', 'main',
- git_cl.GERRIT_SQUASH_HASH_CONFIG_KEY))
- def test_gerrit_upload_traces_no_gitcookies(self):
- self._run_gerrit_upload_test(
- ['--no-squash'],
- 'desc ✔\n\nBUG=\n',
- [],
- squash=False,
- post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
- change_id='Ixxx',
- gitcookies_exists=False)
- def test_gerrit_upload_without_change_id(self):
- self._run_gerrit_upload_test(
- [],
- 'desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
- [],
- change_id='Ixxx')
- def test_gerrit_upload_without_change_id_nosquash(self):
- self._run_gerrit_upload_test(
- ['--no-squash'],
- 'desc ✔\n\nBUG=\n',
- [],
- squash=False,
- post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
- change_id='Ixxx')
- def test_gerrit_upload_without_change_id_override_nosquash(self):
- self._run_gerrit_upload_test(
- [],
- 'desc ✔\n\nBUG=\n',
- [],
- squash=False,
- squash_mode='override_nosquash',
- post_amend_description='desc ✔\n\nBUG=\n\nChange-Id: Ixxx',
- change_id='Ixxx')
- def test_gerrit_no_reviewer(self):
- self._run_gerrit_upload_test(
- [],
- 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
- [],
- squash=False,
- squash_mode='override_nosquash',
- change_id='I123456789')
- def test_gerrit_push_opts(self):
- self._run_gerrit_upload_test(['-o', 'wip'],
- 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
- [],
- squash=False,
- squash_mode='override_nosquash',
- change_id='I123456789',
- push_opts=['-o', 'wip'])
- def test_gerrit_no_reviewer_non_chromium_host(self):
- # TODO(crbug/877717): remove this test case.
- self._run_gerrit_upload_test([],
- 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
- [],
- squash=False,
- squash_mode='override_nosquash',
- short_hostname='other',
- change_id='I123456789')
- def test_gerrit_patchset_title_special_chars_nosquash(self):
- self._run_gerrit_upload_test(
- ['-f', '-t', 'We\'ll escape ^_ ^ special chars...@{u}'],
- 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
- squash=False,
- squash_mode='override_nosquash',
- change_id='I123456789',
- title='We\'ll escape ^_ ^ special chars...@{u}')
- def test_gerrit_reviewers_cmd_line(self):
- self._run_gerrit_upload_test(
- ['-r', 'foo@example.com', '--send-mail'],
- 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
- reviewers=['foo@example.com'],
- squash=False,
- squash_mode='override_nosquash',
- notify=True,
- change_id='I123456789',
- final_description=(
- 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
- def test_gerrit_reviewers_cmd_line_send_email(self):
- self._run_gerrit_upload_test(
- ['-r', 'foo@example.com', '--send-email'],
- 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
- reviewers=['foo@example.com'],
- squash=False,
- squash_mode='override_nosquash',
- notify=True,
- change_id='I123456789',
- final_description=(
- 'desc ✔\n\nBUG=\nR=foo@example.com\n\nChange-Id: I123456789'))
- def test_gerrit_upload_force_sets_bug(self):
- self._run_gerrit_upload_test(
- ['-b', '10000', '-f'],
- u'desc=\n\nBug: 10000\nChange-Id: Ixxx',
- [],
- force=True,
- fetched_description='desc=\n\nChange-Id: Ixxx',
- change_id='Ixxx')
- def test_gerrit_upload_corrects_wrong_change_id(self):
- self._run_gerrit_upload_test(
- ['-b', '10000', '-m', 'Title', '--edit-description'],
- u'desc=\n\nBug: 10000\nChange-Id: Ixxxx',
- [],
- issue='123456',
- edit_description='desc=\n\nBug: 10000\nChange-Id: Izzzz',
- fetched_description='desc=\n\nChange-Id: Ixxxx',
- title='Title',
- change_id='Ixxxx')
- def test_gerrit_upload_force_sets_fixed(self):
- self._run_gerrit_upload_test(
- ['-x', '10000', '-f'],
- u'desc=\n\nFixed: 10000\nChange-Id: Ixxx',
- [],
- force=True,
- fetched_description='desc=\n\nChange-Id: Ixxx',
- change_id='Ixxx')
- def test_gerrit_reviewer_multiple(self):
- self._run_gerrit_upload_test([], 'desc ✔\nBUG=\nR=another@example.com\n'
- 'CC=more@example.com,people@example.com\n\n'
- 'Change-Id: 123456789',
- ['another@example.com'],
- cc=['more@example.com', 'people@example.com'],
- change_id='123456789')
- def test_gerrit_upload_squash_first_is_default(self):
- self._run_gerrit_upload_test(
- [],
- 'desc ✔\nBUG=\n\nChange-Id: 123456789',
- [],
- change_id='123456789')
- def test_gerrit_upload_squash_first(self):
- self._run_gerrit_upload_test(
- ['--squash'],
- 'desc ✔\nBUG=\n\nChange-Id: 123456789',
- [],
- squash=True,
- change_id='123456789')
- def test_gerrit_upload_squash_first_title(self):
- self._run_gerrit_upload_test(
- ['-f', '-t', 'title'],
- 'title\n\ndesc\n\nChange-Id: 123456789',
- [],
- title='title',
- force=True,
- squash=True,
- log_description='desc',
- change_id='123456789')
- def test_gerrit_upload_squash_first_with_labels(self):
- self._run_gerrit_upload_test(
- ['--squash', '--cq-dry-run', '--enable-auto-submit'],
- 'desc ✔\nBUG=\n\nChange-Id: 123456789',
- [],
- squash=True,
- labels={'Commit-Queue': 1, 'Auto-Submit': 1},
- change_id='123456789')
- def test_gerrit_upload_squash_first_against_rev(self):
- custom_cl_base = 'custom_cl_base_rev_or_branch'
- self._run_gerrit_upload_test(
- ['--squash', custom_cl_base],
- 'desc ✔\nBUG=\n\nChange-Id: 123456789',
- [],
- squash=True,
- custom_cl_base=custom_cl_base,
- change_id='123456789')
- self.assertIn(
- 'If you proceed with upload, more than 1 CL may be created by Gerrit',
- sys.stdout.getvalue())
- def test_gerrit_upload_squash_reupload(self):
- description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
- self._run_gerrit_upload_test(
- ['--squash'],
- description,
- [],
- squash=True,
- issue=123456,
- change_id='123456789')
- @mock.patch('sys.stderr', StringIO())
- def test_gerrit_upload_squash_reupload_to_abandoned(self):
- description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
- with self.assertRaises(SystemExitMock):
- self._run_gerrit_upload_test(
- ['--squash'],
- description,
- [],
- squash=True,
- issue=123456,
- fetched_status='ABANDONED',
- change_id='123456789')
- self.assertEqual(
- 'Change https://chromium-review.googlesource.com/123456 has been '
- 'abandoned, new uploads are not allowed\n',
- sys.stderr.getvalue())
- @mock.patch(
- 'gerrit_util.GetAccountDetails',
- return_value={'email': 'yet-another@example.com'})
- def test_gerrit_upload_squash_reupload_to_not_owned(self, _mock):
- description = 'desc ✔\nBUG=\n\nChange-Id: 123456789'
- self._run_gerrit_upload_test(
- ['--squash'],
- description,
- [],
- squash=True,
- issue=123456,
- other_cl_owner='other@example.com',
- change_id='123456789')
- self.assertIn(
- 'WARNING: Change 123456 is owned by other@example.com, but you '
- 'authenticate to Gerrit as yet-another@example.com.\n'
- 'Uploading may fail due to lack of permissions',
- sys.stdout.getvalue())
- @mock.patch('sys.stderr', StringIO())
- def test_gerrit_upload_for_merged(self):
- with self.assertRaises(SystemExitMock):
- self._run_gerrit_upload_test(
- [],
- 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
- [],
- issue=123456,
- fetched_status='MERGED',
- change_id='I123456789',
- reset_issue=False)
- self.assertEqual(
- 'New uploads are not allowed.\n',
- sys.stderr.getvalue())
- def test_gerrit_upload_new_issue_for_merged(self):
- self._run_gerrit_upload_test(
- [],
- 'desc ✔\n\nBUG=\n\nChange-Id: I123456789',
- [],
- issue=123456,
- fetched_status='MERGED',
- change_id='I123456789',
- reset_issue=True)
- def test_upload_change_description_editor(self):
- fetched_description = 'foo\n\nChange-Id: 123456789'
- description = 'bar\n\nChange-Id: 123456789'
- self._run_gerrit_upload_test(
- ['--squash', '--edit-description'],
- description,
- [],
- fetched_description=fetched_description,
- squash=True,
- issue=123456,
- change_id='123456789',
- edit_description=description)
- @mock.patch('git_cl.Changelist._UpdateWithExternalChanges',
- return_value='newparent')
- def test_upload_change_uses_external_base(self, *_mocks):
- squash_hash = 'branch.main.' + git_cl.GERRIT_SQUASH_HASH_CONFIG_KEY
- self.mockGit.config[squash_hash] = 'beef2'
- self._run_gerrit_upload_test(
- ['--squash'],
- 'desc ✔\n\nBUG=\n\nChange-Id: 123456789',
- [],
- squash=True,
- issue=123456,
- change_id='123456789',
- ref_to_push='beef2',
- external_parent='newparent',
- )
- @mock.patch(
- 'git_cl.Changelist._GerritCommitMsgHookCheck', lambda offer_removal: None)
- @mock.patch('git_cl.Changelist.FetchUpstreamTuple')
- @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
- @mock.patch('git_cl.Changelist.GetBranch')
- @mock.patch('git_cl.Changelist.GetRemoteBranch')
- @mock.patch('scm.GIT.IsAncestor')
- @mock.patch('gclient_utils.AskForData')
- def test_upload_all_precheck_long_chain(self, mockAskForData, mockIsAncestor,
- mockGetRemoteBranch, mockGetBranch,
- mockGetCommonAncestorWithUpstream,
- mockFetchUpstreamTuple, *_mocks):
- mockGetRemoteBranch.return_value = ('origin', 'refs/remotes/origin/main')
- mockGetBranch.side_effect = [
- 'current', 'upstream3', 'upstream2', 'upstream1', 'main'
- ]
- mockGetCommonAncestorWithUpstream.side_effect = [
- 'commit3.5', 'commit2.5', 'commit1.5', 'commit0.5'
- ]
- mockFetchUpstreamTuple.side_effect = [('.', 'refs/heads/upstream3'),
- ('.', 'refs/heads/upstream2'),
- ('.', 'refs/heads/upstream1'),
- ('origin', 'refs/heads/main')]
- options = optparse.Values()
- options.force = False
- orig_args = ['--preserve-tryjobs', '--chicken']
- # Case 2: upstream3 has never been uploaded.
- # (so no LAST_UPLOAD_HASH_CONIFG_KEY)
- # Case 4: upstream2's last_upload is behind upstream3's base_commit
- self.mockGit.config['branch.upstream1.%s' %
- git_cl.LAST_UPLOAD_HASH_CONFIG_KEY] = 'commit2.3'
- mockIsAncestor.side_effect = [True]
- # Case 3: upstream1's last_upload matches upstream2's base_commit
- self.mockGit.config['branch.upstream1.%s' %
- git_cl.LAST_UPLOAD_HASH_CONFIG_KEY] = 'commit1.5'
- cls, cherry_pick = git_cl._UploadAllPrecheck(options, orig_args)
- self.assertFalse(cherry_pick)
- mockAskForData.assert_called_once_with(
- "\noptions ['--preserve-tryjobs', '--chicken'] will be used for all "
- "uploads.\nThere are upstream branches that must be uploaded.\n"
- "Press Enter to confirm, or Ctrl+C to abort")
- self.assertEqual(len(cls), 4)
- @mock.patch(
- 'git_cl.Changelist._GerritCommitMsgHookCheck', lambda offer_removal: None)
- @mock.patch('git_cl.Changelist.FetchUpstreamTuple')
- @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
- @mock.patch('git_cl.Changelist.GetBranch')
- @mock.patch('git_cl.Changelist.GetRemoteBranch')
- @mock.patch('scm.GIT.IsAncestor')
- @mock.patch('gclient_utils.AskForData')
- def test_upload_all_precheck_must_rebase(self, mockAskForData, mockIsAncestor,
- mockGetRemoteBranch, mockGetBranch,
- mockGetCommonAncestorWithUpstream,
- mockFetchUpstreamTuple, *_mocks):
- options = optparse.Values()
- options.force = False
- orig_args = ['--preserve-tryjobs', '--chicken']
- mockGetRemoteBranch.return_value = ('origin', 'refs/remotes/origin/main')
- mockGetBranch.side_effect = [
- 'current', 'upstream3', 'upstream2', 'upstream1', 'main'
- ]
- mockGetCommonAncestorWithUpstream.side_effect = [
- 'commit3.5', 'commit2.5', 'commit1.5', 'commit0.5'
- ]
- mockFetchUpstreamTuple.side_effect = [('.', 'refs/heads/upstream3'),
- ('.', 'refs/heads/upstream2'),
- ('.', 'refs/heads/upstream1'),
- ('origin', 'refs/heads/main')]
- # Case 5: current's base_commit is behind upstream3's last_upload.
- self.mockGit.config['branch.upstream3.%s' %
- git_cl.LAST_UPLOAD_HASH_CONFIG_KEY] = 'commit3.7'
- mockIsAncestor.side_effect = [False, True]
- with self.assertRaises(SystemExitMock):
- git_cl._UploadAllPrecheck(options, orig_args)
- @mock.patch(
- 'git_cl.Changelist._GerritCommitMsgHookCheck', lambda offer_removal: None)
- @mock.patch('git_cl.Changelist.FetchUpstreamTuple')
- @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
- @mock.patch('git_cl.Changelist.GetBranch')
- @mock.patch('git_cl.Changelist.GetRemoteBranch')
- @mock.patch('scm.GIT.IsAncestor')
- @mock.patch('gclient_utils.AskForData')
- def test_upload_all_precheck_hit_main(self, mockAskForData, mockIsAncestor,
- mockGetRemoteBranch, mockGetBranch,
- mockGetCommonAncestorWithUpstream,
- mockFetchUpstreamTuple, *_mocks):
- options = optparse.Values()
- options.force = False
- orig_args = ['--preserve-tryjobs', '--chicken']
- mockGetRemoteBranch.return_value = ('origin', 'refs/remotes/origin/main')
- mockGetBranch.return_value = ['current', 'upstream3', 'main']
- mockGetCommonAncestorWithUpstream.side_effect = ['commit3.5', 'commit0.5']
- mockFetchUpstreamTuple.side_effect = [('.', 'refs/heads/upstream3'),
- ('origin', 'refs/heads/main')]
- mockIsAncestor.return_value = True
- # Test user wants to cherry pick
- mockAskForData.return_value = 'n'
- # Give upstream3 a last upload hash
- self.mockGit.config['branch.upstream3.%s' %
- git_cl.LAST_UPLOAD_HASH_CONFIG_KEY] = 'commit3.4'
- # Case 1: We hit the main branch
- cls, cherry_pick = git_cl._UploadAllPrecheck(options, orig_args)
- self.assertTrue(cherry_pick)
- self.assertEqual(len(cls), 2)
- mockAskForData.assert_called_once_with(
- "\noptions ['--preserve-tryjobs', '--chicken'] will be used for all "
- "uploads.\n"
- "Press enter to update branches [None, 'upstream3'].\n"
- "Or type `n` to upload only `None` cherry-picked on upstream3's last "
- "upload:")
- @mock.patch(
- 'git_cl.Changelist._GerritCommitMsgHookCheck', lambda offer_removal: None)
- @mock.patch('git_cl.Changelist.FetchUpstreamTuple')
- @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
- @mock.patch('git_cl.Changelist.GetBranch')
- @mock.patch('git_cl.Changelist.GetRemoteBranch')
- @mock.patch('scm.GIT.IsAncestor')
- @mock.patch('gclient_utils.AskForData')
- def test_upload_all_precheck_one_change(self, mockAskForData, mockIsAncestor,
- mockGetRemoteBranch, mockGetBranch,
- mockGetCommonAncestorWithUpstream,
- mockFetchUpstreamTuple, *_mocks):
- options = optparse.Values()
- options.force = False
- orig_args = ['--preserve-tryjobs', '--chicken']
- mockGetRemoteBranch.return_value = ('origin', 'refs/remotes/origin/main')
- mockGetBranch.return_value = ['current', 'main']
- mockGetCommonAncestorWithUpstream.side_effect = ['commit3.5']
- mockFetchUpstreamTuple.side_effect = [('', 'refs/heads/main')]
- mockIsAncestor.return_value = True
- # Case 1: We hit the main branch
- cls, cherry_pick = git_cl._UploadAllPrecheck(options, orig_args)
- self.assertFalse(cherry_pick)
- self.assertEqual(len(cls), 1)
- mockAskForData.assert_not_called()
- @mock.patch('git_cl.RunGit')
- @mock.patch('git_cl.CMDupload')
- @mock.patch('sys.stdin', StringIO('\n'))
- @mock.patch('sys.stdout', StringIO())
- def test_upload_branch_deps(self, *_mocks):
- def mock_run_git(*args, **_kwargs):
- if args[0] == ['for-each-ref',
- '--format=%(refname:short) %(upstream:short)',
- 'refs/heads']:
- # Create a local branch dependency tree that looks like this:
- # test1 -> test2 -> test3 -> test4 -> test5
- # -> test3.1
- # test6 -> test0
- branch_deps = [
- 'test2 test1', # test1 -> test2
- 'test3 test2', # test2 -> test3
- 'test3.1 test2', # test2 -> test3.1
- 'test4 test3', # test3 -> test4
- 'test5 test4', # test4 -> test5
- 'test6 test0', # test0 -> test6
- 'test7', # test7
- ]
- return '\n'.join(branch_deps)
- git_cl.RunGit.side_effect = mock_run_git
- git_cl.CMDupload.return_value = 0
- class MockChangelist():
- def __init__(self):
- pass
- def GetBranch(self):
- return 'test1'
- def GetIssue(self):
- return '123'
- def GetPatchset(self):
- return '1001'
- def IsGerrit(self):
- return False
- ret = git_cl.upload_branch_deps(MockChangelist(), [])
- # CMDupload should have been called 5 times because of 5 dependent branches.
- self.assertEqual(5, len(git_cl.CMDupload.mock_calls))
- self.assertIn(
- 'This command will checkout all dependent branches '
- 'and run "git cl upload". Press Enter to continue, '
- 'or Ctrl+C to abort',
- sys.stdout.getvalue())
- self.assertEqual(0, ret)
- def test_gerrit_change_id(self):
- self.calls = [
- ((['git', 'write-tree'], ),
- 'hashtree'),
- ((['git', 'rev-parse', 'HEAD~0'], ),
- 'branch-parent'),
- ((['git', 'var', 'GIT_AUTHOR_IDENT'], ),
- 'A B <a@b.org> 1456848326 +0100'),
- ((['git', 'var', 'GIT_COMMITTER_IDENT'], ),
- 'C D <c@d.org> 1456858326 +0100'),
- ((['git', 'hash-object', '-t', 'commit', '--stdin'], ),
- 'hashchange'),
- ]
- change_id = git_cl.GenerateGerritChangeId('line1\nline2\n')
- self.assertEqual(change_id, 'Ihashchange')
- @mock.patch('gerrit_util.IsCodeOwnersEnabledOnHost')
- @mock.patch('git_cl.Settings.GetBugPrefix')
- @mock.patch('git_cl.Changelist.FetchDescription')
- @mock.patch('git_cl.Changelist.GetBranch')
- @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
- @mock.patch('git_cl.Changelist.GetGerritHost')
- @mock.patch('git_cl.Changelist.GetGerritProject')
- @mock.patch('git_cl.Changelist.GetRemoteBranch')
- @mock.patch('owners_client.OwnersClient.BatchListOwners')
- def getDescriptionForUploadTest(self,
- mockBatchListOwners=None,
- mockGetRemoteBranch=None,
- mockGetGerritProject=None,
- mockGetGerritHost=None,
- mockGetCommonAncestorWithUpstream=None,
- mockGetBranch=None,
- mockFetchDescription=None,
- mockGetBugPrefix=None,
- mockIsCodeOwnersEnabledOnHost=None,
- initial_description='desc',
- bug=None,
- fixed=None,
- branch='branch',
- reviewers=None,
- add_owners_to=None,
- expected_description='desc'):
- reviewers = reviewers or []
- owners_by_path = {
- 'a': ['a@example.com'],
- 'b': ['b@example.com'],
- 'c': ['c@example.com'],
- }
- mockIsCodeOwnersEnabledOnHost.return_value = True
- mockGetBranch.return_value = branch
- mockGetBugPrefix.return_value = 'prefix'
- mockGetCommonAncestorWithUpstream.return_value = 'upstream'
- mockGetRemoteBranch.return_value = ('origin', 'refs/remotes/origin/main')
- mockFetchDescription.return_value = 'desc'
- mockBatchListOwners.side_effect = lambda ps: {
- p: owners_by_path.get(p)
- for p in ps
- }
- cl = git_cl.Changelist(issue=1234)
- actual = cl._GetDescriptionForUpload(options=mock.Mock(
- bug=bug,
- fixed=fixed,
- reviewers=reviewers,
- add_owners_to=add_owners_to,
- message=initial_description),
- git_diff_args=None,
- files=list(owners_by_path))
- self.assertEqual(expected_description, actual.description)
- def testGetDescriptionForUpload(self):
- self.getDescriptionForUploadTest()
- def testGetDescriptionForUpload_Bug(self):
- self.getDescriptionForUploadTest(
- bug='1234',
- expected_description='\n'.join([
- 'desc',
- '',
- 'Bug: prefix:1234',
- ]))
- def testGetDescriptionForUpload_Fixed(self):
- self.getDescriptionForUploadTest(
- fixed='1234',
- expected_description='\n'.join([
- 'desc',
- '',
- 'Fixed: prefix:1234',
- ]))
- @mock.patch('git_cl.Changelist.GetIssue')
- def testGetDescriptionForUpload_BugFromBranch(self, mockGetIssue):
- mockGetIssue.return_value = None
- self.getDescriptionForUploadTest(
- branch='bug-1234',
- expected_description='\n'.join([
- 'desc',
- '',
- 'Bug: prefix:1234',
- ]))
- @mock.patch('git_cl.Changelist.GetIssue')
- def testGetDescriptionForUpload_FixedFromBranch(self, mockGetIssue):
- mockGetIssue.return_value = None
- self.getDescriptionForUploadTest(
- branch='fix-1234',
- expected_description='\n'.join([
- 'desc',
- '',
- 'Fixed: prefix:1234',
- ]))
- def testGetDescriptionForUpload_SkipBugFromBranchIfAlreadyUploaded(self):
- self.getDescriptionForUploadTest(
- branch='bug-1234',
- expected_description='desc',
- )
- def testGetDescriptionForUpload_AddOwnersToR(self):
- self.getDescriptionForUploadTest(
- reviewers=['a@example.com'],
- add_owners_to='R',
- expected_description='\n'.join([
- 'desc',
- '',
- 'R=a@example.com, b@example.com, c@example.com',
- ]))
- def testGetDescriptionForUpload_AddOwnersToNoOwnersNeeded(self):
- self.getDescriptionForUploadTest(
- reviewers=['a@example.com', 'c@example.com'],
- expected_description='\n'.join([
- 'desc',
- '',
- 'R=a@example.com, c@example.com',
- ]))
- def testGetDescriptionForUpload_Reviewers(self):
- self.getDescriptionForUploadTest(
- reviewers=['a@example.com', 'b@example.com'],
- expected_description='\n'.join([
- 'desc',
- '',
- 'R=a@example.com, b@example.com',
- ]))
- def test_description_append_footer(self):
- for init_desc, footer_line, expected_desc in [
- # Use unique desc first lines for easy test failure identification.
- ('foo', 'R=one', 'foo\n\nR=one'),
- ('foo\n\nR=one', 'BUG=', 'foo\n\nR=one\nBUG='),
- ('foo\n\nR=one', 'Change-Id: Ixx', 'foo\n\nR=one\n\nChange-Id: Ixx'),
- ('foo\n\nChange-Id: Ixx', 'R=one', 'foo\n\nR=one\n\nChange-Id: Ixx'),
- ('foo\n\nR=one\n\nChange-Id: Ixx', 'Foo-Bar: baz',
- 'foo\n\nR=one\n\nChange-Id: Ixx\nFoo-Bar: baz'),
- ('foo\n\nChange-Id: Ixx', 'Foo-Bak: baz',
- 'foo\n\nChange-Id: Ixx\nFoo-Bak: baz'),
- ('foo', 'Change-Id: Ixx', 'foo\n\nChange-Id: Ixx'),
- ]:
- desc = git_cl.ChangeDescription(init_desc)
- desc.append_footer(footer_line)
- self.assertEqual(desc.description, expected_desc)
- def test_update_reviewers(self):
- data = [
- ('foo', [], 'foo'),
- ('foo\nR=xx', [], 'foo\nR=xx'),
- ('foo', ['a@c'], 'foo\n\nR=a@c'),
- ('foo\nR=xx', ['a@c'], 'foo\n\nR=a@c, xx'),
- ('foo\nBUG=', ['a@c'], 'foo\nBUG=\nR=a@c'),
- ('foo\nR=xx\nR=bar', ['a@c'], 'foo\n\nR=a@c, bar, xx'),
- ('foo', ['a@c', 'b@c'], 'foo\n\nR=a@c, b@c'),
- ('foo\nBar\n\nR=\nBUG=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),
- ('foo\nBar\n\nR=\nBUG=\nR=', ['c@c'], 'foo\nBar\n\nR=c@c\nBUG='),
- # Same as the line before, but full of whitespaces.
- (
- 'foo\nBar\n\n R = \n BUG = \n R = ',
- ['c@c'],
- 'foo\nBar\n\nR=c@c\n BUG =',
- ),
- # Whitespaces aren't interpreted as new lines.
- ('foo BUG=allo R=joe ', ['c@c'], 'foo BUG=allo R=joe\n\nR=c@c'),
- ]
- expected = [i[-1] for i in data]
- actual = []
- for orig, reviewers, _expected in data:
- obj = git_cl.ChangeDescription(orig)
- obj.update_reviewers(reviewers)
- actual.append(obj.description)
- self.assertEqual(expected, actual)
- def test_get_hash_tags(self):
- cases = [
- ('', []),
- ('a', []),
- ('[a]', ['a']),
- ('[aa]', ['aa']),
- ('[a ]', ['a']),
- ('[a- ]', ['a']),
- ('[a- b]', ['a-b']),
- ('[a--b]', ['a-b']),
- ('[a', []),
- ('[a]x', ['a']),
- ('[aa]x', ['aa']),
- ('[a b]', ['a-b']),
- ('[a b]', ['a-b']),
- ('[a__b]', ['a-b']),
- ('[a] x', ['a']),
- ('[a][b]', ['a', 'b']),
- ('[a] [b]', ['a', 'b']),
- ('[a][b]x', ['a', 'b']),
- ('[a][b] x', ['a', 'b']),
- ('[a]\n[b]', ['a']),
- ('[a\nb]', []),
- ('[a][', ['a']),
- ('Revert "[a] feature"', ['a']),
- ('Reland "[a] feature"', ['a']),
- ('Revert: [a] feature', ['a']),
- ('Reland: [a] feature', ['a']),
- ('Revert "Reland: [a] feature"', ['a']),
- ('Foo: feature', ['foo']),
- ('Foo Bar: feature', ['foo-bar']),
- ('Change Foo::Bar', []),
- ('Foo: Change Foo::Bar', ['foo']),
- ('Revert "Foo bar: feature"', ['foo-bar']),
- ('Reland "Foo bar: feature"', ['foo-bar']),
- ]
- for desc, expected in cases:
- change_desc = git_cl.ChangeDescription(desc)
- actual = change_desc.get_hash_tags()
- self.assertEqual(
- actual,
- expected,
- 'GetHashTags(%r) == %r, expected %r' % (desc, actual, expected))
- self.assertEqual(None, git_cl.GetTargetRef('origin', None, 'main'))
- self.assertEqual(None, git_cl.GetTargetRef(None,
- 'refs/remotes/origin/main',
- 'main'))
- # Check default target refs for branches.
- self.assertEqual('refs/heads/main',
- git_cl.GetTargetRef('origin', 'refs/remotes/origin/main',
- None))
- self.assertEqual('refs/heads/main',
- git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkgr',
- None))
- self.assertEqual('refs/heads/main',
- git_cl.GetTargetRef('origin', 'refs/remotes/origin/lkcr',
- None))
- self.assertEqual('refs/branch-heads/123',
- git_cl.GetTargetRef('origin',
- 'refs/remotes/branch-heads/123',
- None))
- self.assertEqual('refs/diff/test',
- git_cl.GetTargetRef('origin',
- 'refs/remotes/origin/refs/diff/test',
- None))
- self.assertEqual('refs/heads/chrome/m42',
- git_cl.GetTargetRef('origin',
- 'refs/remotes/origin/chrome/m42',
- None))
- # Check target refs for user-specified target branch.
- for branch in ('branch-heads/123', 'remotes/branch-heads/123',
- 'refs/remotes/branch-heads/123'):
- self.assertEqual('refs/branch-heads/123',
- git_cl.GetTargetRef('origin',
- 'refs/remotes/origin/main',
- branch))
- for branch in ('origin/main', 'remotes/origin/main',
- 'refs/remotes/origin/main'):
- self.assertEqual('refs/heads/main',
- git_cl.GetTargetRef('origin',
- 'refs/remotes/branch-heads/123',
- branch))
- for branch in ('main', 'heads/main', 'refs/heads/main'):
- self.assertEqual('refs/heads/main',
- git_cl.GetTargetRef('origin',
- 'refs/remotes/branch-heads/123',
- branch))
- @mock.patch('git_common.is_dirty_git_tree', return_value=True)
- def test_patch_when_dirty(self, *_mocks):
- # Patch when local tree is dirty.
- self.assertNotEqual(git_cl.main(['patch', '123456']), 0)
- def assertIssueAndPatchset(
- self, branch='main', issue='123456', patchset='7',
- git_short_host='chromium'):
- self.assertEqual(
- issue, scm.GIT.GetBranchConfig('', branch, 'gerritissue'))
- self.assertEqual(
- patchset, scm.GIT.GetBranchConfig('', branch, 'gerritpatchset'))
- self.assertEqual(
- 'https://%s-review.googlesource.com' % git_short_host,
- scm.GIT.GetBranchConfig('', branch, 'gerritserver'))
- def _patch_common(self, git_short_host='chromium'):
- mock.patch('scm.GIT.ResolveCommit', return_value='deadbeef').start()
- self.mockGit.config['remote.origin.url'] = (
- 'https://%s.googlesource.com/my/repo' % git_short_host)
- gerrit_util.GetChangeDetail.return_value = {
- 'current_revision': '7777777777',
- 'revisions': {
- '1111111111': {
- '_number': 1,
- 'fetch': {'http': {
- 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
- 'ref': 'refs/changes/56/123456/1',
- }},
- },
- '7777777777': {
- '_number': 7,
- 'fetch': {'http': {
- 'url': 'https://%s.googlesource.com/my/repo' % git_short_host,
- 'ref': 'refs/changes/56/123456/7',
- }},
- },
- },
- }
- def test_patch_gerrit_default(self):
- self._patch_common()
- self.calls += [
- ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
- 'refs/changes/56/123456/7'],), ''),
- ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
- ]
- self.assertEqual(git_cl.main(['patch', '123456']), 0)
- self.assertIssueAndPatchset()
- def test_patch_gerrit_new_branch(self):
- self._patch_common()
- self.calls += [
- ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
- 'refs/changes/56/123456/7'],), ''),
- ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
- ]
- self.assertEqual(git_cl.main(['patch', '-b', 'feature', '123456']), 0)
- self.assertIssueAndPatchset(branch='feature')
- def test_patch_gerrit_force(self):
- self._patch_common('host')
- self.calls += [
- ((['git', 'fetch', 'https://host.googlesource.com/my/repo',
- 'refs/changes/56/123456/7'],), ''),
- ((['git', 'reset', '--hard', 'FETCH_HEAD'],), ''),
- ]
- self.assertEqual(git_cl.main(['patch', '123456', '--force']), 0)
- self.assertIssueAndPatchset(git_short_host='host')
- def test_patch_gerrit_guess_by_url(self):
- self._patch_common('else')
- self.calls += [
- ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
- 'refs/changes/56/123456/1'],), ''),
- ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
- ]
- self.assertEqual(git_cl.main(
- ['patch', 'https://else-review.googlesource.com/#/c/123456/1']), 0)
- self.assertIssueAndPatchset(patchset='1', git_short_host='else')
- def test_patch_gerrit_guess_by_url_with_repo(self):
- self._patch_common('else')
- self.calls += [
- ((['git', 'fetch', 'https://else.googlesource.com/my/repo',
- 'refs/changes/56/123456/1'],), ''),
- ((['git', 'cherry-pick', 'FETCH_HEAD'],), ''),
- ]
- self.assertEqual(git_cl.main(
- ['patch', 'https://else-review.googlesource.com/c/my/repo/+/123456/1']),
- 0)
- self.assertIssueAndPatchset(patchset='1', git_short_host='else')
- @mock.patch('sys.stderr', StringIO())
- def test_patch_gerrit_conflict(self):
- self._patch_common()
- self.calls += [
- ((['git', 'fetch', 'https://chromium.googlesource.com/my/repo',
- 'refs/changes/56/123456/7'],), ''),
- ((['git', 'cherry-pick', 'FETCH_HEAD'],), CERR1),
- ]
- with self.assertRaises(SystemExitMock):
- git_cl.main(['patch', '123456'])
- self.assertEqual(
- 'Command "git cherry-pick FETCH_HEAD" failed.\n\n',
- sys.stderr.getvalue())
- @mock.patch(
- 'gerrit_util.GetChangeDetail',
- side_effect=gerrit_util.GerritError(404, ''))
- @mock.patch('sys.stderr', StringIO())
- def test_patch_gerrit_not_exists(self, *_mocks):
- self.mockGit.config['remote.origin.url'] = (
- 'https://chromium.googlesource.com/my/repo')
- with self.assertRaises(SystemExitMock):
- self.assertEqual(1, git_cl.main(['patch', '123456']))
- self.assertEqual(
- 'change 123456 at https://chromium-review.googlesource.com does not '
- 'exist or you have no access to it\n',
- sys.stderr.getvalue())
- def _checkout_calls(self):
- return [
- ((['git', 'config', '--local', '--get-regexp',
- 'branch\\..*\\.gerritissue'], ),
- ('branch.ger-branch.gerritissue 123456\n'
- 'branch.gbranch654.gerritissue 654321\n')),
- ]
- def test_checkout_gerrit(self):
- """Tests git cl checkout <issue>."""
- self.calls = self._checkout_calls()
- self.calls += [((['git', 'checkout', 'ger-branch'], ), '')]
- self.assertEqual(0, git_cl.main(['checkout', '123456']))
- def test_checkout_not_found(self):
- """Tests git cl checkout <issue>."""
- self.calls = self._checkout_calls()
- self.assertEqual(1, git_cl.main(['checkout', '99999']))
- def test_checkout_no_branch_issues(self):
- """Tests git cl checkout <issue>."""
- self.calls = [
- ((['git', 'config', '--local', '--get-regexp',
- 'branch\\..*\\.gerritissue'], ), CERR1),
- ]
- self.assertEqual(1, git_cl.main(['checkout', '99999']))
- def _test_gerrit_ensure_authenticated_common(self, auth):
- mock.patch(
- 'gclient_utils.AskForData',
- lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
- mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
- CookiesAuthenticatorMockFactory(hosts_with_creds=auth)).start()
- self.mockGit.config['remote.origin.url'] = (
- 'https://chromium.googlesource.com/my/repo')
- cl = git_cl.Changelist()
- cl.branch = 'main'
- cl.branchref = 'refs/heads/main'
- return cl
- @mock.patch('sys.stderr', StringIO())
- def test_gerrit_ensure_authenticated_missing(self):
- cl = self._test_gerrit_ensure_authenticated_common(auth={
- 'chromium.googlesource.com': ('git-is.ok', '', 'but gerrit is missing'),
- })
- with self.assertRaises(SystemExitMock):
- cl.EnsureAuthenticated(force=False)
- self.assertEqual(
- 'Credentials for the following hosts are required:\n'
- ' chromium-review.googlesource.com\n'
- 'These are read from ~%(sep)s.gitcookies '
- '(or legacy ~%(sep)s%(netrc)s)\n'
- 'You can (re)generate your credentials by visiting '
- 'https://chromium-review.googlesource.com/new-password\n' % {
- 'sep': os.sep,
- 'netrc': NETRC_FILENAME,
- }, sys.stderr.getvalue())
- def test_gerrit_ensure_authenticated_conflict(self):
- cl = self._test_gerrit_ensure_authenticated_common(auth={
- 'chromium.googlesource.com':
- ('git-one.example.com', None, 'secret1'),
- 'chromium-review.googlesource.com':
- ('git-other.example.com', None, 'secret2'),
- })
- self.calls.append(
- (('ask_for_data', 'If you know what you are doing '
- 'press Enter to continue, or Ctrl+C to abort'), ''))
- self.assertIsNone(cl.EnsureAuthenticated(force=False))
- def test_gerrit_ensure_authenticated_ok(self):
- cl = self._test_gerrit_ensure_authenticated_common(auth={
- 'chromium.googlesource.com':
- ('git-same.example.com', None, 'secret'),
- 'chromium-review.googlesource.com':
- ('git-same.example.com', None, 'secret'),
- })
- self.assertIsNone(cl.EnsureAuthenticated(force=False))
- def test_gerrit_ensure_authenticated_skipped(self):
- self.mockGit.config['gerrit.skip-ensure-authenticated'] = 'true'
- cl = self._test_gerrit_ensure_authenticated_common(auth={})
- self.assertIsNone(cl.EnsureAuthenticated(force=False))
- def test_gerrit_ensure_authenticated_bearer_token(self):
- cl = self._test_gerrit_ensure_authenticated_common(auth={
- 'chromium.googlesource.com':
- ('', None, 'secret'),
- 'chromium-review.googlesource.com':
- ('', None, 'secret'),
- })
- self.assertIsNone(cl.EnsureAuthenticated(force=False))
- header = gerrit_util.CookiesAuthenticator().get_auth_header(
- 'chromium.googlesource.com')
- self.assertTrue('Bearer' in header)
- def test_gerrit_ensure_authenticated_non_https(self):
- self.mockGit.config['remote.origin.url'] = 'custom-scheme://repo'
- self.calls = [
- (('logging.warning',
- 'Ignoring branch %(branch)s with non-https/sso remote '
- '%(remote)s', {
- 'branch': 'main',
- 'remote': 'custom-scheme://repo'
- }), None),
- ]
- mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
- CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
- mock.patch('logging.warning',
- lambda *a: self._mocked_call('logging.warning', *a)).start()
- cl = git_cl.Changelist()
- cl.branch = 'main'
- cl.branchref = 'refs/heads/main'
- cl.lookedup_issue = True
- self.assertIsNone(cl.EnsureAuthenticated(force=False))
- def test_gerrit_ensure_authenticated_non_url(self):
- self.mockGit.config['remote.origin.url'] = (
- 'git@somehost.example:foo/bar.git')
- self.calls = [
- (('logging.error',
- 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
- 'but it doesn\'t exist.', {
- 'remote': 'origin',
- 'branch': 'main',
- 'url': 'git@somehost.example:foo/bar.git'}
- ), None),
- ]
- mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
- CookiesAuthenticatorMockFactory(hosts_with_creds={})).start()
- mock.patch('logging.error',
- lambda *a: self._mocked_call('logging.error', *a)).start()
- cl = git_cl.Changelist()
- cl.branch = 'main'
- cl.branchref = 'refs/heads/main'
- cl.lookedup_issue = True
- self.assertIsNone(cl.EnsureAuthenticated(force=False))
- def _cmd_set_commit_gerrit_common(self, vote, notify=None):
- self.mockGit.config['branch.main.gerritissue'] = '123'
- self.mockGit.config['branch.main.gerritserver'] = (
- 'https://chromium-review.googlesource.com')
- self.mockGit.config['remote.origin.url'] = (
- 'https://chromium.googlesource.com/infra/infra')
- self.calls = [
- (('SetReview', 'chromium-review.googlesource.com',
- 'infra%2Finfra~123', None,
- {'Commit-Queue': vote}, notify, None), ''),
- ]
- def _cmd_set_quick_run_gerrit(self):
- self.mockGit.config['branch.main.gerritissue'] = '123'
- self.mockGit.config['branch.main.gerritserver'] = (
- 'https://chromium-review.googlesource.com')
- self.mockGit.config['remote.origin.url'] = (
- 'https://chromium.googlesource.com/infra/infra')
- self.calls = [
- (('SetReview', 'chromium-review.googlesource.com',
- 'infra%2Finfra~123', None,
- {'Commit-Queue': 1, 'Quick-Run': 1}, None, None), ''),
- ]
- def test_cmd_set_commit_gerrit_clear(self):
- self._cmd_set_commit_gerrit_common(0)
- self.assertEqual(0, git_cl.main(['set-commit', '-c']))
- def test_cmd_set_commit_gerrit_dry(self):
- self._cmd_set_commit_gerrit_common(1, notify=False)
- self.assertEqual(0, git_cl.main(['set-commit', '-d']))
- def test_cmd_set_commit_gerrit(self):
- self._cmd_set_commit_gerrit_common(2)
- self.assertEqual(0, git_cl.main(['set-commit']))
- def test_cmd_set_quick_run_gerrit(self):
- self._cmd_set_quick_run_gerrit()
- self.assertEqual(0, git_cl.main(['set-commit', '-q']))
- def test_description_display(self):
- mock.patch('git_cl.Changelist', ChangelistMock).start()
- ChangelistMock.desc = 'foo\n'
- self.assertEqual(0, git_cl.main(['description', '-d']))
- self.assertEqual('foo\n', sys.stdout.getvalue())
- @mock.patch('sys.stderr', StringIO())
- def test_StatusFieldOverrideIssueMissingArgs(self):
- try:
- self.assertEqual(git_cl.main(['status', '--issue', '1']), 0)
- except SystemExitMock:
- self.assertIn(
- '--field must be given when --issue is set.', sys.stderr.getvalue())
- def test_StatusFieldOverrideIssue(self):
- def assertIssue(cl_self, *_args):
- self.assertEqual(cl_self.issue, 1)
- return 'foobar'
- mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
- self.assertEqual(
- git_cl.main(['status', '--issue', '1', '--field', 'desc']),
- 0)
- self.assertEqual(sys.stdout.getvalue(), 'foobar\n')
- def test_SetCloseOverrideIssue(self):
- def assertIssue(cl_self, *_args):
- self.assertEqual(cl_self.issue, 1)
- return 'foobar'
- mock.patch('git_cl.Changelist.FetchDescription', assertIssue).start()
- mock.patch('git_cl.Changelist.CloseIssue', lambda *_: None).start()
- self.assertEqual(
- git_cl.main(['set-close', '--issue', '1']), 0)
- def test_description(self):
- self.mockGit.config['remote.origin.url'] = (
- 'https://chromium.googlesource.com/my/repo')
- gerrit_util.GetChangeDetail.return_value = {
- 'current_revision': 'sha1',
- 'revisions': {'sha1': {
- 'commit': {'message': 'foobar'},
- }},
- }
- self.assertEqual(0, git_cl.main([
- 'description',
- 'https://chromium-review.googlesource.com/c/my/repo/+/123123',
- '-d']))
- self.assertEqual('foobar\n', sys.stdout.getvalue())
- def test_description_set_raw(self):
- mock.patch('git_cl.Changelist', ChangelistMock).start()
- mock.patch('git_cl.sys.stdin', StringIO('hihi')).start()
- self.assertEqual(0, git_cl.main(['description', '-n', 'hihi']))
- self.assertEqual('hihi', ChangelistMock.desc)
- def test_description_appends_bug_line(self):
- current_desc = 'Some.\n\nChange-Id: xxx'
- def RunEditor(desc, _, **kwargs):
- self.assertEqual(
- '# Enter a description of the change.\n'
- '# This will be displayed on the codereview site.\n'
- '# The first line will also be used as the subject of the review.\n'
- '#--------------------This line is 72 characters long'
- '--------------------\n'
- 'Some.\n\nChange-Id: xxx\nBug: ',
- desc)
- # Simulate user changing something.
- return 'Some.\n\nChange-Id: xxx\nBug: 123'
- def UpdateDescription(_, desc, force=False):
- self.assertEqual(desc, 'Some.\n\nChange-Id: xxx\nBug: 123')
- mock.patch('git_cl.Changelist.FetchDescription',
- lambda *args: current_desc).start()
- mock.patch('git_cl.Changelist.UpdateDescription',
- UpdateDescription).start()
- mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
- self.mockGit.config['branch.main.gerritissue'] = '123'
- self.assertEqual(0, git_cl.main(['description']))
- def test_description_does_not_append_bug_line_if_fixed_is_present(self):
- current_desc = 'Some.\n\nFixed: 123\nChange-Id: xxx'
- def RunEditor(desc, _, **kwargs):
- self.assertEqual(
- '# Enter a description of the change.\n'
- '# This will be displayed on the codereview site.\n'
- '# The first line will also be used as the subject of the review.\n'
- '#--------------------This line is 72 characters long'
- '--------------------\n'
- 'Some.\n\nFixed: 123\nChange-Id: xxx',
- desc)
- return desc
- mock.patch('git_cl.Changelist.FetchDescription',
- lambda *args: current_desc).start()
- mock.patch('git_cl.gclient_utils.RunEditor', RunEditor).start()
- self.mockGit.config['branch.main.gerritissue'] = '123'
- self.assertEqual(0, git_cl.main(['description']))
- def test_description_set_stdin(self):
- mock.patch('git_cl.Changelist', ChangelistMock).start()
- mock.patch('git_cl.sys.stdin', StringIO('hi \r\n\t there\n\nman')).start()
- self.assertEqual(0, git_cl.main(['description', '-n', '-']))
- self.assertEqual('hi\n\t there\n\nman', ChangelistMock.desc)
- def test_archive(self):
- self.calls = [
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
- 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
- ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],), ''),
- ((['git', 'branch', '-D', 'foo'],), '')
- ]
- mock.patch('git_cl.get_cl_statuses',
- lambda branches, fine_grained, max_processes:
- [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
- (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
- (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
- self.assertEqual(0, git_cl.main(['archive', '-f']))
- def test_archive_tag_collision(self):
- self.calls = [
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
- 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],),
- 'refs/tags/git-cl-archived-456-foo'),
- ((['git', 'tag', 'git-cl-archived-456-foo-2', 'foo'],), ''),
- ((['git', 'branch', '-D', 'foo'],), '')
- ]
- mock.patch('git_cl.get_cl_statuses',
- lambda branches, fine_grained, max_processes:
- [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
- (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
- (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
- self.assertEqual(0, git_cl.main(['archive', '-f']))
- def test_archive_current_branch_fails(self):
- self.calls = [
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
- 'refs/heads/main'),
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
- ]
- mock.patch('git_cl.get_cl_statuses',
- lambda branches, fine_grained, max_processes:
- [(MockChangelistWithBranchAndIssue('main', 1),
- 'closed')]).start()
- self.assertEqual(1, git_cl.main(['archive', '-f']))
- def test_archive_dry_run(self):
- self.calls = [
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
- 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
- ]
- mock.patch('git_cl.get_cl_statuses',
- lambda branches, fine_grained, max_processes:
- [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
- (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
- (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
- self.assertEqual(0, git_cl.main(['archive', '-f', '--dry-run']))
- def test_archive_no_tags(self):
- self.calls = [
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
- 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
- ((['git', 'branch', '-D', 'foo'],), '')
- ]
- mock.patch('git_cl.get_cl_statuses',
- lambda branches, fine_grained, max_processes:
- [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
- (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
- (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
- self.assertEqual(0, git_cl.main(['archive', '-f', '--notags']))
- def test_archive_tag_cleanup_on_branch_deletion_error(self):
- self.calls = [
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'],),
- 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'],), ''),
- ((['git', 'tag', 'git-cl-archived-456-foo', 'foo'],),
- 'refs/tags/git-cl-archived-456-foo'),
- ((['git', 'branch', '-D', 'foo'],), CERR1),
- ((['git', 'tag', '-d', 'git-cl-archived-456-foo'],),
- 'refs/tags/git-cl-archived-456-foo'),
- ]
- mock.patch('git_cl.get_cl_statuses',
- lambda branches, fine_grained, max_processes:
- [(MockChangelistWithBranchAndIssue('main', 1), 'open'),
- (MockChangelistWithBranchAndIssue('foo', 456), 'closed'),
- (MockChangelistWithBranchAndIssue('bar', 789), 'open')]).start()
- self.assertEqual(0, git_cl.main(['archive', '-f']))
- def test_archive_with_format(self):
- self.calls = [
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/heads'], ),
- 'refs/heads/main\nrefs/heads/foo\nrefs/heads/bar'),
- ((['git', 'for-each-ref', '--format=%(refname)', 'refs/tags'], ), ''),
- ((['git', 'tag', 'archived/12-foo', 'foo'], ), ''),
- ((['git', 'branch', '-D', 'foo'], ), ''),
- ]
- mock.patch('git_cl.get_cl_statuses',
- lambda branches, fine_grained, max_processes:
- [(MockChangelistWithBranchAndIssue('foo', 12), 'closed')]).start()
- self.assertEqual(
- 0, git_cl.main(['archive', '-f', '-p', 'archived/{issue}-{branch}']))
- def test_cmd_issue_erase_existing(self):
- self.mockGit.config['branch.main.gerritissue'] = '123'
- self.mockGit.config['branch.main.gerritserver'] = (
- 'https://chromium-review.googlesource.com')
- self.calls = [
- ((['git', 'log', '-1', '--format=%B'],), 'This is a description'),
- ]
- self.assertEqual(0, git_cl.main(['issue', '0']))
- self.assertNotIn('branch.main.gerritissue', self.mockGit.config)
- self.assertNotIn('branch.main.gerritserver', self.mockGit.config)
- def test_cmd_issue_erase_existing_with_change_id(self):
- self.mockGit.config['branch.main.gerritissue'] = '123'
- self.mockGit.config['branch.main.gerritserver'] = (
- 'https://chromium-review.googlesource.com')
- mock.patch('git_cl.Changelist.FetchDescription',
- lambda _: 'This is a description\n\nChange-Id: Ideadbeef').start()
- self.calls = [
- ((['git', 'log', '-1', '--format=%B'],),
- 'This is a description\n\nChange-Id: Ideadbeef'),
- ((['git', 'commit', '--amend', '-m', 'This is a description\n'],), ''),
- ]
- self.assertEqual(0, git_cl.main(['issue', '0']))
- self.assertNotIn('branch.main.gerritissue', self.mockGit.config)
- self.assertNotIn('branch.main.gerritserver', self.mockGit.config)
- def test_cmd_issue_json(self):
- self.mockGit.config['branch.main.gerritissue'] = '123'
- self.mockGit.config['branch.main.gerritserver'] = (
- 'https://chromium-review.googlesource.com')
- self.mockGit.config['remote.origin.url'] = (
- 'https://chromium.googlesource.com/chromium/src'
- )
- self.calls = [(
- (
- 'write_json',
- 'output.json',
- {
- 'issue': 123,
- 'issue_url': 'https://chromium-review.googlesource.com/123',
- 'gerrit_host': 'chromium-review.googlesource.com',
- 'gerrit_project': 'chromium/src',
- },
- ),
- '',
- )]
- self.assertEqual(0, git_cl.main(['issue', '--json', 'output.json']))
- def _common_GerritCommitMsgHookCheck(self):
- mock.patch(
- 'git_cl.os.path.abspath',
- lambda path: self._mocked_call(['abspath', path])).start()
- mock.patch(
- 'git_cl.os.path.exists',
- lambda path: self._mocked_call(['exists', path])).start()
- mock.patch(
- 'git_cl.gclient_utils.FileRead',
- lambda path: self._mocked_call(['FileRead', path])).start()
- mock.patch(
- 'git_cl.gclient_utils.rm_file_or_tree',
- lambda path: self._mocked_call(['rm_file_or_tree', path])).start()
- mock.patch(
- 'gclient_utils.AskForData',
- lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
- return git_cl.Changelist(issue=123)
- def test_GerritCommitMsgHookCheck_custom_hook(self):
- cl = self._common_GerritCommitMsgHookCheck()
- self.calls += [((['exists',
- os.path.join('.git', 'hooks', 'commit-msg')], ), True),
- ((['FileRead',
- os.path.join('.git', 'hooks', 'commit-msg')], ),
- '#!/bin/sh\necho "custom hook"')]
- cl._GerritCommitMsgHookCheck(offer_removal=True)
- def test_GerritCommitMsgHookCheck_not_exists(self):
- cl = self._common_GerritCommitMsgHookCheck()
- self.calls += [
- ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), False),
- ]
- cl._GerritCommitMsgHookCheck(offer_removal=True)
- def test_GerritCommitMsgHookCheck(self):
- cl = self._common_GerritCommitMsgHookCheck()
- self.calls += [
- ((['exists', os.path.join('.git', 'hooks', 'commit-msg')], ), True),
- ((['FileRead', os.path.join('.git', 'hooks', 'commit-msg')], ),
- '...\n# From Gerrit Code Review\n...\nadd_ChangeId()\n'),
- (('ask_for_data', 'Do you want to remove it now? [Yes/No]: '), 'Yes'),
- ((['rm_file_or_tree',
- os.path.join('.git', 'hooks', 'commit-msg')], ), ''),
- ]
- cl._GerritCommitMsgHookCheck(offer_removal=True)
- def test_GerritCmdLand(self):
- self.mockGit.config['branch.main.gerritsquashhash'] = 'deadbeaf'
- self.mockGit.config['branch.main.gerritserver'] = (
- 'chromium-review.googlesource.com')
- self.calls += [
- ((['git', 'diff', 'deadbeaf'],), ''), # No diff.
- ]
- cl = git_cl.Changelist(issue=123)
- cl._GetChangeDetail = lambda *args, **kwargs: {
- 'labels': {},
- 'current_revision': 'deadbeaf',
- }
- cl._GetChangeCommit = lambda: {
- 'commit': 'deadbeef',
- 'web_links': [{'name': 'gitiles',
- 'url': 'https://git.googlesource.com/test/+/deadbeef'}],
- }
- cl.SubmitIssue = lambda: None
- self.assertEqual(0, cl.CMDLand(force=True,
- bypass_hooks=True,
- verbose=True,
- parallel=False,
- resultdb=False,
- realm=None))
- self.assertIn(
- 'Issue chromium-review.googlesource.com/123 has been submitted',
- sys.stdout.getvalue())
- self.assertIn(
- 'Landed as: https://git.googlesource.com/test/+/deadbeef',
- sys.stdout.getvalue())
- def _mock_gerrit_changes_for_detail_cache(self):
- mock.patch('git_cl.Changelist.GetGerritHost', lambda _: 'host').start()
- def test_gerrit_change_detail_cache_simple(self):
- self._mock_gerrit_changes_for_detail_cache()
- gerrit_util.GetChangeDetail.side_effect = ['a', 'b']
- cl1 = git_cl.Changelist(issue=1)
- cl1._cached_remote_url = (
- True, 'https://chromium.googlesource.com/a/my/repo.git/')
- cl2 = git_cl.Changelist(issue=2)
- cl2._cached_remote_url = (
- True, 'https://chromium.googlesource.com/ab/repo')
- self.assertEqual(cl1._GetChangeDetail(), 'a') # Miss.
- self.assertEqual(cl1._GetChangeDetail(), 'a')
- self.assertEqual(cl2._GetChangeDetail(), 'b') # Miss.
- def test_gerrit_change_detail_cache_options(self):
- self._mock_gerrit_changes_for_detail_cache()
- gerrit_util.GetChangeDetail.side_effect = ['cab', 'ad']
- cl = git_cl.Changelist(issue=1)
- cl._cached_remote_url = (True, 'https://chromium.googlesource.com/repo/')
- self.assertEqual(cl._GetChangeDetail(options=['C', 'A', 'B']), 'cab')
- self.assertEqual(cl._GetChangeDetail(options=['A', 'B', 'C']), 'cab')
- self.assertEqual(cl._GetChangeDetail(options=['B', 'A']), 'cab')
- self.assertEqual(cl._GetChangeDetail(options=['C']), 'cab')
- self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
- self.assertEqual(cl._GetChangeDetail(), 'cab')
- self.assertEqual(cl._GetChangeDetail(options=['A', 'D']), 'ad')
- self.assertEqual(cl._GetChangeDetail(options=['A']), 'cab')
- self.assertEqual(cl._GetChangeDetail(options=['D']), 'ad')
- self.assertEqual(cl._GetChangeDetail(), 'cab')
- def test_gerrit_description_caching(self):
- gerrit_util.GetChangeDetail.return_value = {
- 'current_revision': 'rev1',
- 'revisions': {
- 'rev1': {'commit': {'message': 'desc1'}},
- },
- }
- self._mock_gerrit_changes_for_detail_cache()
- cl = git_cl.Changelist(issue=1)
- cl._cached_remote_url = (
- True, 'https://chromium.googlesource.com/a/my/repo.git/')
- self.assertEqual(cl.FetchDescription(), 'desc1')
- self.assertEqual(cl.FetchDescription(), 'desc1') # cache hit.
- def test_print_current_creds(self):
- class CookiesAuthenticatorMock(object):
- def __init__(self):
- self.gitcookies = {
- 'host.googlesource.com': ('user', 'pass'),
- 'host-review.googlesource.com': ('user', 'pass'),
- }
- self.netrc = self
- self.netrc.hosts = {
- 'github.com': ('user2', None, 'pass2'),
- 'host2.googlesource.com': ('user3', None, 'pass'),
- }
- mock.patch('git_cl.gerrit_util.CookiesAuthenticator',
- CookiesAuthenticatorMock).start()
- git_cl._GitCookiesChecker().print_current_creds(include_netrc=True)
- self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
- ' Host\t User\t Which file',
- '============================\t=====\t===========',
- 'host-review.googlesource.com\t user\t.gitcookies',
- ' host.googlesource.com\t user\t.gitcookies',
- ' host2.googlesource.com\tuser3\t .netrc',
- ])
- sys.stdout.seek(0)
- sys.stdout.truncate(0)
- git_cl._GitCookiesChecker().print_current_creds(include_netrc=False)
- self.assertEqual(list(sys.stdout.getvalue().splitlines()), [
- ' Host\tUser\t Which file',
- '============================\t====\t===========',
- 'host-review.googlesource.com\tuser\t.gitcookies',
- ' host.googlesource.com\tuser\t.gitcookies',
- ])
- def _common_creds_check_mocks(self):
- def exists_mock(path):
- dirname = os.path.dirname(path)
- if dirname == os.path.expanduser('~'):
- dirname = '~'
- base = os.path.basename(path)
- if base in (NETRC_FILENAME, '.gitcookies'):
- return self._mocked_call('os.path.exists', os.path.join(dirname, base))
- # git cl also checks for existence other files not relevant to this test.
- return None
- mock.patch(
- 'gclient_utils.AskForData',
- lambda prompt: self._mocked_call('ask_for_data', prompt)).start()
- mock.patch('os.path.exists', exists_mock).start()
- def test_creds_check_gitcookies_not_configured(self):
- self._common_creds_check_mocks()
- mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
- lambda _, include_netrc=False: []).start()
- self.calls = [
- ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
- ((['git', 'config', '--global', 'http.cookiefile'], ), CERR1),
- (('os.path.exists', os.path.join('~', NETRC_FILENAME)), True),
- (('ask_for_data', 'Press Enter to setup .gitcookies, '
- 'or Ctrl+C to abort'), ''),
- (([
- 'git', 'config', '--global', 'http.cookiefile',
- os.path.expanduser(os.path.join('~', '.gitcookies'))
- ], ), ''),
- ]
- self.assertEqual(0, git_cl.main(['creds-check']))
- self.assertTrue(
- sys.stdout.getvalue().startswith(
- 'You seem to be using outdated .netrc for git credentials:'))
- self.assertIn(
- '\nConfigured git to use .gitcookies from',
- sys.stdout.getvalue())
- def test_creds_check_gitcookies_configured_custom_broken(self):
- self._common_creds_check_mocks()
- mock.patch('git_cl._GitCookiesChecker.get_hosts_with_creds',
- lambda _, include_netrc=False: []).start()
- custom_cookie_path = ('C:\\.gitcookies'
- if sys.platform == 'win32' else '/custom/.gitcookies')
- self.calls = [
- ((['git', 'config', '--path', 'http.cookiefile'], ), CERR1),
- ((['git', 'config', '--global', 'http.cookiefile'], ),
- custom_cookie_path),
- (('os.path.exists', custom_cookie_path), False),
- (('ask_for_data', 'Reconfigure git to use default .gitcookies? '
- 'Press Enter to reconfigure, or Ctrl+C to abort'), ''),
- (([
- 'git', 'config', '--global', 'http.cookiefile',
- os.path.expanduser(os.path.join('~', '.gitcookies'))
- ], ), ''),
- ]
- self.assertEqual(0, git_cl.main(['creds-check']))
- self.assertIn(
- 'WARNING: You have configured custom path to .gitcookies: ',
- sys.stdout.getvalue())
- self.assertIn(
- 'However, your configured .gitcookies file is missing.',
- sys.stdout.getvalue())
- def test_git_cl_comment_add_gerrit(self):
- self.mockGit.branchref = None
- self.mockGit.config['remote.origin.url'] = (
- 'https://chromium.googlesource.com/infra/infra')
- self.calls = [
- (('SetReview', 'chromium-review.googlesource.com', 'infra%2Finfra~10',
- 'msg', None, None, None),
- None),
- ]
- self.assertEqual(0, git_cl.main(['comment', '-i', '10', '-a', 'msg']))
- @mock.patch('git_cl.Changelist.GetBranch', return_value='foo')
- def test_git_cl_comments_fetch_gerrit(self, *_mocks):
- self.mockGit.config['remote.origin.url'] = (
- 'https://chromium.googlesource.com/infra/infra')
- gerrit_util.GetChangeDetail.return_value = {
- 'owner': {'email': 'owner@example.com'},
- 'current_revision': 'ba5eba11',
- 'revisions': {
- 'deadbeaf': {
- '_number': 1,
- },
- 'ba5eba11': {
- '_number': 2,
- },
- },
- 'messages': [
- {
- u'_revision_number': 1,
- u'author': {
- u'_account_id': 1111084,
- u'email': u'could-be-anything@example.com',
- u'name': u'LUCI CQ'
- },
- u'date': u'2017-03-15 20:08:45.000000000',
- u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
- u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
- u'tag': u'autogenerated:cv:dry-run'
- },
- {
- u'_revision_number': 2,
- u'author': {
- u'_account_id': 11151243,
- u'email': u'owner@example.com',
- u'name': u'owner'
- },
- u'date': u'2017-03-16 20:00:41.000000000',
- u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
- u'message': u'PTAL',
- },
- {
- u'_revision_number': 2,
- u'author': {
- u'_account_id': 148512,
- u'email': u'reviewer@example.com',
- u'name': u'reviewer'
- },
- u'date': u'2017-03-17 05:19:37.500000000',
- u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
- u'message': u'Patch Set 2: Code-Review+1',
- },
- {
- u'_revision_number': 2,
- u'author': {
- u'_account_id': 42,
- u'name': u'reviewer'
- },
- u'date': u'2017-03-17 05:19:37.900000000',
- u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d0000',
- u'message': u'A bot with no email set',
- },
- ]
- }
- self.calls = [
- (('GetChangeComments', 'chromium-review.googlesource.com',
- 'infra%2Finfra~1'), {
- '/COMMIT_MSG': [
- {
- 'author': {
- 'email': u'reviewer@example.com'
- },
- 'updated': u'2017-03-17 05:19:37.500000000',
- 'patch_set': 2,
- 'side': 'REVISION',
- 'message': 'Please include a bug link',
- },
- ],
- 'codereview.settings': [
- {
- 'author': {
- 'email': u'owner@example.com'
- },
- 'updated': u'2017-03-16 20:00:41.000000000',
- 'patch_set': 2,
- 'side': 'PARENT',
- 'line': 42,
- 'message': 'I removed this because it is bad',
- },
- ]
- }),
- (('GetChangeRobotComments', 'chromium-review.googlesource.com',
- 'infra%2Finfra~1'), {}),
- ] * 2 + [(('write_json', 'output.json', [{
- u'date':
- u'2017-03-16 20:00:41.000000',
- u'message': (u'PTAL\n' + u'\n' + u'codereview.settings\n' +
- u' Base, Line 42: https://crrev.com/c/1/2/'
- u'codereview.settings#b42\n' +
- u' I removed this because it is bad\n'),
- u'autogenerated':
- False,
- u'approval':
- False,
- u'disapproval':
- False,
- u'sender':
- u'owner@example.com'
- }, {
- u'date':
- u'2017-03-17 05:19:37.500000',
- u'message':
- (u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
- u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
- u' Please include a bug link\n'),
- u'autogenerated':
- False,
- u'approval':
- False,
- u'disapproval':
- False,
- u'sender':
- u'reviewer@example.com'
- }]), '')]
- expected_comments_summary = [
- git_cl._CommentSummary(
- message=(u'PTAL\n' + u'\n' + u'codereview.settings\n' +
- u' Base, Line 42: https://crrev.com/c/1/2/' +
- u'codereview.settings#b42\n' +
- u' I removed this because it is bad\n'),
- date=datetime.datetime(2017, 3, 16, 20, 0, 41, 0),
- autogenerated=False,
- disapproval=False,
- approval=False,
- sender=u'owner@example.com'),
- git_cl._CommentSummary(message=(
- u'Patch Set 2: Code-Review+1\n' + u'\n' + u'/COMMIT_MSG\n' +
- u' PS2, File comment: https://crrev.com/c/1/2//COMMIT_MSG#\n' +
- u' Please include a bug link\n'),
- date=datetime.datetime(2017, 3, 17, 5, 19, 37,
- 500000),
- autogenerated=False,
- disapproval=False,
- approval=False,
- sender=u'reviewer@example.com'),
- ]
- cl = git_cl.Changelist(
- issue=1, branchref='refs/heads/foo')
- self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
- self.assertEqual(
- 0, git_cl.main(['comments', '-i', '1', '-j', 'output.json']))
- def test_git_cl_comments_robot_comments(self):
- # git cl comments also fetches robot comments (which are considered a type
- # of autogenerated comment), and unlike other types of comments, only robot
- # comments from the latest patchset are shown.
- self.mockGit.config['remote.origin.url'] = (
- 'https://x.googlesource.com/infra/infra')
- gerrit_util.GetChangeDetail.return_value = {
- 'owner': {'email': 'owner@example.com'},
- 'current_revision': 'ba5eba11',
- 'revisions': {
- 'deadbeaf': {
- '_number': 1,
- },
- 'ba5eba11': {
- '_number': 2,
- },
- },
- 'messages': [
- {
- u'_revision_number': 1,
- u'author': {
- u'_account_id': 1111084,
- u'email': u'commit-bot@chromium.org',
- u'name': u'Commit Bot'
- },
- u'date': u'2017-03-15 20:08:45.000000000',
- u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046dc50b',
- u'message': u'Patch Set 1:\n\nDry run: CQ is trying the patch...',
- u'tag': u'autogenerated:cq:dry-run'
- },
- {
- u'_revision_number': 1,
- u'author': {
- u'_account_id': 123,
- u'email': u'tricium@serviceaccount.com',
- u'name': u'Tricium'
- },
- u'date': u'2017-03-16 20:00:41.000000000',
- u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
- u'message': u'(1 comment)',
- u'tag': u'autogenerated:tricium',
- },
- {
- u'_revision_number': 1,
- u'author': {
- u'_account_id': 123,
- u'email': u'tricium@serviceaccount.com',
- u'name': u'Tricium'
- },
- u'date': u'2017-03-16 20:00:41.000000000',
- u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d1234',
- u'message': u'(1 comment)',
- u'tag': u'autogenerated:tricium',
- },
- {
- u'_revision_number': 2,
- u'author': {
- u'_account_id': 123,
- u'email': u'tricium@serviceaccount.com',
- u'name': u'reviewer'
- },
- u'date': u'2017-03-17 05:30:37.000000000',
- u'tag': u'autogenerated:tricium',
- u'id': u'f5a6c25ecbd3b3b54a43ae418ed97eff046d4568',
- u'message': u'(1 comment)',
- },
- ]
- }
- self.calls = [
- (('GetChangeComments', 'x-review.googlesource.com', 'infra%2Finfra~1'),
- {}),
- (('GetChangeRobotComments', 'x-review.googlesource.com',
- 'infra%2Finfra~1'), {
- 'codereview.settings': [
- {
- u'author': {
- u'email': u'tricium@serviceaccount.com'
- },
- u'updated': u'2017-03-17 05:30:37.000000000',
- u'robot_run_id': u'5565031076855808',
- u'robot_id': u'Linter/Category',
- u'tag': u'autogenerated:tricium',
- u'patch_set': 2,
- u'side': u'REVISION',
- u'message': u'Linter warning message text',
- u'line': 32,
- },
- ],
- }),
- ]
- expected_comments_summary = [
- git_cl._CommentSummary(
- date=datetime.datetime(2017, 3, 17, 5, 30, 37),
- message=(u'(1 comment)\n\ncodereview.settings\n'
- u' PS2, Line 32: https://x-review.googlesource.com/c/1/2/'
- u'codereview.settings#32\n'
- u' Linter warning message text\n'),
- sender=u'tricium@serviceaccount.com',
- autogenerated=True,
- approval=False,
- disapproval=False)
- ]
- cl = git_cl.Changelist(
- issue=1, branchref='refs/heads/foo')
- self.assertEqual(cl.GetCommentsSummary(), expected_comments_summary)
- def test_get_remote_url_with_mirror(self):
- original_os_path_isdir = os.path.isdir
- def selective_os_path_isdir_mock(path):
- if path == '/cache/this-dir-exists':
- return self._mocked_call('os.path.isdir', path)
- return original_os_path_isdir(path)
- mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
- url = 'https://chromium.googlesource.com/my/repo'
- self.mockGit.config['remote.origin.url'] = (
- '/cache/this-dir-exists')
- self.mockGit.config['/cache/this-dir-exists:remote.origin.url'] = (
- url)
- self.calls = [
- (('os.path.isdir', '/cache/this-dir-exists'),
- True),
- ]
- cl = git_cl.Changelist(issue=1)
- self.assertEqual(cl.GetRemoteUrl(), url)
- self.assertEqual(cl.GetRemoteUrl(), url) # Must be cached.
- def test_get_remote_url_non_existing_mirror(self):
- original_os_path_isdir = os.path.isdir
- def selective_os_path_isdir_mock(path):
- if path == '/cache/this-dir-doesnt-exist':
- return self._mocked_call('os.path.isdir', path)
- return original_os_path_isdir(path)
- mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
- mock.patch('logging.error',
- lambda *a: self._mocked_call('logging.error', *a)).start()
- self.mockGit.config['remote.origin.url'] = (
- '/cache/this-dir-doesnt-exist')
- self.calls = [
- (('os.path.isdir', '/cache/this-dir-doesnt-exist'),
- False),
- (('logging.error',
- 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
- 'but it doesn\'t exist.', {
- 'remote': 'origin',
- 'branch': 'main',
- 'url': '/cache/this-dir-doesnt-exist'}
- ), None),
- ]
- cl = git_cl.Changelist(issue=1)
- self.assertIsNone(cl.GetRemoteUrl())
- def test_get_remote_url_misconfigured_mirror(self):
- original_os_path_isdir = os.path.isdir
- def selective_os_path_isdir_mock(path):
- if path == '/cache/this-dir-exists':
- return self._mocked_call('os.path.isdir', path)
- return original_os_path_isdir(path)
- mock.patch('os.path.isdir', selective_os_path_isdir_mock).start()
- mock.patch('logging.error',
- lambda *a: self._mocked_call('logging.error', *a)).start()
- self.mockGit.config['remote.origin.url'] = (
- '/cache/this-dir-exists')
- self.calls = [
- (('os.path.isdir', '/cache/this-dir-exists'), True),
- (('logging.error',
- 'Remote "%(remote)s" for branch "%(branch)s" points to '
- '"%(cache_path)s", but it is misconfigured.\n'
- '"%(cache_path)s" must be a git repo and must have a remote named '
- '"%(remote)s" pointing to the git host.', {
- 'remote': 'origin',
- 'cache_path': '/cache/this-dir-exists',
- 'branch': 'main'}
- ), None),
- ]
- cl = git_cl.Changelist(issue=1)
- self.assertIsNone(cl.GetRemoteUrl())
- def test_gerrit_change_identifier_with_project(self):
- self.mockGit.config['remote.origin.url'] = (
- 'https://chromium.googlesource.com/a/my/repo.git/')
- cl = git_cl.Changelist(issue=123456)
- self.assertEqual(cl._GerritChangeIdentifier(), 'my%2Frepo~123456')
- def test_gerrit_change_identifier_without_project(self):
- mock.patch('logging.error',
- lambda *a: self._mocked_call('logging.error', *a)).start()
- self.calls = [
- (('logging.error',
- 'Remote "%(remote)s" for branch "%(branch)s" points to "%(url)s", '
- 'but it doesn\'t exist.', {
- 'remote': 'origin',
- 'branch': 'main',
- 'url': ''}
- ), None),
- ]
- cl = git_cl.Changelist(issue=123456)
- self.assertEqual(cl._GerritChangeIdentifier(), '123456')
- def test_gerrit_new_default(self):
- self._run_gerrit_upload_test(
- [],
- 'desc ✔\n\nBUG=\n\nChange-Id: I123456789\n',
- [],
- squash=False,
- squash_mode='override_nosquash',
- change_id='I123456789',
- default_branch='main')
- class ChangelistTest(unittest.TestCase):
- LAST_COMMIT_SUBJECT = 'Fixes goat teleporter destination to be Australia'
- def _mock_run_git(commands):
- if commands == ['show', '-s', '--format=%s', 'HEAD']:
- return ChangelistTest.LAST_COMMIT_SUBJECT
- def setUp(self):
- super(ChangelistTest, self).setUp()
- mock.patch('gclient_utils.FileRead').start()
- mock.patch('gclient_utils.FileWrite').start()
- mock.patch('gclient_utils.temporary_file', TemporaryFileMock()).start()
- mock.patch(
- 'git_cl.Changelist.GetCodereviewServer',
- return_value='https://chromium-review.googlesource.com').start()
- mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
- mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
- mock.patch('git_cl.Changelist.GetPatchset', return_value=7).start()
- mock.patch('git_cl.Changelist.GetUsePython3', return_value=False).start()
- mock.patch(
- 'git_cl.Changelist.GetRemoteBranch',
- return_value=('origin', 'refs/remotes/origin/main')).start()
- mock.patch('git_cl.PRESUBMIT_SUPPORT', 'PRESUBMIT_SUPPORT').start()
- mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
- mock.patch('git_cl.Settings.GetIsGerrit', return_value=True).start()
- mock.patch('git_cl.time_time').start()
- mock.patch('metrics.collector').start()
- mock.patch('subprocess2.Popen').start()
- mock.patch(
- 'git_cl.Changelist.GetGerritProject', return_value='project').start()
- mock.patch('sys.exit', side_effect=SystemExitMock).start()
- self.addCleanup(mock.patch.stopall)
- self.temp_count = 0
- self.mockGit = GitMocks()
- mock.patch('scm.GIT.GetConfig', self.mockGit.GetConfig).start()
- def testRunHook(self):
- expected_results = {
- 'more_cc': ['cc@example.com', 'more@example.com'],
- 'errors': [],
- 'notifications': [],
- 'warnings': [],
- }
- gclient_utils.FileRead.return_value = json.dumps(expected_results)
- git_cl.time_time.side_effect = [100, 200, 300, 400]
- mockProcess = mock.Mock()
- mockProcess.wait.return_value = 0
- subprocess2.Popen.return_value = mockProcess
- cl = git_cl.Changelist()
- results = cl.RunHook(
- committing=True,
- may_prompt=True,
- verbose=2,
- parallel=True,
- upstream='upstream',
- description='description',
- all_files=True,
- resultdb=False)
- self.assertEqual(expected_results, results)
- subprocess2.Popen.assert_any_call([
- 'vpython3', 'PRESUBMIT_SUPPORT',
- '--root', 'root',
- '--upstream', 'upstream',
- '--verbose', '--verbose',
- '--gerrit_url', 'https://chromium-review.googlesource.com',
- '--gerrit_project', 'project',
- '--gerrit_branch', 'refs/heads/main',
- '--author', 'author',
- '--issue', '123456',
- '--patchset', '7',
- '--commit',
- '--may_prompt',
- '--parallel',
- '--all_files',
- '--no_diffs',
- '--json_output', '/tmp/fake-temp2',
- '--description_file', '/tmp/fake-temp1',
- ])
- subprocess2.Popen.assert_any_call([
- 'vpython', 'PRESUBMIT_SUPPORT',
- '--root', 'root',
- '--upstream', 'upstream',
- '--verbose', '--verbose',
- '--gerrit_url', 'https://chromium-review.googlesource.com',
- '--gerrit_project', 'project',
- '--gerrit_branch', 'refs/heads/main',
- '--author', 'author',
- '--issue', '123456',
- '--patchset', '7',
- '--commit',
- '--may_prompt',
- '--parallel',
- '--all_files',
- '--no_diffs',
- '--json_output', '/tmp/fake-temp4',
- '--description_file', '/tmp/fake-temp3',
- ])
- gclient_utils.FileWrite.assert_any_call(
- '/tmp/fake-temp1', 'description')
- metrics.collector.add_repeated('sub_commands', {
- 'command': 'presubmit',
- 'execution_time': 100,
- 'exit_code': 0,
- })
- def testRunHook_FewerOptions(self):
- expected_results = {
- 'more_cc': ['cc@example.com', 'more@example.com'],
- 'errors': [],
- 'notifications': [],
- 'warnings': [],
- }
- gclient_utils.FileRead.return_value = json.dumps(expected_results)
- git_cl.time_time.side_effect = [100, 200, 300, 400]
- mockProcess = mock.Mock()
- mockProcess.wait.return_value = 0
- subprocess2.Popen.return_value = mockProcess
- git_cl.Changelist.GetAuthor.return_value = None
- git_cl.Changelist.GetIssue.return_value = None
- git_cl.Changelist.GetPatchset.return_value = None
- cl = git_cl.Changelist()
- results = cl.RunHook(
- committing=False,
- may_prompt=False,
- verbose=0,
- parallel=False,
- upstream='upstream',
- description='description',
- all_files=False,
- resultdb=False)
- self.assertEqual(expected_results, results)
- subprocess2.Popen.assert_any_call([
- 'vpython3', 'PRESUBMIT_SUPPORT',
- '--root', 'root',
- '--upstream', 'upstream',
- '--gerrit_url', 'https://chromium-review.googlesource.com',
- '--gerrit_project', 'project',
- '--gerrit_branch', 'refs/heads/main',
- '--upload',
- '--json_output', '/tmp/fake-temp2',
- '--description_file', '/tmp/fake-temp1',
- ])
- gclient_utils.FileWrite.assert_any_call(
- '/tmp/fake-temp1', 'description')
- metrics.collector.add_repeated('sub_commands', {
- 'command': 'presubmit',
- 'execution_time': 100,
- 'exit_code': 0,
- })
- def testRunHook_FewerOptionsResultDB(self):
- expected_results = {
- 'more_cc': ['cc@example.com', 'more@example.com'],
- 'errors': [],
- 'notifications': [],
- 'warnings': [],
- }
- gclient_utils.FileRead.return_value = json.dumps(expected_results)
- git_cl.time_time.side_effect = [100, 200, 300, 400]
- mockProcess = mock.Mock()
- mockProcess.wait.return_value = 0
- subprocess2.Popen.return_value = mockProcess
- git_cl.Changelist.GetAuthor.return_value = None
- git_cl.Changelist.GetIssue.return_value = None
- git_cl.Changelist.GetPatchset.return_value = None
- cl = git_cl.Changelist()
- results = cl.RunHook(
- committing=False,
- may_prompt=False,
- verbose=0,
- parallel=False,
- upstream='upstream',
- description='description',
- all_files=False,
- resultdb=True,
- realm='chromium:public')
- self.assertEqual(expected_results, results)
- subprocess2.Popen.assert_any_call([
- 'rdb', 'stream', '-new', '-realm', 'chromium:public', '--',
- 'vpython3', 'PRESUBMIT_SUPPORT',
- '--root', 'root',
- '--upstream', 'upstream',
- '--gerrit_url', 'https://chromium-review.googlesource.com',
- '--gerrit_project', 'project',
- '--gerrit_branch', 'refs/heads/main',
- '--upload',
- '--json_output', '/tmp/fake-temp2',
- '--description_file', '/tmp/fake-temp1',
- ])
- def testRunHook_NoGerrit(self):
- mock.patch('git_cl.Settings.GetIsGerrit', return_value=False).start()
- expected_results = {
- 'more_cc': ['cc@example.com', 'more@example.com'],
- 'errors': [],
- 'notifications': [],
- 'warnings': [],
- }
- gclient_utils.FileRead.return_value = json.dumps(expected_results)
- git_cl.time_time.side_effect = [100, 200, 300, 400]
- mockProcess = mock.Mock()
- mockProcess.wait.return_value = 0
- subprocess2.Popen.return_value = mockProcess
- git_cl.Changelist.GetAuthor.return_value = None
- git_cl.Changelist.GetIssue.return_value = None
- git_cl.Changelist.GetPatchset.return_value = None
- cl = git_cl.Changelist()
- results = cl.RunHook(
- committing=False,
- may_prompt=False,
- verbose=0,
- parallel=False,
- upstream='upstream',
- description='description',
- all_files=False,
- resultdb=False)
- self.assertEqual(expected_results, results)
- subprocess2.Popen.assert_any_call([
- 'vpython3', 'PRESUBMIT_SUPPORT',
- '--root', 'root',
- '--upstream', 'upstream',
- '--upload',
- '--json_output', '/tmp/fake-temp2',
- '--description_file', '/tmp/fake-temp1',
- ])
- gclient_utils.FileWrite.assert_any_call(
- '/tmp/fake-temp1', 'description')
- metrics.collector.add_repeated('sub_commands', {
- 'command': 'presubmit',
- 'execution_time': 100,
- 'exit_code': 0,
- })
- @mock.patch('sys.exit', side_effect=SystemExitMock)
- def testRunHook_Failure(self, _mock):
- git_cl.time_time.side_effect = [100, 200]
- mockProcess = mock.Mock()
- mockProcess.wait.return_value = 2
- subprocess2.Popen.return_value = mockProcess
- cl = git_cl.Changelist()
- with self.assertRaises(SystemExitMock):
- cl.RunHook(
- committing=True,
- may_prompt=True,
- verbose=2,
- parallel=True,
- upstream='upstream',
- description='description',
- all_files=True,
- resultdb=False)
- sys.exit.assert_called_once_with(2)
- def testRunPostUploadHook(self):
- cl = git_cl.Changelist()
- cl.RunPostUploadHook(2, 'upstream', 'description', False)
- subprocess2.Popen.assert_any_call([
- 'vpython',
- 'PRESUBMIT_SUPPORT',
- '--root',
- 'root',
- '--upstream',
- 'upstream',
- '--verbose',
- '--verbose',
- '--gerrit_url',
- 'https://chromium-review.googlesource.com',
- '--gerrit_project',
- 'project',
- '--gerrit_branch',
- 'refs/heads/main',
- '--author',
- 'author',
- '--issue',
- '123456',
- '--patchset',
- '7',
- '--post_upload',
- '--description_file',
- '/tmp/fake-temp1',
- ])
- subprocess2.Popen.assert_called_with([
- 'vpython3',
- 'PRESUBMIT_SUPPORT',
- '--root',
- 'root',
- '--upstream',
- 'upstream',
- '--verbose',
- '--verbose',
- '--gerrit_url',
- 'https://chromium-review.googlesource.com',
- '--gerrit_project',
- 'project',
- '--gerrit_branch',
- 'refs/heads/main',
- '--author',
- 'author',
- '--issue',
- '123456',
- '--patchset',
- '7',
- '--post_upload',
- '--description_file',
- '/tmp/fake-temp1',
- '--use-python3',
- ])
- gclient_utils.FileWrite.assert_called_once_with(
- '/tmp/fake-temp1', 'description')
- def testRunPostUploadHookPy3Only(self):
- cl = git_cl.Changelist()
- cl.RunPostUploadHook(2, 'upstream', 'description', True)
- subprocess2.Popen.assert_called_once_with([
- 'vpython3',
- 'PRESUBMIT_SUPPORT',
- '--root',
- 'root',
- '--upstream',
- 'upstream',
- '--verbose',
- '--verbose',
- '--gerrit_url',
- 'https://chromium-review.googlesource.com',
- '--gerrit_project',
- 'project',
- '--gerrit_branch',
- 'refs/heads/main',
- '--author',
- 'author',
- '--issue',
- '123456',
- '--patchset',
- '7',
- '--post_upload',
- '--description_file',
- '/tmp/fake-temp1',
- '--use-python3',
- ])
- gclient_utils.FileWrite.assert_called_once_with('/tmp/fake-temp1',
- 'description')
- @mock.patch('git_cl.RunGit', _mock_run_git)
- def testDefaultTitleEmptyMessage(self):
- cl = git_cl.Changelist()
- cl.issue = 100
- options = optparse.Values({
- 'squash': True,
- 'title': None,
- 'message': None,
- 'force': None,
- 'skip_title': None
- })
- mock.patch('gclient_utils.AskForData', lambda _: user_title).start()
- for user_title in ['', 'y', 'Y']:
- self.assertEqual(cl._GetTitleForUpload(options), self.LAST_COMMIT_SUBJECT)
- for user_title in ['not empty', 'yes', 'YES']:
- self.assertEqual(cl._GetTitleForUpload(options), user_title)
- @mock.patch('git_cl.Settings.GetRoot', return_value='')
- @mock.patch('git_cl.Changelist.FetchUpstreamTuple')
- @mock.patch('git_cl.RunGitWithCode')
- @mock.patch('git_cl.RunGit')
- @mock.patch('git_cl.Changelist._PrepareChange')
- @mock.patch('git_cl.Changelist.GetCommonAncestorWithUpstream')
- def testPrepareCherryPickSquashedCommit(self,
- mockGetCommonAncestorWithUpstream,
- mockPrepareChange, mockRunGit,
- mockRunGitWithCode,
- mockFetchUpstreamTuple, *_mocks):
- parent_hash = '1a2bparentcommit'
- mockGetCommonAncestorWithUpstream.return_value = parent_hash
- change_desc = git_cl.ChangeDescription('BOO!')
- ccs = ['cc@review.cl']
- reviewers = ['reviewer@review.cl']
- mockPrepareChange.return_value = (reviewers, ccs, change_desc)
- branchref = 'refs/heads/current-branch'
- cl = git_cl.Changelist(branchref=branchref)
- options = optparse.Values()
- mockFetchUpstreamTuple.return_value = ('', 'refs/heads/upstream')
- upstream_gerrit_hash = 'upstream-gerrit-hash'
- self.mockGit.config['branch.upstream.%s' %
- git_cl.GERRIT_SQUASH_HASH_CONFIG_KEY] = (
- upstream_gerrit_hash)
- latest_tree_hash = 'tree-hash'
- hash_to_cp = 'squashed-hash'
- hash_to_push = 'hash-to-push'
- hash_to_save_as_last_upload = 'last-upload'
- def mock_run_git(commands):
- if commands == ['rev-parse', branchref]:
- return hash_to_save_as_last_upload
- if commands == ['rev-parse', branchref + ':']:
- return latest_tree_hash
- if {'commit-tree', latest_tree_hash, '-p', parent_hash,
- '-F'}.issubset(set(commands)):
- return hash_to_cp
- if commands == ['rev-parse', 'HEAD']:
- return hash_to_push
- mockRunGit.side_effect = mock_run_git
- def mock_run_git_with_code(commands):
- if commands == ['cherry-pick', hash_to_cp]:
- return 0, ''
- mockRunGitWithCode.side_effect = mock_run_git_with_code
- new_upload = cl.PrepareCherryPickSquashedCommit(options)
- self.assertEqual(new_upload.reviewers, reviewers)
- self.assertEqual(new_upload.ccs, ccs)
- self.assertEqual(new_upload.commit_to_push, hash_to_push)
- self.assertEqual(new_upload.new_last_uploaded_commit,
- hash_to_save_as_last_upload)
- self.assertEqual(new_upload.change_desc, change_desc)
- # Test failed cherry-pick
- def mock_run_git_with_code(commands):
- if commands == ['cherry-pick', hash_to_cp]:
- return 1, ''
- mockRunGitWithCode.side_effect = mock_run_git_with_code
- with self.assertRaises(SystemExitMock):
- cl.PrepareCherryPickSquashedCommit(options)
- @mock.patch('git_cl.Changelist.GetAffectedFiles', return_value=[])
- @mock.patch('git_cl.GenerateGerritChangeId', return_value='1a2b3c')
- @mock.patch('git_cl.Changelist.GetIssue', return_value=None)
- @mock.patch('git_cl.ChangeDescription.prompt')
- @mock.patch('git_cl.Changelist.RunHook')
- @mock.patch('git_cl.Changelist._GetDescriptionForUpload')
- @mock.patch('git_cl.Changelist.EnsureCanUploadPatchset')
- def testPrepareChange_new(self, mockEnsureCanUploadPatchset,
- mockGetDescriptionForupload, mockRunHook,
- mockPrompt, *_mocks):
- options = optparse.Values()
- options.force = False
- options.bypass_hooks = False
- options.verbose = False
- options.parallel = False
- options.preserve_tryjobs = False
- options.private = False
- options.no_autocc = False
- options.message_file = None
- options.cc = ['chicken@bok.farm']
- parent = '420parent'
- latest_tree = '420latest_tree'
- mockRunHook.return_value = {'more_cc': ['cow@moo.farm']}
- desc = 'AH!\nCC=cow2@moo.farm\nR=horse@apple.farm'
- mockGetDescriptionForupload.return_value = git_cl.ChangeDescription(desc)
- cl = git_cl.Changelist()
- reviewers, ccs, change_desc = cl._PrepareChange(options, parent,
- latest_tree)
- self.assertEqual(reviewers, ['horse@apple.farm'])
- self.assertEqual(ccs, ['chicken@bok.farm', 'cow2@moo.farm'])
- self.assertEqual(change_desc._description_lines, [
- 'AH!', 'CC=cow2@moo.farm', 'R=horse@apple.farm', '', 'Change-Id: 1a2b3c'
- ])
- mockPrompt.assert_called_once()
- mockEnsureCanUploadPatchset.assert_called_once()
- mockRunHook.assert_called_once_with(committing=False,
- may_prompt=True,
- verbose=False,
- parallel=False,
- upstream='420parent',
- description=desc,
- all_files=False)
- @mock.patch('git_cl.Settings.GetDefaultCCList', return_value=[])
- @mock.patch('git_cl.Changelist.GetAffectedFiles', return_value=[])
- @mock.patch('git_cl.Changelist.GetIssue', return_value='123')
- @mock.patch('git_cl.ChangeDescription.prompt')
- @mock.patch('gerrit_util.GetChangeDetail')
- @mock.patch('git_cl.Changelist.RunHook')
- @mock.patch('git_cl.Changelist._GetDescriptionForUpload')
- @mock.patch('git_cl.Changelist.EnsureCanUploadPatchset')
- def testPrepareChange_existing(self, mockEnsureCanUploadPatchset,
- mockGetDescriptionForupload, mockRunHook,
- mockGetChangeDetail, mockPrompt, *_mocks):
- cl = git_cl.Changelist()
- options = optparse.Values()
- options.force = False
- options.bypass_hooks = False
- options.verbose = False
- options.parallel = False
- options.edit_description = False
- options.preserve_tryjobs = False
- options.private = False
- options.no_autocc = False
- options.cc = ['chicken@bok.farm']
- parent = '420parent'
- latest_tree = '420latest_tree'
- mockRunHook.return_value = {'more_cc': ['cow@moo.farm']}
- desc = 'AH!\nCC=cow2@moo.farm\nR=horse@apple.farm'
- mockGetDescriptionForupload.return_value = git_cl.ChangeDescription(desc)
- # Existing change
- gerrit_util.GetChangeDetail.return_value = {
- 'change_id': ('123456789'),
- 'current_revision': 'sha1_of_current_revision',
- }
- reviewers, ccs, change_desc = cl._PrepareChange(options, parent,
- latest_tree)
- self.assertEqual(reviewers, ['horse@apple.farm'])
- self.assertEqual(ccs, ['cow@moo.farm', 'chicken@bok.farm', 'cow2@moo.farm'])
- self.assertEqual(change_desc._description_lines, [
- 'AH!', 'CC=cow2@moo.farm', 'R=horse@apple.farm', '',
- 'Change-Id: 123456789'
- ])
- mockRunHook.assert_called_once_with(committing=False,
- may_prompt=True,
- verbose=False,
- parallel=False,
- upstream='420parent',
- description=desc,
- all_files=False)
- mockEnsureCanUploadPatchset.assert_called_once()
- # Test preserve_tryjob
- options.preserve_tryjobs = True
- # Test edit_description
- options.edit_description = True
- # Test private
- options.private = True
- options.no_autocc = True
- reviewers, ccs, change_desc = cl._PrepareChange(options, parent,
- latest_tree)
- self.assertEqual(ccs, ['chicken@bok.farm', 'cow2@moo.farm'])
- mockPrompt.assert_called_once()
- self.assertEqual(change_desc._description_lines, [
- 'AH!', 'CC=cow2@moo.farm', 'R=horse@apple.farm', '',
- 'Change-Id: 123456789', 'Cq-Do-Not-Cancel-Tryjobs: true'
- ])
- class CMDTestCaseBase(unittest.TestCase):
- _STATUSES = [
- 'STATUS_UNSPECIFIED', 'SCHEDULED', 'STARTED', 'SUCCESS', 'FAILURE',
- 'INFRA_FAILURE', 'CANCELED',
- ]
- _CHANGE_DETAIL = {
- 'project': 'depot_tools',
- 'status': 'OPEN',
- 'owner': {'email': 'owner@e.mail'},
- 'current_revision': 'beeeeeef',
- 'revisions': {
- 'deadbeaf': {
- '_number': 6,
- 'kind': 'REWORK',
- },
- 'beeeeeef': {
- '_number': 7,
- 'kind': 'NO_CODE_CHANGE',
- 'fetch': {'http': {
- 'url': 'https://chromium.googlesource.com/depot_tools',
- 'ref': 'refs/changes/56/123456/7'
- }},
- },
- },
- }
- _DEFAULT_RESPONSE = {
- 'builds': [{
- 'id': str(100 + idx),
- 'builder': {
- 'project': 'chromium',
- 'bucket': 'try',
- 'builder': 'bot_' + status.lower(),
- },
- 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
- 'tags': [],
- 'status': status,
- } for idx, status in enumerate(_STATUSES)]
- }
- def setUp(self):
- super(CMDTestCaseBase, self).setUp()
- mock.patch('git_cl.sys.stdout', StringIO()).start()
- mock.patch('git_cl.uuid.uuid4', return_value='uuid4').start()
- mock.patch('git_cl.Changelist.GetIssue', return_value=123456).start()
- mock.patch(
- 'git_cl.Changelist.GetCodereviewServer',
- return_value='https://chromium-review.googlesource.com').start()
- mock.patch(
- 'git_cl.Changelist.GetGerritHost',
- return_value='chromium-review.googlesource.com').start()
- mock.patch(
- 'git_cl.Changelist.GetMostRecentPatchset',
- return_value=7).start()
- mock.patch(
- 'git_cl.Changelist.GetMostRecentDryRunPatchset',
- return_value=6).start()
- mock.patch(
- 'git_cl.Changelist.GetRemoteUrl',
- return_value='https://chromium.googlesource.com/depot_tools').start()
- mock.patch(
- 'auth.Authenticator',
- return_value=AuthenticatorMock()).start()
- mock.patch(
- 'gerrit_util.GetChangeDetail',
- return_value=self._CHANGE_DETAIL).start()
- mock.patch(
- 'git_cl._call_buildbucket',
- return_value = self._DEFAULT_RESPONSE).start()
- mock.patch('git_common.is_dirty_git_tree', return_value=False).start()
- self.addCleanup(mock.patch.stopall)
- class CMDPresubmitTestCase(CMDTestCaseBase):
- def setUp(self):
- super(CMDPresubmitTestCase, self).setUp()
- mock.patch(
- 'git_cl.Changelist.GetCommonAncestorWithUpstream',
- return_value='upstream').start()
- mock.patch(
- 'git_cl.Changelist.FetchDescription',
- return_value='fetch description').start()
- mock.patch(
- 'git_cl._create_description_from_log',
- return_value='get description').start()
- mock.patch('git_cl.Changelist.RunHook').start()
- def testDefaultCase(self):
- self.assertEqual(0, git_cl.main(['presubmit']))
- git_cl.Changelist.RunHook.assert_called_once_with(
- committing=True,
- may_prompt=False,
- verbose=0,
- parallel=None,
- upstream='upstream',
- description='fetch description',
- all_files=None,
- files=None,
- resultdb=None,
- realm=None)
- def testNoIssue(self):
- git_cl.Changelist.GetIssue.return_value = None
- self.assertEqual(0, git_cl.main(['presubmit']))
- git_cl.Changelist.RunHook.assert_called_once_with(
- committing=True,
- may_prompt=False,
- verbose=0,
- parallel=None,
- upstream='upstream',
- description='get description',
- all_files=None,
- files=None,
- resultdb=None,
- realm=None)
- def testCustomBranch(self):
- self.assertEqual(0, git_cl.main(['presubmit', 'custom_branch']))
- git_cl.Changelist.RunHook.assert_called_once_with(
- committing=True,
- may_prompt=False,
- verbose=0,
- parallel=None,
- upstream='custom_branch',
- description='fetch description',
- all_files=None,
- files=None,
- resultdb=None,
- realm=None)
- def testOptions(self):
- self.assertEqual(
- 0, git_cl.main(['presubmit', '-v', '-v', '--all', '--parallel', '-u',
- '--resultdb', '--realm', 'chromium:public']))
- git_cl.Changelist.RunHook.assert_called_once_with(
- committing=False,
- may_prompt=False,
- verbose=2,
- parallel=True,
- upstream='upstream',
- description='fetch description',
- all_files=True,
- files=None,
- resultdb=True,
- realm='chromium:public')
- class CMDTryResultsTestCase(CMDTestCaseBase):
- _DEFAULT_REQUEST = {
- 'predicate': {
- "gerritChanges": [{
- "project": "depot_tools",
- "host": "chromium-review.googlesource.com",
- "patchset": 6,
- "change": 123456,
- }],
- },
- 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
- ',builds.*.createTime,builds.*.tags'),
- }
- _TRIVIAL_REQUEST = {
- 'predicate': {
- "gerritChanges": [{
- "project": "depot_tools",
- "host": "chromium-review.googlesource.com",
- "patchset": 7,
- "change": 123456,
- }],
- },
- 'fields': ('builds.*.id,builds.*.builder,builds.*.status' +
- ',builds.*.createTime,builds.*.tags'),
- }
- def testNoJobs(self):
- git_cl._call_buildbucket.return_value = {}
- self.assertEqual(0, git_cl.main(['try-results']))
- self.assertEqual('No tryjobs scheduled.\n', sys.stdout.getvalue())
- git_cl._call_buildbucket.assert_called_once_with(
- mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
- self._DEFAULT_REQUEST)
- def testTrivialCommits(self):
- self.assertEqual(0, git_cl.main(['try-results']))
- git_cl._call_buildbucket.assert_called_with(
- mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
- self._DEFAULT_REQUEST)
- git_cl._call_buildbucket.return_value = {}
- self.assertEqual(0, git_cl.main(['try-results', '--patchset', '7']))
- git_cl._call_buildbucket.assert_called_with(
- mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
- self._TRIVIAL_REQUEST)
- self.assertEqual([
- 'Successes:',
- ' bot_success https://ci.chromium.org/b/103',
- 'Infra Failures:',
- ' bot_infra_failure https://ci.chromium.org/b/105',
- 'Failures:',
- ' bot_failure https://ci.chromium.org/b/104',
- 'Canceled:',
- ' bot_canceled ',
- 'Started:',
- ' bot_started https://ci.chromium.org/b/102',
- 'Scheduled:',
- ' bot_scheduled id=101',
- 'Other:',
- ' bot_status_unspecified id=100',
- 'Total: 7 tryjobs',
- 'No tryjobs scheduled.',
- ], sys.stdout.getvalue().splitlines())
- def testPrintToStdout(self):
- self.assertEqual(0, git_cl.main(['try-results']))
- self.assertEqual([
- 'Successes:',
- ' bot_success https://ci.chromium.org/b/103',
- 'Infra Failures:',
- ' bot_infra_failure https://ci.chromium.org/b/105',
- 'Failures:',
- ' bot_failure https://ci.chromium.org/b/104',
- 'Canceled:',
- ' bot_canceled ',
- 'Started:',
- ' bot_started https://ci.chromium.org/b/102',
- 'Scheduled:',
- ' bot_scheduled id=101',
- 'Other:',
- ' bot_status_unspecified id=100',
- 'Total: 7 tryjobs',
- ], sys.stdout.getvalue().splitlines())
- git_cl._call_buildbucket.assert_called_once_with(
- mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
- self._DEFAULT_REQUEST)
- def testPrintToStdoutWithMasters(self):
- self.assertEqual(0, git_cl.main(['try-results', '--print-master']))
- self.assertEqual([
- 'Successes:',
- ' try bot_success https://ci.chromium.org/b/103',
- 'Infra Failures:',
- ' try bot_infra_failure https://ci.chromium.org/b/105',
- 'Failures:',
- ' try bot_failure https://ci.chromium.org/b/104',
- 'Canceled:',
- ' try bot_canceled ',
- 'Started:',
- ' try bot_started https://ci.chromium.org/b/102',
- 'Scheduled:',
- ' try bot_scheduled id=101',
- 'Other:',
- ' try bot_status_unspecified id=100',
- 'Total: 7 tryjobs',
- ], sys.stdout.getvalue().splitlines())
- git_cl._call_buildbucket.assert_called_once_with(
- mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
- self._DEFAULT_REQUEST)
- @mock.patch('git_cl.write_json')
- def testWriteToJson(self, mockJsonDump):
- self.assertEqual(0, git_cl.main(['try-results', '--json', 'file.json']))
- git_cl._call_buildbucket.assert_called_once_with(
- mock.ANY, 'cr-buildbucket.appspot.com', 'SearchBuilds',
- self._DEFAULT_REQUEST)
- mockJsonDump.assert_called_once_with(
- 'file.json', self._DEFAULT_RESPONSE['builds'])
- def test_filter_failed_for_one_simple(self):
- self.assertEqual([], git_cl._filter_failed_for_retry([]))
- self.assertEqual(
- [
- ('chromium', 'try', 'bot_failure'),
- ('chromium', 'try', 'bot_infra_failure'),
- ],
- git_cl._filter_failed_for_retry(self._DEFAULT_RESPONSE['builds']))
- def test_filter_failed_for_retry_many_builds(self):
- def _build(name, created_sec, status, experimental=False):
- assert 0 <= created_sec < 100, created_sec
- b = {
- 'id': 112112,
- 'builder': {
- 'project': 'chromium',
- 'bucket': 'try',
- 'builder': name,
- },
- 'createTime': '2019-10-09T08:00:%02d.854286Z' % created_sec,
- 'status': status,
- 'tags': [],
- }
- if experimental:
- b['tags'].append({'key': 'cq_experimental', 'value': 'true'})
- return b
- builds = [
- _build('flaky-last-green', 1, 'FAILURE'),
- _build('flaky-last-green', 2, 'SUCCESS'),
- _build('flaky', 1, 'SUCCESS'),
- _build('flaky', 2, 'FAILURE'),
- _build('running', 1, 'FAILED'),
- _build('running', 2, 'SCHEDULED'),
- _build('yep-still-running', 1, 'STARTED'),
- _build('yep-still-running', 2, 'FAILURE'),
- _build('cq-experimental', 1, 'SUCCESS', experimental=True),
- _build('cq-experimental', 2, 'FAILURE', experimental=True),
- # Simulate experimental in CQ builder, which developer decided
- # to retry manually which resulted in 2nd build non-experimental.
- _build('sometimes-experimental', 1, 'FAILURE', experimental=True),
- _build('sometimes-experimental', 2, 'FAILURE', experimental=False),
- ]
- builds.sort(key=lambda b: b['status']) # ~deterministic shuffle.
- self.assertEqual(
- [
- ('chromium', 'try', 'flaky'),
- ('chromium', 'try', 'sometimes-experimental'),
- ],
- git_cl._filter_failed_for_retry(builds))
- class CMDTryTestCase(CMDTestCaseBase):
- @mock.patch('git_cl.Changelist.SetCQState')
- def testSetCQDryRunByDefault(self, mockSetCQState):
- mockSetCQState.return_value = 0
- self.assertEqual(0, git_cl.main(['try']))
- git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.DRY_RUN)
- self.assertEqual(
- sys.stdout.getvalue(),
- 'Scheduling CQ dry run on: '
- 'https://chromium-review.googlesource.com/123456\n')
- @mock.patch('git_cl.Changelist.SetCQState')
- def testSetCQQuickRunByDefault(self, mockSetCQState):
- mockSetCQState.return_value = 0
- self.assertEqual(0, git_cl.main(['try', '-q']))
- git_cl.Changelist.SetCQState.assert_called_with(git_cl._CQState.QUICK_RUN)
- self.assertEqual(
- sys.stdout.getvalue(),
- 'Scheduling CQ quick run on: '
- 'https://chromium-review.googlesource.com/123456\n')
- @mock.patch('git_cl._call_buildbucket')
- def testScheduleOnBuildbucket(self, mockCallBuildbucket):
- mockCallBuildbucket.return_value = {}
- self.assertEqual(0, git_cl.main([
- 'try', '-B', 'luci.chromium.try', '-b', 'win',
- '-p', 'key=val', '-p', 'json=[{"a":1}, null]']))
- self.assertIn(
- 'Scheduling jobs on:\n'
- ' chromium/try: win',
- git_cl.sys.stdout.getvalue())
- expected_request = {
- "requests": [{
- "scheduleBuild": {
- "requestId": "uuid4",
- "builder": {
- "project": "chromium",
- "builder": "win",
- "bucket": "try",
- },
- "gerritChanges": [{
- "project": "depot_tools",
- "host": "chromium-review.googlesource.com",
- "patchset": 7,
- "change": 123456,
- }],
- "properties": {
- "category": "git_cl_try",
- "json": [{"a": 1}, None],
- "key": "val",
- },
- "tags": [
- {"value": "win", "key": "builder"},
- {"value": "git_cl_try", "key": "user_agent"},
- ],
- },
- }],
- }
- mockCallBuildbucket.assert_called_with(
- mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
- @mock.patch('git_cl._call_buildbucket')
- def testScheduleOnBuildbucketWithRevision(self, mockCallBuildbucket):
- mockCallBuildbucket.return_value = {}
- mock.patch('git_cl.Changelist.GetRemoteBranch',
- return_value=('origin', 'refs/remotes/origin/main')).start()
- self.assertEqual(0, git_cl.main([
- 'try', '-B', 'luci.chromium.try', '-b', 'win', '-b', 'linux',
- '-p', 'key=val', '-p', 'json=[{"a":1}, null]',
- '-r', 'beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef']))
- self.assertIn(
- 'Scheduling jobs on:\n'
- ' chromium/try: linux\n'
- ' chromium/try: win',
- git_cl.sys.stdout.getvalue())
- expected_request = {
- "requests": [{
- "scheduleBuild": {
- "requestId":
- "uuid4",
- "builder": {
- "project": "chromium",
- "builder": "linux",
- "bucket": "try",
- },
- "gerritChanges": [{
- "project": "depot_tools",
- "host": "chromium-review.googlesource.com",
- "patchset": 7,
- "change": 123456,
- }],
- "properties": {
- "category": "git_cl_try",
- "json": [{
- "a": 1
- }, None],
- "key": "val",
- },
- "tags": [
- {
- "value": "linux",
- "key": "builder"
- },
- {
- "value": "git_cl_try",
- "key": "user_agent"
- },
- ],
- "gitilesCommit": {
- "host": "chromium.googlesource.com",
- "project": "depot_tools",
- "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
- "ref": "refs/heads/main",
- }
- },
- }, {
- "scheduleBuild": {
- "requestId":
- "uuid4",
- "builder": {
- "project": "chromium",
- "builder": "win",
- "bucket": "try",
- },
- "gerritChanges": [{
- "project": "depot_tools",
- "host": "chromium-review.googlesource.com",
- "patchset": 7,
- "change": 123456,
- }],
- "properties": {
- "category": "git_cl_try",
- "json": [{
- "a": 1
- }, None],
- "key": "val",
- },
- "tags": [
- {
- "value": "win",
- "key": "builder"
- },
- {
- "value": "git_cl_try",
- "key": "user_agent"
- },
- ],
- "gitilesCommit": {
- "host": "chromium.googlesource.com",
- "project": "depot_tools",
- "id": "beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeef",
- "ref": "refs/heads/main",
- }
- },
- }],
- }
- mockCallBuildbucket.assert_called_with(
- mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
- @mock.patch('sys.stderr', StringIO())
- def testScheduleOnBuildbucket_WrongBucket(self):
- with self.assertRaises(SystemExit):
- git_cl.main([
- 'try', '-B', 'not-a-bucket', '-b', 'win',
- '-p', 'key=val', '-p', 'json=[{"a":1}, null]'])
- self.assertIn(
- 'Invalid bucket: not-a-bucket.',
- sys.stderr.getvalue())
- @mock.patch('git_cl._call_buildbucket')
- @mock.patch('git_cl._fetch_tryjobs')
- def testScheduleOnBuildbucketRetryFailed(
- self, mockFetchTryJobs, mockCallBuildbucket):
- git_cl._fetch_tryjobs.side_effect = lambda *_, **kw: {
- 7: [],
- 6: [{
- 'id': 112112,
- 'builder': {
- 'project': 'chromium',
- 'bucket': 'try',
- 'builder': 'linux', },
- 'createTime': '2019-10-09T08:00:01.854286Z',
- 'tags': [],
- 'status': 'FAILURE', }], }[kw['patchset']]
- mockCallBuildbucket.return_value = {}
- self.assertEqual(0, git_cl.main(['try', '--retry-failed']))
- self.assertIn(
- 'Scheduling jobs on:\n'
- ' chromium/try: linux',
- git_cl.sys.stdout.getvalue())
- expected_request = {
- "requests": [{
- "scheduleBuild": {
- "requestId": "uuid4",
- "builder": {
- "project": "chromium",
- "bucket": "try",
- "builder": "linux",
- },
- "gerritChanges": [{
- "project": "depot_tools",
- "host": "chromium-review.googlesource.com",
- "patchset": 7,
- "change": 123456,
- }],
- "properties": {
- "category": "git_cl_try",
- },
- "tags": [
- {"value": "linux", "key": "builder"},
- {"value": "git_cl_try", "key": "user_agent"},
- {"value": "1", "key": "retry_failed"},
- ],
- },
- }],
- }
- mockCallBuildbucket.assert_called_with(
- mock.ANY, 'cr-buildbucket.appspot.com', 'Batch', expected_request)
- def test_parse_bucket(self):
- test_cases = [
- {
- 'bucket': 'chromium/try',
- 'result': ('chromium', 'try'),
- },
- {
- 'bucket': 'luci.chromium.try',
- 'result': ('chromium', 'try'),
- 'has_warning': True,
- },
- {
- 'bucket': 'skia.primary',
- 'result': ('skia', 'skia.primary'),
- 'has_warning': True,
- },
- {
- 'bucket': 'not-a-bucket',
- 'result': (None, None),
- },
- ]
- for test_case in test_cases:
- git_cl.sys.stdout.truncate(0)
- self.assertEqual(
- test_case['result'], git_cl._parse_bucket(test_case['bucket']))
- if test_case.get('has_warning'):
- expected_warning = 'WARNING Please use %s/%s to specify the bucket' % (
- test_case['result'])
- self.assertIn(expected_warning, git_cl.sys.stdout.getvalue())
- class CMDUploadTestCase(CMDTestCaseBase):
- def setUp(self):
- super(CMDUploadTestCase, self).setUp()
- mock.patch('git_cl._fetch_tryjobs').start()
- mock.patch('git_cl._trigger_tryjobs', return_value={}).start()
- mock.patch('git_cl.Changelist.CMDUpload', return_value=0).start()
- mock.patch('git_cl.Settings.GetRoot', return_value='').start()
- mock.patch(
- 'git_cl.Settings.GetSquashGerritUploads',
- return_value=True).start()
- self.addCleanup(mock.patch.stopall)
- def testWarmUpChangeDetailCache(self):
- self.assertEqual(0, git_cl.main(['upload']))
- gerrit_util.GetChangeDetail.assert_called_once_with(
- 'chromium-review.googlesource.com', 'depot_tools~123456',
- frozenset([
- 'LABELS', 'CURRENT_REVISION', 'DETAILED_ACCOUNTS',
- 'CURRENT_COMMIT']))
- def testUploadRetryFailed(self):
- # This test mocks out the actual upload part, and just asserts that after
- # upload, if --retry-failed is added, then the tool will fetch try jobs
- # from the previous patchset and trigger the right builders on the latest
- # patchset.
- git_cl._fetch_tryjobs.side_effect = [
- # Latest patchset: No builds.
- [],
- # Patchset before latest: Some builds.
- [{
- 'id': str(100 + idx),
- 'builder': {
- 'project': 'chromium',
- 'bucket': 'try',
- 'builder': 'bot_' + status.lower(),
- },
- 'createTime': '2019-10-09T08:00:0%d.854286Z' % (idx % 10),
- 'tags': [],
- 'status': status,
- } for idx, status in enumerate(self._STATUSES)],
- ]
- self.assertEqual(0, git_cl.main(['upload', '--retry-failed']))
- self.assertEqual([
- mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=7),
- mock.call(mock.ANY, 'cr-buildbucket.appspot.com', patchset=6),
- ], git_cl._fetch_tryjobs.mock_calls)
- expected_buckets = [
- ('chromium', 'try', 'bot_failure'),
- ('chromium', 'try', 'bot_infra_failure'),
- ]
- git_cl._trigger_tryjobs.assert_called_once_with(mock.ANY, expected_buckets,
- mock.ANY, 8)
- class MakeRequestsHelperTestCase(unittest.TestCase):
- def exampleGerritChange(self):
- return {
- 'host': 'chromium-review.googlesource.com',
- 'project': 'depot_tools',
- 'change': 1,
- 'patchset': 2,
- }
- def testMakeRequestsHelperNoOptions(self):
- # Basic test for the helper function _make_tryjob_schedule_requests;
- # it shouldn't throw AttributeError even when options doesn't have any
- # of the expected values; it will use default option values.
- changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
- jobs = [('chromium', 'try', 'my-builder')]
- options = optparse.Values()
- requests = git_cl._make_tryjob_schedule_requests(
- changelist, jobs, options, patchset=None)
- # requestId is non-deterministic. Just assert that it's there and has
- # a particular length.
- self.assertEqual(len(requests[0]['scheduleBuild'].pop('requestId')), 36)
- self.assertEqual(requests, [{
- 'scheduleBuild': {
- 'builder': {
- 'bucket': 'try',
- 'builder': 'my-builder',
- 'project': 'chromium'
- },
- 'gerritChanges': [self.exampleGerritChange()],
- 'properties': {
- 'category': 'git_cl_try'
- },
- 'tags': [{
- 'key': 'builder',
- 'value': 'my-builder'
- }, {
- 'key': 'user_agent',
- 'value': 'git_cl_try'
- }]
- }
- }])
- def testMakeRequestsHelperPresubmitSetsDryRunProperty(self):
- changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
- jobs = [('chromium', 'try', 'presubmit')]
- options = optparse.Values()
- requests = git_cl._make_tryjob_schedule_requests(
- changelist, jobs, options, patchset=None)
- self.assertEqual(requests[0]['scheduleBuild']['properties'], {
- 'category': 'git_cl_try',
- 'dry_run': 'true'
- })
- def testMakeRequestsHelperRevisionSet(self):
- # Gitiles commit is specified when revision is in options.
- changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
- jobs = [('chromium', 'try', 'my-builder')]
- options = optparse.Values({'revision': 'ba5eba11'})
- requests = git_cl._make_tryjob_schedule_requests(
- changelist, jobs, options, patchset=None)
- self.assertEqual(
- requests[0]['scheduleBuild']['gitilesCommit'], {
- 'host': 'chromium.googlesource.com',
- 'id': 'ba5eba11',
- 'project': 'depot_tools',
- 'ref': 'refs/heads/main',
- })
- def testMakeRequestsHelperRetryFailedSet(self):
- # An extra tag is added when retry_failed is in options.
- changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
- jobs = [('chromium', 'try', 'my-builder')]
- options = optparse.Values({'retry_failed': 'true'})
- requests = git_cl._make_tryjob_schedule_requests(
- changelist, jobs, options, patchset=None)
- self.assertEqual(
- requests[0]['scheduleBuild']['tags'], [
- {
- 'key': 'builder',
- 'value': 'my-builder'
- },
- {
- 'key': 'user_agent',
- 'value': 'git_cl_try'
- },
- {
- 'key': 'retry_failed',
- 'value': '1'
- }
- ])
- def testMakeRequestsHelperCategorySet(self):
- # The category property can be overridden with options.
- changelist = ChangelistMock(gerrit_change=self.exampleGerritChange())
- jobs = [('chromium', 'try', 'my-builder')]
- options = optparse.Values({'category': 'my-special-category'})
- requests = git_cl._make_tryjob_schedule_requests(
- changelist, jobs, options, patchset=None)
- self.assertEqual(requests[0]['scheduleBuild']['properties'],
- {'category': 'my-special-category'})
- class CMDFormatTestCase(unittest.TestCase):
- def setUp(self):
- super(CMDFormatTestCase, self).setUp()
- mock.patch('git_cl.RunCommand').start()
- mock.patch('clang_format.FindClangFormatToolInChromiumTree').start()
- mock.patch('clang_format.FindClangFormatScriptInChromiumTree').start()
- mock.patch('git_cl.settings').start()
- self._top_dir = tempfile.mkdtemp()
- self.addCleanup(mock.patch.stopall)
- def tearDown(self):
- shutil.rmtree(self._top_dir)
- super(CMDFormatTestCase, self).tearDown()
- def _make_temp_file(self, fname, contents):
- gclient_utils.FileWrite(os.path.join(self._top_dir, fname),
- ('\n'.join(contents)))
- def _make_yapfignore(self, contents):
- self._make_temp_file('.yapfignore', contents)
- def _check_yapf_filtering(self, files, expected):
- self.assertEqual(expected, git_cl._FilterYapfIgnoredFiles(
- files, git_cl._GetYapfIgnorePatterns(self._top_dir)))
- def _run_command_mock(self, return_value):
- def f(*args, **kwargs):
- if 'stdin' in kwargs:
- self.assertIsInstance(kwargs['stdin'], bytes)
- return return_value
- return f
- def testClangFormatDiffFull(self):
- self._make_temp_file('test.cc', ['// test'])
- git_cl.settings.GetFormatFullByDefault.return_value = False
- diff_file = [os.path.join(self._top_dir, 'test.cc')]
- mock_opts = mock.Mock(full=True, dry_run=True, diff=False)
- # Diff
- git_cl.RunCommand.side_effect = self._run_command_mock(' // test')
- return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
- self._top_dir, 'HEAD')
- self.assertEqual(2, return_value)
- # No diff
- git_cl.RunCommand.side_effect = self._run_command_mock('// test')
- return_value = git_cl._RunClangFormatDiff(mock_opts, diff_file,
- self._top_dir, 'HEAD')
- self.assertEqual(0, return_value)
- def testClangFormatDiff(self):
- git_cl.settings.GetFormatFullByDefault.return_value = False
- # A valid file is required, so use this test.
- clang_format.FindClangFormatToolInChromiumTree.return_value = __file__
- mock_opts = mock.Mock(full=False, dry_run=True, diff=False)
- # Diff
- git_cl.RunCommand.side_effect = self._run_command_mock('error')
- return_value = git_cl._RunClangFormatDiff(
- mock_opts, ['.'], self._top_dir, 'HEAD')
- self.assertEqual(2, return_value)
- # No diff
- git_cl.RunCommand.side_effect = self._run_command_mock('')
- return_value = git_cl._RunClangFormatDiff(mock_opts, ['.'], self._top_dir,
- 'HEAD')
- self.assertEqual(0, return_value)
- def testYapfignoreExplicit(self):
- self._make_yapfignore(['foo/bar.py', 'foo/bar/baz.py'])
- files = [
- 'bar.py',
- 'foo/bar.py',
- 'foo/baz.py',
- 'foo/bar/baz.py',
- 'foo/bar/foobar.py',
- ]
- expected = [
- 'bar.py',
- 'foo/baz.py',
- 'foo/bar/foobar.py',
- ]
- self._check_yapf_filtering(files, expected)
- def testYapfignoreSingleWildcards(self):
- self._make_yapfignore(['*bar.py', 'foo*', 'baz*.py'])
- files = [
- 'bar.py', # Matched by *bar.py.
- 'bar.txt',
- 'foobar.py', # Matched by *bar.py, foo*.
- 'foobar.txt', # Matched by foo*.
- 'bazbar.py', # Matched by *bar.py, baz*.py.
- 'bazbar.txt',
- 'foo/baz.txt', # Matched by foo*.
- 'bar/bar.py', # Matched by *bar.py.
- 'baz/foo.py', # Matched by baz*.py, foo*.
- 'baz/foo.txt',
- ]
- expected = [
- 'bar.txt',
- 'bazbar.txt',
- 'baz/foo.txt',
- ]
- self._check_yapf_filtering(files, expected)
- def testYapfignoreMultiplewildcards(self):
- self._make_yapfignore(['*bar*', '*foo*baz.txt'])
- files = [
- 'bar.py', # Matched by *bar*.
- 'bar.txt', # Matched by *bar*.
- 'abar.py', # Matched by *bar*.
- 'foobaz.txt', # Matched by *foo*baz.txt.
- 'foobaz.py',
- 'afoobaz.txt', # Matched by *foo*baz.txt.
- ]
- expected = [
- 'foobaz.py',
- ]
- self._check_yapf_filtering(files, expected)
- def testYapfignoreComments(self):
- self._make_yapfignore(['test.py', '#test2.py'])
- files = [
- 'test.py',
- 'test2.py',
- ]
- expected = [
- 'test2.py',
- ]
- self._check_yapf_filtering(files, expected)
- def testYapfHandleUtf8(self):
- self._make_yapfignore(['test.py', 'test_🌐.py'])
- files = [
- 'test.py',
- 'test_🌐.py',
- 'test2.py',
- ]
- expected = [
- 'test2.py',
- ]
- self._check_yapf_filtering(files, expected)
- def testYapfignoreBlankLines(self):
- self._make_yapfignore(['test.py', '', '', 'test2.py'])
- files = [
- 'test.py',
- 'test2.py',
- 'test3.py',
- ]
- expected = [
- 'test3.py',
- ]
- self._check_yapf_filtering(files, expected)
- def testYapfignoreWhitespace(self):
- self._make_yapfignore([' test.py '])
- files = [
- 'test.py',
- 'test2.py',
- ]
- expected = [
- 'test2.py',
- ]
- self._check_yapf_filtering(files, expected)
- def testYapfignoreNoFiles(self):
- self._make_yapfignore(['test.py'])
- self._check_yapf_filtering([], [])
- def testYapfignoreMissingYapfignore(self):
- files = [
- 'test.py',
- ]
- expected = [
- 'test.py',
- ]
- self._check_yapf_filtering(files, expected)
- class CMDStatusTestCase(CMDTestCaseBase):
- # Return branch names a,..,f with comitterdates in increasing order, i.e.
- # 'f' is the most-recently changed branch.
- def _mock_run_git(commands):
- if commands == [
- 'for-each-ref', '--format=%(refname) %(committerdate:unix)',
- 'refs/heads'
- ]:
- branches_and_committerdates = [
- 'refs/heads/a 1',
- 'refs/heads/b 2',
- 'refs/heads/c 3',
- 'refs/heads/d 4',
- 'refs/heads/e 5',
- 'refs/heads/f 6',
- ]
- return '\n'.join(branches_and_committerdates)
- # Mock the status in such a way that the issue number gives us an
- # indication of the commit date (simplifies manual debugging).
- def _mock_get_cl_statuses(branches, fine_grained, max_processes):
- for c in branches:
- c.issue = (100 + int(c.GetCommitDate()))
- yield (c, 'open')
- @mock.patch('git_cl.Changelist.EnsureAuthenticated')
- @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
- @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
- @mock.patch('git_cl.RunGit', _mock_run_git)
- @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
- @mock.patch('git_cl.Settings.GetRoot', return_value='')
- @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=False)
- @mock.patch('scm.GIT.GetBranch', return_value='a')
- def testStatus(self, *_mocks):
- self.assertEqual(0, git_cl.main(['status', '--no-branch-color']))
- self.maxDiff = None
- self.assertEqual(
- sys.stdout.getvalue(), 'Branches associated with reviews:\n'
- ' * a : https://crrev.com/c/101 (open)\n'
- ' b : https://crrev.com/c/102 (open)\n'
- ' c : https://crrev.com/c/103 (open)\n'
- ' d : https://crrev.com/c/104 (open)\n'
- ' e : https://crrev.com/c/105 (open)\n'
- ' f : https://crrev.com/c/106 (open)\n\n'
- 'Current branch: a\n'
- 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
- 'Issue description:\n'
- 'x\n')
- @mock.patch('git_cl.Changelist.EnsureAuthenticated')
- @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
- @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
- @mock.patch('git_cl.RunGit', _mock_run_git)
- @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
- @mock.patch('git_cl.Settings.GetRoot', return_value='')
- @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=False)
- @mock.patch('scm.GIT.GetBranch', return_value='a')
- def testStatusByDate(self, *_mocks):
- self.assertEqual(
- 0, git_cl.main(['status', '--no-branch-color', '--date-order']))
- self.maxDiff = None
- self.assertEqual(
- sys.stdout.getvalue(), 'Branches associated with reviews:\n'
- ' f : https://crrev.com/c/106 (open)\n'
- ' e : https://crrev.com/c/105 (open)\n'
- ' d : https://crrev.com/c/104 (open)\n'
- ' c : https://crrev.com/c/103 (open)\n'
- ' b : https://crrev.com/c/102 (open)\n'
- ' * a : https://crrev.com/c/101 (open)\n\n'
- 'Current branch: a\n'
- 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
- 'Issue description:\n'
- 'x\n')
- @mock.patch('git_cl.Changelist.EnsureAuthenticated')
- @mock.patch('git_cl.Changelist.FetchDescription', lambda cl, pretty: 'x')
- @mock.patch('git_cl.Changelist.GetIssue', lambda cl: cl.issue)
- @mock.patch('git_cl.RunGit', _mock_run_git)
- @mock.patch('git_cl.get_cl_statuses', _mock_get_cl_statuses)
- @mock.patch('git_cl.Settings.GetRoot', return_value='')
- @mock.patch('git_cl.Settings.IsStatusCommitOrderByDate', return_value=True)
- @mock.patch('scm.GIT.GetBranch', return_value='a')
- def testStatusByDate(self, *_mocks):
- self.assertEqual(
- 0, git_cl.main(['status', '--no-branch-color']))
- self.maxDiff = None
- self.assertEqual(
- sys.stdout.getvalue(), 'Branches associated with reviews:\n'
- ' f : https://crrev.com/c/106 (open)\n'
- ' e : https://crrev.com/c/105 (open)\n'
- ' d : https://crrev.com/c/104 (open)\n'
- ' c : https://crrev.com/c/103 (open)\n'
- ' b : https://crrev.com/c/102 (open)\n'
- ' * a : https://crrev.com/c/101 (open)\n\n'
- 'Current branch: a\n'
- 'Issue number: 101 (https://chromium-review.googlesource.com/101)\n'
- 'Issue description:\n'
- 'x\n')
- class CMDOwnersTestCase(CMDTestCaseBase):
- def setUp(self):
- super(CMDOwnersTestCase, self).setUp()
- self.owners_by_path = {
- 'foo': ['a@example.com'],
- 'bar': ['b@example.com', 'c@example.com'],
- }
- mock.patch('git_cl.Settings.GetRoot', return_value='root').start()
- mock.patch('git_cl.Changelist.GetAuthor', return_value='author').start()
- mock.patch(
- 'git_cl.Changelist.GetAffectedFiles',
- return_value=list(self.owners_by_path)).start()
- mock.patch(
- 'git_cl.Changelist.GetCommonAncestorWithUpstream',
- return_value='upstream').start()
- mock.patch(
- 'git_cl.Changelist.GetGerritHost',
- return_value='host').start()
- mock.patch(
- 'git_cl.Changelist.GetGerritProject',
- return_value='project').start()
- mock.patch(
- 'git_cl.Changelist.GetRemoteBranch',
- return_value=('origin', 'refs/remotes/origin/main')).start()
- mock.patch(
- 'owners_client.OwnersClient.BatchListOwners',
- return_value=self.owners_by_path).start()
- mock.patch(
- 'gerrit_util.IsCodeOwnersEnabledOnHost', return_value=True).start()
- self.addCleanup(mock.patch.stopall)
- def testShowAllNoArgs(self):
- self.assertEqual(0, git_cl.main(['owners', '--show-all']))
- self.assertEqual(
- 'No files specified for --show-all. Nothing to do.\n',
- git_cl.sys.stdout.getvalue())
- def testShowAll(self):
- self.assertEqual(
- 0,
- git_cl.main(['owners', '--show-all', 'foo', 'bar', 'baz']))
- owners_client.OwnersClient.BatchListOwners.assert_called_once_with(
- ['foo', 'bar', 'baz'])
- self.assertEqual(
- '\n'.join([
- 'Owners for foo:',
- ' - a@example.com',
- 'Owners for bar:',
- ' - b@example.com',
- ' - c@example.com',
- 'Owners for baz:',
- ' - No owners found',
- '',
- ]),
- sys.stdout.getvalue())
- def testBatch(self):
- self.assertEqual(0, git_cl.main(['owners', '--batch']))
- self.assertIn('a@example.com', sys.stdout.getvalue())
- self.assertIn('b@example.com', sys.stdout.getvalue())
- if __name__ == '__main__':
- logging.basicConfig(
- level=logging.DEBUG if '-v' in sys.argv else logging.ERROR)
- unittest.main()
|