소스 검색

post_build_ninja_summary: run siso.py instead of siso command

Passing args via siso.bat is problematic.
Invoke 'python3 siso.py' instead.

Bug: 323780528
Change-Id: I991aeab375068d790f9e1f9fd264db9c1003f9dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6247814
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Fumitoshi Ukai 6 달 전
부모
커밋
a5519ca872
1개의 변경된 파일3개의 추가작업 그리고 2개의 파일을 삭제
  1. 3 2
      post_build_ninja_summary.py

+ 3 - 2
post_build_ninja_summary.py

@@ -57,6 +57,8 @@ import os
 import subprocess
 import sys
 
+THIS_DIR = os.path.dirname(__file__)
+
 # The number of long build times to report:
 long_count = 10
 # The number of long times by extension to report
@@ -362,8 +364,7 @@ def main():
         long_ext_count += len(args.step_types.split(";"))
 
     if os.path.exists(metrics_file):
-        # Automatically handle summarizing siso builds.
-        cmd = ["siso.bat" if "win32" in sys.platform else "siso"]
+        cmd = [sys.executable, os.path.join(THIS_DIR, "siso.py")]
         cmd.extend(["metrics", "summary"])
         if args.build_directory:
             cmd.extend(["-C", args.build_directory])