瀏覽代碼

Print clarifying message when no new owners needed

If a CL already has owners on the reviewer list that cover all of the
files - regardless of whether they have approved the change - git cl
owners just prints ** You selected these owners **, which can be
confusing. This change adds an explanation in the no-unowned-files case
and suggests using --ignore-current if more reviewers are wanted.

Bug: 1071967
Change-Id: If60455c5ec15006e09feed39633fa62e3ddf0a04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2183222
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Bruce Dawson 5 年之前
父節點
當前提交
9b4a0570e5
共有 1 個文件被更改,包括 13 次插入8 次删除
  1. 13 8
      owners_finder.py

+ 13 - 8
owners_finder.py

@@ -334,14 +334,19 @@ class OwnersFinder(object):
     # Print results
     # Print results
     self.writeln()
     self.writeln()
     self.writeln()
     self.writeln()
-    self.writeln('** You selected these owners **')
-    self.writeln()
-    for owner in self.selected_owners:
-      self.writeln(self.bold_name(owner) + ':')
-      self.indent()
-      for file_name in sorted(self.owners_to_files[owner]):
-        self.writeln(file_name)
-      self.unindent()
+    if len(self.selected_owners) == 0:
+      self.writeln('This change list already has owner-reviewers for all '
+                   'files.')
+      self.writeln('Use --ignore-current if you want to ignore them.')
+    else:
+      self.writeln('** You selected these owners **')
+      self.writeln()
+      for owner in self.selected_owners:
+        self.writeln(self.bold_name(owner) + ':')
+        self.indent()
+        for file_name in sorted(self.owners_to_files[owner]):
+          self.writeln(file_name)
+        self.unindent()
 
 
   def bold(self, text):
   def bold(self, text):
     return self.COLOR_BOLD + text + self.COLOR_RESET
     return self.COLOR_BOLD + text + self.COLOR_RESET