Bläddra i källkod

Ignore TBR and don't enforce OWNERS on commit

Change-Id: Ic18cbdcbef99fcfc563a37df1e1727f1426233b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2685631
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Edward Lesmes 4 år sedan
förälder
incheckning
8404644cfd
1 ändrade filer med 7 tillägg och 4 borttagningar
  1. 7 4
      PRESUBMIT.py

+ 7 - 4
PRESUBMIT.py

@@ -65,9 +65,6 @@ def CommonChecks(input_api, output_api, tests_to_skip_list, run_on_python3):
   input_api.SetTimeout(TEST_TIMEOUT_S)
   input_api.SetTimeout(TEST_TIMEOUT_S)
 
 
   results = []
   results = []
-  results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
-  results.extend(input_api.canned_checks.CheckOwnersFormat(
-      input_api, output_api))
   results.extend(input_api.canned_checks.CheckJsonParses(
   results.extend(input_api.canned_checks.CheckJsonParses(
       input_api, output_api))
       input_api, output_api))
 
 
@@ -136,9 +133,15 @@ def CheckChangeOnUpload(input_api, output_api):
       r'^cipd_bootstrap_test\.py$',
       r'^cipd_bootstrap_test\.py$',
       r'^gclient_smoketest\.py$',
       r'^gclient_smoketest\.py$',
   ]
   ]
+  results = []
+  results.extend(input_api.canned_checks.CheckOwners(
+      input_api, output_api, allow_tbr=False))
+  results.extend(input_api.canned_checks.CheckOwnersFormat(
+      input_api, output_api))
   # TODO(ehmaldonado): Run Python 3 tests on upload once Python 3 is
   # TODO(ehmaldonado): Run Python 3 tests on upload once Python 3 is
   # bootstrapped on Linux and Mac.
   # bootstrapped on Linux and Mac.
-  return CommonChecks(input_api, output_api, tests_to_skip_list, False)
+  results.extend(CommonChecks(input_api, output_api, tests_to_skip_list, False))
+  return results
 
 
 
 
 def CheckChangeOnCommit(input_api, output_api):
 def CheckChangeOnCommit(input_api, output_api):