Forráskód Böngészése

gerrit_util: Fix checking if code-owners enabled on repo.

Change-Id: I5f518c22be4c5496f91202015c9caf18d0fa1be9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2778638
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Edward Lesmes 4 éve
szülő
commit
743e98ce87
2 módosított fájl, 14 hozzáadás és 1 törlés
  1. 1 1
      gerrit_util.py
  2. 13 0
      tests/gerrit_util_test.py

+ 1 - 1
gerrit_util.py

@@ -783,7 +783,7 @@ def IsCodeOwnersEnabledOnRepo(host, repo):
   repo = PercentEncodeForGitRef(repo)
   path = '/projects/%s/code_owners.project_config' % repo
   config = ReadHttpJsonResponse(CreateHttpConn(host, path))
-  return config['status'].get('disabled', False)
+  return not config['status'].get('disabled', False)
 
 
 def GetOwnersForFile(host, project, branch, path, limit=100,

+ 13 - 0
tests/gerrit_util_test.py

@@ -481,6 +481,19 @@ class GerritUtilTest(unittest.TestCase):
         ],
         mockQueryChanges.mock_calls)
 
+  @mock.patch('gerrit_util.CreateHttpConn')
+  @mock.patch('gerrit_util.ReadHttpJsonResponse')
+  def testIsCodeOwnersEnabledOnRepo_Disabled(
+      self, mockJsonResponse, mockCreateHttpConn):
+    mockJsonResponse.return_value = {'status': {'disabled': True}}
+    self.assertFalse(gerrit_util.IsCodeOwnersEnabledOnRepo('host', 'repo'))
+
+  @mock.patch('gerrit_util.CreateHttpConn')
+  @mock.patch('gerrit_util.ReadHttpJsonResponse')
+  def testIsCodeOwnersEnabledOnRepo_Enabled(
+      self, mockJsonResponse, mockCreateHttpConn):
+    mockJsonResponse.return_value = {'status': {}}
+    self.assertTrue(gerrit_util.IsCodeOwnersEnabledOnRepo('host', 'repo'))
 
 if __name__ == '__main__':
   unittest.main()