Ver código fonte

Remove agable from depot_tools OWNERS and TODOs

Change-Id: I0667af4562208a111ab3673f3fca6aab655f5f26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2218962
Auto-Submit: Aaron Gable <agable@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>
Aaron Gable 5 anos atrás
pai
commit
6e7ddb698b
6 arquivos alterados com 4 adições e 12 exclusões
  1. 0 1
      OWNERS
  2. 0 5
      gclient.py
  3. 0 1
      gclient_utils.py
  4. 1 1
      git_cl.py
  5. 0 1
      presubmit_canned_checks.py
  6. 3 3
      presubmit_support.py

+ 0 - 1
OWNERS

@@ -1,6 +1,5 @@
 set noparent
 
-agable@chromium.org
 apolito@google.com
 dpranke@chromium.org
 ehmaldonado@chromium.org

+ 0 - 5
gclient.py

@@ -2698,11 +2698,6 @@ def CMDsync(parser, args):
   parser.add_option('--lock_timeout', type='int', default=5000,
                     help='GIT ONLY - Deadline (in seconds) to wait for git '
                          'cache lock to become available. Default is %default.')
-  # TODO(agable): Remove these when the oldest CrOS release milestone is M56.
-  parser.add_option('-t', '--transitive', action='store_true',
-                    help='DEPRECATED: This is a no-op.')
-  parser.add_option('-m', '--manually_grab_svn_rev', action='store_true',
-                    help='DEPRECATED: This is a no-op.')
   parser.add_option('--no-rebase-patch-ref', action='store_false',
                     dest='rebase_patch_ref', default=True,
                     help='Bypass rebase of the patch ref after checkout.')

+ 0 - 1
gclient_utils.py

@@ -425,7 +425,6 @@ class Annotated(Wrapper):
     # Continue lockless.
     obj[0] += out
     while True:
-      # TODO(agable): find both of these with a single pass.
       cr_loc = obj[0].find(b'\r')
       lf_loc = obj[0].find(b'\n')
       if cr_loc == lf_loc == -1:

+ 1 - 1
git_cl.py

@@ -2300,7 +2300,7 @@ class Changelist(object):
 
     if self.GetIssue() and (reviewers or cc):
       # GetIssue() is not set in case of non-squash uploads according to tests.
-      # TODO(agable): non-squash uploads in git cl should be removed.
+      # TODO(crbug.com/751901): non-squash uploads in git cl should be removed.
       gerrit_util.AddReviewers(
           self._GetGerritHost(),
           self._GerritChangeIdentifier(),

+ 0 - 1
presubmit_canned_checks.py

@@ -1612,7 +1612,6 @@ def CheckLucicfgGenOutput(input_api, output_api, entry_script):
         output_api.PresubmitError)
   ]
 
-# TODO(agable): Add this to PanProjectChecks.
 def CheckJsonParses(input_api, output_api):
   """Verifies that all JSON files at least parse as valid JSON."""
   import json

+ 3 - 3
presubmit_support.py

@@ -1119,12 +1119,12 @@ class Change(object):
   def TBRsFromDescription(self):
     """Returns all TBR reviewers listed in the commit description."""
     tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
-    # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically
-    # determined by self-CR+1s.
+    # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
+    # programmatically determined by self-CR+1s.
     footers = self.GitFootersFromDescription().get('Tbr', [])
     return sorted(set(tags + footers))
 
-  # TODO(agable): Delete these once we're sure they're unused.
+  # TODO(crbug.com/753425): Delete these once we're sure they're unused.
   @property
   def BUG(self):
     return ','.join(self.BugsFromDescription())