PrintfFormatString.cpp 19 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642
  1. //== PrintfFormatString.cpp - Analysis of printf format strings --*- C++ -*-==//
  2. //
  3. // The LLVM Compiler Infrastructure
  4. //
  5. // This file is distributed under the University of Illinois Open Source
  6. // License. See LICENSE.TXT for details.
  7. //
  8. //===----------------------------------------------------------------------===//
  9. //
  10. // Handling of format string in printf and friends. The structure of format
  11. // strings for fprintf() are described in C99 7.19.6.1.
  12. //
  13. //===----------------------------------------------------------------------===//
  14. #include "clang/Analysis/Analyses/FormatString.h"
  15. #include "FormatStringParsing.h"
  16. using clang::analyze_format_string::ArgTypeResult;
  17. using clang::analyze_format_string::FormatStringHandler;
  18. using clang::analyze_format_string::LengthModifier;
  19. using clang::analyze_format_string::OptionalAmount;
  20. using clang::analyze_format_string::ConversionSpecifier;
  21. using clang::analyze_printf::PrintfSpecifier;
  22. using namespace clang;
  23. typedef clang::analyze_format_string::SpecifierResult<PrintfSpecifier>
  24. PrintfSpecifierResult;
  25. //===----------------------------------------------------------------------===//
  26. // Methods for parsing format strings.
  27. //===----------------------------------------------------------------------===//
  28. using analyze_format_string::ParseNonPositionAmount;
  29. static bool ParsePrecision(FormatStringHandler &H, PrintfSpecifier &FS,
  30. const char *Start, const char *&Beg, const char *E,
  31. unsigned *argIndex) {
  32. if (argIndex) {
  33. FS.setPrecision(ParseNonPositionAmount(Beg, E, *argIndex));
  34. } else {
  35. const OptionalAmount Amt = ParsePositionAmount(H, Start, Beg, E,
  36. analyze_format_string::PrecisionPos);
  37. if (Amt.isInvalid())
  38. return true;
  39. FS.setPrecision(Amt);
  40. }
  41. return false;
  42. }
  43. static PrintfSpecifierResult ParsePrintfSpecifier(FormatStringHandler &H,
  44. const char *&Beg,
  45. const char *E,
  46. unsigned &argIndex) {
  47. using namespace clang::analyze_format_string;
  48. using namespace clang::analyze_printf;
  49. const char *I = Beg;
  50. const char *Start = 0;
  51. UpdateOnReturn <const char*> UpdateBeg(Beg, I);
  52. // Look for a '%' character that indicates the start of a format specifier.
  53. for ( ; I != E ; ++I) {
  54. char c = *I;
  55. if (c == '\0') {
  56. // Detect spurious null characters, which are likely errors.
  57. H.HandleNullChar(I);
  58. return true;
  59. }
  60. if (c == '%') {
  61. Start = I++; // Record the start of the format specifier.
  62. break;
  63. }
  64. }
  65. // No format specifier found?
  66. if (!Start)
  67. return false;
  68. if (I == E) {
  69. // No more characters left?
  70. H.HandleIncompleteSpecifier(Start, E - Start);
  71. return true;
  72. }
  73. PrintfSpecifier FS;
  74. if (ParseArgPosition(H, FS, Start, I, E))
  75. return true;
  76. if (I == E) {
  77. // No more characters left?
  78. H.HandleIncompleteSpecifier(Start, E - Start);
  79. return true;
  80. }
  81. // Look for flags (if any).
  82. bool hasMore = true;
  83. for ( ; I != E; ++I) {
  84. switch (*I) {
  85. default: hasMore = false; break;
  86. case '\'':
  87. // FIXME: POSIX specific. Always accept?
  88. FS.setHasThousandsGrouping(I);
  89. break;
  90. case '-': FS.setIsLeftJustified(I); break;
  91. case '+': FS.setHasPlusPrefix(I); break;
  92. case ' ': FS.setHasSpacePrefix(I); break;
  93. case '#': FS.setHasAlternativeForm(I); break;
  94. case '0': FS.setHasLeadingZeros(I); break;
  95. }
  96. if (!hasMore)
  97. break;
  98. }
  99. if (I == E) {
  100. // No more characters left?
  101. H.HandleIncompleteSpecifier(Start, E - Start);
  102. return true;
  103. }
  104. // Look for the field width (if any).
  105. if (ParseFieldWidth(H, FS, Start, I, E,
  106. FS.usesPositionalArg() ? 0 : &argIndex))
  107. return true;
  108. if (I == E) {
  109. // No more characters left?
  110. H.HandleIncompleteSpecifier(Start, E - Start);
  111. return true;
  112. }
  113. // Look for the precision (if any).
  114. if (*I == '.') {
  115. ++I;
  116. if (I == E) {
  117. H.HandleIncompleteSpecifier(Start, E - Start);
  118. return true;
  119. }
  120. if (ParsePrecision(H, FS, Start, I, E,
  121. FS.usesPositionalArg() ? 0 : &argIndex))
  122. return true;
  123. if (I == E) {
  124. // No more characters left?
  125. H.HandleIncompleteSpecifier(Start, E - Start);
  126. return true;
  127. }
  128. }
  129. // Look for the length modifier.
  130. if (ParseLengthModifier(FS, I, E) && I == E) {
  131. // No more characters left?
  132. H.HandleIncompleteSpecifier(Start, E - Start);
  133. return true;
  134. }
  135. if (*I == '\0') {
  136. // Detect spurious null characters, which are likely errors.
  137. H.HandleNullChar(I);
  138. return true;
  139. }
  140. // Finally, look for the conversion specifier.
  141. const char *conversionPosition = I++;
  142. ConversionSpecifier::Kind k = ConversionSpecifier::InvalidSpecifier;
  143. switch (*conversionPosition) {
  144. default:
  145. break;
  146. // C99: 7.19.6.1 (section 8).
  147. case '%': k = ConversionSpecifier::PercentArg; break;
  148. case 'A': k = ConversionSpecifier::AArg; break;
  149. case 'E': k = ConversionSpecifier::EArg; break;
  150. case 'F': k = ConversionSpecifier::FArg; break;
  151. case 'G': k = ConversionSpecifier::GArg; break;
  152. case 'X': k = ConversionSpecifier::XArg; break;
  153. case 'a': k = ConversionSpecifier::aArg; break;
  154. case 'c': k = ConversionSpecifier::cArg; break;
  155. case 'd': k = ConversionSpecifier::dArg; break;
  156. case 'e': k = ConversionSpecifier::eArg; break;
  157. case 'f': k = ConversionSpecifier::fArg; break;
  158. case 'g': k = ConversionSpecifier::gArg; break;
  159. case 'i': k = ConversionSpecifier::iArg; break;
  160. case 'n': k = ConversionSpecifier::nArg; break;
  161. case 'o': k = ConversionSpecifier::oArg; break;
  162. case 'p': k = ConversionSpecifier::pArg; break;
  163. case 's': k = ConversionSpecifier::sArg; break;
  164. case 'u': k = ConversionSpecifier::uArg; break;
  165. case 'x': k = ConversionSpecifier::xArg; break;
  166. // POSIX specific.
  167. case 'C': k = ConversionSpecifier::CArg; break;
  168. case 'S': k = ConversionSpecifier::SArg; break;
  169. // Objective-C.
  170. case '@': k = ConversionSpecifier::ObjCObjArg; break;
  171. // Glibc specific.
  172. case 'm': k = ConversionSpecifier::PrintErrno; break;
  173. }
  174. PrintfConversionSpecifier CS(conversionPosition, k);
  175. FS.setConversionSpecifier(CS);
  176. if (CS.consumesDataArgument() && !FS.usesPositionalArg())
  177. FS.setArgIndex(argIndex++);
  178. if (k == ConversionSpecifier::InvalidSpecifier) {
  179. // Assume the conversion takes one argument.
  180. return !H.HandleInvalidPrintfConversionSpecifier(FS, Start, I - Start);
  181. }
  182. return PrintfSpecifierResult(Start, FS);
  183. }
  184. bool clang::analyze_format_string::ParsePrintfString(FormatStringHandler &H,
  185. const char *I,
  186. const char *E) {
  187. unsigned argIndex = 0;
  188. // Keep looking for a format specifier until we have exhausted the string.
  189. while (I != E) {
  190. const PrintfSpecifierResult &FSR = ParsePrintfSpecifier(H, I, E, argIndex);
  191. // Did a fail-stop error of any kind occur when parsing the specifier?
  192. // If so, don't do any more processing.
  193. if (FSR.shouldStop())
  194. return true;;
  195. // Did we exhaust the string or encounter an error that
  196. // we can recover from?
  197. if (!FSR.hasValue())
  198. continue;
  199. // We have a format specifier. Pass it to the callback.
  200. if (!H.HandlePrintfSpecifier(FSR.getValue(), FSR.getStart(),
  201. I - FSR.getStart()))
  202. return true;
  203. }
  204. assert(I == E && "Format string not exhausted");
  205. return false;
  206. }
  207. //===----------------------------------------------------------------------===//
  208. // Methods on PrintfSpecifier.
  209. //===----------------------------------------------------------------------===//
  210. ArgTypeResult PrintfSpecifier::getArgType(ASTContext &Ctx) const {
  211. const PrintfConversionSpecifier &CS = getConversionSpecifier();
  212. if (!CS.consumesDataArgument())
  213. return ArgTypeResult::Invalid();
  214. if (CS.getKind() == ConversionSpecifier::cArg)
  215. switch (LM.getKind()) {
  216. case LengthModifier::None: return Ctx.IntTy;
  217. case LengthModifier::AsLong:
  218. return ArgTypeResult(ArgTypeResult::WIntTy, "wint_t");
  219. default:
  220. return ArgTypeResult::Invalid();
  221. }
  222. if (CS.isIntArg())
  223. switch (LM.getKind()) {
  224. case LengthModifier::AsLongDouble:
  225. return ArgTypeResult::Invalid();
  226. case LengthModifier::None: return Ctx.IntTy;
  227. case LengthModifier::AsChar: return ArgTypeResult::AnyCharTy;
  228. case LengthModifier::AsShort: return Ctx.ShortTy;
  229. case LengthModifier::AsLong: return Ctx.LongTy;
  230. case LengthModifier::AsLongLong: return Ctx.LongLongTy;
  231. case LengthModifier::AsIntMax:
  232. return ArgTypeResult(Ctx.getIntMaxType(), "intmax_t");
  233. case LengthModifier::AsSizeT:
  234. // FIXME: How to get the corresponding signed version of size_t?
  235. return ArgTypeResult();
  236. case LengthModifier::AsPtrDiff:
  237. return ArgTypeResult(Ctx.getPointerDiffType(), "ptrdiff_t");
  238. }
  239. if (CS.isUIntArg())
  240. switch (LM.getKind()) {
  241. case LengthModifier::AsLongDouble:
  242. return ArgTypeResult::Invalid();
  243. case LengthModifier::None: return Ctx.UnsignedIntTy;
  244. case LengthModifier::AsChar: return Ctx.UnsignedCharTy;
  245. case LengthModifier::AsShort: return Ctx.UnsignedShortTy;
  246. case LengthModifier::AsLong: return Ctx.UnsignedLongTy;
  247. case LengthModifier::AsLongLong: return Ctx.UnsignedLongLongTy;
  248. case LengthModifier::AsIntMax:
  249. return ArgTypeResult(Ctx.getUIntMaxType(), "uintmax_t");
  250. case LengthModifier::AsSizeT:
  251. return ArgTypeResult(Ctx.getSizeType(), "size_t");
  252. case LengthModifier::AsPtrDiff:
  253. // FIXME: How to get the corresponding unsigned
  254. // version of ptrdiff_t?
  255. return ArgTypeResult();
  256. }
  257. if (CS.isDoubleArg()) {
  258. if (LM.getKind() == LengthModifier::AsLongDouble)
  259. return Ctx.LongDoubleTy;
  260. return Ctx.DoubleTy;
  261. }
  262. switch (CS.getKind()) {
  263. case ConversionSpecifier::sArg: {
  264. if (LM.getKind() == LengthModifier::AsWideChar)
  265. return ArgTypeResult(ArgTypeResult::WCStrTy, "wchar_t *");
  266. return ArgTypeResult::CStrTy;
  267. }
  268. case ConversionSpecifier::SArg:
  269. // FIXME: This appears to be Mac OS X specific.
  270. return ArgTypeResult(ArgTypeResult::WCStrTy, "wchar_t *");
  271. case ConversionSpecifier::CArg:
  272. return ArgTypeResult(Ctx.WCharTy, "wchar_t");
  273. case ConversionSpecifier::pArg:
  274. return ArgTypeResult::CPointerTy;
  275. default:
  276. break;
  277. }
  278. // FIXME: Handle other cases.
  279. return ArgTypeResult();
  280. }
  281. bool PrintfSpecifier::fixType(QualType QT, const LangOptions &LangOpt) {
  282. // Handle strings first (char *, wchar_t *)
  283. if (QT->isPointerType() && (QT->getPointeeType()->isAnyCharacterType())) {
  284. CS.setKind(ConversionSpecifier::sArg);
  285. // Disable irrelevant flags
  286. HasAlternativeForm = 0;
  287. HasLeadingZeroes = 0;
  288. // Set the long length modifier for wide characters
  289. if (QT->getPointeeType()->isWideCharType())
  290. LM.setKind(LengthModifier::AsWideChar);
  291. else
  292. LM.setKind(LengthModifier::None);
  293. return true;
  294. }
  295. // We can only work with builtin types.
  296. const BuiltinType *BT = QT->getAs<BuiltinType>();
  297. if (!BT)
  298. return false;
  299. // Set length modifier
  300. switch (BT->getKind()) {
  301. case BuiltinType::Bool:
  302. case BuiltinType::WChar_U:
  303. case BuiltinType::WChar_S:
  304. case BuiltinType::Char16:
  305. case BuiltinType::Char32:
  306. case BuiltinType::UInt128:
  307. case BuiltinType::Int128:
  308. case BuiltinType::Half:
  309. // Various types which are non-trivial to correct.
  310. return false;
  311. #define SIGNED_TYPE(Id, SingletonId)
  312. #define UNSIGNED_TYPE(Id, SingletonId)
  313. #define FLOATING_TYPE(Id, SingletonId)
  314. #define BUILTIN_TYPE(Id, SingletonId) \
  315. case BuiltinType::Id:
  316. #include "clang/AST/BuiltinTypes.def"
  317. // Misc other stuff which doesn't make sense here.
  318. return false;
  319. case BuiltinType::UInt:
  320. case BuiltinType::Int:
  321. case BuiltinType::Float:
  322. case BuiltinType::Double:
  323. LM.setKind(LengthModifier::None);
  324. break;
  325. case BuiltinType::Char_U:
  326. case BuiltinType::UChar:
  327. case BuiltinType::Char_S:
  328. case BuiltinType::SChar:
  329. LM.setKind(LengthModifier::AsChar);
  330. break;
  331. case BuiltinType::Short:
  332. case BuiltinType::UShort:
  333. LM.setKind(LengthModifier::AsShort);
  334. break;
  335. case BuiltinType::Long:
  336. case BuiltinType::ULong:
  337. LM.setKind(LengthModifier::AsLong);
  338. break;
  339. case BuiltinType::LongLong:
  340. case BuiltinType::ULongLong:
  341. LM.setKind(LengthModifier::AsLongLong);
  342. break;
  343. case BuiltinType::LongDouble:
  344. LM.setKind(LengthModifier::AsLongDouble);
  345. break;
  346. }
  347. // Handle size_t, ptrdiff_t, etc. that have dedicated length modifiers in C99.
  348. if (isa<TypedefType>(QT) && (LangOpt.C99 || LangOpt.CPlusPlus0x)) {
  349. const IdentifierInfo *Identifier = QT.getBaseTypeIdentifier();
  350. if (Identifier->getName() == "size_t") {
  351. LM.setKind(LengthModifier::AsSizeT);
  352. } else if (Identifier->getName() == "ssize_t") {
  353. // Not C99, but common in Unix.
  354. LM.setKind(LengthModifier::AsSizeT);
  355. } else if (Identifier->getName() == "intmax_t") {
  356. LM.setKind(LengthModifier::AsIntMax);
  357. } else if (Identifier->getName() == "uintmax_t") {
  358. LM.setKind(LengthModifier::AsIntMax);
  359. } else if (Identifier->getName() == "ptrdiff_t") {
  360. LM.setKind(LengthModifier::AsPtrDiff);
  361. }
  362. }
  363. // Set conversion specifier and disable any flags which do not apply to it.
  364. // Let typedefs to char fall through to int, as %c is silly for uint8_t.
  365. if (isa<TypedefType>(QT) && QT->isAnyCharacterType()) {
  366. CS.setKind(ConversionSpecifier::cArg);
  367. LM.setKind(LengthModifier::None);
  368. Precision.setHowSpecified(OptionalAmount::NotSpecified);
  369. HasAlternativeForm = 0;
  370. HasLeadingZeroes = 0;
  371. HasPlusPrefix = 0;
  372. }
  373. // Test for Floating type first as LongDouble can pass isUnsignedIntegerType
  374. else if (QT->isRealFloatingType()) {
  375. CS.setKind(ConversionSpecifier::fArg);
  376. }
  377. else if (QT->isSignedIntegerType()) {
  378. CS.setKind(ConversionSpecifier::dArg);
  379. HasAlternativeForm = 0;
  380. }
  381. else if (QT->isUnsignedIntegerType()) {
  382. // Preserve the original formatting, e.g. 'X', 'o'.
  383. if (!cast<PrintfConversionSpecifier>(CS).isUIntArg())
  384. CS.setKind(ConversionSpecifier::uArg);
  385. HasAlternativeForm = 0;
  386. HasPlusPrefix = 0;
  387. } else {
  388. llvm_unreachable("Unexpected type");
  389. }
  390. return true;
  391. }
  392. void PrintfSpecifier::toString(raw_ostream &os) const {
  393. // Whilst some features have no defined order, we are using the order
  394. // appearing in the C99 standard (ISO/IEC 9899:1999 (E) 7.19.6.1)
  395. os << "%";
  396. // Positional args
  397. if (usesPositionalArg()) {
  398. os << getPositionalArgIndex() << "$";
  399. }
  400. // Conversion flags
  401. if (IsLeftJustified) os << "-";
  402. if (HasPlusPrefix) os << "+";
  403. if (HasSpacePrefix) os << " ";
  404. if (HasAlternativeForm) os << "#";
  405. if (HasLeadingZeroes) os << "0";
  406. // Minimum field width
  407. FieldWidth.toString(os);
  408. // Precision
  409. Precision.toString(os);
  410. // Length modifier
  411. os << LM.toString();
  412. // Conversion specifier
  413. os << CS.toString();
  414. }
  415. bool PrintfSpecifier::hasValidPlusPrefix() const {
  416. if (!HasPlusPrefix)
  417. return true;
  418. // The plus prefix only makes sense for signed conversions
  419. switch (CS.getKind()) {
  420. case ConversionSpecifier::dArg:
  421. case ConversionSpecifier::iArg:
  422. case ConversionSpecifier::fArg:
  423. case ConversionSpecifier::FArg:
  424. case ConversionSpecifier::eArg:
  425. case ConversionSpecifier::EArg:
  426. case ConversionSpecifier::gArg:
  427. case ConversionSpecifier::GArg:
  428. case ConversionSpecifier::aArg:
  429. case ConversionSpecifier::AArg:
  430. return true;
  431. default:
  432. return false;
  433. }
  434. }
  435. bool PrintfSpecifier::hasValidAlternativeForm() const {
  436. if (!HasAlternativeForm)
  437. return true;
  438. // Alternate form flag only valid with the oxXaAeEfFgG conversions
  439. switch (CS.getKind()) {
  440. case ConversionSpecifier::oArg:
  441. case ConversionSpecifier::xArg:
  442. case ConversionSpecifier::XArg:
  443. case ConversionSpecifier::aArg:
  444. case ConversionSpecifier::AArg:
  445. case ConversionSpecifier::eArg:
  446. case ConversionSpecifier::EArg:
  447. case ConversionSpecifier::fArg:
  448. case ConversionSpecifier::FArg:
  449. case ConversionSpecifier::gArg:
  450. case ConversionSpecifier::GArg:
  451. return true;
  452. default:
  453. return false;
  454. }
  455. }
  456. bool PrintfSpecifier::hasValidLeadingZeros() const {
  457. if (!HasLeadingZeroes)
  458. return true;
  459. // Leading zeroes flag only valid with the diouxXaAeEfFgG conversions
  460. switch (CS.getKind()) {
  461. case ConversionSpecifier::dArg:
  462. case ConversionSpecifier::iArg:
  463. case ConversionSpecifier::oArg:
  464. case ConversionSpecifier::uArg:
  465. case ConversionSpecifier::xArg:
  466. case ConversionSpecifier::XArg:
  467. case ConversionSpecifier::aArg:
  468. case ConversionSpecifier::AArg:
  469. case ConversionSpecifier::eArg:
  470. case ConversionSpecifier::EArg:
  471. case ConversionSpecifier::fArg:
  472. case ConversionSpecifier::FArg:
  473. case ConversionSpecifier::gArg:
  474. case ConversionSpecifier::GArg:
  475. return true;
  476. default:
  477. return false;
  478. }
  479. }
  480. bool PrintfSpecifier::hasValidSpacePrefix() const {
  481. if (!HasSpacePrefix)
  482. return true;
  483. // The space prefix only makes sense for signed conversions
  484. switch (CS.getKind()) {
  485. case ConversionSpecifier::dArg:
  486. case ConversionSpecifier::iArg:
  487. case ConversionSpecifier::fArg:
  488. case ConversionSpecifier::FArg:
  489. case ConversionSpecifier::eArg:
  490. case ConversionSpecifier::EArg:
  491. case ConversionSpecifier::gArg:
  492. case ConversionSpecifier::GArg:
  493. case ConversionSpecifier::aArg:
  494. case ConversionSpecifier::AArg:
  495. return true;
  496. default:
  497. return false;
  498. }
  499. }
  500. bool PrintfSpecifier::hasValidLeftJustified() const {
  501. if (!IsLeftJustified)
  502. return true;
  503. // The left justified flag is valid for all conversions except n
  504. switch (CS.getKind()) {
  505. case ConversionSpecifier::nArg:
  506. return false;
  507. default:
  508. return true;
  509. }
  510. }
  511. bool PrintfSpecifier::hasValidThousandsGroupingPrefix() const {
  512. if (!HasThousandsGrouping)
  513. return true;
  514. switch (CS.getKind()) {
  515. case ConversionSpecifier::dArg:
  516. case ConversionSpecifier::iArg:
  517. case ConversionSpecifier::uArg:
  518. case ConversionSpecifier::fArg:
  519. case ConversionSpecifier::FArg:
  520. case ConversionSpecifier::gArg:
  521. case ConversionSpecifier::GArg:
  522. return true;
  523. default:
  524. return false;
  525. }
  526. }
  527. bool PrintfSpecifier::hasValidPrecision() const {
  528. if (Precision.getHowSpecified() == OptionalAmount::NotSpecified)
  529. return true;
  530. // Precision is only valid with the diouxXaAeEfFgGs conversions
  531. switch (CS.getKind()) {
  532. case ConversionSpecifier::dArg:
  533. case ConversionSpecifier::iArg:
  534. case ConversionSpecifier::oArg:
  535. case ConversionSpecifier::uArg:
  536. case ConversionSpecifier::xArg:
  537. case ConversionSpecifier::XArg:
  538. case ConversionSpecifier::aArg:
  539. case ConversionSpecifier::AArg:
  540. case ConversionSpecifier::eArg:
  541. case ConversionSpecifier::EArg:
  542. case ConversionSpecifier::fArg:
  543. case ConversionSpecifier::FArg:
  544. case ConversionSpecifier::gArg:
  545. case ConversionSpecifier::GArg:
  546. case ConversionSpecifier::sArg:
  547. return true;
  548. default:
  549. return false;
  550. }
  551. }
  552. bool PrintfSpecifier::hasValidFieldWidth() const {
  553. if (FieldWidth.getHowSpecified() == OptionalAmount::NotSpecified)
  554. return true;
  555. // The field width is valid for all conversions except n
  556. switch (CS.getKind()) {
  557. case ConversionSpecifier::nArg:
  558. return false;
  559. default:
  560. return true;
  561. }
  562. }