FormatTestJava.cpp 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505
  1. //===- unittest/Format/FormatTestJava.cpp - Formatting tests for Java -----===//
  2. //
  3. // The LLVM Compiler Infrastructure
  4. //
  5. // This file is distributed under the University of Illinois Open Source
  6. // License. See LICENSE.TXT for details.
  7. //
  8. //===----------------------------------------------------------------------===//
  9. #include "FormatTestUtils.h"
  10. #include "clang/Format/Format.h"
  11. #include "llvm/Support/Debug.h"
  12. #include "gtest/gtest.h"
  13. #define DEBUG_TYPE "format-test"
  14. namespace clang {
  15. namespace format {
  16. class FormatTestJava : public ::testing::Test {
  17. protected:
  18. static std::string format(llvm::StringRef Code, unsigned Offset,
  19. unsigned Length, const FormatStyle &Style) {
  20. DEBUG(llvm::errs() << "---\n");
  21. DEBUG(llvm::errs() << Code << "\n\n");
  22. std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length));
  23. tooling::Replacements Replaces = reformat(Style, Code, Ranges);
  24. std::string Result = applyAllReplacements(Code, Replaces);
  25. EXPECT_NE("", Result);
  26. DEBUG(llvm::errs() << "\n" << Result << "\n\n");
  27. return Result;
  28. }
  29. static std::string format(
  30. llvm::StringRef Code,
  31. const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_Java)) {
  32. return format(Code, 0, Code.size(), Style);
  33. }
  34. static FormatStyle getStyleWithColumns(unsigned ColumnLimit) {
  35. FormatStyle Style = getGoogleStyle(FormatStyle::LK_Java);
  36. Style.ColumnLimit = ColumnLimit;
  37. return Style;
  38. }
  39. static void verifyFormat(
  40. llvm::StringRef Code,
  41. const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_Java)) {
  42. EXPECT_EQ(Code.str(), format(test::messUp(Code), Style));
  43. }
  44. };
  45. TEST_F(FormatTestJava, NoAlternativeOperatorNames) {
  46. verifyFormat("someObject.and();");
  47. }
  48. TEST_F(FormatTestJava, UnderstandsCasts) {
  49. verifyFormat("a[b >> 1] = (byte) (c() << 4);");
  50. }
  51. TEST_F(FormatTestJava, FormatsInstanceOfLikeOperators) {
  52. FormatStyle Style = getStyleWithColumns(50);
  53. verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
  54. " instanceof bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;",
  55. Style);
  56. Style.BreakBeforeBinaryOperators = FormatStyle::BOS_None;
  57. verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaa instanceof\n"
  58. " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;",
  59. Style);
  60. }
  61. TEST_F(FormatTestJava, Chromium) {
  62. verifyFormat("class SomeClass {\n"
  63. " void f() {}\n"
  64. " int g() {\n"
  65. " return 0;\n"
  66. " }\n"
  67. " void h() {\n"
  68. " while (true) f();\n"
  69. " for (;;) f();\n"
  70. " if (true) f();\n"
  71. " }\n"
  72. "}",
  73. getChromiumStyle(FormatStyle::LK_Java));
  74. }
  75. TEST_F(FormatTestJava, QualifiedNames) {
  76. verifyFormat("public some.package.Type someFunction( // comment\n"
  77. " int parameter) {}");
  78. }
  79. TEST_F(FormatTestJava, ClassKeyword) {
  80. verifyFormat("SomeClass.class.getName();");
  81. verifyFormat("Class c = SomeClass.class;");
  82. }
  83. TEST_F(FormatTestJava, ClassDeclarations) {
  84. verifyFormat("public class SomeClass {\n"
  85. " private int a;\n"
  86. " private int b;\n"
  87. "}");
  88. verifyFormat("public class A {\n"
  89. " class B {\n"
  90. " int i;\n"
  91. " }\n"
  92. " class C {\n"
  93. " int j;\n"
  94. " }\n"
  95. "}");
  96. verifyFormat("public class A extends B.C {}");
  97. verifyFormat("abstract class SomeClass\n"
  98. " extends SomeOtherClass implements SomeInterface {}",
  99. getStyleWithColumns(60));
  100. verifyFormat("abstract class SomeClass extends SomeOtherClass\n"
  101. " implements SomeInterfaceeeeeeeeeeeee {}",
  102. getStyleWithColumns(60));
  103. verifyFormat("abstract class SomeClass\n"
  104. " extends SomeOtherClass\n"
  105. " implements SomeInterface {}",
  106. getStyleWithColumns(40));
  107. verifyFormat("abstract class SomeClass\n"
  108. " extends SomeOtherClass\n"
  109. " implements SomeInterface,\n"
  110. " AnotherInterface {}",
  111. getStyleWithColumns(40));
  112. verifyFormat("abstract class SomeClass\n"
  113. " implements SomeInterface, AnotherInterface {}",
  114. getStyleWithColumns(60));
  115. verifyFormat("@SomeAnnotation()\n"
  116. "abstract class aaaaaaaaaaaa\n"
  117. " extends bbbbbbbbbbbbbbb implements cccccccccccc {}",
  118. getStyleWithColumns(76));
  119. verifyFormat("@SomeAnnotation()\n"
  120. "abstract class aaaaaaaaa<a>\n"
  121. " extends bbbbbbbbbbbb<b> implements cccccccccccc {}",
  122. getStyleWithColumns(76));
  123. verifyFormat("interface SomeInterface<A> extends Foo, Bar {\n"
  124. " void doStuff(int theStuff);\n"
  125. " void doMoreStuff(int moreStuff);\n"
  126. "}");
  127. verifyFormat("public interface SomeInterface {\n"
  128. " void doStuff(int theStuff);\n"
  129. " void doMoreStuff(int moreStuff);\n"
  130. "}");
  131. verifyFormat("@interface SomeInterface {\n"
  132. " void doStuff(int theStuff);\n"
  133. " void doMoreStuff(int moreStuff);\n"
  134. "}");
  135. verifyFormat("public @interface SomeInterface {\n"
  136. " void doStuff(int theStuff);\n"
  137. " void doMoreStuff(int moreStuff);\n"
  138. "}");
  139. }
  140. TEST_F(FormatTestJava, AnonymousClasses) {
  141. verifyFormat("return new A() {\n"
  142. " public String toString() {\n"
  143. " return \"NotReallyA\";\n"
  144. " }\n"
  145. "};");
  146. verifyFormat("A a = new A() {\n"
  147. " public String toString() {\n"
  148. " return \"NotReallyA\";\n"
  149. " }\n"
  150. "};");
  151. }
  152. TEST_F(FormatTestJava, EnumDeclarations) {
  153. verifyFormat("enum SomeThing { ABC, CDE }");
  154. verifyFormat("enum SomeThing {\n"
  155. " ABC,\n"
  156. " CDE,\n"
  157. "}");
  158. verifyFormat("public class SomeClass {\n"
  159. " enum SomeThing { ABC, CDE }\n"
  160. " void f() {}\n"
  161. "}");
  162. verifyFormat("public class SomeClass implements SomeInterface {\n"
  163. " enum SomeThing { ABC, CDE }\n"
  164. " void f() {}\n"
  165. "}");
  166. verifyFormat("enum SomeThing {\n"
  167. " ABC,\n"
  168. " CDE;\n"
  169. " void f() {}\n"
  170. "}");
  171. verifyFormat("enum SomeThing {\n"
  172. " ABC(1, \"ABC\"),\n"
  173. " CDE(2, \"CDE\");\n"
  174. " Something(int i, String s) {}\n"
  175. "}");
  176. verifyFormat("enum SomeThing {\n"
  177. " ABC(new int[] {1, 2}),\n"
  178. " CDE(new int[] {2, 3});\n"
  179. " Something(int[] i) {}\n"
  180. "}");
  181. verifyFormat("public enum SomeThing {\n"
  182. " ABC {\n"
  183. " public String toString() {\n"
  184. " return \"ABC\";\n"
  185. " }\n"
  186. " },\n"
  187. " CDE {\n"
  188. " @Override\n"
  189. " public String toString() {\n"
  190. " return \"CDE\";\n"
  191. " }\n"
  192. " };\n"
  193. " public void f() {}\n"
  194. "}");
  195. verifyFormat("private enum SomeEnum implements Foo<?, B> {\n"
  196. " ABC {\n"
  197. " @Override\n"
  198. " public String toString() {\n"
  199. " return \"ABC\";\n"
  200. " }\n"
  201. " },\n"
  202. " CDE {\n"
  203. " @Override\n"
  204. " public String toString() {\n"
  205. " return \"CDE\";\n"
  206. " }\n"
  207. " };\n"
  208. "}");
  209. }
  210. TEST_F(FormatTestJava, ArrayInitializers) {
  211. verifyFormat("new int[] {1, 2, 3, 4};");
  212. verifyFormat("new int[] {\n"
  213. " 1, 2, 3, 4,\n"
  214. "};");
  215. FormatStyle Style = getStyleWithColumns(65);
  216. Style.Cpp11BracedListStyle = false;
  217. verifyFormat(
  218. "expected = new int[] { 10, 10, 10, 10, 10, 10, 10, 10, 10, 10,\n"
  219. " 100, 100, 100, 100, 100, 100, 100, 100, 100, 100 };",
  220. Style);
  221. }
  222. TEST_F(FormatTestJava, ThrowsDeclarations) {
  223. verifyFormat("public void doSooooooooooooooooooooooooooomething()\n"
  224. " throws LooooooooooooooooooooooooooooongException {}");
  225. verifyFormat("public void doSooooooooooooooooooooooooooomething()\n"
  226. " throws LoooooooooongException, LooooooooooongException {}");
  227. }
  228. TEST_F(FormatTestJava, Annotations) {
  229. verifyFormat("@Override\n"
  230. "public String toString() {}");
  231. verifyFormat("@Override\n"
  232. "@Nullable\n"
  233. "public String getNameIfPresent() {}");
  234. verifyFormat("@Override // comment\n"
  235. "@Nullable\n"
  236. "public String getNameIfPresent() {}");
  237. verifyFormat("@java.lang.Override // comment\n"
  238. "@Nullable\n"
  239. "public String getNameIfPresent() {}");
  240. verifyFormat("@SuppressWarnings(value = \"unchecked\")\n"
  241. "public void doSomething() {}");
  242. verifyFormat("@SuppressWarnings(value = \"unchecked\")\n"
  243. "@Author(name = \"abc\")\n"
  244. "public void doSomething() {}");
  245. verifyFormat("DoSomething(new A() {\n"
  246. " @Override\n"
  247. " public String toString() {}\n"
  248. "});");
  249. verifyFormat("void SomeFunction(@Nullable String something) {}");
  250. verifyFormat("void SomeFunction(@org.llvm.Nullable String something) {}");
  251. verifyFormat("@Partial @Mock DataLoader loader;");
  252. verifyFormat("@SuppressWarnings(value = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\")\n"
  253. "public static int iiiiiiiiiiiiiiiiiiiiiiii;");
  254. verifyFormat("@SomeAnnotation(\"With some really looooooooooooooong text\")\n"
  255. "private static final long something = 0L;");
  256. verifyFormat("@org.llvm.Qualified(\"With some really looooooooooong text\")\n"
  257. "private static final long something = 0L;");
  258. verifyFormat("@Mock\n"
  259. "DataLoader loooooooooooooooooooooooader =\n"
  260. " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;",
  261. getStyleWithColumns(60));
  262. verifyFormat("@org.llvm.QualifiedMock\n"
  263. "DataLoader loooooooooooooooooooooooader =\n"
  264. " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;",
  265. getStyleWithColumns(60));
  266. verifyFormat("@Test(a)\n"
  267. "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
  268. " aaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa);");
  269. verifyFormat("@SomeAnnotation(\n"
  270. " aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa)\n"
  271. "int i;",
  272. getStyleWithColumns(50));
  273. verifyFormat("@Test\n"
  274. "ReturnType doSomething(\n"
  275. " String aaaaaaaaaaaaa, String bbbbbbbbbbbbbbb) {}",
  276. getStyleWithColumns(60));
  277. verifyFormat("{\n"
  278. " boolean someFunction(\n"
  279. " @Param(aaaaaaaaaaaaaaaa) String aaaaa,\n"
  280. " String bbbbbbbbbbbbbbb) {}\n"
  281. "}",
  282. getStyleWithColumns(60));
  283. }
  284. TEST_F(FormatTestJava, Generics) {
  285. verifyFormat("Iterable<?> a;");
  286. verifyFormat("Iterable<?> a;");
  287. verifyFormat("Iterable<? extends SomeObject> a;");
  288. verifyFormat("A.<B>doSomething();");
  289. verifyFormat("@Override\n"
  290. "public Map<String, ?> getAll() {}");
  291. verifyFormat("public <R> ArrayList<R> get() {}");
  292. verifyFormat("protected <R> ArrayList<R> get() {}");
  293. verifyFormat("private <R> ArrayList<R> get() {}");
  294. verifyFormat("public static <R> ArrayList<R> get() {}");
  295. verifyFormat("public static native <R> ArrayList<R> get();");
  296. verifyFormat("public final <X> Foo foo() {}");
  297. verifyFormat("public abstract <X> Foo foo();");
  298. verifyFormat("<T extends B> T getInstance(Class<T> type);");
  299. verifyFormat("Function<F, ? extends T> function;");
  300. verifyFormat("private Foo<X, Y>[] foos;");
  301. verifyFormat("Foo<X, Y>[] foos = this.foos;");
  302. verifyFormat("return (a instanceof List<?>)\n"
  303. " ? aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n"
  304. " : aaaaaaaaaaaaaaaaaaaaaaa;",
  305. getStyleWithColumns(60));
  306. verifyFormat(
  307. "SomeLoooooooooooooooooooooongType name =\n"
  308. " SomeType.foo(someArgument)\n"
  309. " .<X>method()\n"
  310. " .aaaaaaaaaaaaaaaaaaa()\n"
  311. " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();");
  312. }
  313. TEST_F(FormatTestJava, StringConcatenation) {
  314. verifyFormat("String someString = \"abc\"\n"
  315. " + \"cde\";");
  316. }
  317. TEST_F(FormatTestJava, TryCatchFinally) {
  318. verifyFormat("try {\n"
  319. " Something();\n"
  320. "} catch (SomeException e) {\n"
  321. " HandleException(e);\n"
  322. "}");
  323. verifyFormat("try {\n"
  324. " Something();\n"
  325. "} finally {\n"
  326. " AlwaysDoThis();\n"
  327. "}");
  328. verifyFormat("try {\n"
  329. " Something();\n"
  330. "} catch (SomeException e) {\n"
  331. " HandleException(e);\n"
  332. "} finally {\n"
  333. " AlwaysDoThis();\n"
  334. "}");
  335. verifyFormat("try {\n"
  336. " Something();\n"
  337. "} catch (SomeException | OtherException e) {\n"
  338. " HandleException(e);\n"
  339. "}");
  340. }
  341. TEST_F(FormatTestJava, TryWithResources) {
  342. verifyFormat("try (SomeResource rs = someFunction()) {\n"
  343. " Something();\n"
  344. "}");
  345. verifyFormat("try (SomeResource rs = someFunction()) {\n"
  346. " Something();\n"
  347. "} catch (SomeException e) {\n"
  348. " HandleException(e);\n"
  349. "}");
  350. }
  351. TEST_F(FormatTestJava, SynchronizedKeyword) {
  352. verifyFormat("synchronized (mData) {\n"
  353. " // ...\n"
  354. "}");
  355. }
  356. TEST_F(FormatTestJava, PackageDeclarations) {
  357. verifyFormat("package some.really.loooooooooooooooooooooong.package;",
  358. getStyleWithColumns(50));
  359. }
  360. TEST_F(FormatTestJava, ImportDeclarations) {
  361. verifyFormat("import some.really.loooooooooooooooooooooong.imported.Class;",
  362. getStyleWithColumns(50));
  363. verifyFormat("import static some.really.looooooooooooooooong.imported.Class;",
  364. getStyleWithColumns(50));
  365. }
  366. TEST_F(FormatTestJava, MethodDeclarations) {
  367. verifyFormat("void methodName(Object arg1,\n"
  368. " Object arg2, Object arg3) {}",
  369. getStyleWithColumns(40));
  370. verifyFormat("void methodName(\n"
  371. " Object arg1, Object arg2) {}",
  372. getStyleWithColumns(40));
  373. }
  374. TEST_F(FormatTestJava, CppKeywords) {
  375. verifyFormat("public void union(Type a, Type b);");
  376. verifyFormat("public void struct(Object o);");
  377. verifyFormat("public void delete(Object o);");
  378. }
  379. TEST_F(FormatTestJava, NeverAlignAfterReturn) {
  380. verifyFormat("return aaaaaaaaaaaaaaaaaaa\n"
  381. " && bbbbbbbbbbbbbbbbbbb\n"
  382. " && ccccccccccccccccccc;",
  383. getStyleWithColumns(40));
  384. verifyFormat("return (result == null)\n"
  385. " ? aaaaaaaaaaaaaaaaa\n"
  386. " : bbbbbbbbbbbbbbbbb;",
  387. getStyleWithColumns(40));
  388. verifyFormat("return aaaaaaaaaaaaaaaaaaa()\n"
  389. " .bbbbbbbbbbbbbbbbbbb()\n"
  390. " .ccccccccccccccccccc();",
  391. getStyleWithColumns(40));
  392. verifyFormat("return aaaaaaaaaaaaaaaaaaa()\n"
  393. " .bbbbbbbbbbbbbbbbbbb(\n"
  394. " ccccccccccccccc)\n"
  395. " .ccccccccccccccccccc();",
  396. getStyleWithColumns(40));
  397. }
  398. TEST_F(FormatTestJava, FormatsInnerBlocks) {
  399. verifyFormat("someObject.someFunction(new Runnable() {\n"
  400. " @Override\n"
  401. " public void run() {\n"
  402. " System.out.println(42);\n"
  403. " }\n"
  404. "}, someOtherParameter);");
  405. verifyFormat("someFunction(new Runnable() {\n"
  406. " public void run() {\n"
  407. " System.out.println(42);\n"
  408. " }\n"
  409. "});");
  410. verifyFormat("someObject.someFunction(\n"
  411. " new Runnable() {\n"
  412. " @Override\n"
  413. " public void run() {\n"
  414. " System.out.println(42);\n"
  415. " }\n"
  416. " },\n"
  417. " new Runnable() {\n"
  418. " @Override\n"
  419. " public void run() {\n"
  420. " System.out.println(43);\n"
  421. " }\n"
  422. " },\n"
  423. " someOtherParameter);");
  424. }
  425. TEST_F(FormatTestJava, FormatsLambdas) {
  426. verifyFormat("(aaaaaaaaaa, bbbbbbbbbb) -> aaaaaaaaaa + bbbbbbbbbb;");
  427. verifyFormat("(aaaaaaaaaa, bbbbbbbbbb)\n"
  428. " -> aaaaaaaaaa + bbbbbbbbbb;",
  429. getStyleWithColumns(40));
  430. verifyFormat("Runnable someLambda = () -> DoSomething();");
  431. verifyFormat("Runnable someLambda = () -> {\n"
  432. " DoSomething();\n"
  433. "}");
  434. verifyFormat("Runnable someLambda =\n"
  435. " (int aaaaa) -> DoSomething(aaaaa);",
  436. getStyleWithColumns(40));
  437. }
  438. TEST_F(FormatTestJava, BreaksStringLiterals) {
  439. // FIXME: String literal breaking is currently disabled for Java and JS, as it
  440. // requires strings to be merged using "+" which we don't support.
  441. EXPECT_EQ("\"some text other\";",
  442. format("\"some text other\";", getStyleWithColumns(14)));
  443. }
  444. TEST_F(FormatTestJava, AlignsBlockComments) {
  445. EXPECT_EQ("/*\n"
  446. " * Really multi-line\n"
  447. " * comment.\n"
  448. " */\n"
  449. "void f() {}",
  450. format(" /*\n"
  451. " * Really multi-line\n"
  452. " * comment.\n"
  453. " */\n"
  454. " void f() {}"));
  455. }
  456. } // end namespace tooling
  457. } // end namespace clang