FormatTestJava.cpp 19 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550
  1. //===- unittest/Format/FormatTestJava.cpp - Formatting tests for Java -----===//
  2. //
  3. // The LLVM Compiler Infrastructure
  4. //
  5. // This file is distributed under the University of Illinois Open Source
  6. // License. See LICENSE.TXT for details.
  7. //
  8. //===----------------------------------------------------------------------===//
  9. #include "FormatTestUtils.h"
  10. #include "clang/Format/Format.h"
  11. #include "llvm/Support/Debug.h"
  12. #include "gtest/gtest.h"
  13. #define DEBUG_TYPE "format-test"
  14. namespace clang {
  15. namespace format {
  16. class FormatTestJava : public ::testing::Test {
  17. protected:
  18. static std::string format(llvm::StringRef Code, unsigned Offset,
  19. unsigned Length, const FormatStyle &Style) {
  20. DEBUG(llvm::errs() << "---\n");
  21. DEBUG(llvm::errs() << Code << "\n\n");
  22. std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length));
  23. tooling::Replacements Replaces = reformat(Style, Code, Ranges);
  24. auto Result = applyAllReplacements(Code, Replaces);
  25. EXPECT_TRUE(static_cast<bool>(Result));
  26. DEBUG(llvm::errs() << "\n" << *Result << "\n\n");
  27. return *Result;
  28. }
  29. static std::string
  30. format(llvm::StringRef Code,
  31. const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_Java)) {
  32. return format(Code, 0, Code.size(), Style);
  33. }
  34. static FormatStyle getStyleWithColumns(unsigned ColumnLimit) {
  35. FormatStyle Style = getGoogleStyle(FormatStyle::LK_Java);
  36. Style.ColumnLimit = ColumnLimit;
  37. return Style;
  38. }
  39. static void verifyFormat(
  40. llvm::StringRef Code,
  41. const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_Java)) {
  42. EXPECT_EQ(Code.str(), format(test::messUp(Code), Style));
  43. }
  44. };
  45. TEST_F(FormatTestJava, NoAlternativeOperatorNames) {
  46. verifyFormat("someObject.and();");
  47. }
  48. TEST_F(FormatTestJava, UnderstandsCasts) {
  49. verifyFormat("a[b >> 1] = (byte) (c() << 4);");
  50. }
  51. TEST_F(FormatTestJava, FormatsInstanceOfLikeOperators) {
  52. FormatStyle Style = getStyleWithColumns(50);
  53. verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
  54. " instanceof bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;",
  55. Style);
  56. Style.BreakBeforeBinaryOperators = FormatStyle::BOS_None;
  57. verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaa instanceof\n"
  58. " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;",
  59. Style);
  60. verifyFormat("return aaaaaaaaaaaaaaaaaaa instanceof bbbbbbbbbbbbbbbbbbbbbbb\n"
  61. " && ccccccccccccccccccc instanceof dddddddddddddddddddddd;");
  62. }
  63. TEST_F(FormatTestJava, Chromium) {
  64. verifyFormat("class SomeClass {\n"
  65. " void f() {}\n"
  66. " int g() {\n"
  67. " return 0;\n"
  68. " }\n"
  69. " void h() {\n"
  70. " while (true) f();\n"
  71. " for (;;) f();\n"
  72. " if (true) f();\n"
  73. " }\n"
  74. "}",
  75. getChromiumStyle(FormatStyle::LK_Java));
  76. }
  77. TEST_F(FormatTestJava, QualifiedNames) {
  78. verifyFormat("public some.package.Type someFunction( // comment\n"
  79. " int parameter) {}");
  80. }
  81. TEST_F(FormatTestJava, ClassKeyword) {
  82. verifyFormat("SomeClass.class.getName();");
  83. verifyFormat("Class c = SomeClass.class;");
  84. }
  85. TEST_F(FormatTestJava, ClassDeclarations) {
  86. verifyFormat("public class SomeClass {\n"
  87. " private int a;\n"
  88. " private int b;\n"
  89. "}");
  90. verifyFormat("public class A {\n"
  91. " class B {\n"
  92. " int i;\n"
  93. " }\n"
  94. " class C {\n"
  95. " int j;\n"
  96. " }\n"
  97. "}");
  98. verifyFormat("public class A extends B.C {}");
  99. verifyFormat("abstract class SomeClass\n"
  100. " extends SomeOtherClass implements SomeInterface {}",
  101. getStyleWithColumns(60));
  102. verifyFormat("abstract class SomeClass extends SomeOtherClass\n"
  103. " implements SomeInterfaceeeeeeeeeeeee {}",
  104. getStyleWithColumns(60));
  105. verifyFormat("abstract class SomeClass\n"
  106. " extends SomeOtherClass\n"
  107. " implements SomeInterface {}",
  108. getStyleWithColumns(40));
  109. verifyFormat("abstract class SomeClass\n"
  110. " extends SomeOtherClass\n"
  111. " implements SomeInterface,\n"
  112. " AnotherInterface {}",
  113. getStyleWithColumns(40));
  114. verifyFormat("abstract class SomeClass\n"
  115. " implements SomeInterface, AnotherInterface {}",
  116. getStyleWithColumns(60));
  117. verifyFormat("@SomeAnnotation()\n"
  118. "abstract class aaaaaaaaaaaa\n"
  119. " extends bbbbbbbbbbbbbbb implements cccccccccccc {}",
  120. getStyleWithColumns(76));
  121. verifyFormat("@SomeAnnotation()\n"
  122. "abstract class aaaaaaaaa<a>\n"
  123. " extends bbbbbbbbbbbb<b> implements cccccccccccc {}",
  124. getStyleWithColumns(76));
  125. verifyFormat("interface SomeInterface<A> extends Foo, Bar {\n"
  126. " void doStuff(int theStuff);\n"
  127. " void doMoreStuff(int moreStuff);\n"
  128. "}");
  129. verifyFormat("public interface SomeInterface {\n"
  130. " void doStuff(int theStuff);\n"
  131. " void doMoreStuff(int moreStuff);\n"
  132. "}");
  133. verifyFormat("@interface SomeInterface {\n"
  134. " void doStuff(int theStuff);\n"
  135. " void doMoreStuff(int moreStuff);\n"
  136. "}");
  137. verifyFormat("public @interface SomeInterface {\n"
  138. " void doStuff(int theStuff);\n"
  139. " void doMoreStuff(int moreStuff);\n"
  140. "}");
  141. }
  142. TEST_F(FormatTestJava, AnonymousClasses) {
  143. verifyFormat("return new A() {\n"
  144. " public String toString() {\n"
  145. " return \"NotReallyA\";\n"
  146. " }\n"
  147. "};");
  148. verifyFormat("A a = new A() {\n"
  149. " public String toString() {\n"
  150. " return \"NotReallyA\";\n"
  151. " }\n"
  152. "};");
  153. }
  154. TEST_F(FormatTestJava, EnumDeclarations) {
  155. verifyFormat("enum SomeThing { ABC, CDE }");
  156. verifyFormat("enum SomeThing {\n"
  157. " ABC,\n"
  158. " CDE,\n"
  159. "}");
  160. verifyFormat("public class SomeClass {\n"
  161. " enum SomeThing { ABC, CDE }\n"
  162. " void f() {}\n"
  163. "}");
  164. verifyFormat("public class SomeClass implements SomeInterface {\n"
  165. " enum SomeThing { ABC, CDE }\n"
  166. " void f() {}\n"
  167. "}");
  168. verifyFormat("enum SomeThing {\n"
  169. " ABC,\n"
  170. " CDE;\n"
  171. " void f() {}\n"
  172. "}");
  173. verifyFormat("enum SomeThing {\n"
  174. " ABC(1, \"ABC\"),\n"
  175. " CDE(2, \"CDE\");\n"
  176. " Something(int i, String s) {}\n"
  177. "}");
  178. verifyFormat("enum SomeThing {\n"
  179. " ABC(new int[] {1, 2}),\n"
  180. " CDE(new int[] {2, 3});\n"
  181. " Something(int[] i) {}\n"
  182. "}");
  183. verifyFormat("public enum SomeThing {\n"
  184. " ABC {\n"
  185. " public String toString() {\n"
  186. " return \"ABC\";\n"
  187. " }\n"
  188. " },\n"
  189. " CDE {\n"
  190. " @Override\n"
  191. " public String toString() {\n"
  192. " return \"CDE\";\n"
  193. " }\n"
  194. " };\n"
  195. " public void f() {}\n"
  196. "}");
  197. verifyFormat("private enum SomeEnum implements Foo<?, B> {\n"
  198. " ABC {\n"
  199. " @Override\n"
  200. " public String toString() {\n"
  201. " return \"ABC\";\n"
  202. " }\n"
  203. " },\n"
  204. " CDE {\n"
  205. " @Override\n"
  206. " public String toString() {\n"
  207. " return \"CDE\";\n"
  208. " }\n"
  209. " };\n"
  210. "}");
  211. verifyFormat("public enum VeryLongEnum {\n"
  212. " ENUM_WITH_MANY_PARAMETERS(\n"
  213. " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\", \"bbbbbbbbbbbbbbbb\", "
  214. "\"cccccccccccccccccccccccc\"),\n"
  215. " SECOND_ENUM(\"a\", \"b\", \"c\");\n"
  216. " private VeryLongEnum(String a, String b, String c) {}\n"
  217. "}\n");
  218. }
  219. TEST_F(FormatTestJava, ArrayInitializers) {
  220. verifyFormat("new int[] {1, 2, 3, 4};");
  221. verifyFormat("new int[] {\n"
  222. " 1,\n"
  223. " 2,\n"
  224. " 3,\n"
  225. " 4,\n"
  226. "};");
  227. FormatStyle Style = getStyleWithColumns(65);
  228. Style.Cpp11BracedListStyle = false;
  229. verifyFormat(
  230. "expected = new int[] { 10, 10, 10, 10, 10, 10, 10, 10, 10, 10,\n"
  231. " 100, 100, 100, 100, 100, 100, 100, 100, 100, 100 };",
  232. Style);
  233. }
  234. TEST_F(FormatTestJava, ThrowsDeclarations) {
  235. verifyFormat("public void doSooooooooooooooooooooooooooomething()\n"
  236. " throws LooooooooooooooooooooooooooooongException {}");
  237. verifyFormat("public void doSooooooooooooooooooooooooooomething()\n"
  238. " throws LoooooooooongException, LooooooooooongException {}");
  239. }
  240. TEST_F(FormatTestJava, Annotations) {
  241. verifyFormat("@Override\n"
  242. "public String toString() {}");
  243. verifyFormat("@Override\n"
  244. "@Nullable\n"
  245. "public String getNameIfPresent() {}");
  246. verifyFormat("@Override // comment\n"
  247. "@Nullable\n"
  248. "public String getNameIfPresent() {}");
  249. verifyFormat("@java.lang.Override // comment\n"
  250. "@Nullable\n"
  251. "public String getNameIfPresent() {}");
  252. verifyFormat("@SuppressWarnings(value = \"unchecked\")\n"
  253. "public void doSomething() {}");
  254. verifyFormat("@SuppressWarnings(value = \"unchecked\")\n"
  255. "@Author(name = \"abc\")\n"
  256. "public void doSomething() {}");
  257. verifyFormat("DoSomething(new A() {\n"
  258. " @Override\n"
  259. " public String toString() {}\n"
  260. "});");
  261. verifyFormat("void SomeFunction(@Nullable String something) {}");
  262. verifyFormat("void SomeFunction(@org.llvm.Nullable String something) {}");
  263. verifyFormat("@Partial @Mock DataLoader loader;");
  264. verifyFormat("@Partial\n"
  265. "@Mock\n"
  266. "DataLoader loader;",
  267. getChromiumStyle(FormatStyle::LK_Java));
  268. verifyFormat("@SuppressWarnings(value = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\")\n"
  269. "public static int iiiiiiiiiiiiiiiiiiiiiiii;");
  270. verifyFormat("@SomeAnnotation(\"With some really looooooooooooooong text\")\n"
  271. "private static final long something = 0L;");
  272. verifyFormat("@org.llvm.Qualified(\"With some really looooooooooong text\")\n"
  273. "private static final long something = 0L;");
  274. verifyFormat("@Mock\n"
  275. "DataLoader loooooooooooooooooooooooader =\n"
  276. " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;",
  277. getStyleWithColumns(60));
  278. verifyFormat("@org.llvm.QualifiedMock\n"
  279. "DataLoader loooooooooooooooooooooooader =\n"
  280. " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;",
  281. getStyleWithColumns(60));
  282. verifyFormat("@Test(a)\n"
  283. "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
  284. " aaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa);");
  285. verifyFormat("@SomeAnnotation(\n"
  286. " aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa)\n"
  287. "int i;",
  288. getStyleWithColumns(50));
  289. verifyFormat("@Test\n"
  290. "ReturnType doSomething(\n"
  291. " String aaaaaaaaaaaaa, String bbbbbbbbbbbbbbb) {}",
  292. getStyleWithColumns(60));
  293. verifyFormat("{\n"
  294. " boolean someFunction(\n"
  295. " @Param(aaaaaaaaaaaaaaaa) String aaaaa,\n"
  296. " String bbbbbbbbbbbbbbb) {}\n"
  297. "}",
  298. getStyleWithColumns(60));
  299. verifyFormat("@Annotation(\"Some\"\n"
  300. " + \" text\")\n"
  301. "List<Integer> list;");
  302. }
  303. TEST_F(FormatTestJava, Generics) {
  304. verifyFormat("Iterable<?> a;");
  305. verifyFormat("Iterable<?> a;");
  306. verifyFormat("Iterable<? extends SomeObject> a;");
  307. verifyFormat("A.<B>doSomething();");
  308. verifyFormat("@Override\n"
  309. "public Map<String, ?> getAll() {}");
  310. verifyFormat("public <R> ArrayList<R> get() {}");
  311. verifyFormat("protected <R> ArrayList<R> get() {}");
  312. verifyFormat("private <R> ArrayList<R> get() {}");
  313. verifyFormat("public static <R> ArrayList<R> get() {}");
  314. verifyFormat("public static native <R> ArrayList<R> get();");
  315. verifyFormat("public final <X> Foo foo() {}");
  316. verifyFormat("public abstract <X> Foo foo();");
  317. verifyFormat("<T extends B> T getInstance(Class<T> type);");
  318. verifyFormat("Function<F, ? extends T> function;");
  319. verifyFormat("private Foo<X, Y>[] foos;");
  320. verifyFormat("Foo<X, Y>[] foos = this.foos;");
  321. verifyFormat("return (a instanceof List<?>)\n"
  322. " ? aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n"
  323. " : aaaaaaaaaaaaaaaaaaaaaaa;",
  324. getStyleWithColumns(60));
  325. verifyFormat(
  326. "SomeLoooooooooooooooooooooongType name =\n"
  327. " SomeType.foo(someArgument)\n"
  328. " .<X>method()\n"
  329. " .aaaaaaaaaaaaaaaaaaa()\n"
  330. " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();");
  331. }
  332. TEST_F(FormatTestJava, StringConcatenation) {
  333. verifyFormat("String someString = \"abc\"\n"
  334. " + \"cde\";");
  335. }
  336. TEST_F(FormatTestJava, TryCatchFinally) {
  337. verifyFormat("try {\n"
  338. " Something();\n"
  339. "} catch (SomeException e) {\n"
  340. " HandleException(e);\n"
  341. "}");
  342. verifyFormat("try {\n"
  343. " Something();\n"
  344. "} finally {\n"
  345. " AlwaysDoThis();\n"
  346. "}");
  347. verifyFormat("try {\n"
  348. " Something();\n"
  349. "} catch (SomeException e) {\n"
  350. " HandleException(e);\n"
  351. "} finally {\n"
  352. " AlwaysDoThis();\n"
  353. "}");
  354. verifyFormat("try {\n"
  355. " Something();\n"
  356. "} catch (SomeException | OtherException e) {\n"
  357. " HandleException(e);\n"
  358. "}");
  359. }
  360. TEST_F(FormatTestJava, TryWithResources) {
  361. verifyFormat("try (SomeResource rs = someFunction()) {\n"
  362. " Something();\n"
  363. "}");
  364. verifyFormat("try (SomeResource rs = someFunction()) {\n"
  365. " Something();\n"
  366. "} catch (SomeException e) {\n"
  367. " HandleException(e);\n"
  368. "}");
  369. }
  370. TEST_F(FormatTestJava, SynchronizedKeyword) {
  371. verifyFormat("synchronized (mData) {\n"
  372. " // ...\n"
  373. "}");
  374. }
  375. TEST_F(FormatTestJava, AssertKeyword) {
  376. verifyFormat("assert a && b;");
  377. }
  378. TEST_F(FormatTestJava, PackageDeclarations) {
  379. verifyFormat("package some.really.loooooooooooooooooooooong.package;",
  380. getStyleWithColumns(50));
  381. }
  382. TEST_F(FormatTestJava, ImportDeclarations) {
  383. verifyFormat("import some.really.loooooooooooooooooooooong.imported.Class;",
  384. getStyleWithColumns(50));
  385. verifyFormat("import static some.really.looooooooooooooooong.imported.Class;",
  386. getStyleWithColumns(50));
  387. }
  388. TEST_F(FormatTestJava, MethodDeclarations) {
  389. verifyFormat("void methodName(Object arg1,\n"
  390. " Object arg2, Object arg3) {}",
  391. getStyleWithColumns(40));
  392. verifyFormat("void methodName(\n"
  393. " Object arg1, Object arg2) {}",
  394. getStyleWithColumns(40));
  395. }
  396. TEST_F(FormatTestJava, CppKeywords) {
  397. verifyFormat("public void union(Type a, Type b);");
  398. verifyFormat("public void struct(Object o);");
  399. verifyFormat("public void delete(Object o);");
  400. verifyFormat("return operator && (aa);");
  401. }
  402. TEST_F(FormatTestJava, NeverAlignAfterReturn) {
  403. verifyFormat("return aaaaaaaaaaaaaaaaaaa\n"
  404. " && bbbbbbbbbbbbbbbbbbb\n"
  405. " && ccccccccccccccccccc;",
  406. getStyleWithColumns(40));
  407. verifyFormat("return (result == null)\n"
  408. " ? aaaaaaaaaaaaaaaaa\n"
  409. " : bbbbbbbbbbbbbbbbb;",
  410. getStyleWithColumns(40));
  411. verifyFormat("return aaaaaaaaaaaaaaaaaaa()\n"
  412. " .bbbbbbbbbbbbbbbbbbb()\n"
  413. " .ccccccccccccccccccc();",
  414. getStyleWithColumns(40));
  415. verifyFormat("return aaaaaaaaaaaaaaaaaaa()\n"
  416. " .bbbbbbbbbbbbbbbbbbb(\n"
  417. " ccccccccccccccc)\n"
  418. " .ccccccccccccccccccc();",
  419. getStyleWithColumns(40));
  420. }
  421. TEST_F(FormatTestJava, FormatsInnerBlocks) {
  422. verifyFormat("someObject.someFunction(new Runnable() {\n"
  423. " @Override\n"
  424. " public void run() {\n"
  425. " System.out.println(42);\n"
  426. " }\n"
  427. "}, someOtherParameter);");
  428. verifyFormat("someFunction(new Runnable() {\n"
  429. " public void run() {\n"
  430. " System.out.println(42);\n"
  431. " }\n"
  432. "});");
  433. verifyFormat("someObject.someFunction(\n"
  434. " new Runnable() {\n"
  435. " @Override\n"
  436. " public void run() {\n"
  437. " System.out.println(42);\n"
  438. " }\n"
  439. " },\n"
  440. " new Runnable() {\n"
  441. " @Override\n"
  442. " public void run() {\n"
  443. " System.out.println(43);\n"
  444. " }\n"
  445. " },\n"
  446. " someOtherParameter);");
  447. }
  448. TEST_F(FormatTestJava, FormatsLambdas) {
  449. verifyFormat("(aaaaaaaaaa, bbbbbbbbbb) -> aaaaaaaaaa + bbbbbbbbbb;");
  450. verifyFormat("(aaaaaaaaaa, bbbbbbbbbb)\n"
  451. " -> aaaaaaaaaa + bbbbbbbbbb;",
  452. getStyleWithColumns(40));
  453. verifyFormat("Runnable someLambda = () -> DoSomething();");
  454. verifyFormat("Runnable someLambda = () -> {\n"
  455. " DoSomething();\n"
  456. "}");
  457. verifyFormat("Runnable someLambda =\n"
  458. " (int aaaaa) -> DoSomething(aaaaa);",
  459. getStyleWithColumns(40));
  460. }
  461. TEST_F(FormatTestJava, BreaksStringLiterals) {
  462. // FIXME: String literal breaking is currently disabled for Java and JS, as it
  463. // requires strings to be merged using "+" which we don't support.
  464. EXPECT_EQ("\"some text other\";",
  465. format("\"some text other\";", getStyleWithColumns(14)));
  466. }
  467. TEST_F(FormatTestJava, AlignsBlockComments) {
  468. EXPECT_EQ("/*\n"
  469. " * Really multi-line\n"
  470. " * comment.\n"
  471. " */\n"
  472. "void f() {}",
  473. format(" /*\n"
  474. " * Really multi-line\n"
  475. " * comment.\n"
  476. " */\n"
  477. " void f() {}"));
  478. }
  479. TEST_F(FormatTestJava, KeepsDelimitersOnOwnLineInJavaDocComments) {
  480. EXPECT_EQ("/**\n"
  481. " * javadoc line 1\n"
  482. " * javadoc line 2\n"
  483. " */",
  484. format("/** javadoc line 1\n"
  485. " * javadoc line 2 */"));
  486. }
  487. TEST_F(FormatTestJava, RetainsLogicalShifts) {
  488. verifyFormat("void f() {\n"
  489. " int a = 1;\n"
  490. " a >>>= 1;\n"
  491. "}");
  492. verifyFormat("void f() {\n"
  493. " int a = 1;\n"
  494. " a = a >>> 1;\n"
  495. "}");
  496. }
  497. } // end namespace tooling
  498. } // end namespace clang