RefactoringTest.cpp 30 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736
  1. //===- unittest/Tooling/RefactoringTest.cpp - Refactoring unit tests ------===//
  2. //
  3. // The LLVM Compiler Infrastructure
  4. //
  5. // This file is distributed under the University of Illinois Open Source
  6. // License. See LICENSE.TXT for details.
  7. //
  8. //===----------------------------------------------------------------------===//
  9. #include "RewriterTestContext.h"
  10. #include "clang/AST/ASTConsumer.h"
  11. #include "clang/AST/ASTContext.h"
  12. #include "clang/AST/DeclCXX.h"
  13. #include "clang/AST/DeclGroup.h"
  14. #include "clang/AST/RecursiveASTVisitor.h"
  15. #include "clang/Basic/Diagnostic.h"
  16. #include "clang/Basic/DiagnosticOptions.h"
  17. #include "clang/Basic/FileManager.h"
  18. #include "clang/Basic/LangOptions.h"
  19. #include "clang/Basic/SourceManager.h"
  20. #include "clang/Format/Format.h"
  21. #include "clang/Frontend/CompilerInstance.h"
  22. #include "clang/Frontend/FrontendAction.h"
  23. #include "clang/Frontend/TextDiagnosticPrinter.h"
  24. #include "clang/Rewrite/Core/Rewriter.h"
  25. #include "clang/Tooling/Refactoring.h"
  26. #include "clang/Tooling/Tooling.h"
  27. #include "llvm/ADT/SmallString.h"
  28. #include "llvm/Support/Path.h"
  29. #include "gtest/gtest.h"
  30. namespace clang {
  31. namespace tooling {
  32. class ReplacementTest : public ::testing::Test {
  33. protected:
  34. Replacement createReplacement(SourceLocation Start, unsigned Length,
  35. llvm::StringRef ReplacementText) {
  36. return Replacement(Context.Sources, Start, Length, ReplacementText);
  37. }
  38. RewriterTestContext Context;
  39. };
  40. TEST_F(ReplacementTest, CanDeleteAllText) {
  41. FileID ID = Context.createInMemoryFile("input.cpp", "text");
  42. SourceLocation Location = Context.getLocation(ID, 1, 1);
  43. Replacement Replace(createReplacement(Location, 4, ""));
  44. EXPECT_TRUE(Replace.apply(Context.Rewrite));
  45. EXPECT_EQ("", Context.getRewrittenText(ID));
  46. }
  47. TEST_F(ReplacementTest, CanDeleteAllTextInTextWithNewlines) {
  48. FileID ID = Context.createInMemoryFile("input.cpp", "line1\nline2\nline3");
  49. SourceLocation Location = Context.getLocation(ID, 1, 1);
  50. Replacement Replace(createReplacement(Location, 17, ""));
  51. EXPECT_TRUE(Replace.apply(Context.Rewrite));
  52. EXPECT_EQ("", Context.getRewrittenText(ID));
  53. }
  54. TEST_F(ReplacementTest, CanAddText) {
  55. FileID ID = Context.createInMemoryFile("input.cpp", "");
  56. SourceLocation Location = Context.getLocation(ID, 1, 1);
  57. Replacement Replace(createReplacement(Location, 0, "result"));
  58. EXPECT_TRUE(Replace.apply(Context.Rewrite));
  59. EXPECT_EQ("result", Context.getRewrittenText(ID));
  60. }
  61. TEST_F(ReplacementTest, CanReplaceTextAtPosition) {
  62. FileID ID = Context.createInMemoryFile("input.cpp",
  63. "line1\nline2\nline3\nline4");
  64. SourceLocation Location = Context.getLocation(ID, 2, 3);
  65. Replacement Replace(createReplacement(Location, 12, "x"));
  66. EXPECT_TRUE(Replace.apply(Context.Rewrite));
  67. EXPECT_EQ("line1\nlixne4", Context.getRewrittenText(ID));
  68. }
  69. TEST_F(ReplacementTest, CanReplaceTextAtPositionMultipleTimes) {
  70. FileID ID = Context.createInMemoryFile("input.cpp",
  71. "line1\nline2\nline3\nline4");
  72. SourceLocation Location1 = Context.getLocation(ID, 2, 3);
  73. Replacement Replace1(createReplacement(Location1, 12, "x\ny\n"));
  74. EXPECT_TRUE(Replace1.apply(Context.Rewrite));
  75. EXPECT_EQ("line1\nlix\ny\nne4", Context.getRewrittenText(ID));
  76. // Since the original source has not been modified, the (4, 4) points to the
  77. // 'e' in the original content.
  78. SourceLocation Location2 = Context.getLocation(ID, 4, 4);
  79. Replacement Replace2(createReplacement(Location2, 1, "f"));
  80. EXPECT_TRUE(Replace2.apply(Context.Rewrite));
  81. EXPECT_EQ("line1\nlix\ny\nnf4", Context.getRewrittenText(ID));
  82. }
  83. TEST_F(ReplacementTest, ApplyFailsForNonExistentLocation) {
  84. Replacement Replace("nonexistent-file.cpp", 0, 1, "");
  85. EXPECT_FALSE(Replace.apply(Context.Rewrite));
  86. }
  87. TEST_F(ReplacementTest, CanRetrivePath) {
  88. Replacement Replace("/path/to/file.cpp", 0, 1, "");
  89. EXPECT_EQ("/path/to/file.cpp", Replace.getFilePath());
  90. }
  91. TEST_F(ReplacementTest, ReturnsInvalidPath) {
  92. Replacement Replace1(Context.Sources, SourceLocation(), 0, "");
  93. EXPECT_TRUE(Replace1.getFilePath().empty());
  94. Replacement Replace2;
  95. EXPECT_TRUE(Replace2.getFilePath().empty());
  96. }
  97. TEST_F(ReplacementTest, CanApplyReplacements) {
  98. FileID ID = Context.createInMemoryFile("input.cpp",
  99. "line1\nline2\nline3\nline4");
  100. Replacements Replaces;
  101. Replaces.insert(Replacement(Context.Sources, Context.getLocation(ID, 2, 1),
  102. 5, "replaced"));
  103. Replaces.insert(Replacement(Context.Sources, Context.getLocation(ID, 3, 1),
  104. 5, "other"));
  105. EXPECT_TRUE(applyAllReplacements(Replaces, Context.Rewrite));
  106. EXPECT_EQ("line1\nreplaced\nother\nline4", Context.getRewrittenText(ID));
  107. }
  108. // FIXME: Remove this test case when Replacements is implemented as std::vector
  109. // instead of std::set. The other ReplacementTest tests will need to be updated
  110. // at that point as well.
  111. TEST_F(ReplacementTest, VectorCanApplyReplacements) {
  112. FileID ID = Context.createInMemoryFile("input.cpp",
  113. "line1\nline2\nline3\nline4");
  114. std::vector<Replacement> Replaces;
  115. Replaces.push_back(Replacement(Context.Sources, Context.getLocation(ID, 2, 1),
  116. 5, "replaced"));
  117. Replaces.push_back(
  118. Replacement(Context.Sources, Context.getLocation(ID, 3, 1), 5, "other"));
  119. EXPECT_TRUE(applyAllReplacements(Replaces, Context.Rewrite));
  120. EXPECT_EQ("line1\nreplaced\nother\nline4", Context.getRewrittenText(ID));
  121. }
  122. TEST_F(ReplacementTest, SkipsDuplicateReplacements) {
  123. FileID ID = Context.createInMemoryFile("input.cpp",
  124. "line1\nline2\nline3\nline4");
  125. Replacements Replaces;
  126. Replaces.insert(Replacement(Context.Sources, Context.getLocation(ID, 2, 1),
  127. 5, "replaced"));
  128. Replaces.insert(Replacement(Context.Sources, Context.getLocation(ID, 2, 1),
  129. 5, "replaced"));
  130. Replaces.insert(Replacement(Context.Sources, Context.getLocation(ID, 2, 1),
  131. 5, "replaced"));
  132. EXPECT_TRUE(applyAllReplacements(Replaces, Context.Rewrite));
  133. EXPECT_EQ("line1\nreplaced\nline3\nline4", Context.getRewrittenText(ID));
  134. }
  135. TEST_F(ReplacementTest, ApplyAllFailsIfOneApplyFails) {
  136. // This test depends on the value of the file name of an invalid source
  137. // location being in the range ]a, z[.
  138. FileID IDa = Context.createInMemoryFile("a.cpp", "text");
  139. FileID IDz = Context.createInMemoryFile("z.cpp", "text");
  140. Replacements Replaces;
  141. Replaces.insert(Replacement(Context.Sources, Context.getLocation(IDa, 1, 1),
  142. 4, "a"));
  143. Replaces.insert(Replacement(Context.Sources, SourceLocation(),
  144. 5, "2"));
  145. Replaces.insert(Replacement(Context.Sources, Context.getLocation(IDz, 1, 1),
  146. 4, "z"));
  147. EXPECT_FALSE(applyAllReplacements(Replaces, Context.Rewrite));
  148. EXPECT_EQ("a", Context.getRewrittenText(IDa));
  149. EXPECT_EQ("z", Context.getRewrittenText(IDz));
  150. }
  151. TEST_F(ReplacementTest, MultipleFilesReplaceAndFormat) {
  152. // Column limit is 20.
  153. std::string Code1 = "Long *a =\n"
  154. " new Long();\n"
  155. "long x = 1;";
  156. std::string Expected1 = "auto a = new Long();\n"
  157. "long x =\n"
  158. " 12345678901;";
  159. std::string Code2 = "int x = 123;\n"
  160. "int y = 0;";
  161. std::string Expected2 = "int x =\n"
  162. " 1234567890123;\n"
  163. "int y = 10;";
  164. FileID ID1 = Context.createInMemoryFile("format_1.cpp", Code1);
  165. FileID ID2 = Context.createInMemoryFile("format_2.cpp", Code2);
  166. tooling::Replacements Replaces;
  167. // Scrambled the order of replacements.
  168. Replaces.insert(tooling::Replacement(
  169. Context.Sources, Context.getLocation(ID2, 1, 12), 0, "4567890123"));
  170. Replaces.insert(tooling::Replacement(
  171. Context.Sources, Context.getLocation(ID1, 1, 1), 6, "auto "));
  172. Replaces.insert(tooling::Replacement(
  173. Context.Sources, Context.getLocation(ID2, 2, 9), 1, "10"));
  174. Replaces.insert(tooling::Replacement(
  175. Context.Sources, Context.getLocation(ID1, 3, 10), 1, "12345678901"));
  176. EXPECT_TRUE(formatAndApplyAllReplacements(
  177. Replaces, Context.Rewrite, "{BasedOnStyle: LLVM, ColumnLimit: 20}"));
  178. EXPECT_EQ(Expected1, Context.getRewrittenText(ID1));
  179. EXPECT_EQ(Expected2, Context.getRewrittenText(ID2));
  180. }
  181. TEST(ShiftedCodePositionTest, FindsNewCodePosition) {
  182. Replacements Replaces;
  183. Replaces.insert(Replacement("", 0, 1, ""));
  184. Replaces.insert(Replacement("", 4, 3, " "));
  185. // Assume ' int i;' is turned into 'int i;' and cursor is located at '|'.
  186. EXPECT_EQ(0u, shiftedCodePosition(Replaces, 0)); // |int i;
  187. EXPECT_EQ(0u, shiftedCodePosition(Replaces, 1)); // |nt i;
  188. EXPECT_EQ(1u, shiftedCodePosition(Replaces, 2)); // i|t i;
  189. EXPECT_EQ(2u, shiftedCodePosition(Replaces, 3)); // in| i;
  190. EXPECT_EQ(3u, shiftedCodePosition(Replaces, 4)); // int| i;
  191. EXPECT_EQ(3u, shiftedCodePosition(Replaces, 5)); // int | i;
  192. EXPECT_EQ(3u, shiftedCodePosition(Replaces, 6)); // int |i;
  193. EXPECT_EQ(4u, shiftedCodePosition(Replaces, 7)); // int |;
  194. EXPECT_EQ(5u, shiftedCodePosition(Replaces, 8)); // int i|
  195. }
  196. // FIXME: Remove this test case when Replacements is implemented as std::vector
  197. // instead of std::set. The other ReplacementTest tests will need to be updated
  198. // at that point as well.
  199. TEST(ShiftedCodePositionTest, VectorFindsNewCodePositionWithInserts) {
  200. std::vector<Replacement> Replaces;
  201. Replaces.push_back(Replacement("", 0, 1, ""));
  202. Replaces.push_back(Replacement("", 4, 3, " "));
  203. // Assume ' int i;' is turned into 'int i;' and cursor is located at '|'.
  204. EXPECT_EQ(0u, shiftedCodePosition(Replaces, 0)); // |int i;
  205. EXPECT_EQ(0u, shiftedCodePosition(Replaces, 1)); // |nt i;
  206. EXPECT_EQ(1u, shiftedCodePosition(Replaces, 2)); // i|t i;
  207. EXPECT_EQ(2u, shiftedCodePosition(Replaces, 3)); // in| i;
  208. EXPECT_EQ(3u, shiftedCodePosition(Replaces, 4)); // int| i;
  209. EXPECT_EQ(3u, shiftedCodePosition(Replaces, 5)); // int | i;
  210. EXPECT_EQ(3u, shiftedCodePosition(Replaces, 6)); // int |i;
  211. EXPECT_EQ(4u, shiftedCodePosition(Replaces, 7)); // int |;
  212. EXPECT_EQ(5u, shiftedCodePosition(Replaces, 8)); // int i|
  213. }
  214. TEST(ShiftedCodePositionTest, FindsNewCodePositionWithInserts) {
  215. Replacements Replaces;
  216. Replaces.insert(Replacement("", 4, 0, "\"\n\""));
  217. // Assume '"12345678"' is turned into '"1234"\n"5678"'.
  218. EXPECT_EQ(3u, shiftedCodePosition(Replaces, 3)); // "123|5678"
  219. EXPECT_EQ(7u, shiftedCodePosition(Replaces, 4)); // "1234|678"
  220. EXPECT_EQ(8u, shiftedCodePosition(Replaces, 5)); // "12345|78"
  221. }
  222. TEST(ShiftedCodePositionTest, FindsNewCodePositionInReplacedText) {
  223. Replacements Replaces;
  224. // Replace the first four characters with "abcd".
  225. Replaces.insert(Replacement("", 0, 4, "abcd"));
  226. for (unsigned i = 0; i < 3; ++i)
  227. EXPECT_EQ(i, shiftedCodePosition(Replaces, i));
  228. }
  229. class FlushRewrittenFilesTest : public ::testing::Test {
  230. public:
  231. FlushRewrittenFilesTest() {}
  232. ~FlushRewrittenFilesTest() override {
  233. for (llvm::StringMap<std::string>::iterator I = TemporaryFiles.begin(),
  234. E = TemporaryFiles.end();
  235. I != E; ++I) {
  236. llvm::StringRef Name = I->second;
  237. std::error_code EC = llvm::sys::fs::remove(Name);
  238. (void)EC;
  239. assert(!EC);
  240. }
  241. }
  242. FileID createFile(llvm::StringRef Name, llvm::StringRef Content) {
  243. SmallString<1024> Path;
  244. int FD;
  245. std::error_code EC = llvm::sys::fs::createTemporaryFile(Name, "", FD, Path);
  246. assert(!EC);
  247. (void)EC;
  248. llvm::raw_fd_ostream OutStream(FD, true);
  249. OutStream << Content;
  250. OutStream.close();
  251. const FileEntry *File = Context.Files.getFile(Path);
  252. assert(File != nullptr);
  253. StringRef Found =
  254. TemporaryFiles.insert(std::make_pair(Name, Path.str())).first->second;
  255. assert(Found == Path);
  256. (void)Found;
  257. return Context.Sources.createFileID(File, SourceLocation(), SrcMgr::C_User);
  258. }
  259. std::string getFileContentFromDisk(llvm::StringRef Name) {
  260. std::string Path = TemporaryFiles.lookup(Name);
  261. assert(!Path.empty());
  262. // We need to read directly from the FileManager without relaying through
  263. // a FileEntry, as otherwise we'd read through an already opened file
  264. // descriptor, which might not see the changes made.
  265. // FIXME: Figure out whether there is a way to get the SourceManger to
  266. // reopen the file.
  267. auto FileBuffer = Context.Files.getBufferForFile(Path);
  268. return (*FileBuffer)->getBuffer();
  269. }
  270. llvm::StringMap<std::string> TemporaryFiles;
  271. RewriterTestContext Context;
  272. };
  273. TEST_F(FlushRewrittenFilesTest, StoresChangesOnDisk) {
  274. FileID ID = createFile("input.cpp", "line1\nline2\nline3\nline4");
  275. Replacements Replaces;
  276. Replaces.insert(Replacement(Context.Sources, Context.getLocation(ID, 2, 1),
  277. 5, "replaced"));
  278. EXPECT_TRUE(applyAllReplacements(Replaces, Context.Rewrite));
  279. EXPECT_FALSE(Context.Rewrite.overwriteChangedFiles());
  280. EXPECT_EQ("line1\nreplaced\nline3\nline4",
  281. getFileContentFromDisk("input.cpp"));
  282. }
  283. namespace {
  284. template <typename T>
  285. class TestVisitor : public clang::RecursiveASTVisitor<T> {
  286. public:
  287. bool runOver(StringRef Code) {
  288. return runToolOnCode(new TestAction(this), Code);
  289. }
  290. protected:
  291. clang::SourceManager *SM;
  292. clang::ASTContext *Context;
  293. private:
  294. class FindConsumer : public clang::ASTConsumer {
  295. public:
  296. FindConsumer(TestVisitor *Visitor) : Visitor(Visitor) {}
  297. void HandleTranslationUnit(clang::ASTContext &Context) override {
  298. Visitor->TraverseDecl(Context.getTranslationUnitDecl());
  299. }
  300. private:
  301. TestVisitor *Visitor;
  302. };
  303. class TestAction : public clang::ASTFrontendAction {
  304. public:
  305. TestAction(TestVisitor *Visitor) : Visitor(Visitor) {}
  306. std::unique_ptr<clang::ASTConsumer>
  307. CreateASTConsumer(clang::CompilerInstance &compiler,
  308. llvm::StringRef dummy) override {
  309. Visitor->SM = &compiler.getSourceManager();
  310. Visitor->Context = &compiler.getASTContext();
  311. /// TestConsumer will be deleted by the framework calling us.
  312. return llvm::make_unique<FindConsumer>(Visitor);
  313. }
  314. private:
  315. TestVisitor *Visitor;
  316. };
  317. };
  318. } // end namespace
  319. void expectReplacementAt(const Replacement &Replace,
  320. StringRef File, unsigned Offset, unsigned Length) {
  321. ASSERT_TRUE(Replace.isApplicable());
  322. EXPECT_EQ(File, Replace.getFilePath());
  323. EXPECT_EQ(Offset, Replace.getOffset());
  324. EXPECT_EQ(Length, Replace.getLength());
  325. }
  326. class ClassDeclXVisitor : public TestVisitor<ClassDeclXVisitor> {
  327. public:
  328. bool VisitCXXRecordDecl(CXXRecordDecl *Record) {
  329. if (Record->getName() == "X") {
  330. Replace = Replacement(*SM, Record, "");
  331. }
  332. return true;
  333. }
  334. Replacement Replace;
  335. };
  336. TEST(Replacement, CanBeConstructedFromNode) {
  337. ClassDeclXVisitor ClassDeclX;
  338. EXPECT_TRUE(ClassDeclX.runOver(" class X;"));
  339. expectReplacementAt(ClassDeclX.Replace, "input.cc", 5, 7);
  340. }
  341. TEST(Replacement, ReplacesAtSpellingLocation) {
  342. ClassDeclXVisitor ClassDeclX;
  343. EXPECT_TRUE(ClassDeclX.runOver("#define A(Y) Y\nA(class X);"));
  344. expectReplacementAt(ClassDeclX.Replace, "input.cc", 17, 7);
  345. }
  346. class CallToFVisitor : public TestVisitor<CallToFVisitor> {
  347. public:
  348. bool VisitCallExpr(CallExpr *Call) {
  349. if (Call->getDirectCallee()->getName() == "F") {
  350. Replace = Replacement(*SM, Call, "");
  351. }
  352. return true;
  353. }
  354. Replacement Replace;
  355. };
  356. TEST(Replacement, FunctionCall) {
  357. CallToFVisitor CallToF;
  358. EXPECT_TRUE(CallToF.runOver("void F(); void G() { F(); }"));
  359. expectReplacementAt(CallToF.Replace, "input.cc", 21, 3);
  360. }
  361. TEST(Replacement, TemplatedFunctionCall) {
  362. CallToFVisitor CallToF;
  363. EXPECT_TRUE(CallToF.runOver(
  364. "template <typename T> void F(); void G() { F<int>(); }"));
  365. expectReplacementAt(CallToF.Replace, "input.cc", 43, 8);
  366. }
  367. class NestedNameSpecifierAVisitor
  368. : public TestVisitor<NestedNameSpecifierAVisitor> {
  369. public:
  370. bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNSLoc) {
  371. if (NNSLoc.getNestedNameSpecifier()) {
  372. if (const NamespaceDecl* NS = NNSLoc.getNestedNameSpecifier()->getAsNamespace()) {
  373. if (NS->getName() == "a") {
  374. Replace = Replacement(*SM, &NNSLoc, "", Context->getLangOpts());
  375. }
  376. }
  377. }
  378. return TestVisitor<NestedNameSpecifierAVisitor>::TraverseNestedNameSpecifierLoc(
  379. NNSLoc);
  380. }
  381. Replacement Replace;
  382. };
  383. TEST(Replacement, ColonColon) {
  384. NestedNameSpecifierAVisitor VisitNNSA;
  385. EXPECT_TRUE(VisitNNSA.runOver("namespace a { void f() { ::a::f(); } }"));
  386. expectReplacementAt(VisitNNSA.Replace, "input.cc", 25, 5);
  387. }
  388. TEST(Range, overlaps) {
  389. EXPECT_TRUE(Range(10, 10).overlapsWith(Range(0, 11)));
  390. EXPECT_TRUE(Range(0, 11).overlapsWith(Range(10, 10)));
  391. EXPECT_FALSE(Range(10, 10).overlapsWith(Range(0, 10)));
  392. EXPECT_FALSE(Range(0, 10).overlapsWith(Range(10, 10)));
  393. EXPECT_TRUE(Range(0, 10).overlapsWith(Range(2, 6)));
  394. EXPECT_TRUE(Range(2, 6).overlapsWith(Range(0, 10)));
  395. }
  396. TEST(Range, contains) {
  397. EXPECT_TRUE(Range(0, 10).contains(Range(0, 10)));
  398. EXPECT_TRUE(Range(0, 10).contains(Range(2, 6)));
  399. EXPECT_FALSE(Range(2, 6).contains(Range(0, 10)));
  400. EXPECT_FALSE(Range(0, 10).contains(Range(0, 11)));
  401. }
  402. TEST(Range, CalculateRangesOfReplacements) {
  403. // Before: aaaabbbbbbz
  404. // After : bbbbbbzzzzzzoooooooooooooooo
  405. Replacements Replaces;
  406. Replaces.insert(Replacement("foo", 0, 4, ""));
  407. Replaces.insert(Replacement("foo", 10, 1, "zzzzzz"));
  408. Replaces.insert(Replacement("foo", 11, 0, "oooooooooooooooo"));
  409. std::vector<Range> Ranges = calculateChangedRanges(Replaces);
  410. EXPECT_EQ(2ul, Ranges.size());
  411. EXPECT_TRUE(Ranges[0].getOffset() == 0);
  412. EXPECT_TRUE(Ranges[0].getLength() == 0);
  413. EXPECT_TRUE(Ranges[1].getOffset() == 6);
  414. EXPECT_TRUE(Ranges[1].getLength() == 22);
  415. }
  416. TEST(Range, RangesAfterReplacements) {
  417. std::vector<Range> Ranges = {Range(5, 2), Range(10, 5)};
  418. Replacements Replaces = {Replacement("foo", 0, 2, "1234")};
  419. std::vector<Range> Expected = {Range(0, 4), Range(7, 2), Range(12, 5)};
  420. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  421. }
  422. TEST(Range, RangesBeforeReplacements) {
  423. std::vector<Range> Ranges = {Range(5, 2), Range(10, 5)};
  424. Replacements Replaces = {Replacement("foo", 20, 2, "1234")};
  425. std::vector<Range> Expected = {Range(5, 2), Range(10, 5), Range(20, 4)};
  426. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  427. }
  428. TEST(Range, NotAffectedByReplacements) {
  429. std::vector<Range> Ranges = {Range(0, 2), Range(5, 2), Range(10, 5)};
  430. Replacements Replaces = {Replacement("foo", 3, 2, "12"),
  431. Replacement("foo", 12, 2, "12"),
  432. Replacement("foo", 20, 5, "")};
  433. std::vector<Range> Expected = {Range(0, 2), Range(3, 4), Range(10, 5),
  434. Range(20, 0)};
  435. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  436. }
  437. TEST(Range, RangesWithNonOverlappingReplacements) {
  438. std::vector<Range> Ranges = {Range(0, 2), Range(5, 2), Range(10, 5)};
  439. Replacements Replaces = {Replacement("foo", 3, 1, ""),
  440. Replacement("foo", 6, 1, "123"),
  441. Replacement("foo", 20, 2, "12345")};
  442. std::vector<Range> Expected = {Range(0, 2), Range(3, 0), Range(4, 4),
  443. Range(11, 5), Range(21, 5)};
  444. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  445. }
  446. TEST(Range, RangesWithOverlappingReplacements) {
  447. std::vector<Range> Ranges = {Range(0, 2), Range(5, 2), Range(15, 5),
  448. Range(30, 5)};
  449. Replacements Replaces = {
  450. Replacement("foo", 1, 3, ""), Replacement("foo", 6, 1, "123"),
  451. Replacement("foo", 13, 3, "1"), Replacement("foo", 25, 15, "")};
  452. std::vector<Range> Expected = {Range(0, 1), Range(2, 4), Range(12, 5),
  453. Range(22, 0)};
  454. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  455. }
  456. TEST(Range, MergeIntoOneRange) {
  457. std::vector<Range> Ranges = {Range(0, 2), Range(5, 2), Range(15, 5)};
  458. Replacements Replaces = {Replacement("foo", 1, 15, "1234567890")};
  459. std::vector<Range> Expected = {Range(0, 15)};
  460. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  461. }
  462. TEST(Range, ReplacementsStartingAtRangeOffsets) {
  463. std::vector<Range> Ranges = {Range(0, 2), Range(5, 5), Range(15, 5)};
  464. Replacements Replaces = {
  465. Replacement("foo", 0, 2, "12"), Replacement("foo", 5, 1, "123"),
  466. Replacement("foo", 7, 4, "12345"), Replacement("foo", 15, 10, "12")};
  467. std::vector<Range> Expected = {Range(0, 2), Range(5, 9), Range(18, 2)};
  468. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  469. }
  470. TEST(Range, ReplacementsEndingAtRangeEnds) {
  471. std::vector<Range> Ranges = {Range(0, 2), Range(5, 2), Range(15, 5)};
  472. Replacements Replaces = {Replacement("foo", 6, 1, "123"),
  473. Replacement("foo", 17, 3, "12")};
  474. std::vector<Range> Expected = {Range(0, 2), Range(5, 4), Range(17, 4)};
  475. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  476. }
  477. TEST(Range, AjacentReplacements) {
  478. std::vector<Range> Ranges = {Range(0, 0), Range(15, 5)};
  479. Replacements Replaces = {Replacement("foo", 1, 2, "123"),
  480. Replacement("foo", 12, 3, "1234")};
  481. std::vector<Range> Expected = {Range(0, 0), Range(1, 3), Range(13, 9)};
  482. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  483. }
  484. TEST(Range, MergeRangesAfterReplacements) {
  485. std::vector<Range> Ranges = {Range(8, 0), Range(5, 2), Range(9, 0), Range(0, 1)};
  486. Replacements Replaces = {Replacement("foo", 1, 3, ""),
  487. Replacement("foo", 7, 0, "12"), Replacement("foo", 9, 2, "")};
  488. std::vector<Range> Expected = {Range(0, 1), Range(2, 4), Range(7, 0), Range(8, 0)};
  489. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  490. }
  491. TEST(DeduplicateTest, removesDuplicates) {
  492. std::vector<Replacement> Input;
  493. Input.push_back(Replacement("fileA", 50, 0, " foo "));
  494. Input.push_back(Replacement("fileA", 10, 3, " bar "));
  495. Input.push_back(Replacement("fileA", 10, 2, " bar ")); // Length differs
  496. Input.push_back(Replacement("fileA", 9, 3, " bar ")); // Offset differs
  497. Input.push_back(Replacement("fileA", 50, 0, " foo ")); // Duplicate
  498. Input.push_back(Replacement("fileA", 51, 3, " bar "));
  499. Input.push_back(Replacement("fileB", 51, 3, " bar ")); // Filename differs!
  500. Input.push_back(Replacement("fileB", 60, 1, " bar "));
  501. Input.push_back(Replacement("fileA", 60, 2, " bar "));
  502. Input.push_back(Replacement("fileA", 51, 3, " moo ")); // Replacement text
  503. // differs!
  504. std::vector<Replacement> Expected;
  505. Expected.push_back(Replacement("fileA", 9, 3, " bar "));
  506. Expected.push_back(Replacement("fileA", 10, 2, " bar "));
  507. Expected.push_back(Replacement("fileA", 10, 3, " bar "));
  508. Expected.push_back(Replacement("fileA", 50, 0, " foo "));
  509. Expected.push_back(Replacement("fileA", 51, 3, " bar "));
  510. Expected.push_back(Replacement("fileA", 51, 3, " moo "));
  511. Expected.push_back(Replacement("fileB", 60, 1, " bar "));
  512. Expected.push_back(Replacement("fileA", 60, 2, " bar "));
  513. std::vector<Range> Conflicts; // Ignored for this test
  514. deduplicate(Input, Conflicts);
  515. EXPECT_EQ(3U, Conflicts.size());
  516. EXPECT_EQ(Expected, Input);
  517. }
  518. TEST(DeduplicateTest, detectsConflicts) {
  519. {
  520. std::vector<Replacement> Input;
  521. Input.push_back(Replacement("fileA", 0, 5, " foo "));
  522. Input.push_back(Replacement("fileA", 0, 5, " foo ")); // Duplicate not a
  523. // conflict.
  524. Input.push_back(Replacement("fileA", 2, 6, " bar "));
  525. Input.push_back(Replacement("fileA", 7, 3, " moo "));
  526. std::vector<Range> Conflicts;
  527. deduplicate(Input, Conflicts);
  528. // One duplicate is removed and the remaining three items form one
  529. // conflicted range.
  530. ASSERT_EQ(3u, Input.size());
  531. ASSERT_EQ(1u, Conflicts.size());
  532. ASSERT_EQ(0u, Conflicts.front().getOffset());
  533. ASSERT_EQ(3u, Conflicts.front().getLength());
  534. }
  535. {
  536. std::vector<Replacement> Input;
  537. // Expected sorted order is shown. It is the sorted order to which the
  538. // returned conflict info refers to.
  539. Input.push_back(Replacement("fileA", 0, 5, " foo ")); // 0
  540. Input.push_back(Replacement("fileA", 5, 5, " bar ")); // 1
  541. Input.push_back(Replacement("fileA", 6, 0, " bar ")); // 3
  542. Input.push_back(Replacement("fileA", 5, 5, " moo ")); // 2
  543. Input.push_back(Replacement("fileA", 7, 2, " bar ")); // 4
  544. Input.push_back(Replacement("fileA", 15, 5, " golf ")); // 5
  545. Input.push_back(Replacement("fileA", 16, 5, " bag ")); // 6
  546. Input.push_back(Replacement("fileA", 10, 3, " club ")); // 7
  547. // #3 is special in that it is completely contained by another conflicting
  548. // Replacement. #4 ensures #3 hasn't messed up the conflicting range size.
  549. std::vector<Range> Conflicts;
  550. deduplicate(Input, Conflicts);
  551. // No duplicates
  552. ASSERT_EQ(8u, Input.size());
  553. ASSERT_EQ(2u, Conflicts.size());
  554. ASSERT_EQ(1u, Conflicts[0].getOffset());
  555. ASSERT_EQ(4u, Conflicts[0].getLength());
  556. ASSERT_EQ(6u, Conflicts[1].getOffset());
  557. ASSERT_EQ(2u, Conflicts[1].getLength());
  558. }
  559. }
  560. class MergeReplacementsTest : public ::testing::Test {
  561. protected:
  562. void mergeAndTestRewrite(StringRef Code, StringRef Intermediate,
  563. StringRef Result, const Replacements &First,
  564. const Replacements &Second) {
  565. // These are mainly to verify the test itself and make it easier to read.
  566. auto AfterFirst = applyAllReplacements(Code, First);
  567. EXPECT_TRUE(static_cast<bool>(AfterFirst));
  568. auto InSequenceRewrite = applyAllReplacements(*AfterFirst, Second);
  569. EXPECT_TRUE(static_cast<bool>(InSequenceRewrite));
  570. EXPECT_EQ(Intermediate, *AfterFirst);
  571. EXPECT_EQ(Result, *InSequenceRewrite);
  572. tooling::Replacements Merged = mergeReplacements(First, Second);
  573. auto MergedRewrite = applyAllReplacements(Code, Merged);
  574. EXPECT_TRUE(static_cast<bool>(MergedRewrite));
  575. EXPECT_EQ(*InSequenceRewrite, *MergedRewrite);
  576. if (*InSequenceRewrite != *MergedRewrite)
  577. for (tooling::Replacement M : Merged)
  578. llvm::errs() << M.getOffset() << " " << M.getLength() << " "
  579. << M.getReplacementText() << "\n";
  580. }
  581. void mergeAndTestRewrite(StringRef Code, const Replacements &First,
  582. const Replacements &Second) {
  583. auto AfterFirst = applyAllReplacements(Code, First);
  584. EXPECT_TRUE(static_cast<bool>(AfterFirst));
  585. auto InSequenceRewrite = applyAllReplacements(*AfterFirst, Second);
  586. tooling::Replacements Merged = mergeReplacements(First, Second);
  587. auto MergedRewrite = applyAllReplacements(Code, Merged);
  588. EXPECT_TRUE(static_cast<bool>(MergedRewrite));
  589. EXPECT_EQ(*InSequenceRewrite, *MergedRewrite);
  590. if (*InSequenceRewrite != *MergedRewrite)
  591. for (tooling::Replacement M : Merged)
  592. llvm::errs() << M.getOffset() << " " << M.getLength() << " "
  593. << M.getReplacementText() << "\n";
  594. }
  595. };
  596. TEST_F(MergeReplacementsTest, Offsets) {
  597. mergeAndTestRewrite("aaa", "aabab", "cacabab",
  598. {{"", 2, 0, "b"}, {"", 3, 0, "b"}},
  599. {{"", 0, 0, "c"}, {"", 1, 0, "c"}});
  600. mergeAndTestRewrite("aaa", "babaa", "babacac",
  601. {{"", 0, 0, "b"}, {"", 1, 0, "b"}},
  602. {{"", 4, 0, "c"}, {"", 5, 0, "c"}});
  603. mergeAndTestRewrite("aaaa", "aaa", "aac", {{"", 1, 1, ""}},
  604. {{"", 2, 1, "c"}});
  605. mergeAndTestRewrite("aa", "bbabba", "bbabcba",
  606. {{"", 0, 0, "bb"}, {"", 1, 0, "bb"}}, {{"", 4, 0, "c"}});
  607. }
  608. TEST_F(MergeReplacementsTest, Concatenations) {
  609. // Basic concatenations. It is important to merge these into a single
  610. // replacement to ensure the correct order.
  611. EXPECT_EQ((Replacements{{"", 0, 0, "ab"}}),
  612. mergeReplacements({{"", 0, 0, "a"}}, {{"", 1, 0, "b"}}));
  613. EXPECT_EQ((Replacements{{"", 0, 0, "ba"}}),
  614. mergeReplacements({{"", 0, 0, "a"}}, {{"", 0, 0, "b"}}));
  615. mergeAndTestRewrite("", "a", "ab", {{"", 0, 0, "a"}}, {{"", 1, 0, "b"}});
  616. mergeAndTestRewrite("", "a", "ba", {{"", 0, 0, "a"}}, {{"", 0, 0, "b"}});
  617. }
  618. TEST_F(MergeReplacementsTest, NotChangingLengths) {
  619. mergeAndTestRewrite("aaaa", "abba", "acca", {{"", 1, 2, "bb"}},
  620. {{"", 1, 2, "cc"}});
  621. mergeAndTestRewrite("aaaa", "abba", "abcc", {{"", 1, 2, "bb"}},
  622. {{"", 2, 2, "cc"}});
  623. mergeAndTestRewrite("aaaa", "abba", "ccba", {{"", 1, 2, "bb"}},
  624. {{"", 0, 2, "cc"}});
  625. mergeAndTestRewrite("aaaaaa", "abbdda", "abccda",
  626. {{"", 1, 2, "bb"}, {"", 3, 2, "dd"}}, {{"", 2, 2, "cc"}});
  627. }
  628. TEST_F(MergeReplacementsTest, OverlappingRanges) {
  629. mergeAndTestRewrite("aaa", "bbd", "bcbcd",
  630. {{"", 0, 1, "bb"}, {"", 1, 2, "d"}},
  631. {{"", 1, 0, "c"}, {"", 2, 0, "c"}});
  632. mergeAndTestRewrite("aaaa", "aabbaa", "acccca", {{"", 2, 0, "bb"}},
  633. {{"", 1, 4, "cccc"}});
  634. mergeAndTestRewrite("aaaa", "aababa", "acccca",
  635. {{"", 2, 0, "b"}, {"", 3, 0, "b"}}, {{"", 1, 4, "cccc"}});
  636. mergeAndTestRewrite("aaaaaa", "abbbba", "abba", {{"", 1, 4, "bbbb"}},
  637. {{"", 2, 2, ""}});
  638. mergeAndTestRewrite("aaaa", "aa", "cc", {{"", 1, 1, ""}, {"", 2, 1, ""}},
  639. {{"", 0, 2, "cc"}});
  640. mergeAndTestRewrite("aa", "abbba", "abcbcba", {{"", 1, 0, "bbb"}},
  641. {{"", 2, 0, "c"}, {"", 3, 0, "c"}});
  642. mergeAndTestRewrite("aaa", "abbab", "ccdd",
  643. {{"", 0, 1, ""}, {"", 2, 0, "bb"}, {"", 3, 0, "b"}},
  644. {{"", 0, 2, "cc"}, {"", 2, 3, "dd"}});
  645. mergeAndTestRewrite("aa", "babbab", "ccdd",
  646. {{"", 0, 0, "b"}, {"", 1, 0, "bb"}, {"", 2, 0, "b"}},
  647. {{"", 0, 3, "cc"}, {"", 3, 3, "dd"}});
  648. }
  649. } // end namespace tooling
  650. } // end namespace clang