FormatTestJava.cpp 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519
  1. //===- unittest/Format/FormatTestJava.cpp - Formatting tests for Java -----===//
  2. //
  3. // The LLVM Compiler Infrastructure
  4. //
  5. // This file is distributed under the University of Illinois Open Source
  6. // License. See LICENSE.TXT for details.
  7. //
  8. //===----------------------------------------------------------------------===//
  9. #include "FormatTestUtils.h"
  10. #include "clang/Format/Format.h"
  11. #include "llvm/Support/Debug.h"
  12. #include "gtest/gtest.h"
  13. #define DEBUG_TYPE "format-test"
  14. namespace clang {
  15. namespace format {
  16. class FormatTestJava : public ::testing::Test {
  17. protected:
  18. static std::string format(llvm::StringRef Code, unsigned Offset,
  19. unsigned Length, const FormatStyle &Style) {
  20. DEBUG(llvm::errs() << "---\n");
  21. DEBUG(llvm::errs() << Code << "\n\n");
  22. std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length));
  23. tooling::Replacements Replaces = reformat(Style, Code, Ranges);
  24. auto Result = applyAllReplacements(Code, Replaces);
  25. EXPECT_TRUE(static_cast<bool>(Result));
  26. DEBUG(llvm::errs() << "\n" << *Result << "\n\n");
  27. return *Result;
  28. }
  29. static std::string
  30. format(llvm::StringRef Code,
  31. const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_Java)) {
  32. return format(Code, 0, Code.size(), Style);
  33. }
  34. static FormatStyle getStyleWithColumns(unsigned ColumnLimit) {
  35. FormatStyle Style = getGoogleStyle(FormatStyle::LK_Java);
  36. Style.ColumnLimit = ColumnLimit;
  37. return Style;
  38. }
  39. static void verifyFormat(
  40. llvm::StringRef Code,
  41. const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_Java)) {
  42. EXPECT_EQ(Code.str(), format(test::messUp(Code), Style));
  43. }
  44. };
  45. TEST_F(FormatTestJava, NoAlternativeOperatorNames) {
  46. verifyFormat("someObject.and();");
  47. }
  48. TEST_F(FormatTestJava, UnderstandsCasts) {
  49. verifyFormat("a[b >> 1] = (byte) (c() << 4);");
  50. }
  51. TEST_F(FormatTestJava, FormatsInstanceOfLikeOperators) {
  52. FormatStyle Style = getStyleWithColumns(50);
  53. verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n"
  54. " instanceof bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;",
  55. Style);
  56. Style.BreakBeforeBinaryOperators = FormatStyle::BOS_None;
  57. verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaa instanceof\n"
  58. " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;",
  59. Style);
  60. verifyFormat("return aaaaaaaaaaaaaaaaaaa instanceof bbbbbbbbbbbbbbbbbbbbbbb\n"
  61. " && ccccccccccccccccccc instanceof dddddddddddddddddddddd;");
  62. }
  63. TEST_F(FormatTestJava, Chromium) {
  64. verifyFormat("class SomeClass {\n"
  65. " void f() {}\n"
  66. " int g() {\n"
  67. " return 0;\n"
  68. " }\n"
  69. " void h() {\n"
  70. " while (true) f();\n"
  71. " for (;;) f();\n"
  72. " if (true) f();\n"
  73. " }\n"
  74. "}",
  75. getChromiumStyle(FormatStyle::LK_Java));
  76. }
  77. TEST_F(FormatTestJava, QualifiedNames) {
  78. verifyFormat("public some.package.Type someFunction( // comment\n"
  79. " int parameter) {}");
  80. }
  81. TEST_F(FormatTestJava, ClassKeyword) {
  82. verifyFormat("SomeClass.class.getName();");
  83. verifyFormat("Class c = SomeClass.class;");
  84. }
  85. TEST_F(FormatTestJava, ClassDeclarations) {
  86. verifyFormat("public class SomeClass {\n"
  87. " private int a;\n"
  88. " private int b;\n"
  89. "}");
  90. verifyFormat("public class A {\n"
  91. " class B {\n"
  92. " int i;\n"
  93. " }\n"
  94. " class C {\n"
  95. " int j;\n"
  96. " }\n"
  97. "}");
  98. verifyFormat("public class A extends B.C {}");
  99. verifyFormat("abstract class SomeClass\n"
  100. " extends SomeOtherClass implements SomeInterface {}",
  101. getStyleWithColumns(60));
  102. verifyFormat("abstract class SomeClass extends SomeOtherClass\n"
  103. " implements SomeInterfaceeeeeeeeeeeee {}",
  104. getStyleWithColumns(60));
  105. verifyFormat("abstract class SomeClass\n"
  106. " extends SomeOtherClass\n"
  107. " implements SomeInterface {}",
  108. getStyleWithColumns(40));
  109. verifyFormat("abstract class SomeClass\n"
  110. " extends SomeOtherClass\n"
  111. " implements SomeInterface,\n"
  112. " AnotherInterface {}",
  113. getStyleWithColumns(40));
  114. verifyFormat("abstract class SomeClass\n"
  115. " implements SomeInterface, AnotherInterface {}",
  116. getStyleWithColumns(60));
  117. verifyFormat("@SomeAnnotation()\n"
  118. "abstract class aaaaaaaaaaaa\n"
  119. " extends bbbbbbbbbbbbbbb implements cccccccccccc {}",
  120. getStyleWithColumns(76));
  121. verifyFormat("@SomeAnnotation()\n"
  122. "abstract class aaaaaaaaa<a>\n"
  123. " extends bbbbbbbbbbbb<b> implements cccccccccccc {}",
  124. getStyleWithColumns(76));
  125. verifyFormat("interface SomeInterface<A> extends Foo, Bar {\n"
  126. " void doStuff(int theStuff);\n"
  127. " void doMoreStuff(int moreStuff);\n"
  128. "}");
  129. verifyFormat("public interface SomeInterface {\n"
  130. " void doStuff(int theStuff);\n"
  131. " void doMoreStuff(int moreStuff);\n"
  132. "}");
  133. verifyFormat("@interface SomeInterface {\n"
  134. " void doStuff(int theStuff);\n"
  135. " void doMoreStuff(int moreStuff);\n"
  136. "}");
  137. verifyFormat("public @interface SomeInterface {\n"
  138. " void doStuff(int theStuff);\n"
  139. " void doMoreStuff(int moreStuff);\n"
  140. "}");
  141. }
  142. TEST_F(FormatTestJava, AnonymousClasses) {
  143. verifyFormat("return new A() {\n"
  144. " public String toString() {\n"
  145. " return \"NotReallyA\";\n"
  146. " }\n"
  147. "};");
  148. verifyFormat("A a = new A() {\n"
  149. " public String toString() {\n"
  150. " return \"NotReallyA\";\n"
  151. " }\n"
  152. "};");
  153. }
  154. TEST_F(FormatTestJava, EnumDeclarations) {
  155. verifyFormat("enum SomeThing { ABC, CDE }");
  156. verifyFormat("enum SomeThing {\n"
  157. " ABC,\n"
  158. " CDE,\n"
  159. "}");
  160. verifyFormat("public class SomeClass {\n"
  161. " enum SomeThing { ABC, CDE }\n"
  162. " void f() {}\n"
  163. "}");
  164. verifyFormat("public class SomeClass implements SomeInterface {\n"
  165. " enum SomeThing { ABC, CDE }\n"
  166. " void f() {}\n"
  167. "}");
  168. verifyFormat("enum SomeThing {\n"
  169. " ABC,\n"
  170. " CDE;\n"
  171. " void f() {}\n"
  172. "}");
  173. verifyFormat("enum SomeThing {\n"
  174. " ABC(1, \"ABC\"),\n"
  175. " CDE(2, \"CDE\");\n"
  176. " Something(int i, String s) {}\n"
  177. "}");
  178. verifyFormat("enum SomeThing {\n"
  179. " ABC(new int[] {1, 2}),\n"
  180. " CDE(new int[] {2, 3});\n"
  181. " Something(int[] i) {}\n"
  182. "}");
  183. verifyFormat("public enum SomeThing {\n"
  184. " ABC {\n"
  185. " public String toString() {\n"
  186. " return \"ABC\";\n"
  187. " }\n"
  188. " },\n"
  189. " CDE {\n"
  190. " @Override\n"
  191. " public String toString() {\n"
  192. " return \"CDE\";\n"
  193. " }\n"
  194. " };\n"
  195. " public void f() {}\n"
  196. "}");
  197. verifyFormat("private enum SomeEnum implements Foo<?, B> {\n"
  198. " ABC {\n"
  199. " @Override\n"
  200. " public String toString() {\n"
  201. " return \"ABC\";\n"
  202. " }\n"
  203. " },\n"
  204. " CDE {\n"
  205. " @Override\n"
  206. " public String toString() {\n"
  207. " return \"CDE\";\n"
  208. " }\n"
  209. " };\n"
  210. "}");
  211. }
  212. TEST_F(FormatTestJava, ArrayInitializers) {
  213. verifyFormat("new int[] {1, 2, 3, 4};");
  214. verifyFormat("new int[] {\n"
  215. " 1, 2, 3, 4,\n"
  216. "};");
  217. FormatStyle Style = getStyleWithColumns(65);
  218. Style.Cpp11BracedListStyle = false;
  219. verifyFormat(
  220. "expected = new int[] { 10, 10, 10, 10, 10, 10, 10, 10, 10, 10,\n"
  221. " 100, 100, 100, 100, 100, 100, 100, 100, 100, 100 };",
  222. Style);
  223. }
  224. TEST_F(FormatTestJava, ThrowsDeclarations) {
  225. verifyFormat("public void doSooooooooooooooooooooooooooomething()\n"
  226. " throws LooooooooooooooooooooooooooooongException {}");
  227. verifyFormat("public void doSooooooooooooooooooooooooooomething()\n"
  228. " throws LoooooooooongException, LooooooooooongException {}");
  229. }
  230. TEST_F(FormatTestJava, Annotations) {
  231. verifyFormat("@Override\n"
  232. "public String toString() {}");
  233. verifyFormat("@Override\n"
  234. "@Nullable\n"
  235. "public String getNameIfPresent() {}");
  236. verifyFormat("@Override // comment\n"
  237. "@Nullable\n"
  238. "public String getNameIfPresent() {}");
  239. verifyFormat("@java.lang.Override // comment\n"
  240. "@Nullable\n"
  241. "public String getNameIfPresent() {}");
  242. verifyFormat("@SuppressWarnings(value = \"unchecked\")\n"
  243. "public void doSomething() {}");
  244. verifyFormat("@SuppressWarnings(value = \"unchecked\")\n"
  245. "@Author(name = \"abc\")\n"
  246. "public void doSomething() {}");
  247. verifyFormat("DoSomething(new A() {\n"
  248. " @Override\n"
  249. " public String toString() {}\n"
  250. "});");
  251. verifyFormat("void SomeFunction(@Nullable String something) {}");
  252. verifyFormat("void SomeFunction(@org.llvm.Nullable String something) {}");
  253. verifyFormat("@Partial @Mock DataLoader loader;");
  254. verifyFormat("@Partial\n"
  255. "@Mock\n"
  256. "DataLoader loader;",
  257. getChromiumStyle(FormatStyle::LK_Java));
  258. verifyFormat("@SuppressWarnings(value = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\")\n"
  259. "public static int iiiiiiiiiiiiiiiiiiiiiiii;");
  260. verifyFormat("@SomeAnnotation(\"With some really looooooooooooooong text\")\n"
  261. "private static final long something = 0L;");
  262. verifyFormat("@org.llvm.Qualified(\"With some really looooooooooong text\")\n"
  263. "private static final long something = 0L;");
  264. verifyFormat("@Mock\n"
  265. "DataLoader loooooooooooooooooooooooader =\n"
  266. " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;",
  267. getStyleWithColumns(60));
  268. verifyFormat("@org.llvm.QualifiedMock\n"
  269. "DataLoader loooooooooooooooooooooooader =\n"
  270. " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;",
  271. getStyleWithColumns(60));
  272. verifyFormat("@Test(a)\n"
  273. "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n"
  274. " aaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa);");
  275. verifyFormat("@SomeAnnotation(\n"
  276. " aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa)\n"
  277. "int i;",
  278. getStyleWithColumns(50));
  279. verifyFormat("@Test\n"
  280. "ReturnType doSomething(\n"
  281. " String aaaaaaaaaaaaa, String bbbbbbbbbbbbbbb) {}",
  282. getStyleWithColumns(60));
  283. verifyFormat("{\n"
  284. " boolean someFunction(\n"
  285. " @Param(aaaaaaaaaaaaaaaa) String aaaaa,\n"
  286. " String bbbbbbbbbbbbbbb) {}\n"
  287. "}",
  288. getStyleWithColumns(60));
  289. verifyFormat("@Annotation(\"Some\"\n"
  290. " + \" text\")\n"
  291. "List<Integer> list;");
  292. }
  293. TEST_F(FormatTestJava, Generics) {
  294. verifyFormat("Iterable<?> a;");
  295. verifyFormat("Iterable<?> a;");
  296. verifyFormat("Iterable<? extends SomeObject> a;");
  297. verifyFormat("A.<B>doSomething();");
  298. verifyFormat("@Override\n"
  299. "public Map<String, ?> getAll() {}");
  300. verifyFormat("public <R> ArrayList<R> get() {}");
  301. verifyFormat("protected <R> ArrayList<R> get() {}");
  302. verifyFormat("private <R> ArrayList<R> get() {}");
  303. verifyFormat("public static <R> ArrayList<R> get() {}");
  304. verifyFormat("public static native <R> ArrayList<R> get();");
  305. verifyFormat("public final <X> Foo foo() {}");
  306. verifyFormat("public abstract <X> Foo foo();");
  307. verifyFormat("<T extends B> T getInstance(Class<T> type);");
  308. verifyFormat("Function<F, ? extends T> function;");
  309. verifyFormat("private Foo<X, Y>[] foos;");
  310. verifyFormat("Foo<X, Y>[] foos = this.foos;");
  311. verifyFormat("return (a instanceof List<?>)\n"
  312. " ? aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n"
  313. " : aaaaaaaaaaaaaaaaaaaaaaa;",
  314. getStyleWithColumns(60));
  315. verifyFormat(
  316. "SomeLoooooooooooooooooooooongType name =\n"
  317. " SomeType.foo(someArgument)\n"
  318. " .<X>method()\n"
  319. " .aaaaaaaaaaaaaaaaaaa()\n"
  320. " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();");
  321. }
  322. TEST_F(FormatTestJava, StringConcatenation) {
  323. verifyFormat("String someString = \"abc\"\n"
  324. " + \"cde\";");
  325. }
  326. TEST_F(FormatTestJava, TryCatchFinally) {
  327. verifyFormat("try {\n"
  328. " Something();\n"
  329. "} catch (SomeException e) {\n"
  330. " HandleException(e);\n"
  331. "}");
  332. verifyFormat("try {\n"
  333. " Something();\n"
  334. "} finally {\n"
  335. " AlwaysDoThis();\n"
  336. "}");
  337. verifyFormat("try {\n"
  338. " Something();\n"
  339. "} catch (SomeException e) {\n"
  340. " HandleException(e);\n"
  341. "} finally {\n"
  342. " AlwaysDoThis();\n"
  343. "}");
  344. verifyFormat("try {\n"
  345. " Something();\n"
  346. "} catch (SomeException | OtherException e) {\n"
  347. " HandleException(e);\n"
  348. "}");
  349. }
  350. TEST_F(FormatTestJava, TryWithResources) {
  351. verifyFormat("try (SomeResource rs = someFunction()) {\n"
  352. " Something();\n"
  353. "}");
  354. verifyFormat("try (SomeResource rs = someFunction()) {\n"
  355. " Something();\n"
  356. "} catch (SomeException e) {\n"
  357. " HandleException(e);\n"
  358. "}");
  359. }
  360. TEST_F(FormatTestJava, SynchronizedKeyword) {
  361. verifyFormat("synchronized (mData) {\n"
  362. " // ...\n"
  363. "}");
  364. }
  365. TEST_F(FormatTestJava, AssertKeyword) {
  366. verifyFormat("assert a && b;");
  367. }
  368. TEST_F(FormatTestJava, PackageDeclarations) {
  369. verifyFormat("package some.really.loooooooooooooooooooooong.package;",
  370. getStyleWithColumns(50));
  371. }
  372. TEST_F(FormatTestJava, ImportDeclarations) {
  373. verifyFormat("import some.really.loooooooooooooooooooooong.imported.Class;",
  374. getStyleWithColumns(50));
  375. verifyFormat("import static some.really.looooooooooooooooong.imported.Class;",
  376. getStyleWithColumns(50));
  377. }
  378. TEST_F(FormatTestJava, MethodDeclarations) {
  379. verifyFormat("void methodName(Object arg1,\n"
  380. " Object arg2, Object arg3) {}",
  381. getStyleWithColumns(40));
  382. verifyFormat("void methodName(\n"
  383. " Object arg1, Object arg2) {}",
  384. getStyleWithColumns(40));
  385. }
  386. TEST_F(FormatTestJava, CppKeywords) {
  387. verifyFormat("public void union(Type a, Type b);");
  388. verifyFormat("public void struct(Object o);");
  389. verifyFormat("public void delete(Object o);");
  390. verifyFormat("return operator && (aa);");
  391. }
  392. TEST_F(FormatTestJava, NeverAlignAfterReturn) {
  393. verifyFormat("return aaaaaaaaaaaaaaaaaaa\n"
  394. " && bbbbbbbbbbbbbbbbbbb\n"
  395. " && ccccccccccccccccccc;",
  396. getStyleWithColumns(40));
  397. verifyFormat("return (result == null)\n"
  398. " ? aaaaaaaaaaaaaaaaa\n"
  399. " : bbbbbbbbbbbbbbbbb;",
  400. getStyleWithColumns(40));
  401. verifyFormat("return aaaaaaaaaaaaaaaaaaa()\n"
  402. " .bbbbbbbbbbbbbbbbbbb()\n"
  403. " .ccccccccccccccccccc();",
  404. getStyleWithColumns(40));
  405. verifyFormat("return aaaaaaaaaaaaaaaaaaa()\n"
  406. " .bbbbbbbbbbbbbbbbbbb(\n"
  407. " ccccccccccccccc)\n"
  408. " .ccccccccccccccccccc();",
  409. getStyleWithColumns(40));
  410. }
  411. TEST_F(FormatTestJava, FormatsInnerBlocks) {
  412. verifyFormat("someObject.someFunction(new Runnable() {\n"
  413. " @Override\n"
  414. " public void run() {\n"
  415. " System.out.println(42);\n"
  416. " }\n"
  417. "}, someOtherParameter);");
  418. verifyFormat("someFunction(new Runnable() {\n"
  419. " public void run() {\n"
  420. " System.out.println(42);\n"
  421. " }\n"
  422. "});");
  423. verifyFormat("someObject.someFunction(\n"
  424. " new Runnable() {\n"
  425. " @Override\n"
  426. " public void run() {\n"
  427. " System.out.println(42);\n"
  428. " }\n"
  429. " },\n"
  430. " new Runnable() {\n"
  431. " @Override\n"
  432. " public void run() {\n"
  433. " System.out.println(43);\n"
  434. " }\n"
  435. " },\n"
  436. " someOtherParameter);");
  437. }
  438. TEST_F(FormatTestJava, FormatsLambdas) {
  439. verifyFormat("(aaaaaaaaaa, bbbbbbbbbb) -> aaaaaaaaaa + bbbbbbbbbb;");
  440. verifyFormat("(aaaaaaaaaa, bbbbbbbbbb)\n"
  441. " -> aaaaaaaaaa + bbbbbbbbbb;",
  442. getStyleWithColumns(40));
  443. verifyFormat("Runnable someLambda = () -> DoSomething();");
  444. verifyFormat("Runnable someLambda = () -> {\n"
  445. " DoSomething();\n"
  446. "}");
  447. verifyFormat("Runnable someLambda =\n"
  448. " (int aaaaa) -> DoSomething(aaaaa);",
  449. getStyleWithColumns(40));
  450. }
  451. TEST_F(FormatTestJava, BreaksStringLiterals) {
  452. // FIXME: String literal breaking is currently disabled for Java and JS, as it
  453. // requires strings to be merged using "+" which we don't support.
  454. EXPECT_EQ("\"some text other\";",
  455. format("\"some text other\";", getStyleWithColumns(14)));
  456. }
  457. TEST_F(FormatTestJava, AlignsBlockComments) {
  458. EXPECT_EQ("/*\n"
  459. " * Really multi-line\n"
  460. " * comment.\n"
  461. " */\n"
  462. "void f() {}",
  463. format(" /*\n"
  464. " * Really multi-line\n"
  465. " * comment.\n"
  466. " */\n"
  467. " void f() {}"));
  468. }
  469. } // end namespace tooling
  470. } // end namespace clang