RefactoringTest.cpp 63 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724
  1. //===- unittest/Tooling/RefactoringTest.cpp - Refactoring unit tests ------===//
  2. //
  3. // The LLVM Compiler Infrastructure
  4. //
  5. // This file is distributed under the University of Illinois Open Source
  6. // License. See LICENSE.TXT for details.
  7. //
  8. //===----------------------------------------------------------------------===//
  9. #include "ReplacementTest.h"
  10. #include "RewriterTestContext.h"
  11. #include "clang/AST/ASTConsumer.h"
  12. #include "clang/AST/ASTContext.h"
  13. #include "clang/AST/DeclCXX.h"
  14. #include "clang/AST/DeclGroup.h"
  15. #include "clang/AST/RecursiveASTVisitor.h"
  16. #include "clang/Basic/Diagnostic.h"
  17. #include "clang/Basic/DiagnosticOptions.h"
  18. #include "clang/Basic/FileManager.h"
  19. #include "clang/Basic/LangOptions.h"
  20. #include "clang/Basic/SourceManager.h"
  21. #include "clang/Basic/VirtualFileSystem.h"
  22. #include "clang/Format/Format.h"
  23. #include "clang/Frontend/CompilerInstance.h"
  24. #include "clang/Frontend/FrontendAction.h"
  25. #include "clang/Frontend/TextDiagnosticPrinter.h"
  26. #include "clang/Rewrite/Core/Rewriter.h"
  27. #include "clang/Tooling/Refactoring.h"
  28. #include "clang/Tooling/Refactoring/AtomicChange.h"
  29. #include "clang/Tooling/Tooling.h"
  30. #include "llvm/ADT/SmallString.h"
  31. #include "gtest/gtest.h"
  32. namespace clang {
  33. namespace tooling {
  34. TEST_F(ReplacementTest, CanDeleteAllText) {
  35. FileID ID = Context.createInMemoryFile("input.cpp", "text");
  36. SourceLocation Location = Context.getLocation(ID, 1, 1);
  37. Replacement Replace(createReplacement(Location, 4, ""));
  38. EXPECT_TRUE(Replace.apply(Context.Rewrite));
  39. EXPECT_EQ("", Context.getRewrittenText(ID));
  40. }
  41. TEST_F(ReplacementTest, CanDeleteAllTextInTextWithNewlines) {
  42. FileID ID = Context.createInMemoryFile("input.cpp", "line1\nline2\nline3");
  43. SourceLocation Location = Context.getLocation(ID, 1, 1);
  44. Replacement Replace(createReplacement(Location, 17, ""));
  45. EXPECT_TRUE(Replace.apply(Context.Rewrite));
  46. EXPECT_EQ("", Context.getRewrittenText(ID));
  47. }
  48. TEST_F(ReplacementTest, CanAddText) {
  49. FileID ID = Context.createInMemoryFile("input.cpp", "");
  50. SourceLocation Location = Context.getLocation(ID, 1, 1);
  51. Replacement Replace(createReplacement(Location, 0, "result"));
  52. EXPECT_TRUE(Replace.apply(Context.Rewrite));
  53. EXPECT_EQ("result", Context.getRewrittenText(ID));
  54. }
  55. TEST_F(ReplacementTest, CanReplaceTextAtPosition) {
  56. FileID ID = Context.createInMemoryFile("input.cpp",
  57. "line1\nline2\nline3\nline4");
  58. SourceLocation Location = Context.getLocation(ID, 2, 3);
  59. Replacement Replace(createReplacement(Location, 12, "x"));
  60. EXPECT_TRUE(Replace.apply(Context.Rewrite));
  61. EXPECT_EQ("line1\nlixne4", Context.getRewrittenText(ID));
  62. }
  63. TEST_F(ReplacementTest, CanReplaceTextAtPositionMultipleTimes) {
  64. FileID ID = Context.createInMemoryFile("input.cpp",
  65. "line1\nline2\nline3\nline4");
  66. SourceLocation Location1 = Context.getLocation(ID, 2, 3);
  67. Replacement Replace1(createReplacement(Location1, 12, "x\ny\n"));
  68. EXPECT_TRUE(Replace1.apply(Context.Rewrite));
  69. EXPECT_EQ("line1\nlix\ny\nne4", Context.getRewrittenText(ID));
  70. // Since the original source has not been modified, the (4, 4) points to the
  71. // 'e' in the original content.
  72. SourceLocation Location2 = Context.getLocation(ID, 4, 4);
  73. Replacement Replace2(createReplacement(Location2, 1, "f"));
  74. EXPECT_TRUE(Replace2.apply(Context.Rewrite));
  75. EXPECT_EQ("line1\nlix\ny\nnf4", Context.getRewrittenText(ID));
  76. }
  77. TEST_F(ReplacementTest, ApplyFailsForNonExistentLocation) {
  78. Replacement Replace("nonexistent-file.cpp", 0, 1, "");
  79. EXPECT_FALSE(Replace.apply(Context.Rewrite));
  80. }
  81. TEST_F(ReplacementTest, CanRetrivePath) {
  82. Replacement Replace("/path/to/file.cpp", 0, 1, "");
  83. EXPECT_EQ("/path/to/file.cpp", Replace.getFilePath());
  84. }
  85. TEST_F(ReplacementTest, ReturnsInvalidPath) {
  86. Replacement Replace1(Context.Sources, SourceLocation(), 0, "");
  87. EXPECT_TRUE(Replace1.getFilePath().empty());
  88. Replacement Replace2;
  89. EXPECT_TRUE(Replace2.getFilePath().empty());
  90. }
  91. // Checks that an llvm::Error instance contains a ReplacementError with expected
  92. // error code, expected new replacement, and expected existing replacement.
  93. static bool checkReplacementError(llvm::Error &&Error,
  94. replacement_error ExpectedErr,
  95. llvm::Optional<Replacement> ExpectedExisting,
  96. llvm::Optional<Replacement> ExpectedNew) {
  97. if (!Error) {
  98. llvm::errs() << "Error is a success.";
  99. return false;
  100. }
  101. std::string ErrorMessage;
  102. llvm::raw_string_ostream OS(ErrorMessage);
  103. llvm::handleAllErrors(std::move(Error), [&](const ReplacementError &RE) {
  104. llvm::errs() << "Handling error...\n";
  105. if (ExpectedErr != RE.get())
  106. OS << "Unexpected error code: " << int(RE.get()) << "\n";
  107. if (ExpectedExisting != RE.getExistingReplacement()) {
  108. OS << "Expected Existing != Actual Existing.\n";
  109. if (ExpectedExisting.hasValue())
  110. OS << "Expected existing replacement: " << ExpectedExisting->toString()
  111. << "\n";
  112. if (RE.getExistingReplacement().hasValue())
  113. OS << "Actual existing replacement: "
  114. << RE.getExistingReplacement()->toString() << "\n";
  115. }
  116. if (ExpectedNew != RE.getNewReplacement()) {
  117. OS << "Expected New != Actual New.\n";
  118. if (ExpectedNew.hasValue())
  119. OS << "Expected new replacement: " << ExpectedNew->toString() << "\n";
  120. if (RE.getNewReplacement().hasValue())
  121. OS << "Actual new replacement: " << RE.getNewReplacement()->toString()
  122. << "\n";
  123. }
  124. });
  125. OS.flush();
  126. if (ErrorMessage.empty()) return true;
  127. llvm::errs() << ErrorMessage;
  128. return false;
  129. }
  130. TEST_F(ReplacementTest, FailAddReplacements) {
  131. Replacements Replaces;
  132. Replacement Deletion("x.cc", 0, 10, "3");
  133. auto Err = Replaces.add(Deletion);
  134. EXPECT_TRUE(!Err);
  135. llvm::consumeError(std::move(Err));
  136. Replacement OverlappingReplacement("x.cc", 0, 2, "a");
  137. Err = Replaces.add(OverlappingReplacement);
  138. EXPECT_TRUE(checkReplacementError(std::move(Err),
  139. replacement_error::overlap_conflict,
  140. Deletion, OverlappingReplacement));
  141. Replacement ContainedReplacement("x.cc", 2, 2, "a");
  142. Err = Replaces.add(Replacement(ContainedReplacement));
  143. EXPECT_TRUE(checkReplacementError(std::move(Err),
  144. replacement_error::overlap_conflict,
  145. Deletion, ContainedReplacement));
  146. Replacement WrongPathReplacement("y.cc", 20, 2, "");
  147. Err = Replaces.add(WrongPathReplacement);
  148. EXPECT_TRUE(checkReplacementError(std::move(Err),
  149. replacement_error::wrong_file_path,
  150. Deletion, WrongPathReplacement));
  151. EXPECT_EQ(1u, Replaces.size());
  152. EXPECT_EQ(Deletion, *Replaces.begin());
  153. }
  154. TEST_F(ReplacementTest, DeletionInReplacements) {
  155. Replacements Replaces;
  156. Replacement R("x.cc", 0, 10, "3");
  157. auto Err = Replaces.add(R);
  158. EXPECT_TRUE(!Err);
  159. llvm::consumeError(std::move(Err));
  160. Err = Replaces.add(Replacement("x.cc", 0, 2, ""));
  161. EXPECT_TRUE(!Err);
  162. llvm::consumeError(std::move(Err));
  163. Err = Replaces.add(Replacement("x.cc", 2, 2, ""));
  164. EXPECT_TRUE(!Err);
  165. llvm::consumeError(std::move(Err));
  166. EXPECT_EQ(1u, Replaces.size());
  167. EXPECT_EQ(R, *Replaces.begin());
  168. }
  169. TEST_F(ReplacementTest, OverlappingReplacements) {
  170. Replacements Replaces;
  171. auto Err = Replaces.add(Replacement("x.cc", 0, 3, "345"));
  172. EXPECT_TRUE(!Err);
  173. llvm::consumeError(std::move(Err));
  174. Err = Replaces.add(Replacement("x.cc", 2, 3, "543"));
  175. EXPECT_TRUE(!Err);
  176. llvm::consumeError(std::move(Err));
  177. EXPECT_EQ(1u, Replaces.size());
  178. EXPECT_EQ(Replacement("x.cc", 0, 5, "34543"), *Replaces.begin());
  179. Err = Replaces.add(Replacement("x.cc", 2, 1, "5"));
  180. EXPECT_TRUE(!Err);
  181. llvm::consumeError(std::move(Err));
  182. EXPECT_EQ(1u, Replaces.size());
  183. EXPECT_EQ(Replacement("x.cc", 0, 5, "34543"), *Replaces.begin());
  184. }
  185. TEST_F(ReplacementTest, AddAdjacentInsertionAndReplacement) {
  186. Replacements Replaces;
  187. // Test adding an insertion at the offset of an existing replacement.
  188. auto Err = Replaces.add(Replacement("x.cc", 10, 3, "replace"));
  189. EXPECT_TRUE(!Err);
  190. llvm::consumeError(std::move(Err));
  191. Err = Replaces.add(Replacement("x.cc", 10, 0, "insert"));
  192. EXPECT_TRUE(!Err);
  193. llvm::consumeError(std::move(Err));
  194. EXPECT_EQ(Replaces.size(), 2u);
  195. Replaces.clear();
  196. // Test overlap with an existing insertion.
  197. Err = Replaces.add(Replacement("x.cc", 10, 0, "insert"));
  198. EXPECT_TRUE(!Err);
  199. llvm::consumeError(std::move(Err));
  200. Err = Replaces.add(Replacement("x.cc", 10, 3, "replace"));
  201. EXPECT_TRUE(!Err);
  202. llvm::consumeError(std::move(Err));
  203. EXPECT_EQ(Replaces.size(), 2u);
  204. }
  205. TEST_F(ReplacementTest, MergeNewDeletions) {
  206. Replacements Replaces;
  207. Replacement ContainingReplacement("x.cc", 0, 10, "");
  208. auto Err = Replaces.add(ContainingReplacement);
  209. EXPECT_TRUE(!Err);
  210. llvm::consumeError(std::move(Err));
  211. Err = Replaces.add(Replacement("x.cc", 5, 3, ""));
  212. EXPECT_TRUE(!Err);
  213. llvm::consumeError(std::move(Err));
  214. Err = Replaces.add(Replacement("x.cc", 0, 10, ""));
  215. EXPECT_TRUE(!Err);
  216. llvm::consumeError(std::move(Err));
  217. Err = Replaces.add(Replacement("x.cc", 5, 5, ""));
  218. EXPECT_TRUE(!Err);
  219. llvm::consumeError(std::move(Err));
  220. EXPECT_EQ(1u, Replaces.size());
  221. EXPECT_EQ(*Replaces.begin(), ContainingReplacement);
  222. }
  223. TEST_F(ReplacementTest, MergeOverlappingButNotAdjacentReplacement) {
  224. Replacements Replaces;
  225. auto Err = Replaces.add(Replacement("x.cc", 0, 2, ""));
  226. EXPECT_TRUE(!Err);
  227. llvm::consumeError(std::move(Err));
  228. Err = Replaces.add(Replacement("x.cc", 5, 5, ""));
  229. EXPECT_TRUE(!Err);
  230. llvm::consumeError(std::move(Err));
  231. Replacement After = Replacement("x.cc", 10, 5, "");
  232. Err = Replaces.add(After);
  233. EXPECT_TRUE(!Err);
  234. llvm::consumeError(std::move(Err));
  235. Replacement ContainingReplacement("x.cc", 0, 10, "");
  236. Err = Replaces.add(ContainingReplacement);
  237. EXPECT_TRUE(!Err);
  238. llvm::consumeError(std::move(Err));
  239. EXPECT_EQ(2u, Replaces.size());
  240. EXPECT_EQ(*Replaces.begin(), ContainingReplacement);
  241. EXPECT_EQ(*(++Replaces.begin()), After);
  242. }
  243. TEST_F(ReplacementTest, InsertionBeforeMergedDeletions) {
  244. Replacements Replaces;
  245. Replacement Insertion("x.cc", 0, 0, "123");
  246. auto Err = Replaces.add(Insertion);
  247. EXPECT_TRUE(!Err);
  248. llvm::consumeError(std::move(Err));
  249. Err = Replaces.add(Replacement("x.cc", 5, 5, ""));
  250. EXPECT_TRUE(!Err);
  251. llvm::consumeError(std::move(Err));
  252. Replacement Deletion("x.cc", 0, 10, "");
  253. Err = Replaces.add(Deletion);
  254. EXPECT_TRUE(!Err);
  255. llvm::consumeError(std::move(Err));
  256. EXPECT_EQ(2u, Replaces.size());
  257. EXPECT_EQ(*Replaces.begin(), Insertion);
  258. EXPECT_EQ(*(++Replaces.begin()), Deletion);
  259. }
  260. TEST_F(ReplacementTest, MergeOverlappingDeletions) {
  261. Replacements Replaces;
  262. auto Err = Replaces.add(Replacement("x.cc", 0, 2, ""));
  263. EXPECT_TRUE(!Err);
  264. llvm::consumeError(std::move(Err));
  265. Err = Replaces.add(Replacement("x.cc", 0, 5, ""));
  266. EXPECT_TRUE(!Err);
  267. llvm::consumeError(std::move(Err));
  268. EXPECT_EQ(1u, Replaces.size());
  269. EXPECT_EQ(Replacement("x.cc", 0, 5, ""), *Replaces.begin());
  270. Err = Replaces.add(Replacement("x.cc", 1, 5, ""));
  271. EXPECT_TRUE(!Err);
  272. llvm::consumeError(std::move(Err));
  273. EXPECT_EQ(1u, Replaces.size());
  274. EXPECT_EQ(Replacement("x.cc", 0, 6, ""), *Replaces.begin());
  275. }
  276. TEST_F(ReplacementTest, FailedMergeExistingDeletions) {
  277. Replacements Replaces;
  278. Replacement First("x.cc", 0, 2, "");
  279. auto Err = Replaces.add(First);
  280. EXPECT_TRUE(!Err);
  281. llvm::consumeError(std::move(Err));
  282. Replacement Second("x.cc", 5, 5, "");
  283. Err = Replaces.add(Second);
  284. EXPECT_TRUE(!Err);
  285. llvm::consumeError(std::move(Err));
  286. Err = Replaces.add(Replacement("x.cc", 1, 10, ""));
  287. EXPECT_TRUE(!Err);
  288. llvm::consumeError(std::move(Err));
  289. EXPECT_EQ(1u, Replaces.size());
  290. EXPECT_EQ(Replacement("x.cc", 0, 11, ""), *Replaces.begin());
  291. }
  292. TEST_F(ReplacementTest, FailAddRegression) {
  293. Replacements Replaces;
  294. // Create two replacements, where the second one is an insertion of the empty
  295. // string exactly at the end of the first one.
  296. auto Err = Replaces.add(Replacement("x.cc", 0, 10, "1"));
  297. EXPECT_TRUE(!Err);
  298. llvm::consumeError(std::move(Err));
  299. Err = Replaces.add(Replacement("x.cc", 10, 0, ""));
  300. EXPECT_TRUE(!Err);
  301. llvm::consumeError(std::move(Err));
  302. // Make sure we find the overlap with the first entry when inserting a
  303. // replacement that ends exactly at the seam of the existing replacements.
  304. Replacement OverlappingReplacement("x.cc", 5, 5, "fail");
  305. Err = Replaces.add(OverlappingReplacement);
  306. EXPECT_TRUE(checkReplacementError(std::move(Err),
  307. replacement_error::overlap_conflict,
  308. *Replaces.begin(), OverlappingReplacement));
  309. Err = Replaces.add(Replacement("x.cc", 10, 0, ""));
  310. EXPECT_TRUE(!Err);
  311. llvm::consumeError(std::move(Err));
  312. }
  313. TEST_F(ReplacementTest, InsertAtOffsetOfReplacement) {
  314. Replacements Replaces;
  315. auto Err = Replaces.add(Replacement("x.cc", 10, 2, ""));
  316. EXPECT_TRUE(!Err);
  317. llvm::consumeError(std::move(Err));
  318. Err = Replaces.add(Replacement("x.cc", 10, 0, ""));
  319. EXPECT_TRUE(!Err);
  320. llvm::consumeError(std::move(Err));
  321. EXPECT_EQ(Replaces.size(), 2u);
  322. Replaces.clear();
  323. Err = Replaces.add(Replacement("x.cc", 10, 0, ""));
  324. EXPECT_TRUE(!Err);
  325. llvm::consumeError(std::move(Err));
  326. Err = Replaces.add(Replacement("x.cc", 10, 2, ""));
  327. EXPECT_TRUE(!Err);
  328. llvm::consumeError(std::move(Err));
  329. EXPECT_EQ(Replaces.size(), 2u);
  330. }
  331. TEST_F(ReplacementTest, AddInsertAtOtherInsertWhenOderIndependent) {
  332. Replacements Replaces;
  333. auto Err = Replaces.add(Replacement("x.cc", 10, 0, "a"));
  334. EXPECT_TRUE(!Err);
  335. llvm::consumeError(std::move(Err));
  336. Replacement ConflictInsertion("x.cc", 10, 0, "b");
  337. Err = Replaces.add(ConflictInsertion);
  338. EXPECT_TRUE(checkReplacementError(std::move(Err),
  339. replacement_error::insert_conflict,
  340. *Replaces.begin(), ConflictInsertion));
  341. Replaces.clear();
  342. Err = Replaces.add(Replacement("x.cc", 10, 0, "a"));
  343. EXPECT_TRUE(!Err);
  344. llvm::consumeError(std::move(Err));
  345. Err = Replaces.add(Replacement("x.cc", 10, 0, "aa"));
  346. EXPECT_TRUE(!Err);
  347. llvm::consumeError(std::move(Err));
  348. EXPECT_EQ(1u, Replaces.size());
  349. EXPECT_EQ(Replacement("x.cc", 10, 0, "aaa"), *Replaces.begin());
  350. Replaces.clear();
  351. Err = Replaces.add(Replacement("x.cc", 10, 0, ""));
  352. EXPECT_TRUE(!Err);
  353. llvm::consumeError(std::move(Err));
  354. Err = Replaces.add(Replacement("x.cc", 10, 3, ""));
  355. EXPECT_TRUE(!Err);
  356. llvm::consumeError(std::move(Err));
  357. Err = Replaces.add(Replacement("x.cc", 10, 0, ""));
  358. EXPECT_TRUE(!Err);
  359. llvm::consumeError(std::move(Err));
  360. EXPECT_EQ(2u, Replaces.size());
  361. EXPECT_EQ(Replacement("x.cc", 10, 0, ""), *Replaces.begin());
  362. EXPECT_EQ(Replacement("x.cc", 10, 3, ""), *std::next(Replaces.begin()));
  363. }
  364. TEST_F(ReplacementTest, InsertBetweenAdjacentReplacements) {
  365. Replacements Replaces;
  366. auto Err = Replaces.add(Replacement("x.cc", 10, 5, "a"));
  367. EXPECT_TRUE(!Err);
  368. llvm::consumeError(std::move(Err));
  369. Err = Replaces.add(Replacement("x.cc", 8, 2, "a"));
  370. EXPECT_TRUE(!Err);
  371. llvm::consumeError(std::move(Err));
  372. Err = Replaces.add(Replacement("x.cc", 10, 0, "b"));
  373. EXPECT_TRUE(!Err);
  374. llvm::consumeError(std::move(Err));
  375. }
  376. TEST_F(ReplacementTest, CanApplyReplacements) {
  377. FileID ID = Context.createInMemoryFile("input.cpp",
  378. "line1\nline2\nline3\nline4");
  379. Replacements Replaces =
  380. toReplacements({Replacement(Context.Sources,
  381. Context.getLocation(ID, 2, 1), 5, "replaced"),
  382. Replacement(Context.Sources,
  383. Context.getLocation(ID, 3, 1), 5, "other")});
  384. EXPECT_TRUE(applyAllReplacements(Replaces, Context.Rewrite));
  385. EXPECT_EQ("line1\nreplaced\nother\nline4", Context.getRewrittenText(ID));
  386. }
  387. // Verifies that replacement/deletion is applied before insertion at the same
  388. // offset.
  389. TEST_F(ReplacementTest, InsertAndDelete) {
  390. FileID ID = Context.createInMemoryFile("input.cpp",
  391. "line1\nline2\nline3\nline4");
  392. Replacements Replaces = toReplacements(
  393. {Replacement(Context.Sources, Context.getLocation(ID, 2, 1), 6, ""),
  394. Replacement(Context.Sources, Context.getLocation(ID, 2, 1), 0,
  395. "other\n")});
  396. EXPECT_TRUE(applyAllReplacements(Replaces, Context.Rewrite));
  397. EXPECT_EQ("line1\nother\nline3\nline4", Context.getRewrittenText(ID));
  398. }
  399. TEST_F(ReplacementTest, AdjacentReplacements) {
  400. FileID ID = Context.createInMemoryFile("input.cpp",
  401. "ab");
  402. Replacements Replaces = toReplacements(
  403. {Replacement(Context.Sources, Context.getLocation(ID, 1, 1), 1, "x"),
  404. Replacement(Context.Sources, Context.getLocation(ID, 1, 2), 1, "y")});
  405. EXPECT_TRUE(applyAllReplacements(Replaces, Context.Rewrite));
  406. EXPECT_EQ("xy", Context.getRewrittenText(ID));
  407. }
  408. TEST_F(ReplacementTest, AddDuplicateReplacements) {
  409. FileID ID = Context.createInMemoryFile("input.cpp",
  410. "line1\nline2\nline3\nline4");
  411. auto Replaces = toReplacements({Replacement(
  412. Context.Sources, Context.getLocation(ID, 2, 1), 5, "replaced")});
  413. auto Err = Replaces.add(Replacement(
  414. Context.Sources, Context.getLocation(ID, 2, 1), 5, "replaced"));
  415. EXPECT_TRUE(!Err);
  416. llvm::consumeError(std::move(Err));
  417. Err = Replaces.add(Replacement(Context.Sources, Context.getLocation(ID, 2, 1),
  418. 5, "replaced"));
  419. EXPECT_TRUE(!Err);
  420. llvm::consumeError(std::move(Err));
  421. EXPECT_TRUE(applyAllReplacements(Replaces, Context.Rewrite));
  422. EXPECT_EQ("line1\nreplaced\nline3\nline4", Context.getRewrittenText(ID));
  423. }
  424. TEST_F(ReplacementTest, FailOrderDependentReplacements) {
  425. FileID ID = Context.createInMemoryFile("input.cpp",
  426. "line1\nline2\nline3\nline4");
  427. auto Replaces = toReplacements({Replacement(
  428. Context.Sources, Context.getLocation(ID, 2, 1), 5, "other")});
  429. Replacement ConflictReplacement(Context.Sources,
  430. Context.getLocation(ID, 2, 1), 5, "rehto");
  431. auto Err = Replaces.add(ConflictReplacement);
  432. EXPECT_TRUE(checkReplacementError(std::move(Err),
  433. replacement_error::overlap_conflict,
  434. *Replaces.begin(), ConflictReplacement));
  435. EXPECT_TRUE(applyAllReplacements(Replaces, Context.Rewrite));
  436. EXPECT_EQ("line1\nother\nline3\nline4", Context.getRewrittenText(ID));
  437. }
  438. TEST_F(ReplacementTest, InvalidSourceLocationFailsApplyAll) {
  439. Replacements Replaces =
  440. toReplacements({Replacement(Context.Sources, SourceLocation(), 5, "2")});
  441. EXPECT_FALSE(applyAllReplacements(Replaces, Context.Rewrite));
  442. }
  443. TEST_F(ReplacementTest, MultipleFilesReplaceAndFormat) {
  444. // Column limit is 20.
  445. std::string Code1 = "Long *a =\n"
  446. " new Long();\n"
  447. "long x = 1;";
  448. std::string Expected1 = "auto a = new Long();\n"
  449. "long x =\n"
  450. " 12345678901;";
  451. std::string Code2 = "int x = 123;\n"
  452. "int y = 0;";
  453. std::string Expected2 = "int x =\n"
  454. " 1234567890123;\n"
  455. "int y = 10;";
  456. StringRef File1 = "format_1.cpp";
  457. StringRef File2 = "format_2.cpp";
  458. FileID ID1 = Context.createInMemoryFile(File1, Code1);
  459. FileID ID2 = Context.createInMemoryFile(File2, Code2);
  460. // Scrambled the order of replacements.
  461. std::map<std::string, Replacements> FileToReplaces;
  462. FileToReplaces[File1] = toReplacements(
  463. {tooling::Replacement(Context.Sources, Context.getLocation(ID1, 1, 1), 6,
  464. "auto "),
  465. tooling::Replacement(Context.Sources, Context.getLocation(ID1, 3, 10), 1,
  466. "12345678901")});
  467. FileToReplaces[File2] = toReplacements(
  468. {tooling::Replacement(Context.Sources, Context.getLocation(ID2, 1, 12), 0,
  469. "4567890123"),
  470. tooling::Replacement(Context.Sources, Context.getLocation(ID2, 2, 9), 1,
  471. "10")});
  472. EXPECT_TRUE(
  473. formatAndApplyAllReplacements(FileToReplaces, Context.Rewrite,
  474. "{BasedOnStyle: LLVM, ColumnLimit: 20}"));
  475. EXPECT_EQ(Expected1, Context.getRewrittenText(ID1));
  476. EXPECT_EQ(Expected2, Context.getRewrittenText(ID2));
  477. }
  478. TEST(ShiftedCodePositionTest, FindsNewCodePosition) {
  479. Replacements Replaces =
  480. toReplacements({Replacement("", 0, 1, ""), Replacement("", 4, 3, " ")});
  481. // Assume ' int i;' is turned into 'int i;' and cursor is located at '|'.
  482. EXPECT_EQ(0u, Replaces.getShiftedCodePosition(0)); // |int i;
  483. EXPECT_EQ(0u, Replaces.getShiftedCodePosition(1)); // |nt i;
  484. EXPECT_EQ(1u, Replaces.getShiftedCodePosition(2)); // i|t i;
  485. EXPECT_EQ(2u, Replaces.getShiftedCodePosition(3)); // in| i;
  486. EXPECT_EQ(3u, Replaces.getShiftedCodePosition(4)); // int| i;
  487. EXPECT_EQ(3u, Replaces.getShiftedCodePosition(5)); // int | i;
  488. EXPECT_EQ(3u, Replaces.getShiftedCodePosition(6)); // int |i;
  489. EXPECT_EQ(4u, Replaces.getShiftedCodePosition(7)); // int |;
  490. EXPECT_EQ(5u, Replaces.getShiftedCodePosition(8)); // int i|
  491. }
  492. TEST(ShiftedCodePositionTest, FindsNewCodePositionWithInserts) {
  493. Replacements Replaces = toReplacements({Replacement("", 4, 0, "\"\n\"")});
  494. // Assume '"12345678"' is turned into '"1234"\n"5678"'.
  495. EXPECT_EQ(3u, Replaces.getShiftedCodePosition(3)); // "123|5678"
  496. EXPECT_EQ(7u, Replaces.getShiftedCodePosition(4)); // "1234|678"
  497. EXPECT_EQ(8u, Replaces.getShiftedCodePosition(5)); // "12345|78"
  498. }
  499. TEST(ShiftedCodePositionTest, FindsNewCodePositionInReplacedText) {
  500. // Replace the first four characters with "abcd".
  501. auto Replaces = toReplacements({Replacement("", 0, 4, "abcd")});
  502. for (unsigned i = 0; i < 3; ++i)
  503. EXPECT_EQ(i, Replaces.getShiftedCodePosition(i));
  504. }
  505. TEST(ShiftedCodePositionTest, NoReplacementText) {
  506. Replacements Replaces = toReplacements({Replacement("", 0, 42, "")});
  507. EXPECT_EQ(0u, Replaces.getShiftedCodePosition(0));
  508. EXPECT_EQ(0u, Replaces.getShiftedCodePosition(39));
  509. EXPECT_EQ(3u, Replaces.getShiftedCodePosition(45));
  510. EXPECT_EQ(0u, Replaces.getShiftedCodePosition(42));
  511. }
  512. class FlushRewrittenFilesTest : public ::testing::Test {
  513. public:
  514. FlushRewrittenFilesTest() {}
  515. ~FlushRewrittenFilesTest() override {
  516. for (llvm::StringMap<std::string>::iterator I = TemporaryFiles.begin(),
  517. E = TemporaryFiles.end();
  518. I != E; ++I) {
  519. llvm::StringRef Name = I->second;
  520. std::error_code EC = llvm::sys::fs::remove(Name);
  521. (void)EC;
  522. assert(!EC);
  523. }
  524. }
  525. FileID createFile(llvm::StringRef Name, llvm::StringRef Content) {
  526. SmallString<1024> Path;
  527. int FD;
  528. std::error_code EC = llvm::sys::fs::createTemporaryFile(Name, "", FD, Path);
  529. assert(!EC);
  530. (void)EC;
  531. llvm::raw_fd_ostream OutStream(FD, true);
  532. OutStream << Content;
  533. OutStream.close();
  534. const FileEntry *File = Context.Files.getFile(Path);
  535. assert(File != nullptr);
  536. StringRef Found =
  537. TemporaryFiles.insert(std::make_pair(Name, Path.str())).first->second;
  538. assert(Found == Path);
  539. (void)Found;
  540. return Context.Sources.createFileID(File, SourceLocation(), SrcMgr::C_User);
  541. }
  542. std::string getFileContentFromDisk(llvm::StringRef Name) {
  543. std::string Path = TemporaryFiles.lookup(Name);
  544. assert(!Path.empty());
  545. // We need to read directly from the FileManager without relaying through
  546. // a FileEntry, as otherwise we'd read through an already opened file
  547. // descriptor, which might not see the changes made.
  548. // FIXME: Figure out whether there is a way to get the SourceManger to
  549. // reopen the file.
  550. auto FileBuffer = Context.Files.getBufferForFile(Path);
  551. return (*FileBuffer)->getBuffer();
  552. }
  553. llvm::StringMap<std::string> TemporaryFiles;
  554. RewriterTestContext Context;
  555. };
  556. TEST_F(FlushRewrittenFilesTest, StoresChangesOnDisk) {
  557. FileID ID = createFile("input.cpp", "line1\nline2\nline3\nline4");
  558. Replacements Replaces = toReplacements({Replacement(
  559. Context.Sources, Context.getLocation(ID, 2, 1), 5, "replaced")});
  560. EXPECT_TRUE(applyAllReplacements(Replaces, Context.Rewrite));
  561. EXPECT_FALSE(Context.Rewrite.overwriteChangedFiles());
  562. EXPECT_EQ("line1\nreplaced\nline3\nline4",
  563. getFileContentFromDisk("input.cpp"));
  564. }
  565. namespace {
  566. template <typename T>
  567. class TestVisitor : public clang::RecursiveASTVisitor<T> {
  568. public:
  569. bool runOver(StringRef Code) {
  570. return runToolOnCode(new TestAction(this), Code);
  571. }
  572. protected:
  573. clang::SourceManager *SM;
  574. clang::ASTContext *Context;
  575. private:
  576. class FindConsumer : public clang::ASTConsumer {
  577. public:
  578. FindConsumer(TestVisitor *Visitor) : Visitor(Visitor) {}
  579. void HandleTranslationUnit(clang::ASTContext &Context) override {
  580. Visitor->TraverseDecl(Context.getTranslationUnitDecl());
  581. }
  582. private:
  583. TestVisitor *Visitor;
  584. };
  585. class TestAction : public clang::ASTFrontendAction {
  586. public:
  587. TestAction(TestVisitor *Visitor) : Visitor(Visitor) {}
  588. std::unique_ptr<clang::ASTConsumer>
  589. CreateASTConsumer(clang::CompilerInstance &compiler,
  590. llvm::StringRef dummy) override {
  591. Visitor->SM = &compiler.getSourceManager();
  592. Visitor->Context = &compiler.getASTContext();
  593. /// TestConsumer will be deleted by the framework calling us.
  594. return llvm::make_unique<FindConsumer>(Visitor);
  595. }
  596. private:
  597. TestVisitor *Visitor;
  598. };
  599. };
  600. } // end namespace
  601. void expectReplacementAt(const Replacement &Replace,
  602. StringRef File, unsigned Offset, unsigned Length) {
  603. ASSERT_TRUE(Replace.isApplicable());
  604. EXPECT_EQ(File, Replace.getFilePath());
  605. EXPECT_EQ(Offset, Replace.getOffset());
  606. EXPECT_EQ(Length, Replace.getLength());
  607. }
  608. class ClassDeclXVisitor : public TestVisitor<ClassDeclXVisitor> {
  609. public:
  610. bool VisitCXXRecordDecl(CXXRecordDecl *Record) {
  611. if (Record->getName() == "X") {
  612. Replace = Replacement(*SM, Record, "");
  613. }
  614. return true;
  615. }
  616. Replacement Replace;
  617. };
  618. TEST(Replacement, CanBeConstructedFromNode) {
  619. ClassDeclXVisitor ClassDeclX;
  620. EXPECT_TRUE(ClassDeclX.runOver(" class X;"));
  621. expectReplacementAt(ClassDeclX.Replace, "input.cc", 5, 7);
  622. }
  623. TEST(Replacement, ReplacesAtSpellingLocation) {
  624. ClassDeclXVisitor ClassDeclX;
  625. EXPECT_TRUE(ClassDeclX.runOver("#define A(Y) Y\nA(class X);"));
  626. expectReplacementAt(ClassDeclX.Replace, "input.cc", 17, 7);
  627. }
  628. class CallToFVisitor : public TestVisitor<CallToFVisitor> {
  629. public:
  630. bool VisitCallExpr(CallExpr *Call) {
  631. if (Call->getDirectCallee()->getName() == "F") {
  632. Replace = Replacement(*SM, Call, "");
  633. }
  634. return true;
  635. }
  636. Replacement Replace;
  637. };
  638. TEST(Replacement, FunctionCall) {
  639. CallToFVisitor CallToF;
  640. EXPECT_TRUE(CallToF.runOver("void F(); void G() { F(); }"));
  641. expectReplacementAt(CallToF.Replace, "input.cc", 21, 3);
  642. }
  643. TEST(Replacement, TemplatedFunctionCall) {
  644. CallToFVisitor CallToF;
  645. EXPECT_TRUE(CallToF.runOver(
  646. "template <typename T> void F(); void G() { F<int>(); }"));
  647. expectReplacementAt(CallToF.Replace, "input.cc", 43, 8);
  648. }
  649. class NestedNameSpecifierAVisitor
  650. : public TestVisitor<NestedNameSpecifierAVisitor> {
  651. public:
  652. bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNSLoc) {
  653. if (NNSLoc.getNestedNameSpecifier()) {
  654. if (const NamespaceDecl* NS = NNSLoc.getNestedNameSpecifier()->getAsNamespace()) {
  655. if (NS->getName() == "a") {
  656. Replace = Replacement(*SM, &NNSLoc, "", Context->getLangOpts());
  657. }
  658. }
  659. }
  660. return TestVisitor<NestedNameSpecifierAVisitor>::TraverseNestedNameSpecifierLoc(
  661. NNSLoc);
  662. }
  663. Replacement Replace;
  664. };
  665. TEST(Replacement, ColonColon) {
  666. NestedNameSpecifierAVisitor VisitNNSA;
  667. EXPECT_TRUE(VisitNNSA.runOver("namespace a { void f() { ::a::f(); } }"));
  668. expectReplacementAt(VisitNNSA.Replace, "input.cc", 25, 5);
  669. }
  670. TEST(Range, overlaps) {
  671. EXPECT_TRUE(Range(10, 10).overlapsWith(Range(0, 11)));
  672. EXPECT_TRUE(Range(0, 11).overlapsWith(Range(10, 10)));
  673. EXPECT_FALSE(Range(10, 10).overlapsWith(Range(0, 10)));
  674. EXPECT_FALSE(Range(0, 10).overlapsWith(Range(10, 10)));
  675. EXPECT_TRUE(Range(0, 10).overlapsWith(Range(2, 6)));
  676. EXPECT_TRUE(Range(2, 6).overlapsWith(Range(0, 10)));
  677. }
  678. TEST(Range, contains) {
  679. EXPECT_TRUE(Range(0, 10).contains(Range(0, 10)));
  680. EXPECT_TRUE(Range(0, 10).contains(Range(2, 6)));
  681. EXPECT_FALSE(Range(2, 6).contains(Range(0, 10)));
  682. EXPECT_FALSE(Range(0, 10).contains(Range(0, 11)));
  683. }
  684. TEST(Range, CalculateRangesOfReplacements) {
  685. // Before: aaaabbbbbbz
  686. // After : bbbbbbzzzzzzoooooooooooooooo
  687. Replacements Replaces = toReplacements(
  688. {Replacement("foo", 0, 4, ""), Replacement("foo", 10, 1, "zzzzzz"),
  689. Replacement("foo", 11, 0, "oooooooooooooooo")});
  690. std::vector<Range> Ranges = Replaces.getAffectedRanges();
  691. EXPECT_EQ(2ul, Ranges.size());
  692. EXPECT_TRUE(Ranges[0].getOffset() == 0);
  693. EXPECT_TRUE(Ranges[0].getLength() == 0);
  694. EXPECT_TRUE(Ranges[1].getOffset() == 6);
  695. EXPECT_TRUE(Ranges[1].getLength() == 22);
  696. }
  697. TEST(Range, CalculateRangesOfInsertionAroundReplacement) {
  698. Replacements Replaces = toReplacements(
  699. {Replacement("foo", 0, 2, ""), Replacement("foo", 0, 0, "ba")});
  700. std::vector<Range> Ranges = Replaces.getAffectedRanges();
  701. EXPECT_EQ(1ul, Ranges.size());
  702. EXPECT_EQ(0u, Ranges[0].getOffset());
  703. EXPECT_EQ(2u, Ranges[0].getLength());
  704. }
  705. TEST(Range, RangesAfterEmptyReplacements) {
  706. std::vector<Range> Ranges = {Range(5, 6), Range(10, 5)};
  707. Replacements Replaces;
  708. std::vector<Range> Expected = {Range(5, 10)};
  709. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  710. }
  711. TEST(Range, RangesAfterReplacements) {
  712. std::vector<Range> Ranges = {Range(5, 2), Range(10, 5)};
  713. Replacements Replaces = toReplacements({Replacement("foo", 0, 2, "1234")});
  714. std::vector<Range> Expected = {Range(0, 4), Range(7, 2), Range(12, 5)};
  715. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  716. }
  717. TEST(Range, RangesBeforeReplacements) {
  718. std::vector<Range> Ranges = {Range(5, 2), Range(10, 5)};
  719. Replacements Replaces = toReplacements({Replacement("foo", 20, 2, "1234")});
  720. std::vector<Range> Expected = {Range(5, 2), Range(10, 5), Range(20, 4)};
  721. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  722. }
  723. TEST(Range, NotAffectedByReplacements) {
  724. std::vector<Range> Ranges = {Range(0, 2), Range(5, 2), Range(10, 5)};
  725. Replacements Replaces = toReplacements({Replacement("foo", 3, 2, "12"),
  726. Replacement("foo", 12, 2, "12"),
  727. Replacement("foo", 20, 5, "")});
  728. std::vector<Range> Expected = {Range(0, 2), Range(3, 4), Range(10, 5),
  729. Range(20, 0)};
  730. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  731. }
  732. TEST(Range, RangesWithNonOverlappingReplacements) {
  733. std::vector<Range> Ranges = {Range(0, 2), Range(5, 2), Range(10, 5)};
  734. Replacements Replaces = toReplacements({Replacement("foo", 3, 1, ""),
  735. Replacement("foo", 6, 1, "123"),
  736. Replacement("foo", 20, 2, "12345")});
  737. std::vector<Range> Expected = {Range(0, 2), Range(3, 0), Range(4, 4),
  738. Range(11, 5), Range(21, 5)};
  739. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  740. }
  741. TEST(Range, RangesWithOverlappingReplacements) {
  742. std::vector<Range> Ranges = {Range(0, 2), Range(5, 2), Range(15, 5),
  743. Range(30, 5)};
  744. Replacements Replaces = toReplacements(
  745. {Replacement("foo", 1, 3, ""), Replacement("foo", 6, 1, "123"),
  746. Replacement("foo", 13, 3, "1"), Replacement("foo", 25, 15, "")});
  747. std::vector<Range> Expected = {Range(0, 1), Range(2, 4), Range(12, 5),
  748. Range(22, 0)};
  749. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  750. }
  751. TEST(Range, MergeIntoOneRange) {
  752. std::vector<Range> Ranges = {Range(0, 2), Range(5, 2), Range(15, 5)};
  753. Replacements Replaces =
  754. toReplacements({Replacement("foo", 1, 15, "1234567890")});
  755. std::vector<Range> Expected = {Range(0, 15)};
  756. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  757. }
  758. TEST(Range, ReplacementsStartingAtRangeOffsets) {
  759. std::vector<Range> Ranges = {Range(0, 2), Range(5, 5), Range(15, 5)};
  760. Replacements Replaces = toReplacements(
  761. {Replacement("foo", 0, 2, "12"), Replacement("foo", 5, 1, "123"),
  762. Replacement("foo", 7, 4, "12345"), Replacement("foo", 15, 10, "12")});
  763. std::vector<Range> Expected = {Range(0, 2), Range(5, 9), Range(18, 2)};
  764. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  765. }
  766. TEST(Range, ReplacementsEndingAtRangeEnds) {
  767. std::vector<Range> Ranges = {Range(0, 2), Range(5, 2), Range(15, 5)};
  768. Replacements Replaces = toReplacements(
  769. {Replacement("foo", 6, 1, "123"), Replacement("foo", 17, 3, "12")});
  770. std::vector<Range> Expected = {Range(0, 2), Range(5, 4), Range(17, 4)};
  771. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  772. }
  773. TEST(Range, AjacentReplacements) {
  774. std::vector<Range> Ranges = {Range(0, 0), Range(15, 5)};
  775. Replacements Replaces = toReplacements(
  776. {Replacement("foo", 1, 2, "123"), Replacement("foo", 12, 3, "1234")});
  777. std::vector<Range> Expected = {Range(0, 0), Range(1, 3), Range(13, 9)};
  778. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  779. }
  780. TEST(Range, MergeRangesAfterReplacements) {
  781. std::vector<Range> Ranges = {Range(8, 0), Range(5, 2), Range(9, 0), Range(0, 1)};
  782. Replacements Replaces = toReplacements({Replacement("foo", 1, 3, ""),
  783. Replacement("foo", 7, 0, "12"),
  784. Replacement("foo", 9, 2, "")});
  785. std::vector<Range> Expected = {Range(0, 1), Range(2, 4), Range(7, 0),
  786. Range(8, 0)};
  787. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  788. }
  789. TEST(Range, ConflictingRangesBeforeReplacements) {
  790. std::vector<Range> Ranges = {Range(8, 3), Range(5, 4), Range(9, 1)};
  791. Replacements Replaces = toReplacements({Replacement("foo", 1, 3, "")});
  792. std::vector<Range> Expected = {Range(1, 0), Range(2, 6)};
  793. EXPECT_EQ(Expected, calculateRangesAfterReplacements(Replaces, Ranges));
  794. }
  795. class MergeReplacementsTest : public ::testing::Test {
  796. protected:
  797. void mergeAndTestRewrite(StringRef Code, StringRef Intermediate,
  798. StringRef Result, const Replacements &First,
  799. const Replacements &Second) {
  800. // These are mainly to verify the test itself and make it easier to read.
  801. auto AfterFirst = applyAllReplacements(Code, First);
  802. EXPECT_TRUE(static_cast<bool>(AfterFirst));
  803. auto InSequenceRewrite = applyAllReplacements(*AfterFirst, Second);
  804. EXPECT_TRUE(static_cast<bool>(InSequenceRewrite));
  805. EXPECT_EQ(Intermediate, *AfterFirst);
  806. EXPECT_EQ(Result, *InSequenceRewrite);
  807. tooling::Replacements Merged = First.merge(Second);
  808. auto MergedRewrite = applyAllReplacements(Code, Merged);
  809. EXPECT_TRUE(static_cast<bool>(MergedRewrite));
  810. EXPECT_EQ(*InSequenceRewrite, *MergedRewrite);
  811. if (*InSequenceRewrite != *MergedRewrite)
  812. for (tooling::Replacement M : Merged)
  813. llvm::errs() << M.getOffset() << " " << M.getLength() << " "
  814. << M.getReplacementText() << "\n";
  815. }
  816. void mergeAndTestRewrite(StringRef Code, const Replacements &First,
  817. const Replacements &Second) {
  818. auto AfterFirst = applyAllReplacements(Code, First);
  819. EXPECT_TRUE(static_cast<bool>(AfterFirst));
  820. auto InSequenceRewrite = applyAllReplacements(*AfterFirst, Second);
  821. tooling::Replacements Merged = First.merge(Second);
  822. auto MergedRewrite = applyAllReplacements(Code, Merged);
  823. EXPECT_TRUE(static_cast<bool>(MergedRewrite));
  824. EXPECT_EQ(*InSequenceRewrite, *MergedRewrite);
  825. if (*InSequenceRewrite != *MergedRewrite)
  826. for (tooling::Replacement M : Merged)
  827. llvm::errs() << M.getOffset() << " " << M.getLength() << " "
  828. << M.getReplacementText() << "\n";
  829. }
  830. };
  831. TEST_F(MergeReplacementsTest, Offsets) {
  832. mergeAndTestRewrite("aaa", "aabab", "cacabab",
  833. toReplacements({{"", 2, 0, "b"}, {"", 3, 0, "b"}}),
  834. toReplacements({{"", 0, 0, "c"}, {"", 1, 0, "c"}}));
  835. mergeAndTestRewrite("aaa", "babaa", "babacac",
  836. toReplacements({{"", 0, 0, "b"}, {"", 1, 0, "b"}}),
  837. toReplacements({{"", 4, 0, "c"}, {"", 5, 0, "c"}}));
  838. mergeAndTestRewrite("aaaa", "aaa", "aac", toReplacements({{"", 1, 1, ""}}),
  839. toReplacements({{"", 2, 1, "c"}}));
  840. mergeAndTestRewrite("aa", "bbabba", "bbabcba",
  841. toReplacements({{"", 0, 0, "bb"}, {"", 1, 0, "bb"}}),
  842. toReplacements({{"", 4, 0, "c"}}));
  843. }
  844. TEST_F(MergeReplacementsTest, Concatenations) {
  845. // Basic concatenations. It is important to merge these into a single
  846. // replacement to ensure the correct order.
  847. {
  848. auto First = toReplacements({{"", 0, 0, "a"}});
  849. auto Second = toReplacements({{"", 1, 0, "b"}});
  850. EXPECT_EQ(toReplacements({{"", 0, 0, "ab"}}), First.merge(Second));
  851. }
  852. {
  853. auto First = toReplacements({{"", 0, 0, "a"}});
  854. auto Second = toReplacements({{"", 0, 0, "b"}});
  855. EXPECT_EQ(toReplacements({{"", 0, 0, "ba"}}), First.merge(Second));
  856. }
  857. mergeAndTestRewrite("", "a", "ab", toReplacements({{"", 0, 0, "a"}}),
  858. toReplacements({{"", 1, 0, "b"}}));
  859. mergeAndTestRewrite("", "a", "ba", toReplacements({{"", 0, 0, "a"}}),
  860. toReplacements({{"", 0, 0, "b"}}));
  861. }
  862. TEST_F(MergeReplacementsTest, NotChangingLengths) {
  863. mergeAndTestRewrite("aaaa", "abba", "acca",
  864. toReplacements({{"", 1, 2, "bb"}}),
  865. toReplacements({{"", 1, 2, "cc"}}));
  866. mergeAndTestRewrite("aaaa", "abba", "abcc",
  867. toReplacements({{"", 1, 2, "bb"}}),
  868. toReplacements({{"", 2, 2, "cc"}}));
  869. mergeAndTestRewrite("aaaa", "abba", "ccba",
  870. toReplacements({{"", 1, 2, "bb"}}),
  871. toReplacements({{"", 0, 2, "cc"}}));
  872. mergeAndTestRewrite("aaaaaa", "abbdda", "abccda",
  873. toReplacements({{"", 1, 2, "bb"}, {"", 3, 2, "dd"}}),
  874. toReplacements({{"", 2, 2, "cc"}}));
  875. }
  876. TEST_F(MergeReplacementsTest, OverlappingRanges) {
  877. mergeAndTestRewrite("aaa", "bbd", "bcbcd",
  878. toReplacements({{"", 0, 1, "bb"}, {"", 1, 2, "d"}}),
  879. toReplacements({{"", 1, 0, "c"}, {"", 2, 0, "c"}}));
  880. mergeAndTestRewrite("aaaa", "aabbaa", "acccca",
  881. toReplacements({{"", 2, 0, "bb"}}),
  882. toReplacements({{"", 1, 4, "cccc"}}));
  883. mergeAndTestRewrite("aaaa", "aababa", "acccca",
  884. toReplacements({{"", 2, 0, "b"}, {"", 3, 0, "b"}}),
  885. toReplacements({{"", 1, 4, "cccc"}}));
  886. mergeAndTestRewrite("aaaaaa", "abbbba", "abba",
  887. toReplacements({{"", 1, 4, "bbbb"}}),
  888. toReplacements({{"", 2, 2, ""}}));
  889. mergeAndTestRewrite("aaaa", "aa", "cc",
  890. toReplacements({{"", 1, 1, ""}, {"", 2, 1, ""}}),
  891. toReplacements({{"", 0, 2, "cc"}}));
  892. mergeAndTestRewrite("aa", "abbba", "abcbcba",
  893. toReplacements({{"", 1, 0, "bbb"}}),
  894. toReplacements({{"", 2, 0, "c"}, {"", 3, 0, "c"}}));
  895. mergeAndTestRewrite(
  896. "aaa", "abbab", "ccdd",
  897. toReplacements({{"", 0, 1, ""}, {"", 2, 0, "bb"}, {"", 3, 0, "b"}}),
  898. toReplacements({{"", 0, 2, "cc"}, {"", 2, 3, "dd"}}));
  899. mergeAndTestRewrite(
  900. "aa", "babbab", "ccdd",
  901. toReplacements({{"", 0, 0, "b"}, {"", 1, 0, "bb"}, {"", 2, 0, "b"}}),
  902. toReplacements({{"", 0, 3, "cc"}, {"", 3, 3, "dd"}}));
  903. }
  904. TEST(DeduplicateByFileTest, PathsWithDots) {
  905. std::map<std::string, Replacements> FileToReplaces;
  906. llvm::IntrusiveRefCntPtr<vfs::InMemoryFileSystem> VFS(
  907. new vfs::InMemoryFileSystem());
  908. FileManager FileMgr(FileSystemOptions(), VFS);
  909. #if !defined(LLVM_ON_WIN32)
  910. StringRef Path1 = "a/b/.././c.h";
  911. StringRef Path2 = "a/c.h";
  912. #else
  913. StringRef Path1 = "a\\b\\..\\.\\c.h";
  914. StringRef Path2 = "a\\c.h";
  915. #endif
  916. EXPECT_TRUE(VFS->addFile(Path1, 0, llvm::MemoryBuffer::getMemBuffer("")));
  917. EXPECT_TRUE(VFS->addFile(Path2, 0, llvm::MemoryBuffer::getMemBuffer("")));
  918. FileToReplaces[Path1] = Replacements();
  919. FileToReplaces[Path2] = Replacements();
  920. FileToReplaces = groupReplacementsByFile(FileMgr, FileToReplaces);
  921. EXPECT_EQ(1u, FileToReplaces.size());
  922. EXPECT_EQ(Path1, FileToReplaces.begin()->first);
  923. }
  924. TEST(DeduplicateByFileTest, PathWithDotSlash) {
  925. std::map<std::string, Replacements> FileToReplaces;
  926. llvm::IntrusiveRefCntPtr<vfs::InMemoryFileSystem> VFS(
  927. new vfs::InMemoryFileSystem());
  928. FileManager FileMgr(FileSystemOptions(), VFS);
  929. #if !defined(LLVM_ON_WIN32)
  930. StringRef Path1 = "./a/b/c.h";
  931. StringRef Path2 = "a/b/c.h";
  932. #else
  933. StringRef Path1 = ".\\a\\b\\c.h";
  934. StringRef Path2 = "a\\b\\c.h";
  935. #endif
  936. EXPECT_TRUE(VFS->addFile(Path1, 0, llvm::MemoryBuffer::getMemBuffer("")));
  937. EXPECT_TRUE(VFS->addFile(Path2, 0, llvm::MemoryBuffer::getMemBuffer("")));
  938. FileToReplaces[Path1] = Replacements();
  939. FileToReplaces[Path2] = Replacements();
  940. FileToReplaces = groupReplacementsByFile(FileMgr, FileToReplaces);
  941. EXPECT_EQ(1u, FileToReplaces.size());
  942. EXPECT_EQ(Path1, FileToReplaces.begin()->first);
  943. }
  944. TEST(DeduplicateByFileTest, NonExistingFilePath) {
  945. std::map<std::string, Replacements> FileToReplaces;
  946. llvm::IntrusiveRefCntPtr<vfs::InMemoryFileSystem> VFS(
  947. new vfs::InMemoryFileSystem());
  948. FileManager FileMgr(FileSystemOptions(), VFS);
  949. #if !defined(LLVM_ON_WIN32)
  950. StringRef Path1 = "./a/b/c.h";
  951. StringRef Path2 = "a/b/c.h";
  952. #else
  953. StringRef Path1 = ".\\a\\b\\c.h";
  954. StringRef Path2 = "a\\b\\c.h";
  955. #endif
  956. FileToReplaces[Path1] = Replacements();
  957. FileToReplaces[Path2] = Replacements();
  958. FileToReplaces = groupReplacementsByFile(FileMgr, FileToReplaces);
  959. EXPECT_TRUE(FileToReplaces.empty());
  960. }
  961. class AtomicChangeTest : public ::testing::Test {
  962. protected:
  963. void setUp() {
  964. DefaultFileID = Context.createInMemoryFile("input.cpp", DefaultCode);
  965. DefaultLoc = Context.Sources.getLocForStartOfFile(DefaultFileID)
  966. .getLocWithOffset(20);
  967. assert(DefaultLoc.isValid() && "Default location must be valid.");
  968. }
  969. RewriterTestContext Context;
  970. std::string DefaultCode = std::string(100, 'a');
  971. unsigned DefaultOffset = 20;
  972. SourceLocation DefaultLoc;
  973. FileID DefaultFileID;
  974. };
  975. TEST_F(AtomicChangeTest, AtomicChangeToYAML) {
  976. setUp();
  977. AtomicChange Change(Context.Sources, DefaultLoc);
  978. llvm::Error Err =
  979. Change.insert(Context.Sources, DefaultLoc, "aa", /*InsertAfter=*/false);
  980. ASSERT_TRUE(!Err);
  981. Err = Change.insert(Context.Sources, DefaultLoc.getLocWithOffset(10), "bb",
  982. /*InsertAfter=*/false);
  983. ASSERT_TRUE(!Err);
  984. Change.addHeader("a.h");
  985. Change.removeHeader("b.h");
  986. std::string YAMLString = Change.toYAMLString();
  987. // NOTE: If this test starts to fail for no obvious reason, check whitespace.
  988. ASSERT_STREQ("---\n"
  989. "Key: 'input.cpp:20'\n"
  990. "FilePath: input.cpp\n"
  991. "Error: ''\n"
  992. "InsertedHeaders: [ a.h ]\n"
  993. "RemovedHeaders: [ b.h ]\n"
  994. "Replacements: \n" // Extra whitespace here!
  995. " - FilePath: input.cpp\n"
  996. " Offset: 20\n"
  997. " Length: 0\n"
  998. " ReplacementText: aa\n"
  999. " - FilePath: input.cpp\n"
  1000. " Offset: 30\n"
  1001. " Length: 0\n"
  1002. " ReplacementText: bb\n"
  1003. "...\n",
  1004. YAMLString.c_str());
  1005. }
  1006. TEST_F(AtomicChangeTest, YAMLToAtomicChange) {
  1007. setUp();
  1008. std::string YamlContent = "---\n"
  1009. "Key: 'input.cpp:20'\n"
  1010. "FilePath: input.cpp\n"
  1011. "Error: 'ok'\n"
  1012. "InsertedHeaders: [ a.h ]\n"
  1013. "RemovedHeaders: [ b.h ]\n"
  1014. "Replacements: \n" // Extra whitespace here!
  1015. " - FilePath: input.cpp\n"
  1016. " Offset: 20\n"
  1017. " Length: 0\n"
  1018. " ReplacementText: aa\n"
  1019. " - FilePath: input.cpp\n"
  1020. " Offset: 30\n"
  1021. " Length: 0\n"
  1022. " ReplacementText: bb\n"
  1023. "...\n";
  1024. AtomicChange ExpectedChange(Context.Sources, DefaultLoc);
  1025. llvm::Error Err = ExpectedChange.insert(Context.Sources, DefaultLoc, "aa",
  1026. /*InsertAfter=*/false);
  1027. ASSERT_TRUE(!Err);
  1028. Err = ExpectedChange.insert(Context.Sources, DefaultLoc.getLocWithOffset(10),
  1029. "bb", /*InsertAfter=*/false);
  1030. ASSERT_TRUE(!Err);
  1031. ExpectedChange.addHeader("a.h");
  1032. ExpectedChange.removeHeader("b.h");
  1033. ExpectedChange.setError("ok");
  1034. AtomicChange ActualChange = AtomicChange::convertFromYAML(YamlContent);
  1035. EXPECT_EQ(ExpectedChange.getKey(), ActualChange.getKey());
  1036. EXPECT_EQ(ExpectedChange.getFilePath(), ActualChange.getFilePath());
  1037. EXPECT_EQ(ExpectedChange.getError(), ActualChange.getError());
  1038. EXPECT_EQ(ExpectedChange.getInsertedHeaders(),
  1039. ActualChange.getInsertedHeaders());
  1040. EXPECT_EQ(ExpectedChange.getRemovedHeaders(),
  1041. ActualChange.getRemovedHeaders());
  1042. EXPECT_EQ(ExpectedChange.getReplacements().size(),
  1043. ActualChange.getReplacements().size());
  1044. EXPECT_EQ(2u, ActualChange.getReplacements().size());
  1045. EXPECT_EQ(*ExpectedChange.getReplacements().begin(),
  1046. *ActualChange.getReplacements().begin());
  1047. EXPECT_EQ(*(++ExpectedChange.getReplacements().begin()),
  1048. *(++ActualChange.getReplacements().begin()));
  1049. }
  1050. TEST_F(AtomicChangeTest, CheckKeyAndKeyFile) {
  1051. setUp();
  1052. AtomicChange Change(Context.Sources, DefaultLoc);
  1053. EXPECT_EQ("input.cpp:20", Change.getKey());
  1054. EXPECT_EQ("input.cpp", Change.getFilePath());
  1055. }
  1056. TEST_F(AtomicChangeTest, Replace) {
  1057. setUp();
  1058. AtomicChange Change(Context.Sources, DefaultLoc);
  1059. llvm::Error Err = Change.replace(Context.Sources, DefaultLoc, 2, "aa");
  1060. ASSERT_TRUE(!Err);
  1061. EXPECT_EQ(Change.getReplacements().size(), 1u);
  1062. EXPECT_EQ(*Change.getReplacements().begin(),
  1063. Replacement(Context.Sources, DefaultLoc, 2, "aa"));
  1064. // Add a new replacement that conflicts with the existing one.
  1065. Err = Change.replace(Context.Sources, DefaultLoc, 3, "ab");
  1066. EXPECT_TRUE((bool)Err);
  1067. llvm::consumeError(std::move(Err));
  1068. EXPECT_EQ(Change.getReplacements().size(), 1u);
  1069. }
  1070. TEST_F(AtomicChangeTest, InsertBefore) {
  1071. setUp();
  1072. AtomicChange Change(Context.Sources, DefaultLoc);
  1073. llvm::Error Err = Change.insert(Context.Sources, DefaultLoc, "aa");
  1074. ASSERT_TRUE(!Err);
  1075. EXPECT_EQ(Change.getReplacements().size(), 1u);
  1076. EXPECT_EQ(*Change.getReplacements().begin(),
  1077. Replacement(Context.Sources, DefaultLoc, 0, "aa"));
  1078. Err = Change.insert(Context.Sources, DefaultLoc, "b", /*InsertAfter=*/false);
  1079. ASSERT_TRUE(!Err);
  1080. EXPECT_EQ(Change.getReplacements().size(), 1u);
  1081. EXPECT_EQ(*Change.getReplacements().begin(),
  1082. Replacement(Context.Sources, DefaultLoc, 0, "baa"));
  1083. }
  1084. TEST_F(AtomicChangeTest, InsertAfter) {
  1085. setUp();
  1086. AtomicChange Change(Context.Sources, DefaultLoc);
  1087. llvm::Error Err = Change.insert(Context.Sources, DefaultLoc, "aa");
  1088. ASSERT_TRUE(!Err);
  1089. EXPECT_EQ(Change.getReplacements().size(), 1u);
  1090. EXPECT_EQ(*Change.getReplacements().begin(),
  1091. Replacement(Context.Sources, DefaultLoc, 0, "aa"));
  1092. Err = Change.insert(Context.Sources, DefaultLoc, "b");
  1093. ASSERT_TRUE(!Err);
  1094. EXPECT_EQ(Change.getReplacements().size(), 1u);
  1095. EXPECT_EQ(*Change.getReplacements().begin(),
  1096. Replacement(Context.Sources, DefaultLoc, 0, "aab"));
  1097. }
  1098. TEST_F(AtomicChangeTest, InsertBeforeWithInvalidLocation) {
  1099. setUp();
  1100. AtomicChange Change(Context.Sources, DefaultLoc);
  1101. llvm::Error Err =
  1102. Change.insert(Context.Sources, DefaultLoc, "a", /*InsertAfter=*/false);
  1103. ASSERT_TRUE(!Err);
  1104. // Invalid location.
  1105. Err = Change.insert(Context.Sources, SourceLocation(), "a",
  1106. /*InsertAfter=*/false);
  1107. ASSERT_TRUE((bool)Err);
  1108. EXPECT_TRUE(checkReplacementError(
  1109. std::move(Err), replacement_error::wrong_file_path,
  1110. Replacement(Context.Sources, DefaultLoc, 0, "a"),
  1111. Replacement(Context.Sources, SourceLocation(), 0, "a")));
  1112. }
  1113. TEST_F(AtomicChangeTest, InsertBeforeToWrongFile) {
  1114. setUp();
  1115. AtomicChange Change(Context.Sources, DefaultLoc);
  1116. llvm::Error Err =
  1117. Change.insert(Context.Sources, DefaultLoc, "a", /*InsertAfter=*/false);
  1118. ASSERT_TRUE(!Err);
  1119. // Inserting at a different file.
  1120. FileID NewID = Context.createInMemoryFile("extra.cpp", DefaultCode);
  1121. SourceLocation NewLoc = Context.Sources.getLocForStartOfFile(NewID);
  1122. Err = Change.insert(Context.Sources, NewLoc, "b", /*InsertAfter=*/false);
  1123. ASSERT_TRUE((bool)Err);
  1124. EXPECT_TRUE(
  1125. checkReplacementError(std::move(Err), replacement_error::wrong_file_path,
  1126. Replacement(Context.Sources, DefaultLoc, 0, "a"),
  1127. Replacement(Context.Sources, NewLoc, 0, "b")));
  1128. }
  1129. TEST_F(AtomicChangeTest, InsertAfterWithInvalidLocation) {
  1130. setUp();
  1131. AtomicChange Change(Context.Sources, DefaultLoc);
  1132. llvm::Error Err = Change.insert(Context.Sources, DefaultLoc, "a");
  1133. ASSERT_TRUE(!Err);
  1134. // Invalid location.
  1135. Err = Change.insert(Context.Sources, SourceLocation(), "b");
  1136. ASSERT_TRUE((bool)Err);
  1137. EXPECT_TRUE(checkReplacementError(
  1138. std::move(Err), replacement_error::wrong_file_path,
  1139. Replacement(Context.Sources, DefaultLoc, 0, "a"),
  1140. Replacement(Context.Sources, SourceLocation(), 0, "b")));
  1141. }
  1142. class ApplyAtomicChangesTest : public ::testing::Test {
  1143. protected:
  1144. ApplyAtomicChangesTest() : FilePath("file.cc") {
  1145. Spec.Cleanup = true;
  1146. Spec.Format = ApplyChangesSpec::kAll;
  1147. Spec.Style = format::getLLVMStyle();
  1148. }
  1149. ~ApplyAtomicChangesTest() override {}
  1150. void setInput(llvm::StringRef Input) {
  1151. Code = Input;
  1152. FID = Context.createInMemoryFile(FilePath, Code);
  1153. }
  1154. SourceLocation getLoc(unsigned Offset) const {
  1155. return Context.Sources.getLocForStartOfFile(FID).getLocWithOffset(Offset);
  1156. }
  1157. AtomicChange replacementToAtomicChange(llvm::StringRef Key, unsigned Offset,
  1158. unsigned Length,
  1159. llvm::StringRef Text) {
  1160. AtomicChange Change(FilePath, Key);
  1161. llvm::Error Err =
  1162. Change.replace(Context.Sources, getLoc(Offset), Length, Text);
  1163. EXPECT_FALSE(Err);
  1164. return Change;
  1165. }
  1166. std::string rewrite(bool FailureExpected = false) {
  1167. llvm::Expected<std::string> ChangedCode =
  1168. applyAtomicChanges(FilePath, Code, Changes, Spec);
  1169. EXPECT_EQ(FailureExpected, !ChangedCode);
  1170. if (!ChangedCode) {
  1171. llvm::errs() << "Failed to apply changes: "
  1172. << llvm::toString(ChangedCode.takeError()) << "\n";
  1173. return "";
  1174. }
  1175. return *ChangedCode;
  1176. }
  1177. RewriterTestContext Context;
  1178. FileID FID;
  1179. ApplyChangesSpec Spec;
  1180. std::string Code;
  1181. std::string FilePath;
  1182. llvm::SmallVector<AtomicChange, 8> Changes;
  1183. };
  1184. TEST_F(ApplyAtomicChangesTest, BasicRefactoring) {
  1185. setInput("int a;");
  1186. AtomicChange Change(FilePath, "key1");
  1187. Changes.push_back(replacementToAtomicChange("key1", 4, 1, "b"));
  1188. EXPECT_EQ("int b;", rewrite());
  1189. }
  1190. TEST_F(ApplyAtomicChangesTest, SeveralRefactorings) {
  1191. setInput("int a;\n"
  1192. "int b;");
  1193. Changes.push_back(replacementToAtomicChange("key1", 0, 3, "float"));
  1194. Changes.push_back(replacementToAtomicChange("key2", 4, 1, "f"));
  1195. Changes.push_back(replacementToAtomicChange("key3", 11, 1, "g"));
  1196. Changes.push_back(replacementToAtomicChange("key4", 7, 3, "float"));
  1197. EXPECT_EQ("float f;\n"
  1198. "float g;",
  1199. rewrite());
  1200. }
  1201. TEST_F(ApplyAtomicChangesTest, IgnorePathsInRefactorings) {
  1202. setInput("int a;\n"
  1203. "int b;");
  1204. Changes.push_back(replacementToAtomicChange("key1", 4, 1, "aa"));
  1205. FileID ID = Context.createInMemoryFile("AnotherFile", "12345678912345");
  1206. Changes.emplace_back("AnotherFile", "key2");
  1207. auto Err = Changes.back().replace(
  1208. Context.Sources,
  1209. Context.Sources.getLocForStartOfFile(ID).getLocWithOffset(11), 1, "bb");
  1210. ASSERT_TRUE(!Err);
  1211. EXPECT_EQ("int aa;\n"
  1212. "int bb;",
  1213. rewrite());
  1214. }
  1215. TEST_F(ApplyAtomicChangesTest, AppliesDuplicateInsertions) {
  1216. setInput("int a;");
  1217. Changes.push_back(replacementToAtomicChange("key1", 5, 0, "b"));
  1218. Changes.push_back(replacementToAtomicChange("key2", 5, 0, "b"));
  1219. EXPECT_EQ("int abb;", rewrite());
  1220. }
  1221. TEST_F(ApplyAtomicChangesTest, BailsOnOverlappingRefactorings) {
  1222. setInput("int a;");
  1223. Changes.push_back(replacementToAtomicChange("key1", 0, 5, "float f"));
  1224. Changes.push_back(replacementToAtomicChange("key2", 4, 1, "b"));
  1225. EXPECT_EQ("", rewrite(/*FailureExpected=*/true));
  1226. }
  1227. TEST_F(ApplyAtomicChangesTest, BasicReformatting) {
  1228. setInput("int a;");
  1229. Changes.push_back(replacementToAtomicChange("key1", 5, 1, "b"));
  1230. EXPECT_EQ("int b;", rewrite());
  1231. }
  1232. TEST_F(ApplyAtomicChangesTest, OnlyFormatWhenViolateColumnLimits) {
  1233. Spec.Format = ApplyChangesSpec::kViolations;
  1234. Spec.Style.ColumnLimit = 8;
  1235. setInput("int a;\n"
  1236. "int a;\n"
  1237. "int aaaaaaaa;\n");
  1238. Changes.push_back(replacementToAtomicChange("key1", 5, 1, "x"));
  1239. Changes.push_back(replacementToAtomicChange("key2", 15, 1, "x"));
  1240. Changes.push_back(replacementToAtomicChange("key3", 23, 8, "xx"));
  1241. EXPECT_EQ("int x;\n"
  1242. "int x;\n"
  1243. "int xx;\n",
  1244. rewrite());
  1245. }
  1246. TEST_F(ApplyAtomicChangesTest, LastLineViolateColumnLimits) {
  1247. Spec.Format = ApplyChangesSpec::kViolations;
  1248. Spec.Style.ColumnLimit = 8;
  1249. setInput("int a;\n"
  1250. "int a;");
  1251. Changes.push_back(replacementToAtomicChange("key1", 0, 1, "i"));
  1252. Changes.push_back(replacementToAtomicChange("key2", 15, 2, "y;"));
  1253. EXPECT_EQ("int a;\n"
  1254. "int y;",
  1255. rewrite());
  1256. }
  1257. TEST_F(ApplyAtomicChangesTest, LastLineWithNewlineViolateColumnLimits) {
  1258. Spec.Format = ApplyChangesSpec::kViolations;
  1259. Spec.Style.ColumnLimit = 8;
  1260. setInput("int a;\n"
  1261. "int a;\n");
  1262. Changes.push_back(replacementToAtomicChange("key1", 0, 1, "i"));
  1263. Changes.push_back(replacementToAtomicChange("key2", 14, 3, "y;\n"));
  1264. EXPECT_EQ("int a;\n"
  1265. "int y;\n",
  1266. rewrite());
  1267. }
  1268. TEST_F(ApplyAtomicChangesTest, Longer) {
  1269. setInput("int a;");
  1270. Changes.push_back(replacementToAtomicChange("key1", 5, 1, "bbb"));
  1271. EXPECT_EQ("int bbb;", rewrite());
  1272. }
  1273. TEST_F(ApplyAtomicChangesTest, Shorter) {
  1274. setInput("int aaa;");
  1275. Changes.push_back(replacementToAtomicChange("key1", 5, 3, "b"));
  1276. EXPECT_EQ("int b;", rewrite());
  1277. }
  1278. TEST_F(ApplyAtomicChangesTest, OnlyFormatChangedLines) {
  1279. setInput("int aaa;\n"
  1280. "int a = b;\n"
  1281. "int bbb;");
  1282. Changes.push_back(replacementToAtomicChange("key1", 14, 1, "b"));
  1283. EXPECT_EQ("int aaa;\n"
  1284. "int b = b;\n"
  1285. "int bbb;",
  1286. rewrite());
  1287. }
  1288. TEST_F(ApplyAtomicChangesTest, DisableFormatting) {
  1289. Spec.Format = ApplyChangesSpec::kNone;
  1290. setInput("int aaa;\n"
  1291. "int a = b;\n"
  1292. "int bbb;");
  1293. Changes.push_back(replacementToAtomicChange("key1", 14, 1, "b"));
  1294. EXPECT_EQ("int aaa;\n"
  1295. "int b = b;\n"
  1296. "int bbb;",
  1297. rewrite());
  1298. }
  1299. TEST_F(ApplyAtomicChangesTest, AdaptsToLocalPointerStyle) {
  1300. setInput("int *aaa;\n"
  1301. "int *bbb;");
  1302. Changes.push_back(replacementToAtomicChange("key1", 0, 0, "int* ccc;\n"));
  1303. EXPECT_EQ("int *ccc;\n"
  1304. "int *aaa;\n"
  1305. "int *bbb;",
  1306. rewrite());
  1307. }
  1308. TEST_F(ApplyAtomicChangesTest, AcceptsSurroundingFormatting) {
  1309. setInput(" int aaa;\n"
  1310. " int a = b;\n"
  1311. " int bbb;");
  1312. Changes.push_back(replacementToAtomicChange("key1", 20, 1, "b"));
  1313. EXPECT_EQ(" int aaa;\n"
  1314. " int b = b;\n"
  1315. " int bbb;",
  1316. rewrite());
  1317. }
  1318. TEST_F(ApplyAtomicChangesTest, BailsOutOnConflictingChanges) {
  1319. setInput("int c;\n"
  1320. "int f;");
  1321. // Insertions at the same offset are only allowed in the same AtomicChange.
  1322. Changes.push_back(replacementToAtomicChange("key1", 0, 0, "int a;\n"));
  1323. Changes.push_back(replacementToAtomicChange("key2", 0, 0, "int b;\n"));
  1324. EXPECT_EQ("", rewrite(/*FailureExpected=*/true));
  1325. }
  1326. TEST_F(ApplyAtomicChangesTest, InsertsNewIncludesInRightOrder) {
  1327. setInput("int a;");
  1328. Changes.emplace_back(FilePath, "key1");
  1329. Changes.back().addHeader("b");
  1330. Changes.back().addHeader("c");
  1331. Changes.emplace_back(FilePath, "key2");
  1332. Changes.back().addHeader("a");
  1333. EXPECT_EQ("#include \"a\"\n"
  1334. "#include \"b\"\n"
  1335. "#include \"c\"\n"
  1336. "int a;",
  1337. rewrite());
  1338. }
  1339. TEST_F(ApplyAtomicChangesTest, RemoveAndSortIncludes) {
  1340. setInput(R"(
  1341. #include "a"
  1342. #include "b"
  1343. #include "c"
  1344. int a;
  1345. )");
  1346. Changes.emplace_back(FilePath, "key1");
  1347. Changes.back().removeHeader("b");
  1348. EXPECT_EQ(R"(
  1349. #include "a"
  1350. #include "c"
  1351. int a;
  1352. )",
  1353. rewrite());
  1354. }
  1355. TEST_F(ApplyAtomicChangesTest, InsertsSystemIncludes) {
  1356. setInput("#include <asys>\n"
  1357. "#include <csys>\n"
  1358. "\n"
  1359. "#include \"a\"\n"
  1360. "#include \"c\"\n");
  1361. Changes.emplace_back(FilePath, "key1");
  1362. Changes.back().addHeader("<asys>"); // Already exists.
  1363. Changes.back().addHeader("<b>");
  1364. Changes.back().addHeader("<d>");
  1365. Changes.back().addHeader("\"b-already-escaped\"");
  1366. EXPECT_EQ("#include <asys>\n"
  1367. "#include <b>\n"
  1368. "#include <csys>\n"
  1369. "#include <d>\n"
  1370. "\n"
  1371. "#include \"a\"\n"
  1372. "#include \"b-already-escaped\"\n"
  1373. "#include \"c\"\n",
  1374. rewrite());
  1375. }
  1376. TEST_F(ApplyAtomicChangesTest, RemoveSystemIncludes) {
  1377. setInput(R"(
  1378. #include <a>
  1379. #include <b>
  1380. #include "c"
  1381. int a;
  1382. )");
  1383. Changes.emplace_back(FilePath, "key1");
  1384. Changes.back().removeHeader("<a>");
  1385. EXPECT_EQ(R"(
  1386. #include <b>
  1387. #include "c"
  1388. int a;
  1389. )",
  1390. rewrite());
  1391. }
  1392. TEST_F(ApplyAtomicChangesTest,
  1393. DoNotFormatFollowingLinesIfSeparatedWithNewline) {
  1394. setInput("#ifndef __H__\n"
  1395. "#define __H__\n"
  1396. "#include \"b\"\n"
  1397. "\n"
  1398. "int a;\n"
  1399. "int a;\n"
  1400. "int a;\n"
  1401. "#endif // __H__\n");
  1402. Changes.push_back(replacementToAtomicChange("key1",
  1403. llvm::StringRef("#ifndef __H__\n"
  1404. "#define __H__\n"
  1405. "\n"
  1406. "#include \"b\"\n"
  1407. "int a;\n"
  1408. "int ")
  1409. .size(),
  1410. 1, "b"));
  1411. Changes.back().addHeader("a");
  1412. EXPECT_EQ("#ifndef __H__\n"
  1413. "#define __H__\n"
  1414. "#include \"a\"\n"
  1415. "#include \"b\"\n"
  1416. "\n"
  1417. "int a;\n"
  1418. "int b;\n"
  1419. "int a;\n"
  1420. "#endif // __H__\n",
  1421. rewrite());
  1422. }
  1423. TEST_F(ApplyAtomicChangesTest, FormatsCorrectLineWhenHeaderIsRemoved) {
  1424. setInput("#include \"a\"\n"
  1425. "\n"
  1426. "int a;\n"
  1427. "int a;\n"
  1428. "int a;");
  1429. Changes.push_back(replacementToAtomicChange("key1", 27, 1, "b"));
  1430. Changes.back().removeHeader("a");
  1431. EXPECT_EQ("\n"
  1432. "int a;\n"
  1433. "int b;\n"
  1434. "int a;",
  1435. rewrite());
  1436. }
  1437. TEST_F(ApplyAtomicChangesTest, CleansUpCtorInitializers) {
  1438. setInput("A::A() : a(), b() {}\n"
  1439. "A::A() : a(), b() {}\n"
  1440. "A::A() : a(), b() {}\n"
  1441. "A::A() : a()/**/, b() {}\n"
  1442. "A::A() : a() ,// \n"
  1443. " /**/ b() {}");
  1444. Changes.emplace_back(FilePath, "key1");
  1445. auto Err = Changes.back().replace(Context.Sources, getLoc(9), 3, "");
  1446. ASSERT_TRUE(!Err);
  1447. Err = Changes.back().replace(Context.Sources, getLoc(35), 3, "");
  1448. ASSERT_TRUE(!Err);
  1449. Err = Changes.back().replace(Context.Sources, getLoc(51), 3, "");
  1450. ASSERT_TRUE(!Err);
  1451. Err = Changes.back().replace(Context.Sources, getLoc(56), 3, "");
  1452. ASSERT_TRUE(!Err);
  1453. Err = Changes.back().replace(Context.Sources, getLoc(72), 3, "");
  1454. ASSERT_TRUE(!Err);
  1455. Err = Changes.back().replace(Context.Sources, getLoc(97), 3, "");
  1456. ASSERT_TRUE(!Err);
  1457. Err = Changes.back().replace(Context.Sources, getLoc(118), 3, "");
  1458. ASSERT_TRUE(!Err);
  1459. EXPECT_EQ("A::A() : b() {}\n"
  1460. "A::A() : a() {}\n"
  1461. "A::A() {}\n"
  1462. "A::A() : b() {}\n"
  1463. "A::A() {}",
  1464. rewrite());
  1465. }
  1466. TEST_F(ApplyAtomicChangesTest, CleansUpParameterLists) {
  1467. setInput("void f(int i, float f, string s);\n"
  1468. "f(1, 2.0f, \"a\");\n"
  1469. "g(1, 1);");
  1470. Changes.emplace_back(FilePath, "key1");
  1471. auto Err = Changes.back().replace(Context.Sources, getLoc(7), 5, "");
  1472. ASSERT_TRUE(!Err);
  1473. Err = Changes.back().replace(Context.Sources, getLoc(23), 8, "");
  1474. ASSERT_TRUE(!Err);
  1475. Err = Changes.back().replace(Context.Sources, getLoc(36), 1, "");
  1476. ASSERT_TRUE(!Err);
  1477. Err = Changes.back().replace(Context.Sources, getLoc(45), 3, "");
  1478. ASSERT_TRUE(!Err);
  1479. Err = Changes.back().replace(Context.Sources, getLoc(53), 1, "");
  1480. ASSERT_TRUE(!Err);
  1481. Err = Changes.back().replace(Context.Sources, getLoc(56), 1, "");
  1482. ASSERT_TRUE(!Err);
  1483. EXPECT_EQ("void f(float f);\n"
  1484. "f(2.0f);\n"
  1485. "g();",
  1486. rewrite());
  1487. }
  1488. TEST_F(ApplyAtomicChangesTest, DisableCleanup) {
  1489. Spec.Cleanup = false;
  1490. setInput("void f(int i, float f, string s);\n"
  1491. "f(1, 2.0f, \"a\");\n"
  1492. "g(1, 1);");
  1493. Changes.emplace_back(FilePath, "key1");
  1494. auto Err = Changes.back().replace(Context.Sources, getLoc(7), 5, "");
  1495. ASSERT_TRUE(!Err);
  1496. Err = Changes.back().replace(Context.Sources, getLoc(23), 8, "");
  1497. ASSERT_TRUE(!Err);
  1498. Err = Changes.back().replace(Context.Sources, getLoc(36), 1, "");
  1499. ASSERT_TRUE(!Err);
  1500. Err = Changes.back().replace(Context.Sources, getLoc(45), 3, "");
  1501. ASSERT_TRUE(!Err);
  1502. Err = Changes.back().replace(Context.Sources, getLoc(53), 1, "");
  1503. ASSERT_TRUE(!Err);
  1504. Err = Changes.back().replace(Context.Sources, getLoc(56), 1, "");
  1505. ASSERT_TRUE(!Err);
  1506. EXPECT_EQ("void f(, float f, );\n"
  1507. "f(, 2.0f, );\n"
  1508. "g(, );",
  1509. rewrite());
  1510. }
  1511. TEST_F(ApplyAtomicChangesTest, EverythingDeleted) {
  1512. setInput("int a;");
  1513. Changes.push_back(replacementToAtomicChange("key1", 0, 6, ""));
  1514. EXPECT_EQ("", rewrite());
  1515. }
  1516. TEST_F(ApplyAtomicChangesTest, DoesNotDeleteInserts) {
  1517. setInput("int a;\n"
  1518. "int b;");
  1519. Changes.emplace_back(FilePath, "key1");
  1520. auto Err = Changes.back().replace(Context.Sources, getLoc(4), 1, "");
  1521. ASSERT_TRUE(!Err);
  1522. Err = Changes.back().replace(Context.Sources, getLoc(4), 0, "b");
  1523. ASSERT_TRUE(!Err);
  1524. Err = Changes.back().replace(Context.Sources, getLoc(11), 0, "a");
  1525. ASSERT_TRUE(!Err);
  1526. Err = Changes.back().replace(Context.Sources, getLoc(11), 1, "");
  1527. ASSERT_TRUE(!Err);
  1528. EXPECT_EQ("int b;\n"
  1529. "int a;",
  1530. rewrite());
  1531. }
  1532. } // end namespace tooling
  1533. } // end namespace clang