Browse Source

[analyzer] Use getParentIgnoreParenCasts instead of doing it by hand.

Apart from being more compact and already implemented, this also handles the
case where the parent is null. (It does also ignore all casts, not just
implicit ones, but this is more efficient to test and in the case we care
about---a message in a PseudoObjectExpr---there should only be implicit casts
anyway.

This should fix our internal buildbot.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@191094 91177308-0d34-0410-b5e6-96231b3b80d8
Jordan Rose 12 years ago
parent
commit
7c98f9f5c3
1 changed files with 1 additions and 3 deletions
  1. 1 3
      lib/StaticAnalyzer/Core/CallEvent.cpp

+ 1 - 3
lib/StaticAnalyzer/Core/CallEvent.cpp

@@ -688,9 +688,7 @@ ObjCMessageKind ObjCMethodCall::getMessageKind() const {
 
 
     // Find the parent, ignoring implicit casts.
     // Find the parent, ignoring implicit casts.
     ParentMap &PM = getLocationContext()->getParentMap();
     ParentMap &PM = getLocationContext()->getParentMap();
-    const Stmt *S = PM.getParent(getOriginExpr());
-    while (isa<ImplicitCastExpr>(S))
-      S = PM.getParent(S);
+    const Stmt *S = PM.getParentIgnoreParenCasts(getOriginExpr());
 
 
     // Check if parent is a PseudoObjectExpr.
     // Check if parent is a PseudoObjectExpr.
     if (const PseudoObjectExpr *POE = dyn_cast_or_null<PseudoObjectExpr>(S)) {
     if (const PseudoObjectExpr *POE = dyn_cast_or_null<PseudoObjectExpr>(S)) {